[
https://issues.apache.org/jira/browse/KAFKA-15881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vedarth Sharma resolved KAFKA-15881.
Fix Version/s: 3.7.0
Reviewer: Manikumar
Resolution: Fixed
Release
lucasbru commented on PR #14962:
URL: https://github.com/apache/kafka/pull/14962#issuecomment-1853418387
@AndrewJSchofield Please have a look at my comments above, and if you think
it's worth fixing, please open a follow up PR. I merged the change since I
don't think the feature needs to
lucasbru merged PR #14962:
URL: https://github.com/apache/kafka/pull/14962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424943646
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -950,6 +965,43 @@ public void
yashmayya commented on code in PR #14966:
URL: https://github.com/apache/kafka/pull/14966#discussion_r1424910127
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##
@@ -70,74 +80,115 @@ public class OffsetsApiIntegrationTest
omkreddy merged PR #14991:
URL: https://github.com/apache/kafka/pull/14991
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
vamossagar12 commented on PR #14981:
URL: https://github.com/apache/kafka/pull/14981#issuecomment-1853271332
Thanks for the review @dajac . I have addressed the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phuc Hong Tran reassigned KAFKA-15558:
--
Assignee: Phuc Hong Tran
> Determine if Timer should be used elsewhere in
>
soarez commented on PR #14998:
URL: https://github.com/apache/kafka/pull/14998#issuecomment-1853247402
> 36 tests have failed There are 0 new tests failing, 36 existing failing
and 271 skipped.
@rondagostino PTAL
--
This is an automated message from the Apache Git Service.
To
showuon commented on PR #14832:
URL: https://github.com/apache/kafka/pull/14832#issuecomment-1853214842
@clolov , I took the liberty to help fix the checksytle error. Let's see if
the CI build passed. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on PR #14365:
URL: https://github.com/apache/kafka/pull/14365#issuecomment-1853213017
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #14380:
URL: https://github.com/apache/kafka/pull/14380#issuecomment-1853212990
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
showuon commented on PR #14832:
URL: https://github.com/apache/kafka/pull/14832#issuecomment-1853210629
@clolov , there are checkstyle error, please correct them:
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-14832/6/pipeline
Thanks.
--
This
jeffkbkim commented on PR #14988:
URL: https://github.com/apache/kafka/pull/14988#issuecomment-1853155239
The previous build had the error from test
`testNoGroupEpochBumpWhenStaticMemberTemporarilyLeaves() –
org.apache.kafka.coordinator.group.GroupMetadataManagerTest` from jdk 8
```
lihaosky opened a new pull request, #14999:
URL: https://github.com/apache/kafka/pull/14999
Docs for the new `balance_subtopology` config.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build
soarez commented on code in PR #14977:
URL: https://github.com/apache/kafka/pull/14977#discussion_r1424698314
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -191,12 +204,27 @@ class LogDirFailureTest extends IntegrationTestHarness {
soarez opened a new pull request, #14998:
URL: https://github.com/apache/kafka/pull/14998
Any directory changes must be considered when replaying
BrokerRegistrationChangeRecord. This is necessary
to persist directory failures in the cluster metadata, which #14902 missed.
###
[
https://issues.apache.org/jira/browse/KAFKA-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-15111.
-
Resolution: Duplicate
> Correction kafka examples
> -
>
>
[
https://issues.apache.org/jira/browse/KAFKA-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15111:
Fix Version/s: 3.6.0
(was: 3.7.0)
> Correction kafka examples
>
[
https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795958#comment-17795958
]
Greg Harris commented on KAFKA-15372:
-
This is now set to release for 3.7 and 3.6, but I had some
[
https://issues.apache.org/jira/browse/KAFKA-15372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris updated KAFKA-15372:
Fix Version/s: 3.6.2
> MM2 rolling restart can drop configuration changes silently
>
jolshan opened a new pull request, #14997:
URL: https://github.com/apache/kafka/pull/14997
https://github.com/apache/kafka/commit/c8f687ac1505456cb568de2b60df235eb1ceb5f0
was incorrect in reusing the same metadata version to enable the new fetch
request.
This fixes the issue by
gharris1727 merged PR #14293:
URL: https://github.com/apache/kafka/pull/14293
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 commented on PR #14293:
URL: https://github.com/apache/kafka/pull/14293#issuecomment-1852872688
Test failures appear unrelated, and the mirror and runtime tests pass
locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
hachikuji commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1424609415
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -1352,6 +1360,28 @@ object GroupMetadataManager {
"%X".format(BigInt(1,
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1424609554
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/InMemoryPartitionWriter.java:
##
@@ -102,6 +103,14 @@ public long append(
}
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1424597195
##
core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala:
##
@@ -135,7 +136,22 @@ class CoordinatorLoaderImpl[T](
philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1424589872
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -285,44 +286,6 @@ void testEnsureEventsAreCompleted() {
philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1424585777
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -810,89 +854,87 @@ public void
hni61223 commented on code in PR #14996:
URL: https://github.com/apache/kafka/pull/14996#discussion_r1424548302
##
bin/kafka-server-stop.sh:
##
@@ -36,7 +36,7 @@ else
declare -a AbsolutePathToConfigArray
for ((i = 0; i < ${#RelativePathArray[@]}; i++)); do
rondagostino commented on code in PR #14996:
URL: https://github.com/apache/kafka/pull/14996#discussion_r1424547476
##
bin/kafka-server-stop.sh:
##
@@ -36,7 +36,7 @@ else
declare -a AbsolutePathToConfigArray
for ((i = 0; i < ${#RelativePathArray[@]}; i++)); do
hni61223 commented on code in PR #14996:
URL: https://github.com/apache/kafka/pull/14996#discussion_r1424547291
##
bin/kafka-server-stop.sh:
##
@@ -36,7 +36,7 @@ else
declare -a AbsolutePathToConfigArray
for ((i = 0; i < ${#RelativePathArray[@]}; i++)); do
[
https://issues.apache.org/jira/browse/KAFKA-15912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795926#comment-17795926
]
Vojtech Juranek commented on KAFKA-15912:
-
I'd be careful to do the parallelization per
rondagostino commented on code in PR #14996:
URL: https://github.com/apache/kafka/pull/14996#discussion_r1424545171
##
bin/kafka-server-stop.sh:
##
@@ -36,7 +36,7 @@ else
declare -a AbsolutePathToConfigArray
for ((i = 0; i < ${#RelativePathArray[@]}; i++)); do
hni61223 opened a new pull request, #14996:
URL: https://github.com/apache/kafka/pull/14996
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1424518210
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -892,6 +895,43 @@ public void replay(
}
}
+
Lucas Brutschy created KAFKA-16001:
--
Summary: Migrate ConsumerNetworkThreadTestBuilder away from
ConsumerTestBuilder
Key: KAFKA-16001
URL: https://issues.apache.org/jira/browse/KAFKA-16001
Project:
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1424518210
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -892,6 +895,43 @@ public void replay(
}
}
+
Lucas Brutschy created KAFKA-16000:
--
Summary: Migrate MembershipManagerImpl away from
ConsumerTestBuilder
Key: KAFKA-16000
URL: https://issues.apache.org/jira/browse/KAFKA-16000
Project: Kafka
Lucas Brutschy created KAFKA-15999:
--
Summary: Migrate HeartbeatRequestManagerTest away from
ConsumerTestBuilder
Key: KAFKA-15999
URL: https://issues.apache.org/jira/browse/KAFKA-15999
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-15913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795918#comment-17795918
]
Lucas Brutschy commented on KAFKA-15913:
Splitting off the other tests
> Migrate
[
https://issues.apache.org/jira/browse/KAFKA-15913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-15913:
--
Assignee: Lucas Brutschy
Summary: Migrate AsyncKafkaConsumerTest away from
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1424512647
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -862,6 +863,7 @@ public void replay(
}
[
https://issues.apache.org/jira/browse/KAFKA-15998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jonathan Haapala updated KAFKA-15998:
-
Description:
I ran into a case where {{onPartitionsAssigned()}} was called without
Jonathan Haapala created KAFKA-15998:
Summary: EAGER rebalance onPartitionsAssigned() called with no
previous onPartitionsLost() nor onPartitionsRevoked()
Key: KAFKA-15998
URL:
hachikuji commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1424500490
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -1352,6 +1360,28 @@ object GroupMetadataManager {
"%X".format(BigInt(1,
jolshan commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1424497060
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -1352,6 +1360,28 @@ object GroupMetadataManager {
"%X".format(BigInt(1, bytes))
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424473429
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -135,6 +138,11 @@ public Builder withTimer(Timer timer) {
hachikuji commented on code in PR #14774:
URL: https://github.com/apache/kafka/pull/14774#discussion_r1424481055
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -1352,6 +1360,28 @@ object GroupMetadataManager {
"%X".format(BigInt(1,
tinaselenge opened a new pull request, #14995:
URL: https://github.com/apache/kafka/pull/14995
This PR implements
[KIP-993](https://cwiki.apache.org/confluence/display/KAFKA/KIP-993%3A+Allow+restricting+files+accessed+by+File+and+Directory+ConfigProviders)
for restricting files accessed by
gharris1727 commented on code in PR #12290:
URL: https://github.com/apache/kafka/pull/12290#discussion_r1424413335
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java:
##
@@ -350,13 +353,16 @@ private void
C0urante commented on code in PR #14966:
URL: https://github.com/apache/kafka/pull/14966#discussion_r1424453814
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##
@@ -70,74 +80,115 @@ public class OffsetsApiIntegrationTest {
sudeshwasnik commented on code in PR #14966:
URL: https://github.com/apache/kafka/pull/14966#discussion_r1424446893
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##
@@ -70,74 +80,115 @@ public class
sudeshwasnik commented on code in PR #14966:
URL: https://github.com/apache/kafka/pull/14966#discussion_r142423
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##
@@ -70,74 +80,115 @@ public class
sudeshwasnik commented on code in PR #14966:
URL: https://github.com/apache/kafka/pull/14966#discussion_r142423
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##
@@ -70,74 +80,115 @@ public class
dajac commented on PR #14986:
URL: https://github.com/apache/kafka/pull/14986#issuecomment-1852606155
Merged to trunk and 3.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dajac merged PR #14986:
URL: https://github.com/apache/kafka/pull/14986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1424433876
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1050,6 +1062,81 @@ private void close(Duration timeout, boolean
philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1424414983
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -178,27 +171,11 @@ static void runAtClose(final Collection>
philipnee commented on code in PR #14937:
URL: https://github.com/apache/kafka/pull/14937#discussion_r1424413992
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1026,15 +1038,13 @@ private void close(Duration timeout, boolean
MikeEdgar commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1852564791
Thanks for the feedback @jolshan . If I'm following your comments on the
broken test, the assertion
```scala
assertThrows(classOf[ExecutionException], () =>
vamossagar12 commented on PR #14963:
URL: https://github.com/apache/kafka/pull/14963#issuecomment-1852550354
Thanks for the changes @Joker-5 . I will take a look this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jolshan commented on PR #14599:
URL: https://github.com/apache/kafka/pull/14599#issuecomment-1852550819
I synced with @ijuma offline. I think it makes sense to return the
UnknownTopicId exception since that is what we do for the deleteTopics api and
what the server is using.
It is
vamossagar12 commented on code in PR #14966:
URL: https://github.com/apache/kafka/pull/14966#discussion_r1424389303
##
connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java:
##
@@ -70,74 +80,115 @@ public class
vamossagar12 commented on PR #14963:
URL: https://github.com/apache/kafka/pull/14963#issuecomment-1852542077
hmm, the JDK21 build failed with this error =>
```
> Task :examples:spotbugsMain
Cannot contact jenkins-shared-ubuntu-3: java.lang.InterruptedException
> Task
vamossagar12 commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424381464
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -719,20 +721,26 @@ public void run() {
kamalcph commented on code in PR #14832:
URL: https://github.com/apache/kafka/pull/14832#discussion_r1424357202
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -341,9 +341,10 @@ public void onLeadershipChange(Set
partitionsBecomeLeader,
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424354426
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -950,6 +965,43 @@ public void
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424353506
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -950,6 +965,43 @@ public void
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424352569
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -186,6 +187,7 @@ public void testConsumerGroupHeartbeat()
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424351506
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1092,6 +1134,7 @@ private CoordinatorRuntime(
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424350048
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -581,6 +591,12 @@ class CoordinatorWriteEvent implements
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424351314
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1019,6 +1055,11 @@ public void onHighWatermarkUpdated(
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424350465
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -698,13 +720,27 @@ public void run() {
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424350233
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -595,13 +611,15 @@ class CoordinatorWriteEvent implements
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424349399
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -135,6 +138,11 @@ public Builder withTimer(Timer timer) {
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424349887
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -581,6 +591,12 @@ class CoordinatorWriteEvent implements
dajac commented on code in PR #14981:
URL: https://github.com/apache/kafka/pull/14981#discussion_r1424345912
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -719,20 +721,26 @@ public void run() {
[
https://issues.apache.org/jira/browse/KAFKA-9545?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-9545.
Resolution: Fixed
> Flaky Test
[
https://issues.apache.org/jira/browse/KAFKA-15997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot reassigned KAFKA-15997:
---
Assignee: Ritika Reddy
> Ensure fairness in the uniform assignor
>
Emanuele Sabellico created KAFKA-15997:
--
Summary: Ensure fairness in the uniform assignor
Key: KAFKA-15997
URL: https://issues.apache.org/jira/browse/KAFKA-15997
Project: Kafka
Issue
lianetm commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424320386
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -169,7 +169,7 @@ class PlaintextConsumerTest extends BaseConsumerTest {
jeffkbkim commented on code in PR #14848:
URL: https://github.com/apache/kafka/pull/14848#discussion_r1424319049
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java:
##
@@ -77,29 +70,13 @@ public class
mjsax commented on PR #14936:
URL: https://github.com/apache/kafka/pull/14936#issuecomment-1852434603
@stanislavkozlovski There is no 3.7 branch yet, so I merged this one. Must
go into 3.7 release (is ready for days, but Jenkins did not cooperate...) -- If
your cut does not include it,
mjsax merged PR #14936:
URL: https://github.com/apache/kafka/pull/14936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424297697
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +812,197 @@ public void
soarez commented on code in PR #14977:
URL: https://github.com/apache/kafka/pull/14977#discussion_r1424296842
##
core/src/test/scala/unit/kafka/server/LogDirFailureTest.scala:
##
@@ -191,12 +204,27 @@ class LogDirFailureTest extends IntegrationTestHarness {
dajac commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424300228
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -860,6 +871,78 @@ public void testGroupMetadataUpdateSingleCall()
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424285645
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -860,6 +871,78 @@ public void
kirktrue commented on code in PR #14640:
URL: https://github.com/apache/kafka/pull/14640#discussion_r1424283196
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -790,6 +791,297 @@ public void
aliehsaeedii commented on code in PR #14957:
URL: https://github.com/apache/kafka/pull/14957#discussion_r1424277821
##
streams/src/test/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValueTest.java:
##
@@ -0,0 +1,220 @@
+/*
+ * Licensed to the
q-ryanamiri opened a new pull request, #14994:
URL: https://github.com/apache/kafka/pull/14994
Reviewers: Rajini Sivaram
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping
aliehsaeedii commented on code in PR #14957:
URL: https://github.com/apache/kafka/pull/14957#discussion_r1424265799
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java:
##
@@ -69,23 +73,49 @@ public boolean hasNext() {
if
aliehsaeedii commented on code in PR #14957:
URL: https://github.com/apache/kafka/pull/14957#discussion_r1424265799
##
streams/src/main/java/org/apache/kafka/streams/state/internals/LogicalSegmentIterator.java:
##
@@ -69,23 +73,49 @@ public boolean hasNext() {
if
gharris1727 commented on PR #14987:
URL: https://github.com/apache/kafka/pull/14987#issuecomment-1852376741
Closing in favor of #12290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gharris1727 closed pull request #14987: MINOR: Allow Block.resetBlockLatch to
release blocked operation for end-of-test cleanup
URL: https://github.com/apache/kafka/pull/14987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
aliehsaeedii commented on code in PR #14957:
URL: https://github.com/apache/kafka/pull/14957#discussion_r1424245975
##
streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java:
##
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the
satishd merged PR #14649:
URL: https://github.com/apache/kafka/pull/14649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
aliehsaeedii commented on code in PR #14957:
URL: https://github.com/apache/kafka/pull/14957#discussion_r1424136033
##
streams/src/main/java/org/apache/kafka/streams/state/internals/ReadonlyPartiallyDeserializedSegmentValue.java:
##
@@ -0,0 +1,210 @@
+/*
+ * Licensed to the
yashmayya commented on PR #14966:
URL: https://github.com/apache/kafka/pull/14966#issuecomment-1852343242
Thanks Chris, this looks like a really nice improvement! I can review
sometime later this week.
--
This is an automated message from the Apache Git Service.
To respond to the
1 - 100 of 162 matches
Mail list logo
