Re: [PR] KAFKA-15445: Add JVM Docker image [kafka]

2023-12-13 Thread via GitHub
VedarthConfluent commented on PR #14552: URL: https://github.com/apache/kafka/pull/14552#issuecomment-1855353838 Hey @mimaison, Thanks for the input. We will update the KIP based on conclusion of this conversation. Indeed golang is a new language for the repository and it's a

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
ijuma commented on PR #14984: URL: https://github.com/apache/kafka/pull/14984#issuecomment-1855332987 Java 21 build passed, others have failures that look unrelated: > Build / JDK 11 and Scala 2.13 /

[jira] [Assigned] (KAFKA-16013) Implement ExpiresPerSec metric

2023-12-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-16013: - Assignee: Luke Chen > Implement ExpiresPerSec metric > -- > >

Re: [PR] MINOR: Client state machine fix for ignoring new assignments when leaving [kafka]

2023-12-13 Thread via GitHub
cadonna merged PR #15003: URL: https://github.com/apache/kafka/pull/15003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Client state machine fix for ignoring new assignments when leaving [kafka]

2023-12-13 Thread via GitHub
cadonna commented on PR #15003: URL: https://github.com/apache/kafka/pull/15003#issuecomment-1855324814 The build failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-14505; [3/N] Wire WriteTxnMarkers API [kafka]

2023-12-13 Thread via GitHub
jeffkbkim commented on code in PR #14985: URL: https://github.com/apache/kafka/pull/14985#discussion_r1426320341 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -892,6 +895,43 @@ public void replay( } } +

Re: [PR] KAFKA-16002: Implement RemoteCopyLagSegments, RemoteDeleteLagBytes and RemoteDeleteLagSegments [kafka]

2023-12-13 Thread via GitHub
showuon commented on code in PR #15005: URL: https://github.com/apache/kafka/pull/15005#discussion_r1426233918 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -1041,10 +1060,20 @@ void cleanupExpiredRemoteLogSegments() throws RemoteStorageException,

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
philipnee commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1855217598 I rebased to see if that improves the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-15147) Measure pending and outstanding Remote Segment operations

2023-12-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-15147: -- Description:

[jira] [Updated] (KAFKA-15147) Measure pending and outstanding Remote Segment operations

2023-12-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-15147: -- Description: KAFKA-15833: RemoteCopyLagBytes KAFKA-16002: RemoteCopyLagSegments,

[jira] [Created] (KAFKA-16014) Implement RemoteLogSizeComputationTime, RemoteLogSizeBytes, RemoteLogMetadataCount

2023-12-13 Thread Luke Chen (Jira)
Luke Chen created KAFKA-16014: - Summary: Implement RemoteLogSizeComputationTime, RemoteLogSizeBytes, RemoteLogMetadataCount Key: KAFKA-16014 URL: https://issues.apache.org/jira/browse/KAFKA-16014

[jira] [Created] (KAFKA-16013) Implement ExpiresPerSec metric

2023-12-13 Thread Luke Chen (Jira)
Luke Chen created KAFKA-16013: - Summary: Implement ExpiresPerSec metric Key: KAFKA-16013 URL: https://issues.apache.org/jira/browse/KAFKA-16013 Project: Kafka Issue Type: Sub-task

[jira] [Updated] (KAFKA-15158) Add metrics for RemoteDeleteRequestsPerSec, RemoteDeleteErrorsPerSec, BuildRemoteLogAuxStateRequestsPerSec, BuildRemoteLogAuxStateErrorsPerSec

2023-12-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-15158: -- Summary: Add metrics for RemoteDeleteRequestsPerSec, RemoteDeleteErrorsPerSec,

[jira] [Updated] (KAFKA-15158) Add metrics for RemoteRequestsPerSec

2023-12-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15158?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-15158: -- Parent: KAFKA-15147 Issue Type: Sub-task (was: Improvement) > Add metrics for

[jira] [Commented] (KAFKA-10409) Refactor Kafka Streams RocksDb iterators

2023-12-13 Thread Dhawal Kapil (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796564#comment-17796564 ] Dhawal Kapil commented on KAFKA-10409: -- Hi [~jeqo]  A newbie here :) Can this Jira be marked

Re: [PR] KAFKA-15870: Move new group coordinator metrics from Yammer to Metrics [kafka]

2023-12-13 Thread via GitHub
jeffkbkim commented on code in PR #14848: URL: https://github.com/apache/kafka/pull/14848#discussion_r1426200690 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -281,100 +297,93 @@ public void

Re: [PR] KAFKA-15870: Move new group coordinator metrics from Yammer to Metrics [kafka]

2023-12-13 Thread via GitHub
jeffkbkim commented on code in PR #14848: URL: https://github.com/apache/kafka/pull/14848#discussion_r1426193169 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -75,31 +74,23 @@ public class

Re: [PR] MINOR: transform new coordinator error before returning to client [kafka]

2023-12-13 Thread via GitHub
jeffkbkim commented on PR #15001: URL: https://github.com/apache/kafka/pull/15001#issuecomment-1855164600 there's a lot of test failures but they are unrelated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: Fix descriptions of raft-metrics in docs/ops.html [kafka]

2023-12-13 Thread via GitHub
tkuramoto33 commented on PR #14973: URL: https://github.com/apache/kafka/pull/14973#issuecomment-1855118664 @hachikuji @showuon I am sorry to bother you, but could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426151584 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,14 @@ public enum MetadataVersion { // Add JBOD support

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426151584 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,14 @@ public enum MetadataVersion { // Add JBOD support

Re: [PR] KAFKA-15711: KRaft support in LogRecoveryTest [kafka]

2023-12-13 Thread via GitHub
linzihao1999 commented on code in PR #14693: URL: https://github.com/apache/kafka/pull/14693#discussion_r1426141060 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -212,7 +228,7 @@ class LogRecoveryTest extends QuorumTestHarness { server2.startup()

Re: [PR] KAFKA-15158: Add metrics for RemoteRequestsPerSec [kafka]

2023-12-13 Thread via GitHub
showuon commented on PR #14375: URL: https://github.com/apache/kafka/pull/14375#issuecomment-1855078026 Also, please resolve the conflict. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] KAFKA-15158: Add metrics for RemoteRequestsPerSec [kafka]

2023-12-13 Thread via GitHub
showuon commented on code in PR #14375: URL: https://github.com/apache/kafka/pull/14375#discussion_r1426129619 ## core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala: ## @@ -3205,13 +3220,52 @@ class ReplicaManagerTest { threadNamePrefix: Option[String],

Re: [PR] KAFKA-9545: Fix Flaky Test `RegexSourceIntegrationTest.testRegexMatchesTopicsAWhenDeleted` [kafka]

2023-12-13 Thread via GitHub
ashwinpankaj commented on PR #14910: URL: https://github.com/apache/kafka/pull/14910#issuecomment-1855076180 > @wcarlson5 @ashwinpankaj This fix does not seem to unflake the test. If I run it multiple times locally I get a failure after a couple of runs. I reopened the ticket. ack -

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on PR #14984: URL: https://github.com/apache/kafka/pull/14984#issuecomment-1855063162 > Please update the PR description to explain what issue is being fixed. The description doesn't match the changes included in this PR. > > Same with the PR title. Is the

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
jsancio commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426122289 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,14 @@ public enum MetadataVersion { // Add JBOD support for

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
jsancio commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426122289 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,14 @@ public enum MetadataVersion { // Add JBOD support for

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426120064 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,13 @@ public enum MetadataVersion { // Add JBOD support

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426109379 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,14 @@ public enum MetadataVersion { // Add JBOD support

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426109379 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,14 @@ public enum MetadataVersion { // Add JBOD support

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

2023-12-13 Thread via GitHub
jolshan merged PR #14774: URL: https://github.com/apache/kafka/pull/14774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Created] (KAFKA-16012) Incomplete range assignment in consumer

2023-12-13 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-16012: --- Summary: Incomplete range assignment in consumer Key: KAFKA-16012 URL: https://issues.apache.org/jira/browse/KAFKA-16012 Project: Kafka Issue Type:

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
jsancio commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426068254 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,14 @@ public enum MetadataVersion { // Add JBOD support for

Re: [PR] KAFKA-15784: Ensure atomicity of in memory update and write when transactionally committing offsets [kafka]

2023-12-13 Thread via GitHub
jolshan commented on PR #14774: URL: https://github.com/apache/kafka/pull/14774#issuecomment-1854966227 I took a look at the tests and the only one that looked suspicious were the mirrorIntegration tests related to `delete.retention.ms` not being configured correctly. I saw some flakes in

[jira] [Updated] (KAFKA-15883) Implement RemoteCopyLagBytes

2023-12-13 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15883?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-15883: -- Fix Version/s: 3.7.0 > Implement RemoteCopyLagBytes > > >

Re: [PR] KAFKA-15883: Implement RemoteCopyLagBytes [kafka]

2023-12-13 Thread via GitHub
showuon merged PR #14832: URL: https://github.com/apache/kafka/pull/14832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15883: Implement RemoteCopyLagBytes [kafka]

2023-12-13 Thread via GitHub
showuon commented on PR #14832: URL: https://github.com/apache/kafka/pull/14832#issuecomment-1854950876 Failed tests are unrelated: ``` Build / JDK 21 and Scala 2.13 / org.apache.kafka.connect.integration.OffsetsApiIntegrationTest.testAlterSinkConnectorOffsets Build / JDK

[PR] MINOR: Prototype: Measure CI slowness [kafka]

2023-12-13 Thread via GitHub
gharris1727 opened a new pull request, #15008: URL: https://github.com/apache/kafka/pull/15008 This clients test runs a tight loop for a fixed number of iterations, and tries to characterize the time taken to complete a single operation with a linear regression. Results of these

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
jolshan commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426014858 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,13 @@ public enum MetadataVersion { // Add JBOD support for

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426006570 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -228,6 +230,8 @@ public void testShortVersion() {

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426005487 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -74,7 +74,8 @@ object ZkMigrationIntegrationTest {

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426004845 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -274,7 +278,8 @@ public void testVersion() {

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426003941 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -165,13 +165,15 @@ public void testFromVersionString() {

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
pprovenzano commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1426003081 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,13 @@ public enum MetadataVersion { // Add JBOD support

Re: [PR] KAFKA-15456: Commit/Fetch error handling improvements and V9 support [kafka]

2023-12-13 Thread via GitHub
lianetm commented on PR #14557: URL: https://github.com/apache/kafka/pull/14557#issuecomment-1854868531 Thanks for the review! All comments addressed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-16011) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnClose

2023-12-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16011: -- Description: The integration test {{PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnClose}}

[jira] [Created] (KAFKA-16011) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnClose

2023-12-13 Thread Kirk True (Jira)
Kirk True created KAFKA-16011: - Summary: Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnClose Key: KAFKA-16011 URL: https://issues.apache.org/jira/browse/KAFKA-16011 Project: Kafka

Re: [PR] KAFKA-15456: Commit/Fetch error handling improvements and V9 support [kafka]

2023-12-13 Thread via GitHub
lianetm commented on code in PR #14557: URL: https://github.com/apache/kafka/pull/14557#discussion_r1425995440 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -741,61 +767,86 @@ boolean reconcile() {

[jira] [Updated] (KAFKA-15835) Group commit/callbacks triggering logic

2023-12-13 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15835: --- Description: The new consumer reconciliation logic triggers a commit request, revocation

[jira] [Updated] (KAFKA-16010) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling

2023-12-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16010: -- Description: The integration test

[jira] [Updated] (KAFKA-16010) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling

2023-12-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16010: -- Description: The integration test

[jira] [Created] (KAFKA-16010) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling

2023-12-13 Thread Kirk True (Jira)
Kirk True created KAFKA-16010: - Summary: Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling Key: KAFKA-16010 URL: https://issues.apache.org/jira/browse/KAFKA-16010 Project: Kafka

[jira] [Updated] (KAFKA-16010) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling

2023-12-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16010: -- Description: The integration test {{PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation}}

[jira] [Updated] (KAFKA-16009) Fix PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation

2023-12-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16009: -- Description: The integration test {{PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation}}

Re: [PR] KAFKA-15456: Commit/Fetch error handling improvements and V9 support [kafka]

2023-12-13 Thread via GitHub
lianetm commented on code in PR #14557: URL: https://github.com/apache/kafka/pull/14557#discussion_r1425984924 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1077,4 +1131,18 @@ public void onUpdate(ClusterResource

[jira] [Updated] (KAFKA-16009) Fix PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation

2023-12-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16009: -- Description: The integration test {{PlaintextConsumerTest.testMaxPollIntervalMs}} is failing when

[jira] [Created] (KAFKA-16009) Fix PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation

2023-12-13 Thread Kirk True (Jira)
Kirk True created KAFKA-16009: - Summary: Fix PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation Key: KAFKA-16009 URL: https://issues.apache.org/jira/browse/KAFKA-16009 Project: Kafka

[jira] [Updated] (KAFKA-16008) Fix PlaintextConsumerTest.testMaxPollIntervalMs

2023-12-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16008: -- Description: The integration test {{PlaintextConsumerTest.testMaxPollIntervalMs}} is failing when

Re: [PR] KAFKA-15456: Commit/Fetch error handling improvements and V9 support [kafka]

2023-12-13 Thread via GitHub
lianetm commented on code in PR #14557: URL: https://github.com/apache/kafka/pull/14557#discussion_r1425982023 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -190,63 +179,90 @@ private static long findMinTime(final

[jira] [Created] (KAFKA-16008) Fix PlaintextConsumerTest.testMaxPollIntervalMs

2023-12-13 Thread Kirk True (Jira)
Kirk True created KAFKA-16008: - Summary: Fix PlaintextConsumerTest.testMaxPollIntervalMs Key: KAFKA-16008 URL: https://issues.apache.org/jira/browse/KAFKA-16008 Project: Kafka Issue Type: Test

[jira] [Updated] (KAFKA-16008) Fix PlaintextConsumerTest.testMaxPollIntervalMs

2023-12-13 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16008: -- Description: The integration test {{PlaintextConsumerTest.testMaxPollIntervalMs}} is failing with

[jira] [Updated] (KAFKA-15835) Group commit/callbacks triggering logic

2023-12-13 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15835: --- Description: The new consumer reconciliation logic triggers a commit request, revocation

Re: [PR] KAFKA-15456: Commit/Fetch error handling improvements and V9 support [kafka]

2023-12-13 Thread via GitHub
lianetm commented on code in PR #14557: URL: https://github.com/apache/kafka/pull/14557#discussion_r1425965837 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -457,120 +535,224 @@ public void onResponse(final ClientResponse

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
jolshan commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1425960046 ## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ## @@ -194,8 +194,13 @@ public enum MetadataVersion { // Add JBOD support for

Re: [PR] KAFKA-15456: Commit/Fetch error handling improvements and V9 support [kafka]

2023-12-13 Thread via GitHub
lianetm commented on code in PR #14557: URL: https://github.com/apache/kafka/pull/14557#discussion_r1425958312 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitApplicationEvent.java: ## @@ -18,17 +18,36 @@ import

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
rondagostino commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1425956907 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -74,7 +74,8 @@ object ZkMigrationIntegrationTest {

Re: [PR] KAFKA-15922: Bump MetadataVersion to support JBOD with KRaft [kafka]

2023-12-13 Thread via GitHub
rondagostino commented on code in PR #14984: URL: https://github.com/apache/kafka/pull/14984#discussion_r1425955291 ## server-common/src/test/java/org/apache/kafka/server/common/MetadataVersionTest.java: ## @@ -165,13 +165,15 @@ public void testFromVersionString() {

Re: [PR] KAFKA-14505; [3/N] Wire WriteTxnMarkers API [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14985: URL: https://github.com/apache/kafka/pull/14985#discussion_r1425954235 ## core/src/test/scala/integration/kafka/api/TransactionsTest.scala: ## @@ -299,14 +304,14 @@ class TransactionsTest extends IntegrationTestHarness {

[jira] [Created] (KAFKA-16007) ZK migrations can be slow for large clusters

2023-12-13 Thread David Arthur (Jira)
David Arthur created KAFKA-16007: Summary: ZK migrations can be slow for large clusters Key: KAFKA-16007 URL: https://issues.apache.org/jira/browse/KAFKA-16007 Project: Kafka Issue Type:

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425906944 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425906944 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

Re: [PR] KAFKA-14412: Generalise over RocksDB WriteBatch [kafka]

2023-12-13 Thread via GitHub
ableegoldman commented on PR #14853: URL: https://github.com/apache/kafka/pull/14853#issuecomment-1854731072 Two of the builds failed again...one of them looks like a failing Connect test bailed out with a sys exit, not sure what happened with the other one, but let's retry it... --

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425904694 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -368,31 +374,54 @@ private static ConfigDef config() {

[jira] [Updated] (KAFKA-16006) mTLS authentication works for kafka-topic.sh but fails for kafka-metadata-quorum.sh

2023-12-13 Thread 10011 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16006?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] 10011 updated KAFKA-16006: -- Component/s: tools Affects Version/s: 3.4.0 > mTLS authentication works for kafka-topic.sh but

[jira] [Created] (KAFKA-16006) mTLS authentication works for kafka-topic.sh but fails for kafka-metadata-quorum.sh

2023-12-13 Thread 10011 (Jira)
10011 created KAFKA-16006: - Summary: mTLS authentication works for kafka-topic.sh but fails for kafka-metadata-quorum.sh Key: KAFKA-16006 URL: https://issues.apache.org/jira/browse/KAFKA-16006 Project: Kafka

Re: [PR] KAFKA-15471 [MINOR]: Fix backward-compatibility bug [kafka]

2023-12-13 Thread via GitHub
rondagostino commented on code in PR #14996: URL: https://github.com/apache/kafka/pull/14996#discussion_r1425899082 ## bin/kafka-server-stop.sh: ## @@ -32,16 +32,6 @@ elif [[ "$OSNAME" == "OS400" ]]; then else PIDS=$(ps ax | grep ' kafka\.Kafka ' | grep java | grep -v

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425879028 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -139,7 +141,8 @@ public void setup() throws Exception {

[jira] [Commented] (KAFKA-16003) The znode /config/topics is not updated during KRaft migration in "dual-write" mode

2023-12-13 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796445#comment-17796445 ] David Arthur commented on KAFKA-16003: -- Thanks for the report [~ppatierno]. Does this cause any

Re: [PR] KAFKA-15870: Move new group coordinator metrics from Yammer to Metrics [kafka]

2023-12-13 Thread via GitHub
dajac commented on code in PR #14848: URL: https://github.com/apache/kafka/pull/14848#discussion_r1425827813 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorMetrics.java: ## @@ -75,31 +74,23 @@ public class GroupCoordinatorMetrics

Re: [PR] KAFKA-12216; Improve flaky test reporting [kafka]

2023-12-13 Thread via GitHub
dajac commented on PR #14862: URL: https://github.com/apache/kafka/pull/14862#issuecomment-1854591910 Rebased to include https://github.com/apache/kafka/commit/87e3cbe4daa084964596d3f6f79041d85548426b. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
C0urante commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425798851 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -139,7 +141,8 @@ public void setup() throws Exception {

[jira] [Resolved] (KAFKA-15237) Implement write operation timeout

2023-12-13 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-15237. - Fix Version/s: 3.7.0 Resolution: Fixed > Implement write operation timeout >

Re: [PR] KAFKA-15237: Implement write operation timeout [kafka]

2023-12-13 Thread via GitHub
dajac merged PR #14981: URL: https://github.com/apache/kafka/pull/14981 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15237: Implement write operation timeout [kafka]

2023-12-13 Thread via GitHub
dajac commented on PR #14981: URL: https://github.com/apache/kafka/pull/14981#issuecomment-1854579152 The failed tests are not related. Merging to trunk and 3.7. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] MINOR: Fix thread leak in AuthorizerIntegrationTest [kafka]

2023-12-13 Thread via GitHub
dajac opened a new pull request, #15006: URL: https://github.com/apache/kafka/pull/15006 Producers and consumers could be leaked in the AuthorizerIntegrationTest. In the teardown logic, `removeAllClientAcls()` is called before calling the super teardown method. If `removeAllClientAcls()`

Re: [PR] KAFKA-16002: Implement RemoteCopyLagSegments, RemoteDeleteLagBytes and RemoteDeleteLagSegments [kafka]

2023-12-13 Thread via GitHub
clolov commented on PR #15005: URL: https://github.com/apache/kafka/pull/15005#issuecomment-1854551258 Heya @showuon and @kamalcph! I have marked this as a draft, but will aim to add the needed test + functionality tomorrow. I would appreciate any initial reviews and suggestions for

Re: [PR] MINOR: Give FETCH request own MetadataVersion for KIP-951 [kafka]

2023-12-13 Thread via GitHub
jolshan closed pull request #14997: MINOR: Give FETCH request own MetadataVersion for KIP-951 URL: https://github.com/apache/kafka/pull/14997 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Give FETCH request own MetadataVersion for KIP-951 [kafka]

2023-12-13 Thread via GitHub
jolshan commented on PR #14997: URL: https://github.com/apache/kafka/pull/14997#issuecomment-1854528600 I will close this for now after syncing with Proven and others offline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
philipnee commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1854478484 for `testFetcherConcurrency` I'm actually having a hard time to replicate the issue locally. So let's see what the test suggests -- This is an automated message from the Apache Git

[jira] [Closed] (KAFKA-15868) KIP-951 - Leader discovery optimisations for the client

2023-12-13 Thread Mayank Shekhar Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayank Shekhar Narula closed KAFKA-15868. - > KIP-951 - Leader discovery optimisations for the client >

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
philipnee commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1854460882 Sorry about the exceedingly large log, but for documentation purposes: 269/269 tests passed (so i enabled both generic and consumer protocol). ``` Gradle Test Run

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
philipnee closed pull request #14937: KAFKA-15696: Refactor closing consumer URL: https://github.com/apache/kafka/pull/14937 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15696: Refactor closing consumer [kafka]

2023-12-13 Thread via GitHub
philipnee commented on PR #14937: URL: https://github.com/apache/kafka/pull/14937#issuecomment-1854443779 Let me close and reopen the ticket to trigger the test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425661550 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -350,13 +353,16 @@ private void

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2023-12-13 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1425661185 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -139,7 +141,8 @@ public void setup() throws Exception {

Re: [PR] KAFKA-15988: Reuse embedded clusters across test cases in Connect OffsetsApiIntegrationTest suite [kafka]

2023-12-13 Thread via GitHub
C0urante commented on code in PR #14966: URL: https://github.com/apache/kafka/pull/14966#discussion_r1425647269 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java: ## @@ -895,6 +909,55 @@ private Map baseSourceConnectorConfigs()

[jira] [Comment Edited] (KAFKA-15853) Move KafkaConfig to server module

2023-12-13 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796383#comment-17796383 ] Federico Valeri edited comment on KAFKA-15853 at 12/13/23 4:58 PM: ---

[jira] [Comment Edited] (KAFKA-15853) Move KafkaConfig to server module

2023-12-13 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796383#comment-17796383 ] Federico Valeri edited comment on KAFKA-15853 at 12/13/23 4:57 PM: ---

[jira] [Commented] (KAFKA-15853) Move KafkaConfig to server module

2023-12-13 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17796383#comment-17796383 ] Federico Valeri commented on KAFKA-15853: - [~ijuma] the current StrageTool implementation

  1   2   >