showuon merged PR #15015:
URL: https://github.com/apache/kafka/pull/15015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15015:
URL: https://github.com/apache/kafka/pull/15015#issuecomment-1865792143
It's been running 7 hours, but the result of jdk 21 is still not out.
However, the other 3 tasks are completed and the failed tests are unrelated.
--
This is an automated message from
[
https://issues.apache.org/jira/browse/KAFKA-16014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16014:
-
Assignee: Luke Chen
> Implement RemoteLogSizeComputationTime, RemoteLogSizeBytes,
>
showuon merged PR #15005:
URL: https://github.com/apache/kafka/pull/15005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15005:
URL: https://github.com/apache/kafka/pull/15005#issuecomment-1865598500
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
sciclon2 commented on PR #15030:
URL: https://github.com/apache/kafka/pull/15030#issuecomment-1865512396
@pprovenzano , I dont have permissions to merge the PR, so I guess somebody
else eventually will do it, is that correct? thanks!
--
This is an automated message from the Apache Git
[ https://issues.apache.org/jira/browse/KAFKA-15739 ]
Zihao Lin deleted comment on KAFKA-15739:
---
was (Author: JIRAUSER300254):
Hi [~sameert]
I want to test my PR, but how to re-trigger the CI-builds. Any suggestions?
Thanks
> KRaft support in
[
https://issues.apache.org/jira/browse/KAFKA-16039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jianbin Chen updated KAFKA-16039:
-
External issue URL: https://github.com/apache/kafka/pull/15034
> RecordHeaders supports the
Jianbin Chen created KAFKA-16039:
Summary: RecordHeaders supports the addAll method
Key: KAFKA-16039
URL: https://issues.apache.org/jira/browse/KAFKA-16039
Project: Kafka
Issue Type:
philipnee commented on PR #15035:
URL: https://github.com/apache/kafka/pull/15035#issuecomment-1865440196
hmm @cadonna - seems like there are some build stability issue. my other PR
also failed after 8hr (it is completely unrelated to the consumer refactor)
`PR-15023`
--
This is an
philipnee commented on PR #15023:
URL: https://github.com/apache/kafka/pull/15023#issuecomment-1865437639
hi @jolshan - it seems like `OffsetsApiIntegrationTests` is connect related
test, in `org.apache.kafka.connect.integration`. in the other PR, some of the
tests in the integration test
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433436213
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinator.java:
##
@@ -266,6 +267,28 @@ CompletableFuture deleteOffsets(
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433434733
##
core/src/main/scala/kafka/server/KafkaApis.scala:
##
@@ -2432,7 +2477,13 @@ class KafkaApis(val requestChannel: RequestChannel,
origin =
showuon commented on PR #15015:
URL: https://github.com/apache/kafka/pull/15015#issuecomment-1865421593
I'd like to merge https://github.com/apache/kafka/pull/15005 first because
that one is more important than this PR. It should just 1 more hour to get the
results.
--
This is an
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433375910
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -3018,6 +3020,223 @@ class KafkaApisTest {
any())
}
+ @Test
Review Comment:
Are we
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433369682
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/InMemoryPartitionWriter.java:
##
@@ -102,6 +241,31 @@ public long append(
}
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433368003
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/InMemoryPartitionWriter.java:
##
@@ -33,10 +37,141 @@
*/
public class
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433343992
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -1073,6 +1151,314 @@ public CoordinatorShardBuilder
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433342495
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -1073,6 +1151,314 @@ public CoordinatorShardBuilder
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r148933
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java:
##
@@ -1073,6 +1151,314 @@ public CoordinatorShardBuilder
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433329835
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/OffsetMetadataManagerTest.java:
##
@@ -2414,6 +2424,67 @@ public void testReplayWithTombstone() {
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433324984
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java:
##
@@ -1900,4 +1908,59 @@ public void
jolshan commented on PR #14985:
URL: https://github.com/apache/kafka/pull/14985#issuecomment-1865318460
I might start a run of the transactions system test off of this branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-16027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799209#comment-17799209
]
Alexander Aghili commented on KAFKA-16027:
--
[https://github.com/apache/kafka/pull/15055]
Made a
Alexander-Aghili opened a new pull request, #15055:
URL: https://github.com/apache/kafka/pull/15055
Split MetadataTest#testUpdateParitionLeadership into two tests:
MetadataTest#testIgnoreUpdatePartitionLeadership
MetadataTest#testApplyAndIgnoreUpdatesPartitionLeadership
Each
[
https://issues.apache.org/jira/browse/KAFKA-16038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Almog Gavra updated KAFKA-16038:
Summary: Periodic Logging of Current Assignment (was: Periodic Logging fo
Current Assignment)
>
dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433079259
##
core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala:
##
@@ -135,7 +136,22 @@ class CoordinatorLoaderImpl[T](
Almog Gavra created KAFKA-16038:
---
Summary: Periodic Logging fo Current Assignment
Key: KAFKA-16038
URL: https://issues.apache.org/jira/browse/KAFKA-16038
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-16034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16034:
--
Fix Version/s: 3.7.0
> AsyncKafkaConsumer will get Invalid Request error when trying to rejoin on
>
[
https://issues.apache.org/jira/browse/KAFKA-15692?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15692:
--
Parent: (was: KAFKA-14048)
Issue Type: Test (was: Sub-task)
> New integration tests to
[
https://issues.apache.org/jira/browse/KAFKA-15325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15325:
--
Parent: (was: KAFKA-14048)
Issue Type: Improvement (was: Sub-task)
> Integrate topicId
[
https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15538:
--
Priority: Major (was: Minor)
> Client support for java regex based subscription
>
[
https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15538:
--
Parent: (was: KAFKA-14048)
Issue Type: New Feature (was: Sub-task)
> Client support for
[
https://issues.apache.org/jira/browse/KAFKA-15282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15282:
--
Parent: (was: KAFKA-14048)
Issue Type: New Feature (was: Sub-task)
> Implement client
[
https://issues.apache.org/jira/browse/KAFKA-15835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15835:
--
Parent: (was: KAFKA-14048)
Issue Type: Improvement (was: Sub-task)
> Group
[
https://issues.apache.org/jira/browse/KAFKA-15697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15697:
--
Parent: (was: KAFKA-14048)
Issue Type: New Feature (was: Sub-task)
> Add local assignor
[
https://issues.apache.org/jira/browse/KAFKA-16033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16033:
--
Parent: (was: KAFKA-14048)
Issue Type: Improvement (was: Sub-task)
> Review retry logic
[
https://issues.apache.org/jira/browse/KAFKA-15542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15542:
--
Parent: (was: KAFKA-14048)
Issue Type: Improvement (was: Sub-task)
> Release member
[
https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15561:
--
Parent: (was: KAFKA-14048)
Issue Type: New Feature (was: Sub-task)
> Client support for
[
https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15561:
--
Labels: consumer-threading-refactor kip-848 kip-848-client-support (was:
kip-848
[
https://issues.apache.org/jira/browse/KAFKA-15561?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15561:
--
Priority: Major (was: Minor)
> Client support for new SubscriptionPattern based subscription
>
[
https://issues.apache.org/jira/browse/KAFKA-15279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15279:
--
Parent: (was: KAFKA-14048)
Issue Type: New Feature (was: Sub-task)
> Implement client
[
https://issues.apache.org/jira/browse/KAFKA-15283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15283:
--
Parent: (was: KAFKA-14048)
Issue Type: New Feature (was: Sub-task)
> Add support for
[
https://issues.apache.org/jira/browse/KAFKA-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15588:
--
Parent: (was: KAFKA-14048)
Issue Type: Improvement (was: Sub-task)
> Purge the unsent
[
https://issues.apache.org/jira/browse/KAFKA-15839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15839:
--
Parent: (was: KAFKA-14048)
Issue Type: Improvement (was: Sub-task)
> Improve
[
https://issues.apache.org/jira/browse/KAFKA-15773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15773:
--
Parent: (was: KAFKA-14048)
Issue Type: Improvement (was: Sub-task)
> Group protocol
[
https://issues.apache.org/jira/browse/KAFKA-15846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15846:
--
Parent: (was: KAFKA-14048)
Issue Type: Improvement (was: Sub-task)
> Review consumer
[
https://issues.apache.org/jira/browse/KAFKA-15967?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15967:
--
Parent: (was: KAFKA-14048)
Issue Type: Bug (was: Sub-task)
> Fix revocation in
[
https://issues.apache.org/jira/browse/KAFKA-15954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15954:
--
Issue Type: Improvement (was: Task)
> Review minimal effort approach on consumer last heartbeat on
[
https://issues.apache.org/jira/browse/KAFKA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15843:
--
Parent: (was: KAFKA-14048)
Issue Type: Improvement (was: Sub-task)
> Review consumer
[
https://issues.apache.org/jira/browse/KAFKA-15832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15832:
--
Parent: (was: KAFKA-14048)
Issue Type: Improvement (was: Sub-task)
> Trigger client
[
https://issues.apache.org/jira/browse/KAFKA-16032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16032:
--
Parent: (was: KAFKA-14048)
Issue Type: Bug (was: Sub-task)
> Review inconsistent error
[
https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15691:
--
Priority: Major (was: Critical)
> Add new system tests to use new consumer
>
[
https://issues.apache.org/jira/browse/KAFKA-16037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16037:
--
Priority: Blocker (was: Critical)
> Upgrade existing system tests to use new consumer
>
[
https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15691:
--
Fix Version/s: 3.8.0
(was: 4.0.0)
> Add new system tests to use new consumer
>
[
https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15691:
--
Summary: Add new system tests to use new consumer (was: Upgrade existing
and add new system tests to
[
https://issues.apache.org/jira/browse/KAFKA-16037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16037:
--
Fix Version/s: 3.8.0
(was: 4.0.0)
> Upgrade existing system tests to use new
Kirk True created KAFKA-16037:
-
Summary: Upgrade existing system tests to use new consumer
Key: KAFKA-16037
URL: https://issues.apache.org/jira/browse/KAFKA-16037
Project: Kafka
Issue Type: Test
[
https://issues.apache.org/jira/browse/KAFKA-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15321:
--
Parent: (was: KAFKA-14048)
Issue Type: Task (was: Sub-task)
> Document consumer group
jeffkbkim commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433038616
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/SnapshottableCoordinator.java:
##
@@ -111,6 +112,22 @@ public synchronized void replay(
dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433031924
##
core/src/test/scala/unit/kafka/coordinator/group/CoordinatorLoaderImplTest.scala:
##
@@ -511,4 +544,35 @@ class CoordinatorLoaderImplTest {
new
jeffkbkim commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1433029392
##
core/src/test/scala/unit/kafka/coordinator/group/CoordinatorLoaderImplTest.scala:
##
@@ -511,4 +544,35 @@ class CoordinatorLoaderImplTest {
new
dajac commented on PR #15053:
URL: https://github.com/apache/kafka/pull/15053#issuecomment-1864868557
@jeffkbkim The goal is to have something better than
`group.coordinator.new.enable`. Yes, I will add it to the KIP.
--
This is an automated message from the Apache Git Service.
To
jeffkbkim commented on PR #15053:
URL: https://github.com/apache/kafka/pull/15053#issuecomment-1864862018
is the purpose of this config to prevent EA users from accidentally using
the consumer protocol while using the new coordinator?
also, should we update the kip with this new
philipnee commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432925646
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -525,16 +526,37 @@ public void testHeartbeatState() {
[
https://issues.apache.org/jira/browse/KAFKA-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799084#comment-17799084
]
Andras Katona edited comment on KAFKA-13922 at 12/20/23 4:15 PM:
-
Okay,
[
https://issues.apache.org/jira/browse/KAFKA-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799084#comment-17799084
]
Andras Katona edited comment on KAFKA-13922 at 12/20/23 4:15 PM:
-
Okay,
cadonna commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432918143
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -525,16 +526,37 @@ public void testHeartbeatState() {
[
https://issues.apache.org/jira/browse/KAFKA-13922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799084#comment-17799084
]
Andras Katona commented on KAFKA-13922:
---
Okay, I was trying to configure the
cadonna commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432918143
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -525,16 +526,37 @@ public void testHeartbeatState() {
jolshan commented on code in PR #15023:
URL: https://github.com/apache/kafka/pull/15023#discussion_r1432905225
##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -1185,9 +1263,14 @@ else if (partition.equals(internalPart))
/**
* For
cadonna commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432897655
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -525,16 +526,37 @@ public void testHeartbeatState() {
philipnee closed pull request #12038: KAFKA-13421 - fix flaky
ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup
URL: https://github.com/apache/kafka/pull/12038
--
This is an automated message from the Apache Git Service.
To respond to the message,
philipnee closed pull request #13330: Prototyping Rebalance Protocol
URL: https://github.com/apache/kafka/pull/13330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
philipnee closed pull request #13217: Prototype take 2
URL: https://github.com/apache/kafka/pull/13217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
philipnee closed pull request #13716: ctr-staging-testing-draft
URL: https://github.com/apache/kafka/pull/13716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
philipnee closed pull request #14772: KafkaConsumer not respecting
max.poll.record when subscribing to more than 1 topics.
URL: https://github.com/apache/kafka/pull/14772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
dajac commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1432884537
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -190,4 +170,62 @@ class CoordinatorPartitionWriter[T](
throw
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1432877933
##
core/src/test/scala/unit/kafka/coordinator/group/CoordinatorPartitionWriterTest.scala:
##
@@ -234,6 +237,79 @@ class CoordinatorPartitionWriterTest {
lucasbru commented on PR #14963:
URL: https://github.com/apache/kafka/pull/14963#issuecomment-1864703292
Hey @Joker-5, I took the ticket since your original PR seemed to only change
the legacy consumer, so I thought it was just linked to the wrong ticket.
I think there are some
jolshan commented on code in PR #14985:
URL: https://github.com/apache/kafka/pull/14985#discussion_r1432873518
##
core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala:
##
@@ -190,4 +170,62 @@ class CoordinatorPartitionWriter[T](
throw
philipnee commented on code in PR #15023:
URL: https://github.com/apache/kafka/pull/15023#discussion_r1432836418
##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -1067,25 +1067,102 @@ protected boolean retainTopic(String topic, boolean
isInternal,
kamalcph commented on code in PR #15050:
URL: https://github.com/apache/kafka/pull/15050#discussion_r1432837641
##
core/src/main/scala/kafka/server/KafkaRequestHandler.scala:
##
@@ -426,6 +427,18 @@ class BrokerTopicMetrics(name: Option[String], configOpt:
philipnee commented on code in PR #15023:
URL: https://github.com/apache/kafka/pull/15023#discussion_r1432838336
##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -1185,9 +1263,14 @@ else if (partition.equals(internalPart))
/**
* For
jolshan commented on PR #15023:
URL: https://github.com/apache/kafka/pull/15023#issuecomment-1864633877
I was looking at some of the test failures and wasn't seeing the
OffsetsApiIntegrationTests failing elsewhere. Can we check those? Running
locally may not be enough so I will also
raboof opened a new pull request, #15054:
URL: https://github.com/apache/kafka/pull/15054
This avoids `gradle dependencyCheckAggregate` from reporting on advisories
in build-time dependencies (e.g. CVE-2023-46122) which typically should not
affect us.
I checked that this does not
jolshan commented on code in PR #15023:
URL: https://github.com/apache/kafka/pull/15023#discussion_r1432819447
##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -1185,9 +1263,14 @@ else if (partition.equals(internalPart))
/**
* For
jolshan commented on code in PR #15023:
URL: https://github.com/apache/kafka/pull/15023#discussion_r1432814990
##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -1067,25 +1067,102 @@ protected boolean retainTopic(String topic, boolean
isInternal, long
jolshan commented on code in PR #15023:
URL: https://github.com/apache/kafka/pull/15023#discussion_r1432814990
##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -1067,25 +1067,102 @@ protected boolean retainTopic(String topic, boolean
isInternal, long
jolshan commented on code in PR #15023:
URL: https://github.com/apache/kafka/pull/15023#discussion_r1432810817
##
clients/src/test/java/org/apache/kafka/clients/MetadataTest.java:
##
@@ -1068,143 +1067,328 @@ protected boolean retainTopic(String topic, boolean
isInternal, long
[
https://issues.apache.org/jira/browse/KAFKA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-15991.
---
Resolution: Fixed
> Flaky new consumer test testGroupIdNotNullAndValid
>
[
https://issues.apache.org/jira/browse/KAFKA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-15991:
--
Fix Version/s: 3.7.0
(was: 3.8.0)
> Flaky new consumer test
[
https://issues.apache.org/jira/browse/KAFKA-15818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17799043#comment-17799043
]
Philip Nee commented on KAFKA-15818:
hi stan -
philipnee commented on PR #15035:
URL: https://github.com/apache/kafka/pull/15035#issuecomment-1864595438
@cadonna @dajac @AndrewJSchofield - Thanks a lot for the reviews. I've
made changes accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the
philipnee commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432803468
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -679,4 +683,23 @@ private HeartbeatRequestManager
philipnee commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432800050
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -191,10 +191,11 @@ public NetworkClientDelegate.PollResult
philipnee commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432799267
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -673,6 +673,9 @@ public void onHeartbeatRequestSent() {
dajac commented on code in PR #15035:
URL: https://github.com/apache/kafka/pull/15035#discussion_r1432786211
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -673,6 +673,9 @@ public void onHeartbeatRequestSent() {
satishd commented on PR #15015:
URL: https://github.com/apache/kafka/pull/15015#issuecomment-1864568359
Thanks @showuon for the update, LGTM.
I will merge the changes if the Jenkins jobs do not show any related test
failures.
--
This is an automated message from the Apache Git
lianetm commented on code in PR #14557:
URL: https://github.com/apache/kafka/pull/14557#discussion_r1432774544
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##
@@ -272,6 +280,10 @@ private void process(final
1 - 100 of 135 matches
Mail list logo
