Re: [PR] MINOR: Add 3.5.2 and 3.6.1 to system tests [kafka]

2024-01-12 Thread via GitHub
showuon commented on PR #14932: URL: https://github.com/apache/kafka/pull/14932#issuecomment-1890349665 I've backported to 3.7 branch, and created a PR: https://github.com/apache/kafka/pull/15187 to add v3.5.2 into 3.6 branch. Please help review. Thanks. -- This is an automated message

[PR] MINOR: add v3.5.2 in 3.6 branch [kafka]

2024-01-12 Thread via GitHub
showuon opened a new pull request, #15187: URL: https://github.com/apache/kafka/pull/15187 add v3.5.2 in 3.6 branch ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

Re: [PR] KAFKA-15388: Handling remote segment read in case of log compaction [kafka]

2024-01-12 Thread via GitHub
iit2009060 commented on PR #15060: URL: https://github.com/apache/kafka/pull/15060#issuecomment-1890348438 @satishd @kamalcph @divijvaidya I am able to reproduce the issue which @satishd mentioned , I need to introduced a delay to the movement of segments to remote through a hacky

Re: [PR] MINOR: Add isRemoteLogEnabled parameter to the Log Loader Javadoc [kafka]

2024-01-12 Thread via GitHub
showuon merged PR #15179: URL: https://github.com/apache/kafka/pull/15179 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add isRemoteLogEnabled parameter to the Log Loader Javadoc [kafka]

2024-01-12 Thread via GitHub
showuon commented on PR #15179: URL: https://github.com/apache/kafka/pull/15179#issuecomment-1890343953 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15047: Roll active segment when it breaches the retention policy [kafka]

2024-01-12 Thread via GitHub
kamalcph commented on code in PR #14766: URL: https://github.com/apache/kafka/pull/14766#discussion_r1451300245 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,25 +1425,70 @@ class UnifiedLog(@volatile var logStartOffset: Long, */ private def

Re: [PR] KAFKA-15942: Implement ConsumerInterceptor [kafka]

2024-01-12 Thread via GitHub
Joker-5 commented on PR #14963: URL: https://github.com/apache/kafka/pull/14963#issuecomment-1890340469 Hey, @lucasbru, I saw [this PR](https://github.com/apache/kafka/pull/15000) is ready to merge, but I don't see the `Co-authord-by` tag in the commits log. I'm a bit worried that you

Re: [PR] KAFKA-14483 Move/Rewrite of LocalLog to storage module. [kafka]

2024-01-12 Thread via GitHub
satishd commented on code in PR #14034: URL: https://github.com/apache/kafka/pull/14034#discussion_r1451284748 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -1245,8 +1246,8 @@ private[log] class CleanedTransactionMetadata { * * @param abortedTransactions The

Re: [PR] KAFKA-14483 Move/Rewrite of LocalLog to storage module. [kafka]

2024-01-12 Thread via GitHub
satishd commented on code in PR #14034: URL: https://github.com/apache/kafka/pull/14034#discussion_r1451284647 ## core/src/test/scala/unit/kafka/log/UnifiedLogTest.scala: ## @@ -3951,18 +3953,18 @@ class UnifiedLogTest { assertEquals(10, log.logSegments.size()) { -

Re: [PR] KAFKA-14483 Move/Rewrite of LocalLog to storage module. [kafka]

2024-01-12 Thread via GitHub
satishd commented on code in PR #14034: URL: https://github.com/apache/kafka/pull/14034#discussion_r1451284145 ## core/src/main/scala/kafka/log/LogLoader.scala: ## @@ -489,16 +488,16 @@ class LogLoader( * * @param segmentsToDelete The log segments to schedule for

Re: [PR] KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug [kafka]

2024-01-12 Thread via GitHub
kirktrue closed pull request #15186: KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug URL: https://github.com/apache/kafka/pull/15186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug [kafka]

2024-01-12 Thread via GitHub
kirktrue closed pull request #15186: KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug URL: https://github.com/apache/kafka/pull/15186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-14648: Moving bootstrap to NetworkClient Poll. [kafka]

2024-01-12 Thread via GitHub
github-actions[bot] commented on PR #14054: URL: https://github.com/apache/kafka/pull/14054#issuecomment-1890281361 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] POC - DO NOT MERGE: Deprecation cleanup [kafka]

2024-01-12 Thread via GitHub
github-actions[bot] commented on PR #14551: URL: https://github.com/apache/kafka/pull/14551#issuecomment-1890281139 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-14505; [6/N] Avoid recheduling callback in request thread [kafka]

2024-01-12 Thread via GitHub
artemlivshits commented on code in PR #15176: URL: https://github.com/apache/kafka/pull/15176#discussion_r1451074358 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1090,38 +1090,29 @@ class ReplicaManager(val config: KafkaConfig, * @param producerId

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-12 Thread via GitHub
jsancio commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1451075038 ## checkstyle/suppressions.xml: ## @@ -315,7 +315,7 @@ + files="(PartitionRegistration|PartitionChangeBuilder|TopicDelta).java"/> Review

Re: [PR] KAFKA-14957: Update-Description-String [kafka]

2024-01-12 Thread via GitHub
mjsax commented on code in PR #13909: URL: https://github.com/apache/kafka/pull/13909#discussion_r1451069044 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -1263,6 +1327,8 @@ protected String getConfigValue(ConfigKey key, String headerName) {

[jira] [Updated] (KAFKA-16029) Investigate cause of "Unable to find FetchSessionHandler for node X" in logs

2024-01-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16029: -- Description: >From [~mjsax]: {quote}Looking into AK unit/integration test logs for KS, I regularly

Re: [PR] KAFKA-14957: Update-Description-String [kafka]

2024-01-12 Thread via GitHub
mjsax commented on code in PR #13909: URL: https://github.com/apache/kafka/pull/13909#discussion_r1381140128 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -155,6 +155,29 @@ public ConfigDef define(String name, Type type, Object defaultValue,

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-12 Thread via GitHub
apoorvmittal10 commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1451062702 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -715,15 +716,22 @@ private Optional>

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-12 Thread via GitHub
apoorvmittal10 commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1451062702 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -715,15 +716,22 @@ private Optional>

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-12 Thread via GitHub
mjsax commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1451046445 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -715,15 +716,22 @@ private Optional>

Re: [PR] MINOR: Add 3.5.2 and 3.6.1 to system tests [kafka]

2024-01-12 Thread via GitHub
mjsax commented on PR #14932: URL: https://github.com/apache/kafka/pull/14932#issuecomment-1890192134 @mimaison -- should this be cherry-picked to 3.7 branch? -- And the bump to `3.5.2` split out for `3.6` branch? -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-15594: Add version 3.6 to Kafka Streams system tests [kafka]

2024-01-12 Thread via GitHub
mjsax commented on PR #15151: URL: https://github.com/apache/kafka/pull/15151#issuecomment-1890190571 A few tests failed: `streams_standby_replica_test` (both runs) and a multiple `streams_cooperative_rebalance_upgrade_test` (0.11, 1.0, 1.1, 2.2, 2.3) plus: ``` Module:

[jira] [Comment Edited] (KAFKA-16029) Investigate cause of "Unable to find FetchSessionHandler for node X" in logs

2024-01-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806236#comment-17806236 ] Kirk True edited comment on KAFKA-16029 at 1/13/24 12:41 AM: - Based on input

[jira] [Commented] (KAFKA-16029) Investigate cause of "Unable to find FetchSessionHandler for node X" in logs

2024-01-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806236#comment-17806236 ] Kirk True commented on KAFKA-16029: --- Based on input from [~ChrisEgerton], I was also able to reproduce

[jira] [Updated] (KAFKA-16029) Investigate cause of "Unable to find FetchSessionHandler for node X" in logs

2024-01-12 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16029: -- Issue Type: Bug (was: Task) > Investigate cause of "Unable to find FetchSessionHandler for node X"

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-12 Thread via GitHub
jolshan commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1451051792 ## checkstyle/suppressions.xml: ## @@ -315,7 +315,7 @@ + files="(PartitionRegistration|PartitionChangeBuilder|TopicDelta).java"/> Review

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-12 Thread via GitHub
mjsax commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1446041813 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -175,16 +182,42 @@ public static boolean

Re: [PR] [Kafka-14404] fix overlap of streams-config sections & describe additional parameters [kafka]

2024-01-12 Thread via GitHub
mjsax commented on code in PR #15162: URL: https://github.com/apache/kafka/pull/15162#discussion_r1451029920 ## docs/streams/developer-guide/config-streams.html: ## @@ -409,12 +409,12 @@ num.standby.replicasThe replication factor for changelog topics and repartition topics

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1451042152 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -155,72 +153,78 @@ class KRaftMetadataCache(val brokerId: Int) extends

Re: [PR] KAFKA-15468 [1/2]: Prevent transaction coordinator reloads on already loaded leaders [kafka]

2024-01-12 Thread via GitHub
jsancio commented on code in PR #15139: URL: https://github.com/apache/kafka/pull/15139#discussion_r1451037707 ## checkstyle/suppressions.xml: ## @@ -315,7 +315,7 @@ + files="(PartitionRegistration|PartitionChangeBuilder|TopicDelta).java"/> Review

[PR] KAFKA-16029: Fix "Unable to find FetchSessionHandler for node X" bug [kafka]

2024-01-12 Thread via GitHub
kirktrue opened a new pull request, #15186: URL: https://github.com/apache/kafka/pull/15186 This change restores the previous behavior for the `Fetcher` to keep its internal `sessionHandlers` cache even after `close()` is invoked. During the `close()` of a `Consumer`, the `Fetcher`

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1451037879 ## core/src/main/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandler.java: ## @@ -103,14 +102,20 @@ public DescribeTopicPartitionsResponseData

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1451036959 ## core/src/main/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandler.java: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1451036959 ## core/src/main/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandler.java: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1451036632 ## core/src/main/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandler.java: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Created] (KAFKA-16122) TransactionsBounceTest -- server disconnected before response was received

2024-01-12 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-16122: -- Summary: TransactionsBounceTest -- server disconnected before response was received Key: KAFKA-16122 URL: https://issues.apache.org/jira/browse/KAFKA-16122

[jira] [Resolved] (KAFKA-16051) Deadlock on connector initialization

2024-01-12 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-16051. - Fix Version/s: 3.8.0 Resolution: Fixed > Deadlock on connector initialization >

Re: [PR] KAFKA-16051: Fixed deadlock in StandaloneHerder [kafka]

2024-01-12 Thread via GitHub
gharris1727 merged PR #15080: URL: https://github.com/apache/kafka/pull/15080 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16051: Fixed deadlock in StandaloneHerder [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on PR #15080: URL: https://github.com/apache/kafka/pull/15080#issuecomment-1890150013 Test failures appear unrelated, and the tests pass locally for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-16118; Coordinator unloading fails when replica is deleted [kafka]

2024-01-12 Thread via GitHub
jolshan merged PR #15182: URL: https://github.com/apache/kafka/pull/15182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15834: Remove NamedTopologyIntegrationTest which leaks clients [kafka]

2024-01-12 Thread via GitHub
mjsax commented on PR #15185: URL: https://github.com/apache/kafka/pull/15185#issuecomment-1890137576 Not sure. Leave it up to @ableegoldman to sign off and make a call. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-15047: Roll active segment when it breaches the retention policy [kafka]

2024-01-12 Thread via GitHub
junrao commented on code in PR #14766: URL: https://github.com/apache/kafka/pull/14766#discussion_r1450990461 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,25 +1425,70 @@ class UnifiedLog(@volatile var logStartOffset: Long, */ private def

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
artemlivshits commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1450990079 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -155,72 +153,78 @@ class KRaftMetadataCache(val brokerId: Int) extends

[jira] [Commented] (KAFKA-16089) Kafka Streams still leaking memory

2024-01-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806217#comment-17806217 ] Matthias J. Sax commented on KAFKA-16089: - Great job! > Kafka Streams still leaking memory >

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450941019 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -392,90 +397,29 @@ public void testSetConfigs()

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #15180: URL: https://github.com/apache/kafka/pull/15180#discussion_r1450935147 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -884,6 +890,158 @@ private void

[jira] [Resolved] (KAFKA-15816) Typos in tests leak network sockets

2024-01-12 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-15816. - Fix Version/s: 3.8.0 Resolution: Fixed > Typos in tests leak network sockets >

[jira] [Updated] (KAFKA-15816) Typos in tests leak network sockets

2024-01-12 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-15816: Description: There are a few tests which leak network sockets due to small typos in the tests

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450933080 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -392,90 +397,29 @@ public void testSetConfigs() {

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450932511 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrantRecordSinkConnector.java: ## @@ -54,7 +65,16 @@ public void put(Collection records) {

Re: [PR] KAFKA-15816: Fix leaked sockets in core tests [kafka]

2024-01-12 Thread via GitHub
gharris1727 merged PR #14754: URL: https://github.com/apache/kafka/pull/14754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15816: Fix leaked sockets in core tests [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on PR #14754: URL: https://github.com/apache/kafka/pull/14754#issuecomment-1889959363 It looks like the consistent failures I was seeing were present only on JDK21, didn't reproduce with JDK11, but were already present on trunk. I got some flakey failures with JDK11

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15180: URL: https://github.com/apache/kafka/pull/15180#discussion_r1450925859 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -884,6 +890,158 @@ private void

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
mumrah commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1450910805 ## core/src/main/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandler.java: ## @@ -0,0 +1,142 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450911725 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrorHandlingIntegrationTest.java: ## @@ -75,9 +77,9 @@ public class

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15180: URL: https://github.com/apache/kafka/pull/15180#discussion_r1450909786 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -884,6 +890,158 @@ private void

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450908695 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperatorTest.java: ## @@ -392,90 +397,29 @@ public void testSetConfigs()

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450907710 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrantRecordSinkConnector.java: ## @@ -54,7 +65,16 @@ public void put(Collection records) {

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450900313 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrantRecordSinkConnector.java: ## @@ -44,6 +49,12 @@ public ErrantRecordSinkTask() {

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #15180: URL: https://github.com/apache/kafka/pull/15180#discussion_r1450898354 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -884,6 +890,158 @@ private void

[jira] [Updated] (KAFKA-16032) Review client error handling of OffsetFetch and OffsetCommit responses

2024-01-12 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16032: --- Summary: Review client error handling of OffsetFetch and OffsetCommit responses (was:

[jira] [Updated] (KAFKA-16032) Review client inconsistent error handling of OffsetFetch and OffsetCommit responses

2024-01-12 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16032: --- Description: OffsetFetch and OffsetCommit handle errors separately. There are 2 issues to

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15180: URL: https://github.com/apache/kafka/pull/15180#discussion_r1450882720 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerTest.java: ## @@ -619,7 +622,21 @@ public void testAddRemoveSourceTask() {

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15180: URL: https://github.com/apache/kafka/pull/15180#discussion_r1450879034 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -884,6 +890,158 @@ private void

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450850940 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ErrantRecordSinkConnector.java: ## @@ -44,6 +49,12 @@ public ErrantRecordSinkTask() {

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1450863295 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -189,6 +255,86 @@ class KRaftMetadataCache(val brokerId: Int) extends

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1450862714 ## core/src/main/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandler.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1450862538 ## core/src/main/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandler.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1450862006 ## core/src/main/java/kafka/server/handlers/DescribeTopicPartitionsRequestHandler.java: ## @@ -0,0 +1,137 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450846319 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -236,7 +237,7 @@ protected V

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450843684 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/DeadLetterQueueReporter.java: ## @@ -121,20 +121,22 @@ public static DeadLetterQueueReporter

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450843020 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/ProcessingContext.java: ## @@ -17,82 +17,36 @@ package

[jira] [Resolved] (KAFKA-16112) Review JMX metrics in Async Consumer and determine the missing ones

2024-01-12 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-16112. Resolution: Fixed These are the results of this ticket   |KAFKA-16113| |KAFKA-16116|

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #15180: URL: https://github.com/apache/kafka/pull/15180#discussion_r1450813789 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -884,6 +890,158 @@ private void

Re: [PR] KAFKA-16087: Avoid data race which drops wrong record when errors.tolerance=all and asynchronous error occurs [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15154: URL: https://github.com/apache/kafka/pull/15154#discussion_r1450812678 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/errors/RetryWithToleranceOperator.java: ## @@ -80,59 +83,57 @@ public class

Re: [PR] KAFKA-15834: Remove NamedTopologyIntegrationTest which leaks clients [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on PR #15185: URL: https://github.com/apache/kafka/pull/15185#issuecomment-1889780346 Hey @mjsax @ableegoldman thanks for the context on the Jira ticket. I removed just the leaky test, instead of the whole suite, but let me know if you think the whole suite should be

[PR] KAFKA-15834: Remove NamedTopologyIntegrationTest which leaks clients [kafka]

2024-01-12 Thread via GitHub
gharris1727 opened a new pull request, #15185: URL: https://github.com/apache/kafka/pull/15185 This test leaks Kafka clients, because the underlying consumer gets stuck trying to read from a non-existent topic. Rather than change the client behavior in this situation, or change the

Re: [PR] KAFKA-15575: Begin enforcing 'tasks.max' property for connectors [kafka]

2024-01-12 Thread via GitHub
C0urante commented on code in PR #15180: URL: https://github.com/apache/kafka/pull/15180#discussion_r1450799667 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java: ## @@ -391,7 +391,15 @@ public List> connectorTaskConfigs(String connName, Connector

Re: [PR] KAFKA-5863: Avoid NPE when RestClient calls expecting no-content receive content. [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on PR #13294: URL: https://github.com/apache/kafka/pull/13294#issuecomment-1889769357 Hey @yashmayya are you interested in reviewing this? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MINOR: Stop leaking threads in BlockingConnectorTest [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #12290: URL: https://github.com/apache/kafka/pull/12290#discussion_r1450789672 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/BlockingConnectorTest.java: ## @@ -434,23 +484,31 @@ public Block(Map props) {

Re: [PR] KAFKA-14345: Fix flakiness with more accurate bound in (Dynamic)ConnectionQuotaTest [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on PR #12806: URL: https://github.com/apache/kafka/pull/12806#issuecomment-1889743364 Hi @divijvaidya As this is still causing flaky failures ~2% of the time, I'm still interested in getting this fix merged. Thanks! -- This is an automated message from the Apache

Re: [PR] test [kafka]

2024-01-12 Thread via GitHub
dajac closed pull request #15058: test URL: https://github.com/apache/kafka/pull/15058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-12 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1450765739 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -141,17 +144,33 @@ class KRaftMetadataCache(val brokerId: Int) extends

Re: [PR] KAFKA-15945 : Flaky test - testSyncTopicConfigs() – org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #14893: URL: https://github.com/apache/kafka/pull/14893#discussion_r1450758420 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java: ## @@ -101,8 +101,9 @@ */

Re: [PR] KAFKA-16118; Coordinator unloading fails when replica is deleted [kafka]

2024-01-12 Thread via GitHub
jolshan commented on code in PR #15182: URL: https://github.com/apache/kafka/pull/15182#discussion_r1450751697 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -684,6 +685,60 @@ public void testScheduleUnloading()

Re: [PR] KAFKA-16118; Coordinator unloading fails when replica is deleted [kafka]

2024-01-12 Thread via GitHub
jolshan commented on code in PR #15182: URL: https://github.com/apache/kafka/pull/15182#discussion_r1450749432 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -684,6 +685,60 @@ public void testScheduleUnloading()

Re: [PR] KAFKA-16120, KAFKA-16121: Handle removed replicas during KRaft migration [kafka]

2024-01-12 Thread via GitHub
splett2 commented on code in PR #15184: URL: https://github.com/apache/kafka/pull/15184#discussion_r1450726015 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -677,6 +677,88 @@ class ZkMigrationIntegrationTest { } } +

[jira] [Created] (KAFKA-16121) Partition reassignments in ZK migration dual write mode stalled until leader epoch incremented

2024-01-12 Thread David Mao (Jira)
David Mao created KAFKA-16121: - Summary: Partition reassignments in ZK migration dual write mode stalled until leader epoch incremented Key: KAFKA-16121 URL: https://issues.apache.org/jira/browse/KAFKA-16121

Re: [PR] KAFKA-16118; Coordinator unloading fails when replica is deleted [kafka]

2024-01-12 Thread via GitHub
dajac commented on code in PR #15182: URL: https://github.com/apache/kafka/pull/15182#discussion_r1450733355 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -684,6 +685,60 @@ public void testScheduleUnloading() {

Re: [PR] KAFKA-16120: Handle removed replicas during KRaft migration [kafka]

2024-01-12 Thread via GitHub
splett2 commented on code in PR #15184: URL: https://github.com/apache/kafka/pull/15184#discussion_r1450726015 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -677,6 +677,88 @@ class ZkMigrationIntegrationTest { } } +

[jira] [Commented] (KAFKA-16120) Partition reassignments in ZK migration dual write leaves stray partitions

2024-01-12 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806129#comment-17806129 ] Justine Olshan commented on KAFKA-16120: Do you know if

[jira] [Comment Edited] (KAFKA-16120) Partition reassignments in ZK migration dual write leaves stray partitions

2024-01-12 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17806129#comment-17806129 ] Justine Olshan edited comment on KAFKA-16120 at 1/12/24 5:18 PM: - Do you

Re: [PR] KAFKA-16120: Handle removed replicas during KRaft migration [kafka]

2024-01-12 Thread via GitHub
splett2 commented on code in PR #15184: URL: https://github.com/apache/kafka/pull/15184#discussion_r1450726015 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -677,6 +677,88 @@ class ZkMigrationIntegrationTest { } } +

Re: [PR] KAFKA-16118; Coordinator unloading fails when replica is deleted [kafka]

2024-01-12 Thread via GitHub
jolshan commented on code in PR #15182: URL: https://github.com/apache/kafka/pull/15182#discussion_r1450722995 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -684,6 +685,60 @@ public void testScheduleUnloading()

[jira] [Created] (KAFKA-16120) Partition reassignments in ZK migration dual write leaves stray partitions

2024-01-12 Thread David Mao (Jira)
David Mao created KAFKA-16120: - Summary: Partition reassignments in ZK migration dual write leaves stray partitions Key: KAFKA-16120 URL: https://issues.apache.org/jira/browse/KAFKA-16120 Project: Kafka

Re: [PR] KAFKA-16118; Coordinator unloading fails when replica is deleted [kafka]

2024-01-12 Thread via GitHub
jolshan commented on code in PR #15182: URL: https://github.com/apache/kafka/pull/15182#discussion_r1450721942 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1683,7 +1685,7 @@ public void scheduleUnloadOperation(

Re: [PR] improve TopicCommandIntegrationTest to be less flaky [kafka]

2024-01-12 Thread via GitHub
jolshan commented on PR #14891: URL: https://github.com/apache/kafka/pull/14891#issuecomment-1889665664 > Thanks for your feedback! Do you mean we should keep the existing API calls like createAndWaitTopic(buildTopicCommandOptionsWithBootstrap( "--create", "--partitions", "2",

Re: [PR] KAFKA-16051: Fixed deadlock in StandaloneHerder [kafka]

2024-01-12 Thread via GitHub
gharris1727 commented on code in PR #15080: URL: https://github.com/apache/kafka/pull/15080#discussion_r1450714324 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -1001,6 +1001,65 @@ public void

  1   2   >