Re: [PR] MINOR: code cleanup [kafka]

2024-01-17 Thread via GitHub
mjsax merged PR #15208: URL: https://github.com/apache/kafka/pull/15208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Assigned] (KAFKA-15712) KRaft support in MultipleListenersWithSameSecurityProtocolBaseTest

2024-01-17 Thread Sushant Mahajan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sushant Mahajan reassigned KAFKA-15712: --- Assignee: Sushant Mahajan > KRaft support in

Re: [PR] KAFKA-16101: KRaft migration documentation is incorrect [kafka]

2024-01-17 Thread via GitHub
showuon commented on code in PR #15193: URL: https://github.com/apache/kafka/pull/15193#discussion_r1457017055 ## docs/ops.html: ## @@ -3956,25 +3956,31 @@ Reverting to ZooKeeper mode During the Migration While the cluster is still in migration mode, it is possible to

Re: [PR] MINOR: Add test case for follower fetch [kafka]

2024-01-17 Thread via GitHub
showuon merged PR #14212: URL: https://github.com/apache/kafka/pull/14212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] MINOR Remove unreachable if-else block in ReplicaManager.scala [kafka]

2024-01-17 Thread via GitHub
drawxy opened a new pull request, #15220: URL: https://github.com/apache/kafka/pull/15220 After this #13107 PR, an if-else block became unreachable. We need remove it and make the code clean. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-17 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1456873999 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -141,17 +144,33 @@ class KRaftMetadataCache(val brokerId: Int) extends

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-17 Thread via GitHub
CalvinConfluent commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1456867934 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -140,6 +141,71 @@ class KRaftMetadataCache(val brokerId: Int) extends

[jira] [Updated] (KAFKA-16160) AsyncKafkaConsumer is trying to connect to a disconnected node in a tight loop

2024-01-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16160: -- Parent: (was: KAFKA-14246) Issue Type: Bug (was: Sub-task) > AsyncKafkaConsumer is

[jira] [Updated] (KAFKA-16160) AsyncKafkaConsumer is trying to connect to a disconnected node in a tight loop

2024-01-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16160: -- Priority: Critical (was: Major) > AsyncKafkaConsumer is trying to connect to a disconnected node in

[jira] [Updated] (KAFKA-16160) AsyncKafkaConsumer is trying to connect to a disconnected node in a tight loop

2024-01-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16160: -- Component/s: clients > AsyncKafkaConsumer is trying to connect to a disconnected node in a tight loop

[jira] [Updated] (KAFKA-16160) AsyncKafkaConsumer is trying to connect to a disconnected node in a tight loop

2024-01-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16160: -- Fix Version/s: 3.8.0 > AsyncKafkaConsumer is trying to connect to a disconnected node in a tight loop

[jira] [Updated] (KAFKA-16160) AsyncKafkaConsumer is trying to connect to a disconnected node in a tight loop

2024-01-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16160: -- Summary: AsyncKafkaConsumer is trying to connect to a disconnected node in a tight loop (was:

[jira] [Commented] (KAFKA-16104) Enable additional PlaintextConsumerTest tests for new consumer

2024-01-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807998#comment-17807998 ] Kirk True commented on KAFKA-16104: --- testAutoCommitOnCloseAfterWakeup failed for two of three runs on

Re: [PR] MINOR: Don't log missing partitions at ERROR level [kafka]

2024-01-17 Thread via GitHub
github-actions[bot] commented on PR #14579: URL: https://github.com/apache/kafka/pull/14579#issuecomment-1897729360 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15585: Add DescribeTopics API server side support [kafka]

2024-01-17 Thread via GitHub
artemlivshits commented on code in PR #14612: URL: https://github.com/apache/kafka/pull/14612#discussion_r1456764730 ## core/src/main/scala/kafka/server/metadata/KRaftMetadataCache.scala: ## @@ -141,17 +144,33 @@ class KRaftMetadataCache(val brokerId: Int) extends

[jira] [Updated] (KAFKA-16141) StreamsStandbyTask##test_standby_tasks_rebalanceArguments:{ “metadata_quorum”: “ISOLATED_KRAFT”, “use_new_coordinator”: false} fails consistently in 3.7

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16141: Fix Version/s: 3.7.0 > StreamsStandbyTask##test_standby_tasks_rebalanceArguments:{ >

Re: [PR] MINOR: add v3.5.2 in 3.6 branch [kafka]

2024-01-17 Thread via GitHub
showuon merged PR #15187: URL: https://github.com/apache/kafka/pull/15187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16085: Add metric value consolidated for topics on a broker for tiered storage. [kafka]

2024-01-17 Thread via GitHub
showuon commented on PR #15133: URL: https://github.com/apache/kafka/pull/15133#issuecomment-1897627545 @divijvaidya , since Satish is busy, could you help review this PR? We'd like to get it into v3.7.0 for the completion of KIP-963. Thanks. -- This is an automated message from the

[jira] [Updated] (KAFKA-16141) StreamsStandbyTask##test_standby_tasks_rebalanceArguments:{ “metadata_quorum”: “ISOLATED_KRAFT”, “use_new_coordinator”: false} fails consistently in 3.7

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16141: Component/s: streams > StreamsStandbyTask##test_standby_tasks_rebalanceArguments:{ >

[jira] [Updated] (KAFKA-16139) StreamsUpgradeTest fails consistently in 3.7.0

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16139: Component/s: streams system tests > StreamsUpgradeTest fails

Re: [PR] KAFKA-15770: IQv2 must return immutable position [kafka]

2024-01-17 Thread via GitHub
mjsax commented on PR #15219: URL: https://github.com/apache/kafka/pull/15219#issuecomment-1897612010 I am not 100% sure if my analysis is correct, but it's my best guess so far. Given that the test always passed locally, I would like to re-run Jenkins on this PR a few times (but in the

[PR] KAFKA-15770: IQv2 must return immutable position [kafka]

2024-01-17 Thread via GitHub
mjsax opened a new pull request, #15219: URL: https://github.com/apache/kafka/pull/15219 ConsistencyVectorIntegrationTest failed frequently because the returned Position from IQv2 is not immutable while the test assumes immutability. To return a Position with a QueryResult that does not

[jira] [Assigned] (KAFKA-15770) org.apache.kafka.streams.integration.ConsistencyVectorIntegrationTest.shouldHaveSamePositionBoundActiveAndStandBy is flaky

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-15770: --- Assignee: Matthias J. Sax >

[jira] [Updated] (KAFKA-16078) InterBrokerProtocolVersion defaults to non-production MetadataVersion

2024-01-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-16078: - Description: The InterBrokerProtocolVersion currently defaults to a non-production

[jira] [Resolved] (KAFKA-16078) Be more consistent about getting the latest MetadataVersion

2024-01-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-16078. -- Fix Version/s: 3.7.0 Reviewer: Colin Patrick McCabe Resolution: Fixed > Be

[jira] [Updated] (KAFKA-16078) Be more consistent about getting the latest MetadataVersion

2024-01-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-16078: - Summary: Be more consistent about getting the latest MetadataVersion (was:

[jira] [Updated] (KAFKA-16078) InterBrokerProtocolVersion defaults to non-production MetadataVersion

2024-01-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-16078: - Description: Be more consistent about getting the latest MetadataVersion >

[jira] [Updated] (KAFKA-16123) KStreamKStreamJoinProcessor forwards null records for left/outer joins unconditionally of the join window.

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16123: Component/s: streams > KStreamKStreamJoinProcessor forwards null records for left/outer

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-17 Thread via GitHub
mjsax commented on PR #15217: URL: https://github.com/apache/kafka/pull/15217#issuecomment-1897540146 Ah. Fair enough. I think (hope?) that existing unit/integration test ensure we did not miss a place :) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MINOR Removed unused CommittedOffsetsFile class. [kafka]

2024-01-17 Thread via GitHub
satishd commented on PR #15209: URL: https://github.com/apache/kafka/pull/15209#issuecomment-1897539946 >Should we also avoid creating the

[jira] [Assigned] (KAFKA-16161) Avoid creating remote log metadata snapshot file in partition data directory.

2024-01-17 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana reassigned KAFKA-16161: -- Assignee: Kamal Chandraprakash > Avoid creating remote log metadata snapshot file in

[jira] [Created] (KAFKA-16161) Avoid creating remote log metadata snapshot file in partition data directory.

2024-01-17 Thread Satish Duggana (Jira)
Satish Duggana created KAFKA-16161: -- Summary: Avoid creating remote log metadata snapshot file in partition data directory. Key: KAFKA-16161 URL: https://issues.apache.org/jira/browse/KAFKA-16161

[jira] [Updated] (KAFKA-16161) Avoid creating remote log metadata snapshot file in partition data directory.

2024-01-17 Thread Satish Duggana (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Satish Duggana updated KAFKA-16161: --- Labels: KIP-405 (was: ) > Avoid creating remote log metadata snapshot file in partition

Re: [PR] KAFKA-15594: Add version 3.6 to Kafka Streams system tests [kafka]

2024-01-17 Thread via GitHub
mjsax commented on PR #15151: URL: https://github.com/apache/kafka/pull/15151#issuecomment-1897517851 Other system test fixed got merged. Rebased this PR and retriggered system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6037/ -- This is an automated

Re: [PR] KAFKA-15307: update/note deprecated configs [kafka]

2024-01-17 Thread via GitHub
mjsax commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1456637776 ## docs/streams/developer-guide/config-streams.html: ## @@ -1010,6 +1016,18 @@ topology.optimization + windowed.inner.class.serde + + + +

[jira] [Commented] (KAFKA-15538) Client support for java regex based subscription

2024-01-17 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807937#comment-17807937 ] Phuc Hong Tran commented on KAFKA-15538: I understand now. Thanks [~lianetm]  > Client support

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-17 Thread via GitHub
agavra commented on PR #15217: URL: https://github.com/apache/kafka/pull/15217#issuecomment-1897508799 @mjsax - yes the changed code should definitely work, my point was that I can't confirm that there aren't other places we need to change as well. -- This is an automated message from

Re: [PR] KAFKA-15307: update/note deprecated configs [kafka]

2024-01-17 Thread via GitHub
mjsax commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1456632988 ## docs/streams/developer-guide/config-streams.html: ## @@ -257,7 +258,12 @@ num.standby.replicasThe maximum number of records to buffer per partition.

Re: [PR] KAFKA-15307: update/note deprecated configs [kafka]

2024-01-17 Thread via GitHub
mjsax commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1456632789 ## docs/streams/developer-guide/config-streams.html: ## @@ -257,7 +258,12 @@ num.standby.replicasThe maximum number of records to buffer per partition.

Re: [PR] KAFKA-15307: update/note deprecated configs [kafka]

2024-01-17 Thread via GitHub
mjsax commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1456631743 ## docs/streams/developer-guide/config-streams.html: ## @@ -257,7 +258,12 @@ num.standby.replicasThe maximum number of records to buffer per partition.

Re: [PR] KAFKA-15307: update/note deprecated configs [kafka]

2024-01-17 Thread via GitHub
mjsax commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1456631544 ## docs/streams/developer-guide/config-streams.html: ## @@ -257,7 +258,12 @@ num.standby.replicasThe maximum number of records to buffer per partition.

Re: [PR] KAFKA-15307: update/note deprecated configs [kafka]

2024-01-17 Thread via GitHub
mjsax commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1456631293 ## docs/streams/developer-guide/config-streams.html: ## @@ -257,7 +258,12 @@ num.standby.replicasThe maximum number of records to buffer per partition.

Re: [PR] KAFKA-15307: Update/errors for deprecated config [kafka]

2024-01-17 Thread via GitHub
mjsax commented on PR #14448: URL: https://github.com/apache/kafka/pull/14448#issuecomment-1897502404 Thanks for the PR. Overall LGTM. I am just wondering if we should also update the JavaDocs for all deprecated configs? For example: ``` /** {@code

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-17 Thread via GitHub
mjsax commented on PR #15217: URL: https://github.com/apache/kafka/pull/15217#issuecomment-1897479088 > I'm not familiar with the IQv2 path so can't comment on whether or not it makes sense from that perspective but it should fix

[jira] [Updated] (KAFKA-16159) Prune excessive logging from Telemetry Reporter

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16159: Affects Version/s: 3.7.0 > Prune excessive logging from Telemetry Reporter >

[jira] [Updated] (KAFKA-16159) Prune excessive logging from Telemetry Reporter

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16159: Fix Version/s: (was: 3.8.0) > Prune excessive logging from Telemetry Reporter >

[jira] [Commented] (KAFKA-16157) Topic recreation with offline disk doesn't update leadership/shrink ISR correctly

2024-01-17 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807927#comment-17807927 ] Gaurav Narula commented on KAFKA-16157: --- [~mimaison] I raised the bug while testing against trunk

Re: [PR] KAFKA-16078 IBP defaults to latest production MetadataVersion [kafka]

2024-01-17 Thread via GitHub
cmccabe merged PR #15118: URL: https://github.com/apache/kafka/pull/15118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14589 ConsumerGroupCommand options and case classes rewritten [kafka]

2024-01-17 Thread via GitHub
nizhikov commented on code in PR #14856: URL: https://github.com/apache/kafka/pull/14856#discussion_r1456589544 ## tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java: ## @@ -0,0 +1,263 @@ +/* Review Comment: package renamed. --

Re: [PR] KAFKA-14589 ConsumerGroupCommand options and case classes rewritten [kafka]

2024-01-17 Thread via GitHub
jolshan commented on code in PR #14856: URL: https://github.com/apache/kafka/pull/14856#discussion_r1456587593 ## tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java: ## @@ -0,0 +1,263 @@ +/* Review Comment: That works for me. Thanks!

[jira] [Created] (KAFKA-16160) AsyncKafkaConsumer is trying to connect to a disconnected note in a tight loop

2024-01-17 Thread Philip Nee (Jira)
Philip Nee created KAFKA-16160: -- Summary: AsyncKafkaConsumer is trying to connect to a disconnected note in a tight loop Key: KAFKA-16160 URL: https://issues.apache.org/jira/browse/KAFKA-16160 Project:

[jira] [Updated] (KAFKA-16160) AsyncKafkaConsumer is trying to connect to a disconnected note in a tight loop

2024-01-17 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16160: --- Description: Observing some excessive logging running AsyncKafkaConsumer and observing excessive

[jira] [Updated] (KAFKA-16160) AsyncKafkaConsumer is trying to connect to a disconnected note in a tight loop

2024-01-17 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16160: --- Labels: consumer-threading-refactor (was: ) > AsyncKafkaConsumer is trying to connect to a

[jira] [Updated] (KAFKA-16160) AsyncKafkaConsumer is trying to connect to a disconnected note in a tight loop

2024-01-17 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16160: --- Parent: KAFKA-14246 Issue Type: Sub-task (was: Task) > AsyncKafkaConsumer is trying to

Re: [PR] KAFKA-16104: Enable additional PlaintextConsumerTest tests for new consumer [kafka]

2024-01-17 Thread via GitHub
kirktrue commented on PR #15206: URL: https://github.com/apache/kafka/pull/15206#issuecomment-1897133683 Closing and reopening to kick off another test run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16104: Enable additional PlaintextConsumerTest tests for new consumer [kafka]

2024-01-17 Thread via GitHub
kirktrue closed pull request #15206: KAFKA-16104: Enable additional PlaintextConsumerTest tests for new consumer URL: https://github.com/apache/kafka/pull/15206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15827: Prevent KafkaBasedLog subclasses from leaking passed-in clients [kafka]

2024-01-17 Thread via GitHub
gharris1727 commented on code in PR #14763: URL: https://github.com/apache/kafka/pull/14763#discussion_r1456550693 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -812,6 +812,7 @@ public void stop() {

[jira] [Updated] (KAFKA-16159) Prune excessive logging from Telemetry Reporter

2024-01-17 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16159: --- Description: While running system tests locally, I've noticed excessive logging of the Telemtry

[jira] [Resolved] (KAFKA-16131) Repeated UnsupportedVersionException logged when running Kafka 3.7.0-RC2 KRaft cluster with metadata version 3.6

2024-01-17 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe resolved KAFKA-16131. -- Resolution: Fixed > Repeated UnsupportedVersionException logged when running Kafka 3.7.0-RC2

[jira] [Updated] (KAFKA-16159) Prune excessive logging from Telemetry Reporter

2024-01-17 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16159: --- Fix Version/s: 3.8.0 > Prune excessive logging from Telemetry Reporter >

[jira] [Updated] (KAFKA-16159) Prune excessive logging from Telemetry Reporter

2024-01-17 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16159: --- Labels: consumer logging (was: logging) > Prune excessive logging from Telemetry Reporter >

[jira] [Updated] (KAFKA-16159) Prune excessive logging from Telemetry Reporter

2024-01-17 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16159: --- Labels: logging (was: ) > Prune excessive logging from Telemetry Reporter >

Re: [PR] KAFKA-14589 ConsumerGroupCommand options and case classes rewritten [kafka]

2024-01-17 Thread via GitHub
nizhikov commented on code in PR #14856: URL: https://github.com/apache/kafka/pull/14856#discussion_r1456546534 ## tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java: ## @@ -0,0 +1,263 @@ +/* Review Comment: > I think when we have had

[jira] [Created] (KAFKA-16159) Prune excessive logging from Telemetry Reporter

2024-01-17 Thread Philip Nee (Jira)
Philip Nee created KAFKA-16159: -- Summary: Prune excessive logging from Telemetry Reporter Key: KAFKA-16159 URL: https://issues.apache.org/jira/browse/KAFKA-16159 Project: Kafka Issue Type: Task

Re: [PR] KAFKA-16131: Only update directoryIds if the metadata version supports DirectoryAssignment [kafka]

2024-01-17 Thread via GitHub
cmccabe merged PR #15197: URL: https://github.com/apache/kafka/pull/15197 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14589 ConsumerGroupCommand options and case classes rewritten [kafka]

2024-01-17 Thread via GitHub
jolshan commented on code in PR #14856: URL: https://github.com/apache/kafka/pull/14856#discussion_r1456536862 ## tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java: ## @@ -0,0 +1,263 @@ +/* Review Comment: I wasn't sure if we wanted

Re: [PR] KAFKA-14589 ConsumerGroupCommand options and case classes rewritten [kafka]

2024-01-17 Thread via GitHub
nizhikov commented on code in PR #14856: URL: https://github.com/apache/kafka/pull/14856#discussion_r1456530381 ## tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java: ## @@ -0,0 +1,263 @@ +/* Review Comment: > Is the

Re: [PR] KAFKA-14589 ConsumerGroupCommand options and case classes rewritten [kafka]

2024-01-17 Thread via GitHub
nizhikov commented on PR #14856: URL: https://github.com/apache/kafka/pull/14856#issuecomment-1896962207 @jolshan > Did we want to delete the old files in this PR or a follow up? For the previous command we remove old files only when command was merged 1. Reassign case

Re: [PR] MINOR: Uniformize error handling/transformation in GroupCoordinatorService [kafka]

2024-01-17 Thread via GitHub
jeffkbkim commented on code in PR #15196: URL: https://github.com/apache/kafka/pull/15196#discussion_r1456526190 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -1098,30 +1054,36 @@ private static boolean

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-17 Thread via GitHub
mjsax merged PR #15148: URL: https://github.com/apache/kafka/pull/15148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14589 ConsumerGroupCommand options and case classes rewritten [kafka]

2024-01-17 Thread via GitHub
nizhikov commented on code in PR #14856: URL: https://github.com/apache/kafka/pull/14856#discussion_r1456523688 ## tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-01-17 Thread via GitHub
mjsax commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1456522509 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -715,15 +716,22 @@ private Optional>

Re: [PR] KAFKA-14589 ConsumerGroupCommand options and case classes rewritten [kafka]

2024-01-17 Thread via GitHub
nizhikov commented on code in PR #14856: URL: https://github.com/apache/kafka/pull/14856#discussion_r1456521165 ## tools/src/main/java/org/apache/kafka/tools/consumergroup/ConsumerGroupCommandOptions.java: ## @@ -0,0 +1,263 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] KAFKA-14589 ConsumerGroupCommand options and case classes rewritten [kafka]

2024-01-17 Thread via GitHub
nizhikov commented on code in PR #14856: URL: https://github.com/apache/kafka/pull/14856#discussion_r1456518422 ## tools/src/main/java/org/apache/kafka/tools/consumergroup/PartitionAssignmentState.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Resolved] (KAFKA-16139) StreamsUpgradeTest fails consistently in 3.7.0

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-16139. - Fix Version/s: 3.7.0 3.6.1 Resolution: Fixed >

Re: [PR] KAFKA-16139: Fix StreamsUpgradeTest [kafka]

2024-01-17 Thread via GitHub
mjsax commented on PR #15207: URL: https://github.com/apache/kafka/pull/15207#issuecomment-1896826978 Merged to `trunk` and cherry-picked to `3.7` branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16139: Fix StreamsUpgradeTest [kafka]

2024-01-17 Thread via GitHub
mjsax merged PR #15207: URL: https://github.com/apache/kafka/pull/15207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-16141) StreamsStandbyTask##test_standby_tasks_rebalanceArguments:{ “metadata_quorum”: “ISOLATED_KRAFT”, “use_new_coordinator”: false} fails consistently in 3.7

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16141: Issue Type: Bug (was: Test) >

[PR] KAFKA-16107: Stop fetching while onPartitionsAssign completes [kafka]

2024-01-17 Thread via GitHub
anurag-harness opened a new pull request, #15218: URL: https://github.com/apache/kafka/pull/15218 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] KAFKA-16147; Partition is assigned to two members at the same time [kafka]

2024-01-17 Thread via GitHub
jeffkbkim commented on PR #15212: URL: https://github.com/apache/kafka/pull/15212#issuecomment-1896786496 > when a member has a partition pending revocation re-assigned to him before the revocation is completed, the partition epoch is lost to confirm, the `previousMemberEpoch=11`

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-17 Thread via GitHub
mjsax commented on PR #15217: URL: https://github.com/apache/kafka/pull/15217#issuecomment-1896752852 Triggered a system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6035/ -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Comment Edited] (KAFKA-16141) StreamsStandbyTask##test_standby_tasks_rebalanceArguments:{ “metadata_quorum”: “ISOLATED_KRAFT”, “use_new_coordinator”: false} fails consistently in 3.7

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807890#comment-17807890 ] Matthias J. Sax edited comment on KAFKA-16141 at 1/17/24 9:15 PM: --

[jira] [Created] (KAFKA-16158) Cleanup usage of `TimestampedBytesStore` interface

2024-01-17 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-16158: --- Summary: Cleanup usage of `TimestampedBytesStore` interface Key: KAFKA-16158 URL: https://issues.apache.org/jira/browse/KAFKA-16158 Project: Kafka

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-17 Thread via GitHub
mjsax commented on code in PR #15217: URL: https://github.com/apache/kafka/pull/15217#discussion_r1456485535 ## streams/src/main/java/org/apache/kafka/streams/state/internals/StoreQueryUtils.java: ## @@ -422,6 +423,16 @@ public static Function getDeserializeValue(final

Re: [PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-17 Thread via GitHub
mjsax commented on PR #15217: URL: https://github.com/apache/kafka/pull/15217#issuecomment-1896696469 \cc @agavra @stanislavkozlovski -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[PR] KAFKA-16141: Fix StreamsStandbyTask system test [kafka]

2024-01-17 Thread via GitHub
mjsax opened a new pull request, #15217: URL: https://github.com/apache/kafka/pull/15217 KAFKA-15629 added `TimestampedByteStore` interface to `KeyValueToTimestampedKeyValueByteStoreAdapter` which break the restore code path and thus some system tests. This PR reverts this change

[jira] [Commented] (KAFKA-16141) StreamsStandbyTask##test_standby_tasks_rebalanceArguments:{ “metadata_quorum”: “ISOLATED_KRAFT”, “use_new_coordinator”: false} fails consistently in 3.7

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807890#comment-17807890 ] Matthias J. Sax commented on KAFKA-16141: - After discussion with Almog (and testing it)

[jira] [Assigned] (KAFKA-16141) StreamsStandbyTask##test_standby_tasks_rebalanceArguments:{ “metadata_quorum”: “ISOLATED_KRAFT”, “use_new_coordinator”: false} fails consistently in 3.7

2024-01-17 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-16141: --- Assignee: Matthias J. Sax (was: Almog Gavra) >

Re: [PR] Metadata schema checker [kafka]

2024-01-17 Thread via GitHub
cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1456451709 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

2024-01-17 Thread via GitHub
cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1456448973 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

2024-01-17 Thread via GitHub
cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1456448643 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

2024-01-17 Thread via GitHub
cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1456447370 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

2024-01-17 Thread via GitHub
cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1456441308 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

2024-01-17 Thread via GitHub
cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1456442184 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Metadata schema checker [kafka]

2024-01-17 Thread via GitHub
cmccabe commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1456440526 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,347 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (KAFKA-16151) Fix PlaintextConsumerTest.testPerPartitionLeadMetricsCleanUpWithSubscribe

2024-01-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16151. --- Resolution: Duplicate > Fix PlaintextConsumerTest.testPerPartitionLeadMetricsCleanUpWithSubscribe >

[jira] [Resolved] (KAFKA-16150) Fix PlaintextConsumerTest.testPerPartitionLagMetricsCleanUpWithSubscribe

2024-01-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True resolved KAFKA-16150. --- Resolution: Duplicate > Fix PlaintextConsumerTest.testPerPartitionLagMetricsCleanUpWithSubscribe >

[jira] [Commented] (KAFKA-15878) KIP-768: Extend support for opaque (i.e. non-JWT) tokens in SASL/OAUTHBEARER

2024-01-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807866#comment-17807866 ] Kirk True commented on KAFKA-15878: --- [~philomathanuj]—for this to work, I assume the user would have

[jira] [Updated] (KAFKA-16116) AsyncKafkaConsumer: Add missing rebalance metrics

2024-01-17 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16116: -- Parent: (was: KAFKA-14246) Issue Type: Improvement (was: Sub-task) > AsyncKafkaConsumer:

[jira] [Commented] (KAFKA-16156) System test failing for new consumer on endOffsets with negative timestamps

2024-01-17 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17807858#comment-17807858 ] Justine Olshan commented on KAFKA-16156: The transactional copier is pretty old. We can probably

  1   2   >