lucasbru merged PR #15271:
URL: https://github.com/apache/kafka/pull/15271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
yashmayya commented on code in PR #15249:
URL: https://github.com/apache/kafka/pull/15249#discussion_r1473904200
##
connect/runtime/src/test/java/org/apache/kafka/connect/util/clusters/EmbeddedConnect.java:
##
@@ -963,11 +962,19 @@ public Set activeWorkers() {
return
[
https://issues.apache.org/jira/browse/KAFKA-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16156:
--
Component/s: system tests
> System test failing for new consumer on endOffsets with negative
[
https://issues.apache.org/jira/browse/KAFKA-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16156:
--
Labels: consumer-threading-refactor kip-848-client-support system-tests
(was:
[
https://issues.apache.org/jira/browse/KAFKA-16115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16115:
--
Labels: consumer-threading-refactor metrics (was:
consumer-threading-refactor)
>
[
https://issues.apache.org/jira/browse/KAFKA-16112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16112:
--
Labels: consumer-threading-refactor metrics (was:
consumer-threading-refactor)
> Review JMX metrics
[
https://issues.apache.org/jira/browse/KAFKA-16113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16113:
--
Labels: consumer-threading-refactor metrics (was:
consumer-threading-refactor)
>
[
https://issues.apache.org/jira/browse/KAFKA-16142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16142:
--
Labels: consumer-threading-refactor metrics (was:
consumer-threading-refactor)
> Update metrics
[
https://issues.apache.org/jira/browse/KAFKA-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16116:
--
Labels: consumer-threading-refactor metrics (was:
consumer-threading-refactor)
>
[
https://issues.apache.org/jira/browse/KAFKA-16143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16143:
--
Labels: kip-848-client-support metrics (was: kip-848-client-support)
> New metrics for KIP-848
[
https://issues.apache.org/jira/browse/KAFKA-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16109:
--
Component/s: system tests
> Ensure system tests cover the "simple consumer + commit" use case
>
[
https://issues.apache.org/jira/browse/KAFKA-15557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15557:
--
Labels: consumer-threading-refactor fetcher unit-tests (was:
consumer-threading-refactor fetcher)
>
[
https://issues.apache.org/jira/browse/KAFKA-15606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15606:
--
Labels: consumer-threading-refactor fetcher unit-tests (was:
consumer-threading-refactor fetcher)
>
[
https://issues.apache.org/jira/browse/KAFKA-15635?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15635:
--
Labels: consumer-threading-refactor fetcher unit-tests (was:
consumer-threading-refactor fetcher)
>
[
https://issues.apache.org/jira/browse/KAFKA-16000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16000:
--
Labels: consumer-threading-refactor unit-tests (was:
consumer-threading-refactor)
> Migrate
[
https://issues.apache.org/jira/browse/KAFKA-15637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15637:
--
Labels: consumer-threading-refactor fetcher unit-tests (was:
consumer-threading-refactor fetcher)
>
[
https://issues.apache.org/jira/browse/KAFKA-15639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15639:
--
Labels: consumer-threading-refactor unit-tests (was:
consumer-threading-refactor)
> Investigate
[
https://issues.apache.org/jira/browse/KAFKA-15652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15652:
--
Labels: consumer-threading-refactor position unit-tests (was:
consumer-threading-refactor position)
[
https://issues.apache.org/jira/browse/KAFKA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15991:
--
Labels: consumer-threading-refactor flaky-test kip-848-client-support
unit-tests (was:
[
https://issues.apache.org/jira/browse/KAFKA-15999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15999:
--
Labels: consumer-threading-refactor unit-tests (was:
consumer-threading-refactor)
> Migrate
[
https://issues.apache.org/jira/browse/KAFKA-15638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15638:
--
Labels: consumer-threading-refactor unit-tests (was:
consumer-threading-refactor)
> Investigate
[
https://issues.apache.org/jira/browse/KAFKA-16001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16001:
--
Labels: consumer-threading-refactor unit-tests (was:
consumer-threading-refactor)
> Migrate
[
https://issues.apache.org/jira/browse/KAFKA-15636?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15636:
--
Labels: consumer-threading-refactor fetcher unit-tests (was:
consumer-threading-refactor fetcher)
>
[
https://issues.apache.org/jira/browse/KAFKA-14724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-14724:
--
Labels: consumer-threading-refactor fetcher kip-848-e2e kip-848-preview
unit-tests (was:
[
https://issues.apache.org/jira/browse/KAFKA-15634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15634:
--
Labels: consumer-threading-refactor fetcher unit-tests (was:
consumer-threading-refactor fetcher)
>
[
https://issues.apache.org/jira/browse/KAFKA-15617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15617:
--
Labels: consumer-threading-refactor fetcher unit-tests (was:
consumer-threading-refactor fetcher)
>
[
https://issues.apache.org/jira/browse/KAFKA-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15971:
--
Component/s: (was: unit tests)
> Re-enable consumer integration tests for new consumer
>
[
https://issues.apache.org/jira/browse/KAFKA-15971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15971:
--
Labels: consumer-threading-refactor integration-tests kip-848
kip-848-preview (was:
[
https://issues.apache.org/jira/browse/KAFKA-15932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15932:
--
Labels: consumer-threading-refactor flaky-test integration-tests
kip-848-client-support (was:
[
https://issues.apache.org/jira/browse/KAFKA-15932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15932:
--
Labels: consumer-threading-refactor flaky-test integration-tests kip-848
kip-848-client-support
[
https://issues.apache.org/jira/browse/KAFKA-15932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15932:
--
Component/s: (was: unit tests)
> Flaky test -
[
https://issues.apache.org/jira/browse/KAFKA-15986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15986:
--
Component/s: (was: unit tests)
> New consumer group protocol integration test failures
>
[
https://issues.apache.org/jira/browse/KAFKA-15991?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15991:
--
Labels: consumer-threading-refactor flaky-test kip-848-client-support
(was:
[
https://issues.apache.org/jira/browse/KAFKA-15515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15515:
--
Component/s: (was: unit tests)
> Remove duplicated integration tests for new consumer
>
[
https://issues.apache.org/jira/browse/KAFKA-15986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15986:
--
Labels: consumer-threading-refactor integration-tests kip-848
kip-848-client-support (was:
[
https://issues.apache.org/jira/browse/KAFKA-15515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15515:
--
Labels: consumer-threading-refactor integration-tests (was:
consumer-threading-refactor
[
https://issues.apache.org/jira/browse/KAFKA-16167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16167:
--
Labels: consumer-threading-refactor integration-tests
kip-848-client-support (was:
[
https://issues.apache.org/jira/browse/KAFKA-16167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16167:
--
Component/s: (was: unit tests)
> Fix PlaintextConsumerTest.testAutoCommitOnCloseAfterWakeup
>
[
https://issues.apache.org/jira/browse/KAFKA-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16109:
--
Component/s: (was: system tests)
> Ensure system tests cover the "simple consumer + commit" use
[
https://issues.apache.org/jira/browse/KAFKA-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16109:
--
Labels: consumer-threading-refactor system-tests (was:
consumer-threading-refactor)
> Ensure system
[
https://issues.apache.org/jira/browse/KAFKA-16104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16104:
--
Component/s: (was: system tests)
Labels: consumer-threading-refactor integration-tests
[
https://issues.apache.org/jira/browse/KAFKA-15993?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15993:
--
Component/s: (was: system tests)
Labels: consumer-threading-refactor integration-tests
[
https://issues.apache.org/jira/browse/KAFKA-15848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15848:
--
Component/s: (was: system tests)
Labels: consumer-threading-refactor integration-tests
[
https://issues.apache.org/jira/browse/KAFKA-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16023:
--
Component/s: (was: system tests)
Labels: consumer-threading-refactor integration-tests
[
https://issues.apache.org/jira/browse/KAFKA-16019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16019:
--
Component/s: (was: system tests)
Labels: consumer-threading-refactor integration-tests
[
https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16010:
--
Component/s: (was: system tests)
Labels: consumer-threading-refactor integration-tests
[
https://issues.apache.org/jira/browse/KAFKA-16009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16009:
--
Component/s: (was: system tests)
Labels: consumer-threading-refactor integration-tests
[
https://issues.apache.org/jira/browse/KAFKA-16008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16008:
--
Component/s: (was: system tests)
Labels: consumer-threading-refactor integration-tests
[
https://issues.apache.org/jira/browse/KAFKA-16134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16134:
--
Labels: consumer-threading-refactor integration-tests
kip-848-client-support (was:
[
https://issues.apache.org/jira/browse/KAFKA-16134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16134:
--
Component/s: (was: system tests)
>
[
https://issues.apache.org/jira/browse/KAFKA-16151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16151:
--
Labels: consumer-threading-refactor integration-tests
kip-848-client-support (was:
[
https://issues.apache.org/jira/browse/KAFKA-16011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16011:
--
Labels: integration-tests kip-848-client-support timeout (was:
kip-848-client-support timeout)
>
[
https://issues.apache.org/jira/browse/KAFKA-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16150:
--
Labels: consumer-threading-refactor integration-tests
kip-848-client-support (was:
[
https://issues.apache.org/jira/browse/KAFKA-16135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16135:
--
Labels: consumer-threading-refactor integration-tests
kip-848-client-support (was:
[
https://issues.apache.org/jira/browse/KAFKA-16150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16150:
--
Component/s: (was: system tests)
> Fix
[
https://issues.apache.org/jira/browse/KAFKA-16011?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16011:
--
Component/s: (was: system tests)
> Fix
[
https://issues.apache.org/jira/browse/KAFKA-16135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16135:
--
Component/s: (was: system tests)
>
[
https://issues.apache.org/jira/browse/KAFKA-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16152:
--
Component/s: (was: system tests)
> Fix
>
[
https://issues.apache.org/jira/browse/KAFKA-16151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16151:
--
Component/s: (was: system tests)
> Fix
[
https://issues.apache.org/jira/browse/KAFKA-16037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16037:
--
Labels: kip-848-client-support system-tests (was: kip-848-client-support)
> Upgrade existing system
[
https://issues.apache.org/jira/browse/KAFKA-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16152:
--
Labels: consumer-threading-refactor integration-tests
kip-848-client-support (was:
[
https://issues.apache.org/jira/browse/KAFKA-15691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15691:
--
Labels: kip-848-client-support system-tests (was: kip-848-client-support)
> Add new system tests to
jolshan opened a new pull request, #15303:
URL: https://github.com/apache/kafka/pull/15303
Playing around with adding a transaction version feature
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
showuon commented on PR #15273:
URL: https://github.com/apache/kafka/pull/15273#issuecomment-1920457353
> @showuon I rebased and addressed your comments. Did not remove properties
definitions from KafkaConfig, because this breaks a lot of tests. I think this
should be done as part of
gaurav-narula commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1473758133
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4912,7 +4919,9 @@ class ReplicaManagerTest {
assertTrue(fooPart eq fooPart2)
github-actions[bot] commented on PR #14691:
URL: https://github.com/apache/kafka/pull/14691#issuecomment-1920440845
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
Luke Chen created KAFKA-16214:
-
Summary: No user info when SASL authentication failure
Key: KAFKA-16214
URL: https://issues.apache.org/jira/browse/KAFKA-16214
Project: Kafka
Issue Type: Bug
showuon commented on code in PR #15263:
URL: https://github.com/apache/kafka/pull/15263#discussion_r1473746536
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -4912,7 +4919,9 @@ class ReplicaManagerTest {
assertTrue(fooPart eq fooPart2)
mumrah commented on code in PR #15293:
URL: https://github.com/apache/kafka/pull/15293#discussion_r1473671017
##
core/src/main/scala/kafka/server/metadata/ZkMetadataCache.scala:
##
@@ -65,48 +65,84 @@ case class MetadataSnapshot(partitionStates:
mutable.AnyRefMap[String,
[
https://issues.apache.org/jira/browse/KAFKA-12549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812993#comment-17812993
]
Matthias J. Sax commented on KAFKA-12549:
-
[~high.lee] – this ticket is superceded by
gharris1727 commented on code in PR #14663:
URL: https://github.com/apache/kafka/pull/14663#discussion_r1473603606
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java:
##
@@ -1994,53 +1616,6 @@ private void expectInitializeTask() {
mjsax commented on code in PR #14360:
URL: https://github.com/apache/kafka/pull/14360#discussion_r1473438104
##
docs/streams/developer-guide/config-streams.html:
##
@@ -1010,6 +1016,18 @@ topology.optimization
+ windowed.inner.class.serde
+
+
+
+
mjsax commented on code in PR #14360:
URL: https://github.com/apache/kafka/pull/14360#discussion_r1473419962
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -482,7 +482,8 @@ public class StreamsConfig extends AbstractConfig {
public static final
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1473330427
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/AbstractConsumerMetricsManager.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache
dajac commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1473247269
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DescribeConsumerGroupsHandler.java:
##
@@ -158,36 +295,71 @@ public ApiResult handleResponse(
C0urante closed pull request #15178: MINOR: Change Connect integration
StopStartLatch::await to throw TimeoutException on timeout
URL: https://github.com/apache/kafka/pull/15178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
C0urante commented on PR #15178:
URL: https://github.com/apache/kafka/pull/15178#issuecomment-1919630582
This change wasn't really that valuable; the only information it added was
already trivial and what one would expect to see (e.g., testing code that
waited for a connector to be stopped
C0urante opened a new pull request, #15302:
URL: https://github.com/apache/kafka/pull/15302
[Jira 1](https://issues.apache.org/jira/browse/KAFKA-15524), [Jira
2](https://issues.apache.org/jira/browse/KAFKA-15917)
In some rare cases, our integration tests observe that tasks are up and
AndrewJSchofield commented on code in PR #15253:
URL: https://github.com/apache/kafka/pull/15253#discussion_r1473234152
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DescribeConsumerGroupsHandler.java:
##
@@ -158,36 +295,71 @@ public ApiResult
[
https://issues.apache.org/jira/browse/KAFKA-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812824#comment-17812824
]
Lianet Magrans commented on KAFKA-16212:
Similar situation and approach on the client side btw
José Armando García Sancio created KAFKA-16213:
--
Summary: KRaft should honor voterId outside of VotedState
Key: KAFKA-16213
URL: https://issues.apache.org/jira/browse/KAFKA-16213
Project:
jolshan commented on code in PR #15237:
URL: https://github.com/apache/kafka/pull/15237#discussion_r1473219011
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -903,6 +906,45 @@ public boolean cleanupExpiredOffsets(String
gaurav-narula commented on code in PR #15262:
URL: https://github.com/apache/kafka/pull/15262#discussion_r1473210077
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2586,7 +2586,7 @@ class ReplicaManager(val config: KafkaConfig,
// retrieve the UUID here
[
https://issues.apache.org/jira/browse/KAFKA-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17812822#comment-17812822
]
Justine Olshan commented on KAFKA-16212:
When working on KIP-516 (topic IDs) there were many
[
https://issues.apache.org/jira/browse/KAFKA-15524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-15524:
-
Assignee: Chris Egerton
> Flaky test
>
[
https://issues.apache.org/jira/browse/KAFKA-15917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-15917:
-
Assignee: Chris Egerton
> Flaky test -
>
cmccabe commented on code in PR #15262:
URL: https://github.com/apache/kafka/pull/15262#discussion_r1473174695
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2586,7 +2586,7 @@ class ReplicaManager(val config: KafkaConfig,
// retrieve the UUID here because
cmccabe commented on code in PR #15262:
URL: https://github.com/apache/kafka/pull/15262#discussion_r1473174695
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -2586,7 +2586,7 @@ class ReplicaManager(val config: KafkaConfig,
// retrieve the UUID here because
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473168658
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
Review Comment:
Yeah, I can do that. I'm a little concerned that we might forget to
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473167769
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1841,33 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473167034
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1841,33 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473166531
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1841,33 @@ public void
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473165230
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1836,6 +1841,33 @@ public void
philipnee commented on code in PR #15216:
URL: https://github.com/apache/kafka/pull/15216#discussion_r1473160823
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/metrics/AbstractConsumerMetricsManager.java:
##
@@ -0,0 +1,94 @@
+/*
+ * Licensed to the Apache
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473153338
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java:
##
@@ -1097,10 +1102,10 @@ void handleRevocation(final Collection
[
https://issues.apache.org/jira/browse/KAFKA-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Omnia Ibrahim reassigned KAFKA-16212:
-
Assignee: Omnia Ibrahim
> Cache partitions by TopicIdPartition instead of
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473141072
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java:
##
@@ -157,7 +158,8 @@ int
nicktelford commented on code in PR #15264:
URL: https://github.com/apache/kafka/pull/15264#discussion_r1473126369
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##
@@ -1374,7 +1376,7 @@ public void signalResume() {
*/
int
C0urante commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-1919475280
Thanks for the in-depth analysis! I think part of the problem here stems
from trying to make our internal `Future`-based API cooperate with Java's
`CompleteableFuture` API. I've
jlprat commented on code in PR #15279:
URL: https://github.com/apache/kafka/pull/15279#discussion_r1473125018
##
core/src/main/scala/kafka/network/RequestChannel.scala:
##
@@ -92,18 +92,18 @@ object RequestChannel extends Logging {
val envelope:
1 - 100 of 165 matches
Mail list logo
