Re: [PR] KAFKA-14945: Add Serializer#serializeToByteBuffer() to reduce memory copying [kafka]

2024-02-04 Thread via GitHub
showuon commented on PR #12685: URL: https://github.com/apache/kafka/pull/12685#issuecomment-1926319143 @LinShunKang , sorry for being late. I had a quick look at https://github.com/apache/kafka/pull/14617, it looks like the `ByteBufferSerializer#serialize` is a public API and cannot be

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-04 Thread via GitHub
appchemist commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1476948608 ## core/src/test/scala/unit/kafka/server/epoch/LeaderEpochIntegrationTest.scala: ## @@ -142,17 +143,20 @@ class LeaderEpochIntegrationTest extends

[PR] KAFKA-14683 Migrate WorkerSinkTaskTest to Mockito (3/3) [kafka]

2024-02-04 Thread via GitHub
hgeraldino opened a new pull request, #15316: URL: https://github.com/apache/kafka/pull/15316 Last batch for migrating WorkerSinkTaskTest tests to Mockito -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] POC - DO NO MERGE: refactor StreamsConfig [kafka]

2024-02-04 Thread via GitHub
github-actions[bot] commented on PR #14548: URL: https://github.com/apache/kafka/pull/14548#issuecomment-1926172243 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-13965: Add missing doc for socket-server-metrics [kafka]

2024-02-04 Thread via GitHub
github-actions[bot] commented on PR #14676: URL: https://github.com/apache/kafka/pull/14676#issuecomment-1926172214 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

2024-02-04 Thread Hector Geraldino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814145#comment-17814145 ] Hector Geraldino commented on KAFKA-14132: -- Hey [~bachmanity1] - as I'm starting to wrap-up the

[jira] [Assigned] (KAFKA-15722) KRaft support in RackAwareAutoTopicCreationTest

2024-02-04 Thread Quoc Phong Dang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Quoc Phong Dang reassigned KAFKA-15722: --- Assignee: Quoc Phong Dang > KRaft support in RackAwareAutoTopicCreationTest >

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-04 Thread via GitHub
appchemist commented on code in PR #15225: URL: https://github.com/apache/kafka/pull/15225#discussion_r1476948608 ## core/src/test/scala/unit/kafka/server/epoch/LeaderEpochIntegrationTest.scala: ## @@ -142,17 +143,20 @@ class LeaderEpochIntegrationTest extends

[jira] [Updated] (KAFKA-16221) IllegalStateException from Producer

2024-02-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16221: Description: https://issues.apache.org/jira/browse/KAFKA-14831 fixed a producer bug about

[jira] [Updated] (KAFKA-16221) IllegalStateException from Producer

2024-02-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16221: Description: https://issues.apache.org/jira/browse/KAFKA-14831 fixed a producer bug about

[jira] [Commented] (KAFKA-16190) Member should send full heartbeat when rejoining

2024-02-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814133#comment-17814133 ] Lianet Magrans commented on KAFKA-16190: Hey [~phuctran], regarding your first comment, we need

[PR] KAFKA-16221: hotfix for EOS error handling [kafka]

2024-02-04 Thread via GitHub
mjsax opened a new pull request, #15315: URL: https://github.com/apache/kafka/pull/15315 Kafka Streams should not crash if a task is closed dirty. This is a hotfix to catch/swallow an IllegalStateException from `producer.abortTrandsaction()` on the close-dirty clean-up path. A

[jira] [Updated] (KAFKA-16221) IllegalStateException from Producer

2024-02-04 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16221: Description: https://issues.apache.org/jira/browse/KAFKA-14831 fixed a producer bug about

[jira] [Updated] (KAFKA-16190) Member should send full heartbeat when rejoining

2024-02-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16190: --- Description: The heartbeat request builder should make sure that all fields are sent in the

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-02-04 Thread via GitHub
Phuc-Hong-Tran commented on PR #15312: URL: https://github.com/apache/kafka/pull/15312#issuecomment-1925989408 @philipnee, PTAL. Thanks in advance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-16221) IllegalStateException from Producer

2024-02-04 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-16221: --- Summary: IllegalStateException from Producer Key: KAFKA-16221 URL: https://issues.apache.org/jira/browse/KAFKA-16221 Project: Kafka Issue Type: Bug

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-02-04 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1477311393 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-02-04 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1477310892 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] KAFKA-14589 [1/3] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-02-04 Thread via GitHub
nizhikov commented on PR #15256: URL: https://github.com/apache/kafka/pull/15256#issuecomment-1925708621 @showuon Looks like `kafka.server.DynamicBrokerReconfigurationTest.testThreadPoolResize()` fails in the latest trunk, also:

Re: [PR] KAFKA-6225: Adds an option to consume continuously [kafka]

2024-02-04 Thread via GitHub
themaxempire23 commented on PR #4082: URL: https://github.com/apache/kafka/pull/4082#issuecomment-1925699510 Hello is this still an issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Reuse hasDefault instead of comparing with NO_DEFAULT_VALUE directly [kafka]

2024-02-04 Thread via GitHub
wuYin closed pull request #10977: MINOR: Reuse hasDefault instead of comparing with NO_DEFAULT_VALUE directly URL: https://github.com/apache/kafka/pull/10977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-15538) Client support for java regex based subscription

2024-02-04 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814054#comment-17814054 ] Phuc Hong Tran commented on KAFKA-15538: [~lianetm], this ticket has some overlaps with ticket

Re: [PR] KAFKA-15761: KRaft support in EpochDrivenReplicationProtocolAcceptanceTest [kafka]

2024-02-04 Thread via GitHub
highluck commented on PR #15295: URL: https://github.com/apache/kafka/pull/15295#issuecomment-1925633442 @mimaison thank you! Everything has been revised! Please review again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to