Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-02-05 Thread via GitHub
appchemist commented on code in PR #15296: URL: https://github.com/apache/kafka/pull/15296#discussion_r1479343768 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch,

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-02-05 Thread via GitHub
appchemist commented on code in PR #15296: URL: https://github.com/apache/kafka/pull/15296#discussion_r1479343768 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch,

Re: [PR] Additional fix on the rollback migration documentation [kafka]

2024-02-05 Thread via GitHub
ppatierno commented on code in PR #15317: URL: https://github.com/apache/kafka/pull/15317#discussion_r1479329768 ## docs/ops.html: ## @@ -4054,16 +4054,18 @@ Reverting to ZooKeeper mode During the Migration - It is important to perform

Re: [PR] Additional fix on the rollback migration documentation [kafka]

2024-02-05 Thread via GitHub
ppatierno commented on code in PR #15317: URL: https://github.com/apache/kafka/pull/15317#discussion_r1479328537 ## docs/ops.html: ## @@ -4054,16 +4054,18 @@ Reverting to ZooKeeper mode During the Migration - It is important to perform

Re: [PR] Additional fix on the rollback migration documentation [kafka]

2024-02-05 Thread via GitHub
showuon commented on code in PR #15317: URL: https://github.com/apache/kafka/pull/15317#discussion_r1479316119 ## docs/ops.html: ## @@ -4054,16 +4054,18 @@ Reverting to ZooKeeper mode During the Migration - It is important to perform

Re: [PR] MINOR: add clarification about log compaction [kafka]

2024-02-05 Thread via GitHub
github-actions[bot] commented on PR #14701: URL: https://github.com/apache/kafka/pull/14701#issuecomment-1928723236 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15307: update/note deprecated configs [kafka]

2024-02-05 Thread via GitHub
ableegoldman commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1479177626 ## docs/streams/developer-guide/config-streams.html: ## @@ -1010,6 +1016,18 @@ topology.optimization + windowed.inner.class.serde + + +

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

2024-02-05 Thread Hector Geraldino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814575#comment-17814575 ] Hector Geraldino commented on KAFKA-14132: -- [~christo_lolov] I opened a separate Jira ticket to

Re: [PR] KAFKA-14683 Migrate WorkerSinkTaskTest to Mockito (2/3) [kafka]

2024-02-05 Thread via GitHub
hgeraldino commented on PR #15313: URL: https://github.com/apache/kafka/pull/15313#issuecomment-1928672763 Thanks @gharris1727 and @C0urante for reviewing and merging the [first PR](https://github.com/apache/kafka/pull/14663) The second second (of three) batches is ready for review

[PR] KAFKA-16102: fix the dynamic modification of listeners' IP or port no… [kafka]

2024-02-05 Thread via GitHub
pjl1070048431 opened a new pull request, #15321: URL: https://github.com/apache/kafka/pull/15321 When using the kafka-config.sh script to modify the IP and host in the listeners parameter, the configuration changes will not take effect dynamically. A broker restart is required for the

Re: [PR] KAFKA-13328, KAFKA-13329 (2): Add custom preflight validation support for connector header, key, and value converters [kafka]

2024-02-05 Thread via GitHub
gharris1727 commented on PR #14309: URL: https://github.com/apache/kafka/pull/14309#issuecomment-1928574152 Hi @C0urante could you resolve the merge conflicts now that #14304 is merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] MINOR: extend transaction unit test to validate drain [kafka]

2024-02-05 Thread via GitHub
artemlivshits opened a new pull request, #15320: URL: https://github.com/apache/kafka/pull/15320 There is a test already that checks that transactional messages are not drained when partition is not added, this change just logically completes the test to also show that messages can be

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-05 Thread via GitHub
appchemist commented on PR #15225: URL: https://github.com/apache/kafka/pull/15225#issuecomment-1928134072 Thanks for the review! @mimaison Yes, I have About my jira account, Username and Fullname are appchemist. -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-15832: Trigger client reconciliation based on manager poll [kafka]

2024-02-05 Thread via GitHub
lianetm commented on code in PR #15275: URL: https://github.com/apache/kafka/pull/15275#discussion_r1478904746 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -929,6 +938,9 @@ private void revokeAndAssign(SortedSet

Re: [PR] KAFKA-15832: Trigger client reconciliation based on manager poll [kafka]

2024-02-05 Thread via GitHub
lianetm commented on code in PR #15275: URL: https://github.com/apache/kafka/pull/15275#discussion_r1478881882 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1392,4 +1402,16 @@ public void

Re: [PR] KAFKA-15832: Trigger client reconciliation based on manager poll [kafka]

2024-02-05 Thread via GitHub
lianetm commented on code in PR #15275: URL: https://github.com/apache/kafka/pull/15275#discussion_r1478861404 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1392,4 +1402,16 @@ public void

[jira] [Assigned] (KAFKA-16155) Investigate testAutoCommitIntercept

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16155: - Assignee: Lucas Brutschy > Investigate testAutoCommitIntercept >

[jira] [Updated] (KAFKA-16019) Some of the tests in PlaintextConsumer can't seem to deterministically invoke and verify the consumer callback

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16019?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16019: -- Priority: Critical (was: Major) > Some of the tests in PlaintextConsumer can't seem to

[jira] [Updated] (KAFKA-16155) Investigate testAutoCommitIntercept

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16155: -- Priority: Critical (was: Major) > Investigate testAutoCommitIntercept >

[jira] [Updated] (KAFKA-16023) PlaintextConsumerTest needs to wait for reconciliation to complete before proceeding

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16023?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16023: -- Priority: Critical (was: Major) > PlaintextConsumerTest needs to wait for reconciliation to complete

[jira] [Updated] (KAFKA-16008) Fix PlaintextConsumerTest.testMaxPollIntervalMs

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16008?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16008: -- Priority: Critical (was: Major) > Fix PlaintextConsumerTest.testMaxPollIntervalMs >

[jira] [Updated] (KAFKA-16009) Fix PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16009: -- Priority: Critical (was: Major) > Fix PlaintextConsumerTest.testMaxPollIntervalMsDelayInRevocation >

[jira] [Updated] (KAFKA-16010) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16010: -- Priority: Critical (was: Major) > Fix

[jira] [Updated] (KAFKA-16152) Fix PlaintextConsumerTest.testStaticConsumerDetectsNewPartitionCreatedAfterRestart

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16152: -- Priority: Critical (was: Major) > Fix >

[jira] [Updated] (KAFKA-16169) FencedException in commitAsync not propagated without callback

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16169: -- Priority: Critical (was: Major) > FencedException in commitAsync not propagated without callback >

[jira] [Updated] (KAFKA-16167) Fix PlaintextConsumerTest.testAutoCommitOnCloseAfterWakeup

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16167: -- Priority: Critical (was: Major) > Fix PlaintextConsumerTest.testAutoCommitOnCloseAfterWakeup >

[jira] [Updated] (KAFKA-16190) Member should send full heartbeat when rejoining

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16190: -- Priority: Critical (was: Major) > Member should send full heartbeat when rejoining >

Re: [PR] Update Streams API broker compat table for AK 3.7 [kafka]

2024-02-05 Thread via GitHub
mjsax commented on PR #15051: URL: https://github.com/apache/kafka/pull/15051#issuecomment-1928006121 Merged to `trunk` and cherry-picked to `3.7`. Thanks @JimGalasyn! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Updated] (KAFKA-16109) Ensure system tests cover the "simple consumer + commit" use case

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16109: -- Fix Version/s: 4.0.0 (was: 3.8.0) > Ensure system tests cover the "simple

Re: [PR] Update Streams API broker compat table for AK 3.7 [kafka]

2024-02-05 Thread via GitHub
mjsax merged PR #15051: URL: https://github.com/apache/kafka/pull/15051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-16110) Implement consumer performance tests

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814501#comment-17814501 ] Kirk True commented on KAFKA-16110: --- Yes, we can use Trogdor for some _basic_ performance numbers.

[jira] [Updated] (KAFKA-16110) Implement consumer performance tests

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16110: -- Fix Version/s: 4.0.0 (was: 3.8.0) > Implement consumer performance tests >

[jira] [Updated] (KAFKA-15999) Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15999: -- Priority: Minor (was: Major) > Migrate HeartbeatRequestManagerTest away from ConsumerTestBuilder >

[jira] [Updated] (KAFKA-16000) Migrate MembershipManagerImplTest away from ConsumerTestBuilder

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16000: -- Priority: Minor (was: Major) > Migrate MembershipManagerImplTest away from ConsumerTestBuilder >

[jira] [Updated] (KAFKA-16001) Migrate ConsumerNetworkThreadTest away from ConsumerTestBuilder

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16001: -- Priority: Minor (was: Major) > Migrate ConsumerNetworkThreadTest away from ConsumerTestBuilder >

[jira] [Updated] (KAFKA-15556) Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-15556: -- Priority: Minor (was: Major) > Remove NetworkClientDelegate methods isUnavailable,

[jira] [Updated] (KAFKA-16142) Update metrics documentation for errors and new metrics

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16142: -- Priority: Minor (was: Major) > Update metrics documentation for errors and new metrics >

[jira] [Updated] (KAFKA-16142) Update metrics documentation for errors and new metrics

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16142: -- Description: What is the documentation to update here? AFAIUI, we're not changing or adding metrics

[jira] [Updated] (KAFKA-16142) Update metrics documentation for errors and new metrics

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16142: -- Priority: Major (was: Critical) > Update metrics documentation for errors and new metrics >

Re: [PR] KAFKA-15834: Remove more leaky NamedTopologyIntegrationTest tests [kafka]

2024-02-05 Thread via GitHub
gharris1727 merged PR #15243: URL: https://github.com/apache/kafka/pull/15243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-16133) Commits during reconciliation always time out

2024-02-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16133: -- Priority: Critical (was: Major) > Commits during reconciliation always time out >

Re: [PR] MINOR: Upgrade maven artifact version to 3.9.6 [kafka]

2024-02-05 Thread via GitHub
bmscomp commented on code in PR #15309: URL: https://github.com/apache/kafka/pull/15309#discussion_r1478764639 ## NOTICE-binary: ## @@ -560,7 +560,7 @@ The Apache Software Foundation (http://www.apache.org/). Maven Artifact -Copyright 2001-2019 The Apache Software

Re: [PR] KAFKA-14822: Allow restricting File and Directory ConfigProviders to specific paths [kafka]

2024-02-05 Thread via GitHub
gharris1727 commented on PR #14995: URL: https://github.com/apache/kafka/pull/14995#issuecomment-1927875101 @tinaselenge We can continue with the current design for KIP-993, it shouldn't need to change. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-14822: Allow restricting File and Directory ConfigProviders to specific paths [kafka]

2024-02-05 Thread via GitHub
gharris1727 commented on code in PR #14995: URL: https://github.com/apache/kafka/pull/14995#discussion_r1478774161 ## clients/src/main/java/org/apache/kafka/common/config/provider/FileConfigProvider.java: ## @@ -40,7 +42,13 @@ public class FileConfigProvider implements

Re: [PR] KAFKA-16087: Remove more leaky NamedTopologyIntegrationTest tests [kafka]

2024-02-05 Thread via GitHub
gharris1727 commented on PR #15243: URL: https://github.com/apache/kafka/pull/15243#issuecomment-1927847757 Test failures appear unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-14683 Migrate WorkerSinkTaskTest to Mockito (1/3) [kafka]

2024-02-05 Thread via GitHub
gharris1727 merged PR #14663: URL: https://github.com/apache/kafka/pull/14663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14683 Migrate WorkerSinkTaskTest to Mockito (1/3) [kafka]

2024-02-05 Thread via GitHub
gharris1727 commented on PR #14663: URL: https://github.com/apache/kafka/pull/14663#issuecomment-1927816703 Test failures appear unrelated, and the connect:runtime tests pass locally for me. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-14683 Migrate WorkerSinkTaskTest to Mockito (1/3) [kafka]

2024-02-05 Thread via GitHub
gharris1727 commented on PR #14663: URL: https://github.com/apache/kafka/pull/14663#issuecomment-1927814688 LGTM, thanks @hgeraldino for taking this on! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-15524, KAFKA-15917: Wait for zombie sink tasks' consumers to commit offsets before trying to modify their offsets in integration tests [kafka]

2024-02-05 Thread via GitHub
gharris1727 commented on code in PR #15302: URL: https://github.com/apache/kafka/pull/15302#discussion_r1478735608 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/OffsetsApiIntegrationTest.java: ## @@ -801,6 +806,11 @@ public void

Re: [PR] KAFKA-16221: hotfix for EOS error handling [kafka]

2024-02-05 Thread via GitHub
mjsax commented on code in PR #15315: URL: https://github.com/apache/kafka/pull/15315#discussion_r1478708058 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java: ## @@ -343,6 +343,19 @@ void abortTransaction() { //

[jira] [Created] (KAFKA-16225) Flaky test suite LogDirFailureTest

2024-02-05 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16225: --- Summary: Flaky test suite LogDirFailureTest Key: KAFKA-16225 URL: https://issues.apache.org/jira/browse/KAFKA-16225 Project: Kafka Issue Type: Bug

Re: [PR] KAFKA-16221: hotfix for EOS error handling [kafka]

2024-02-05 Thread via GitHub
ijuma commented on code in PR #15315: URL: https://github.com/apache/kafka/pull/15315#discussion_r1478629131 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java: ## @@ -343,6 +343,19 @@ void abortTransaction() { //

Re: [PR] KAFKA-16221: hotfix for EOS error handling [kafka]

2024-02-05 Thread via GitHub
jolshan commented on code in PR #15315: URL: https://github.com/apache/kafka/pull/15315#discussion_r1478623164 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java: ## @@ -343,6 +343,19 @@ void abortTransaction() { //

Re: [PR] KAFKA-16221: hotfix for EOS error handling [kafka]

2024-02-05 Thread via GitHub
ijuma commented on code in PR #15315: URL: https://github.com/apache/kafka/pull/15315#discussion_r1478618824 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsProducer.java: ## @@ -343,6 +343,19 @@ void abortTransaction() { //

Re: [PR] KAFKA-14412: Add statestore.uncommitted.max.bytes [kafka]

2024-02-05 Thread via GitHub
nicktelford commented on code in PR #15264: URL: https://github.com/apache/kafka/pull/15264#discussion_r1478581894 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskExecutor.java: ## @@ -157,7 +158,8 @@ int

[jira] [Resolved] (KAFKA-16221) IllegalStateException from Producer

2024-02-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-16221. - Resolution: Fixed > IllegalStateException from Producer >

[jira] [Commented] (KAFKA-16221) IllegalStateException from Producer

2024-02-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814437#comment-17814437 ] Matthias J. Sax commented on KAFKA-16221: - Marking this as resolved to 3.7 for now – we might

[jira] [Updated] (KAFKA-16221) IllegalStateException from Producer

2024-02-05 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16221: Fix Version/s: 3.7.0 > IllegalStateException from Producer >

[jira] [Created] (KAFKA-16224) Fix handling of deleted topic when auto-committing before revocation

2024-02-05 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16224: -- Summary: Fix handling of deleted topic when auto-committing before revocation Key: KAFKA-16224 URL: https://issues.apache.org/jira/browse/KAFKA-16224 Project:

[jira] [Updated] (KAFKA-16165) Consumer invalid transition on expired poll interval

2024-02-05 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16165?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16165: --- Description: Running system tests with the new async consumer revealed an invalid

Re: [PR] MINOR: Upgrade maven artifact version to 3.9.6 [kafka]

2024-02-05 Thread via GitHub
mimaison commented on code in PR #15309: URL: https://github.com/apache/kafka/pull/15309#discussion_r1478481808 ## NOTICE-binary: ## @@ -560,7 +560,7 @@ The Apache Software Foundation (http://www.apache.org/). Maven Artifact -Copyright 2001-2019 The Apache Software

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-05 Thread via GitHub
mimaison commented on PR #15225: URL: https://github.com/apache/kafka/pull/15225#issuecomment-1927320927 Thanks for the contribution! Do you have a Jira account? If so I can assign https://issues.apache.org/jira/browse/KAFKA-15717 to you. -- This is an automated message from the

[jira] [Resolved] (KAFKA-15717) KRaft support in LeaderEpochIntegrationTest

2024-02-05 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-15717. Fix Version/s: 3.8.0 Resolution: Fixed > KRaft support in

Re: [PR] KAFKA-15717: Added KRaft support in LeaderEpochIntegrationTest [kafka]

2024-02-05 Thread via GitHub
mimaison merged PR #15225: URL: https://github.com/apache/kafka/pull/15225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Fix code listings in quickstart.html [kafka]

2024-02-05 Thread via GitHub
jlprat merged PR #10767: URL: https://github.com/apache/kafka/pull/10767 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-05 Thread via GitHub
mimaison commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1478422740 ## tests/kafkatest/services/console_consumer.py: ## @@ -210,7 +210,10 @@ def start_cmd(self, node): # LoggingMessageFormatter was introduced after 0.9

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-05 Thread via GitHub
mimaison commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1478417021 ## tests/kafkatest/services/console_consumer.py: ## @@ -21,7 +21,7 @@ from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin from

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

2024-02-05 Thread Hector Geraldino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Geraldino updated KAFKA-14132: - Description: {color:#de350b}Some of the tests below use EasyMock as well. For those

[jira] [Created] (KAFKA-16223) Replace EasyMock and PowerMock with Mockito for KafkaConfigBackingStoreTest

2024-02-05 Thread Hector Geraldino (Jira)
Hector Geraldino created KAFKA-16223: Summary: Replace EasyMock and PowerMock with Mockito for KafkaConfigBackingStoreTest Key: KAFKA-16223 URL: https://issues.apache.org/jira/browse/KAFKA-16223

[jira] [Assigned] (KAFKA-16223) Replace EasyMock and PowerMock with Mockito for KafkaConfigBackingStoreTest

2024-02-05 Thread Hector Geraldino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Geraldino reassigned KAFKA-16223: Assignee: Hector Geraldino > Replace EasyMock and PowerMock with Mockito for

[jira] [Updated] (KAFKA-16222) Incorrect default user-principal quota after migration

2024-02-05 Thread Dominik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik updated KAFKA-16222: Description: We observed that our default user quota seems not to be migrated correctly. Before

[jira] [Updated] (KAFKA-16222) Incorrect default user-principal quota after migration

2024-02-05 Thread Dominik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik updated KAFKA-16222: Description: We observed that our default user quota seems not to be migrated correctly. Before

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

2024-02-05 Thread Nelson B. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nelson B. updated KAFKA-14132: -- Description: {color:#de350b}Some of the tests below use EasyMock as well. For those migrate both

[jira] [Comment Edited] (KAFKA-14132) Remaining PowerMock to Mockito tests

2024-02-05 Thread Nelson B. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814391#comment-17814391 ] Nelson B. edited comment on KAFKA-14132 at 2/5/24 2:54 PM: --- Hello,

[jira] [Commented] (KAFKA-14132) Remaining PowerMock to Mockito tests

2024-02-05 Thread Nelson B. (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814391#comment-17814391 ] Nelson B. commented on KAFKA-14132: --- Hello, Hector.  I haven't started working on this. Please feel

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-05 Thread via GitHub
mimaison commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1478369049 ## tools/src/main/java/org/apache/kafka/tools/consumer/LoggingMessageFormatter.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: Fix code listings in quickstart.html [kafka]

2024-02-05 Thread via GitHub
jlprat commented on code in PR #10767: URL: https://github.com/apache/kafka/pull/10767#discussion_r1478363587 ## docs/quickstart.html: ## @@ -233,19 +233,16 @@ Edit the config/connect-standalone.properties file, add or change the plugin.path configuration

[jira] [Created] (KAFKA-16222) Incorrect default user-principal quota after migration

2024-02-05 Thread Dominik (Jira)
Dominik created KAFKA-16222: --- Summary: Incorrect default user-principal quota after migration Key: KAFKA-16222 URL: https://issues.apache.org/jira/browse/KAFKA-16222 Project: Kafka Issue Type: Bug

Re: [PR] MINOR: Fix code listings in quickstart.html [kafka]

2024-02-05 Thread via GitHub
jlprat commented on code in PR #10767: URL: https://github.com/apache/kafka/pull/10767#discussion_r1478360214 ## docs/quickstart.html: ## @@ -233,19 +233,16 @@ Edit the config/connect-standalone.properties file, add or change the plugin.path configuration

Re: [PR] MINOR: fix code listings connect.html [kafka]

2024-02-05 Thread via GitHub
jlprat commented on PR #10769: URL: https://github.com/apache/kafka/pull/10769#issuecomment-1927153379 No need to wait for CI as these changes are not relevant for CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MINOR: fix code listings connect.html [kafka]

2024-02-05 Thread via GitHub
jlprat merged PR #10769: URL: https://github.com/apache/kafka/pull/10769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: fix code listings connect.html [kafka]

2024-02-05 Thread via GitHub
mimaison commented on code in PR #10769: URL: https://github.com/apache/kafka/pull/10769#discussion_r1478357280 ## docs/connect.html: ## @@ -1042,21 +1003,20 @@ 8.4 Administra You can use the REST API to view the current status of a connector and its tasks, including the

Re: [PR] MINOR: fix code listings connect.html [kafka]

2024-02-05 Thread via GitHub
jlprat commented on code in PR #10769: URL: https://github.com/apache/kafka/pull/10769#discussion_r1478346040 ## docs/connect.html: ## @@ -1042,21 +1003,20 @@ 8.4 Administra You can use the REST API to view the current status of a connector and its tasks, including the ID

Re: [PR] MINOR: fix code listings connect.html [kafka]

2024-02-05 Thread via GitHub
jlprat commented on code in PR #10769: URL: https://github.com/apache/kafka/pull/10769#discussion_r1478344272 ## docs/connect.html: ## @@ -1042,21 +1003,20 @@ 8.4 Administra You can use the REST API to view the current status of a connector and its tasks, including the ID

Re: [PR] MINOR: fix code listings connect.html [kafka]

2024-02-05 Thread via GitHub
jlprat commented on code in PR #10769: URL: https://github.com/apache/kafka/pull/10769#discussion_r1478344272 ## docs/connect.html: ## @@ -1042,21 +1003,20 @@ 8.4 Administra You can use the REST API to view the current status of a connector and its tasks, including the ID

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-05 Thread via GitHub
jlprat commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1478335911 ## streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java: ## @@ -1139,8 +1140,7 @@ private String

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-05 Thread via GitHub
mimaison commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1478333292 ## tools/src/test/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptionsTest.java: ## @@ -0,0 +1,622 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-05 Thread via GitHub
mimaison commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1478332515 ## streams/src/test/java/org/apache/kafka/streams/integration/KStreamAggregationIntegrationTest.java: ## @@ -1139,8 +1140,7 @@ private String

Re: [PR] MINOR: Fix code listings in quickstart.html [kafka]

2024-02-05 Thread via GitHub
mimaison commented on code in PR #10767: URL: https://github.com/apache/kafka/pull/10767#discussion_r1478327944 ## docs/quickstart.html: ## @@ -233,19 +233,16 @@ Edit the config/connect-standalone.properties file, add or change the plugin.path configuration

Re: [PR] MINOR: fix code listings connect.html [kafka]

2024-02-05 Thread via GitHub
mimaison commented on code in PR #10769: URL: https://github.com/apache/kafka/pull/10769#discussion_r1478313993 ## docs/connect.html: ## @@ -1042,21 +1003,20 @@ 8.4 Administra You can use the REST API to view the current status of a connector and its tasks, including the

[jira] [Commented] (KAFKA-14384) Flaky Test SelfJoinUpgradeIntegrationTest.shouldUpgradeWithTopologyOptimizationOff

2024-02-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814363#comment-17814363 ] Lucas Brutschy commented on KAFKA-14384: Hasn't failed in the last 30 dasy, so closing it.   

[jira] [Resolved] (KAFKA-14384) Flaky Test SelfJoinUpgradeIntegrationTest.shouldUpgradeWithTopologyOptimizationOff

2024-02-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14384?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-14384. Resolution: Fixed > Flaky Test >

[jira] [Resolved] (KAFKA-14385) Flaky Test QueryableStateIntegrationTest.shouldNotMakeStoreAvailableUntilAllStoresAvailable

2024-02-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-14385. Resolution: Fixed > Flaky Test >

[jira] [Commented] (KAFKA-14385) Flaky Test QueryableStateIntegrationTest.shouldNotMakeStoreAvailableUntilAllStoresAvailable

2024-02-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814362#comment-17814362 ] Lucas Brutschy commented on KAFKA-14385: Hasn't failed in the last 30 days, so closing it:

[jira] [Resolved] (KAFKA-8691) Flakey test ProcessorContextTest#shouldNotAllowToScheduleZeroMillisecondPunctuation

2024-02-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-8691. --- Resolution: Fixed > Flakey test >

[jira] [Commented] (KAFKA-8691) Flakey test ProcessorContextTest#shouldNotAllowToScheduleZeroMillisecondPunctuation

2024-02-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814361#comment-17814361 ] Lucas Brutschy commented on KAFKA-8691: --- Hasn't failed in the last 30 days:  

[jira] [Commented] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

2024-02-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814360#comment-17814360 ] Lucas Brutschy commented on KAFKA-9897: --- Hasn't flaked in the last 30 days, so closing it.  

[jira] [Resolved] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

2024-02-05 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-9897. --- Resolution: Fixed > Flaky Test

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-05 Thread via GitHub
jlprat commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1478135674 ## tools/src/main/java/org/apache/kafka/tools/consumer/LoggingMessageFormatter.java: ## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

[PR] MINOR: Removing `!` and Unused Import [kafka]

2024-02-05 Thread via GitHub
appchemist opened a new pull request, #15319: URL: https://github.com/apache/kafka/pull/15319 Remove `!` in some available cases and remove unused import ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

  1   2   >