Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2024-02-08 Thread via GitHub
VictorvandenHoven closed pull request #14426: KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items URL: https://github.com/apache/kafka/pull/14426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2024-02-08 Thread via GitHub
VictorvandenHoven commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1483962804 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java: ## @@ -436,6 +436,239 @@ public void

Re: [PR] MINOR: [WIP] debugging [kafka]

2024-02-08 Thread via GitHub
github-actions[bot] commented on PR #14730: URL: https://github.com/apache/kafka/pull/14730#issuecomment-1935284695 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] MINOR: fix scala 2.12 compilation [kafka]

2024-02-08 Thread via GitHub
cmccabe closed pull request #15344: MINOR: fix scala 2.12 compilation URL: https://github.com/apache/kafka/pull/15344 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINOR: fix scala 2.12 compilation [kafka]

2024-02-08 Thread via GitHub
cmccabe commented on PR #15344: URL: https://github.com/apache/kafka/pull/15344#issuecomment-1935226803 Fixed by #15343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-14412: Add statestore.uncommitted.max.bytes [kafka]

2024-02-08 Thread via GitHub
ableegoldman commented on code in PR #15264: URL: https://github.com/apache/kafka/pull/15264#discussion_r1483722072 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1836,6 +1842,36 @@ public void

Re: [PR] KAFKA-14822: Allow restricting File and Directory ConfigProviders to specific paths [kafka]

2024-02-08 Thread via GitHub
gharris1727 commented on PR #14995: URL: https://github.com/apache/kafka/pull/14995#issuecomment-1935143575 @tinaselenge Could you rebase on trunk? There was a build breakage that only affected Scala 2.12 which is resolved now. -- This is an automated message from the Apache Git Service.

[jira] [Assigned] (KAFKA-15983) Kafka-acls should return authorization already done if repeating work is issued

2024-02-08 Thread Anish Lukkireddy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anish Lukkireddy reassigned KAFKA-15983: Assignee: Anish Lukkireddy > Kafka-acls should return authorization already done

Re: [PR] MINOR fix scala compile issue [kafka]

2024-02-08 Thread via GitHub
cmccabe merged PR #15343: URL: https://github.com/apache/kafka/pull/15343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2024-02-08 Thread via GitHub
mjsax commented on code in PR #14426: URL: https://github.com/apache/kafka/pull/14426#discussion_r1483677544 ## streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java: ## @@ -436,6 +436,239 @@ public void

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

2024-02-08 Thread via GitHub
jeqo commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1483676179 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/storage/ProducerStateManagerBench.java: ## @@ -0,0 +1,82 @@ +package org.apache.kafka.jmh.storage; + +import

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

2024-02-08 Thread via GitHub
jolshan commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1483652492 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/storage/ProducerStateManagerBench.java: ## @@ -0,0 +1,82 @@ +package org.apache.kafka.jmh.storage; + +import

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

2024-02-08 Thread via GitHub
jolshan commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1483650845 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/storage/ProducerStateManagerBench.java: ## @@ -0,0 +1,82 @@ +package org.apache.kafka.jmh.storage; + +import

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

2024-02-08 Thread via GitHub
jolshan commented on code in PR #15324: URL: https://github.com/apache/kafka/pull/15324#discussion_r1483649564 ## storage/src/main/java/org/apache/kafka/storage/internals/log/ProducerStateManager.java: ## @@ -177,7 +177,7 @@ private void addProducerId(long producerId,

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-08 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1483642156 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -64,28 +67,177 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { val

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-08 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1483642156 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -64,28 +67,177 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { val

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-08 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1483624940 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -2849,6 +2914,44 @@ public void

Re: [PR] KAFKA-15307: update/note deprecated configs [kafka]

2024-02-08 Thread via GitHub
mjsax commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1483595167 ## docs/streams/developer-guide/config-streams.html: ## @@ -1010,6 +1016,18 @@ topology.optimization + windowed.inner.class.serde + + + +

[PR] KafkaDockerWrapper: correct KAFKA_HEAP_OPTS server property [kafka]

2024-02-08 Thread via GitHub
mpareja opened a new pull request, #15345: URL: https://github.com/apache/kafka/pull/15345 Reproduction Run Kafka in Docker with the `KAFKA_HEAP_OPTS` environment variable set ```bash $ docker run -e KAFKA_HEAP_OPTS="-Xmx128m -Xms128m" apache/kafka:3.7.0-rc2 ```

[jira] [Commented] (KAFKA-16156) System test failing for new consumer on endOffsets with negative timestamps

2024-02-08 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815820#comment-17815820 ] Philip Nee commented on KAFKA-16156: This issue seems easily reproducible by simply running

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-08 Thread via GitHub
lianetm commented on PR #15311: URL: https://github.com/apache/kafka/pull/15311#issuecomment-1934860453 Build broken with unrelated scala compilation failures being fixed already. I'll rebase as soon as the fix https://github.com/apache/kafka/pull/15343 goes in. -- This is an automated

Re: [PR] MINOR fix scala compile issue [kafka]

2024-02-08 Thread via GitHub
mumrah commented on PR #15343: URL: https://github.com/apache/kafka/pull/15343#issuecomment-1934798169 @mberndt123 i did in fact try that, but it doesn't seem to work. https://github.com/apache/kafka/assets/55116/c9613031-9235-4e07-ad11-71c97eaf82f0;> -- This is an

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-08 Thread via GitHub
hachikuji commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1483493757 ## clients/src/main/java/org/apache/kafka/clients/MetadataCache.java: ## @@ -52,7 +52,7 @@ public class MetadataCache { private final Map metadataByPartition;

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-08 Thread via GitHub
msn-tldr commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1483459996 ## clients/src/main/java/org/apache/kafka/clients/MetadataCache.java: ## @@ -52,7 +52,7 @@ public class MetadataCache { private final Map metadataByPartition;

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-08 Thread via GitHub
msn-tldr commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1483459996 ## clients/src/main/java/org/apache/kafka/clients/MetadataCache.java: ## @@ -52,7 +52,7 @@ public class MetadataCache { private final Map metadataByPartition;

Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]

2024-02-08 Thread via GitHub
philipnee commented on PR #15020: URL: https://github.com/apache/kafka/pull/15020#issuecomment-1934681669 hi @Phuc-Hong-Tran - thanks for the PR. Could you also clean up the isUnavailable and maybeThrowAuthFailure methods in the networkClientDelegate. I believe they aren't being used

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-02-08 Thread via GitHub
OmniaGM commented on PR #15335: URL: https://github.com/apache/kafka/pull/15335#issuecomment-1934674083 @pprovenzano, @cmccabe @showuon Can one of you please have a look into this pr? If we can't cherry-pick this for 3.7.0 I strongly believe we should revert #15263 cc:

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-08 Thread via GitHub
hachikuji commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1483386345 ## clients/src/main/java/org/apache/kafka/clients/MetadataCache.java: ## @@ -52,7 +52,7 @@ public class MetadataCache { private final Map metadataByPartition;

[jira] [Updated] (KAFKA-16235) auto commit still causes delays due to retriable UNKNOWN_TOPIC_OR_PARTITION

2024-02-08 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16235: -- Component/s: clients > auto commit still causes delays due to retriable UNKNOWN_TOPIC_OR_PARTITION >

[PR] MINOR: fix scala 2.12 compilation [kafka]

2024-02-08 Thread via GitHub
cmccabe opened a new pull request, #15344: URL: https://github.com/apache/kafka/pull/15344 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-16116: Rebalance Metrics for AsyncKafkaConsumer [kafka]

2024-02-08 Thread via GitHub
philipnee commented on PR #15339: URL: https://github.com/apache/kafka/pull/15339#issuecomment-1934623723 Hi @lucasbru - Would you have time to review this PR? The desired logic is written in the description. Thanks! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-08 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1483321154 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -64,28 +67,177 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest { val

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-08 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1483318793 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -111,37 +263,124 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest {

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-08 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1483318096 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -111,37 +263,124 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest {

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-08 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1483317344 ## core/src/main/scala/kafka/admin/ConsumerGroupCommand.scala: ## @@ -189,16 +197,65 @@ object ConsumerGroupCommand extends Logging { } def listGroups():

[jira] [Updated] (KAFKA-16237) Kafka-Streams-Scala for Scala 3

2024-02-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16237: Labels: needs-kip (was: ) > Kafka-Streams-Scala for Scala 3 >

[jira] [Commented] (KAFKA-16237) Kafka-Streams-Scala for Scala 3

2024-02-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16237?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815763#comment-17815763 ] Matthias J. Sax commented on KAFKA-16237: - Thanks for filing the ticket and working on a PR. – I

[jira] [Assigned] (KAFKA-16237) Kafka-Streams-Scala for Scala 3

2024-02-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-16237: --- Assignee: Matthias Berndt > Kafka-Streams-Scala for Scala 3 >

[jira] [Comment Edited] (KAFKA-16236) Interactive Query v2 does not support Global KTables

2024-02-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815760#comment-17815760 ] Matthias J. Sax edited comment on KAFKA-16236 at 2/8/24 4:52 PM: - Thanks

[jira] [Resolved] (KAFKA-16236) Interactive Query v2 does not support Global KTables

2024-02-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-16236. - Resolution: Duplicate Thanks for filing this tickets. It's duplicate of

[jira] [Commented] (KAFKA-14747) FK join should record discarded subscription responses

2024-02-08 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815759#comment-17815759 ] Matthias J. Sax commented on KAFKA-14747: - It seems [~kma] did never find time to pick it up

[jira] [Commented] (KAFKA-16235) auto commit still causes delays due to retriable UNKNOWN_TOPIC_OR_PARTITION

2024-02-08 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815754#comment-17815754 ] Lianet Magrans commented on KAFKA-16235: Hey [~rleslie], very helpful context, thanks! We'll be

[jira] [Created] (KAFKA-16237) Kafka-Streams-Scala for Scala 3

2024-02-08 Thread Matthias Berndt (Jira)
Matthias Berndt created KAFKA-16237: --- Summary: Kafka-Streams-Scala for Scala 3 Key: KAFKA-16237 URL: https://issues.apache.org/jira/browse/KAFKA-16237 Project: Kafka Issue Type: New

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-08 Thread via GitHub
msn-tldr commented on PR #15323: URL: https://github.com/apache/kafka/pull/15323#issuecomment-1934424289 The associated Jenkins failure is due to compilation errors with Scala 2.12 introduced here https://github.com/apache/kafka/pull/15327#issuecomment-1933811374 -- This is an

Re: [PR] MINOR fix scala compile issue [kafka]

2024-02-08 Thread via GitHub
mberndt123 commented on PR #15343: URL: https://github.com/apache/kafka/pull/15343#issuecomment-1934404127 Why not just `errorLogs.append(_)`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] MINOR fix scala compile issue [kafka]

2024-02-08 Thread via GitHub
mumrah opened a new pull request, #15343: URL: https://github.com/apache/kafka/pull/15343 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-08 Thread via GitHub
lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1483184589 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -132,6 +132,16 @@ public void onFailedAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-08 Thread via GitHub
lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1483183111 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -132,6 +132,16 @@ public void onFailedAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-08 Thread via GitHub
msn-tldr commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1483170888 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java: ## @@ -647,27 +647,27 @@ private long batchReady(boolean exhausted,

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-08 Thread via GitHub
dajac commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1483161952 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -132,6 +132,16 @@ public void onFailedAttempt(final long currentTimeMs) {

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-08 Thread via GitHub
msn-tldr commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1483161801 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/RecordAccumulatorTest.java: ## @@ -1564,97 +1597,18 @@ public void

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-08 Thread via GitHub
lianetm commented on PR #15311: URL: https://github.com/apache/kafka/pull/15311#issuecomment-1934281383 Thanks for the feedback @dajac! Comments addressed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-15761: KRaft support in EpochDrivenReplicationProtocolAcceptanceTest [kafka]

2024-02-08 Thread via GitHub
highluck commented on PR #15295: URL: https://github.com/apache/kafka/pull/15295#issuecomment-1934279681 @mimaison https://github.com/apache/kafka/pull/15342 The test was failing, so I posted a PR first. If the above PR is merged, I think the test will also succee -- This is

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-08 Thread via GitHub
dajac commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1483062130 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -2811,6 +2811,71 @@ public void testListConsumerGroupsWithStates() throws

Re: [PR] MINOR: Problem failing in Scala version 2.12 [kafka]

2024-02-08 Thread via GitHub
highluck commented on PR #15342: URL: https://github.com/apache/kafka/pull/15342#issuecomment-1934271953 @mimaison Problem failing in Scala version 2.12 Please review! thanks :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] MINOR: Problem failing in Scala version 2.12 [kafka]

2024-02-08 Thread via GitHub
highluck opened a new pull request, #15342: URL: https://github.com/apache/kafka/pull/15342 ``` [Error] /Users/hy/kafka/core/src/test/scala/unit/kafka/zk/migration/ZkAclMigrationClientTest.scala:234:88: type mismatch; found : Seq[String] => Unit required:

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-08 Thread via GitHub
lianetm commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1483072035 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java: ## @@ -127,8 +127,16 @@ public void onSuccessfulAttempt(final long

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-08 Thread via GitHub
mimaison commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1482987163 ## tests/kafkatest/services/console_consumer.py: ## @@ -21,7 +21,7 @@ from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin from

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-02-08 Thread via GitHub
clolov commented on code in PR #15213: URL: https://github.com/apache/kafka/pull/15213#discussion_r1482965204 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1300,18 +1301,29 @@ class UnifiedLog(@volatile var logStartOffset: Long, } else if (targetTimestamp ==

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

2024-02-08 Thread via GitHub
gaurav-narula commented on code in PR #15065: URL: https://github.com/apache/kafka/pull/15065#discussion_r1482924308 ## clients/src/test/resources/junit-platform.properties: ## @@ -13,3 +13,4 @@ # See the License for the specific language governing permissions and #

Re: [PR] Kafka streams scala3 [kafka]

2024-02-08 Thread via GitHub
mberndt123 commented on code in PR #15338: URL: https://github.com/apache/kafka/pull/15338#discussion_r1482802274 ## gradle.properties: ## @@ -31,3 +31,5 @@ swaggerVersion=2.2.8 task=build org.gradle.jvmargs=-Xmx2g -Xss4m -XX:+UseParallelGC org.gradle.parallel=true +

Re: [PR] KAFKA-15201: Allow git push to fail gracefully [kafka]

2024-02-08 Thread via GitHub
divijvaidya merged PR #14645: URL: https://github.com/apache/kafka/pull/14645 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Kafka streams scala3 [kafka]

2024-02-08 Thread via GitHub
mberndt123 commented on PR #15338: URL: https://github.com/apache/kafka/pull/15338#issuecomment-1933812834 > Thanks @mberndt123 for your PR > > `gradlewAll` needs to be modified as well. But as I mentioned in the mailing list, I think it would be beneficial to start a "DISCUSS"

Re: [PR] KAFKA-15201: Allow git push to fail gracefully [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #14645: URL: https://github.com/apache/kafka/pull/14645#issuecomment-1933812590 @divijvaidya Should we merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Fix some MetadataDelta handling issues during ZK migration [kafka]

2024-02-08 Thread via GitHub
dajac commented on PR #15327: URL: https://github.com/apache/kafka/pull/15327#issuecomment-1933811374 Hey @cmccabe @mumrah. This PR has complication errors with Scala 2.12. I don't understand how we could merge a PR without a single successful build. Could you guys please fix the issue?

Re: [PR] MINOR: Few cleanups to JaasContext/Utils classes for fix CVE-2023-25194 [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #13236: URL: https://github.com/apache/kafka/pull/13236#issuecomment-1933809837 Kafka 3.0.0 was released in 2021. We don't backport fixes to releases this old. The fix is in Kafka 3.4.0 and above. -- This is an automated message from the Apache Git Service. To

Re: [PR] MINOR: Few cleanups to JaasContext/Utils classes for fix CVE-2023-25194 [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #13236: MINOR: Few cleanups to JaasContext/Utils classes for fix CVE-2023-25194 URL: https://github.com/apache/kafka/pull/13236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-8713 KIP-581 Add accept.optional.null to solve optional null [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #8575: URL: https://github.com/apache/kafka/pull/8575#issuecomment-1933799846 This has been done in https://github.com/apache/kafka/pull/13419. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-8713 KIP-581 Add accept.optional.null to solve optional null [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #8575: KAFKA-8713 KIP-581 Add accept.optional.null to solve optional null URL: https://github.com/apache/kafka/pull/8575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Delete docs/documentation directory [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #11628: URL: https://github.com/apache/kafka/pull/11628#issuecomment-1933795164 These files are required for the website, we don't want to delete them. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Delete docs/documentation directory [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #11628: Delete docs/documentation directory URL: https://github.com/apache/kafka/pull/11628 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Resolved] (KAFKA-12937) Mirrormaker2 can only start from the beginning of a topic

2024-02-08 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-12937. Resolution: Duplicate > Mirrormaker2 can only start from the beginning of a topic >

Re: [PR] KAFKA-12937; mm2 can start from the ending of a topic [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #11020: URL: https://github.com/apache/kafka/pull/11020#issuecomment-1933789851 This has been fixed in https://issues.apache.org/jira/browse/KAFKA-13988. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-12937; mm2 can start from the ending of a topic [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #11020: KAFKA-12937; mm2 can start from the ending of a topic URL: https://github.com/apache/kafka/pull/11020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Make it possible to produce messages with a null body in kafka console producer [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #7567: URL: https://github.com/apache/kafka/pull/7567#issuecomment-1933772046 This has been done in https://issues.apache.org/jira/browse/KAFKA-13595. Closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] MINOR: Make it possible to produce messages with a null body in kafka console producer [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #7567: MINOR: Make it possible to produce messages with a null body in kafka console producer URL: https://github.com/apache/kafka/pull/7567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Resolved] (KAFKA-8259) Build RPM for Kafka

2024-02-08 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-8259. --- Resolution: Won't Do > Build RPM for Kafka > --- > > Key:

Re: [PR] KAFKA-8259: Build an RPM for easier installation [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #6611: URL: https://github.com/apache/kafka/pull/6611#issuecomment-1933760592 Publishing an rpm package as part of Kafka release would require a [KIP](https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals). Considering the age of this

Re: [PR] KAFKA-8259: Build an RPM for easier installation [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #6611: KAFKA-8259: Build an RPM for easier installation URL: https://github.com/apache/kafka/pull/6611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] i think ? is bettern than string in understanding [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #5936: i think ? is bettern than string in understanding URL: https://github.com/apache/kafka/pull/5936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] i think ? is bettern than string in understanding [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #5936: URL: https://github.com/apache/kafka/pull/5936#issuecomment-1933756180 `AbstractConfig` is a public API. I don't think we want to do this change. Closing this old PR. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Kafka streams scala3 [kafka]

2024-02-08 Thread via GitHub
mberndt123 commented on code in PR #15338: URL: https://github.com/apache/kafka/pull/15338#discussion_r1482713721 ## build.gradle: ## @@ -2355,7 +2366,7 @@ project(':streams:streams-scala') { spotless { scala { target '**/*.scala' -

[jira] [Resolved] (KAFKA-9094) Validate the replicas for partition reassignments triggered through the /admin/reassign_partitions zNode

2024-02-08 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9094?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-9094. --- Resolution: Won't Do > Validate the replicas for partition reassignments triggered through

Re: [PR] KAFKA-9094: Add server-side replica validation for ZK triggered reassignments [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #7591: URL: https://github.com/apache/kafka/pull/7591#issuecomment-1933742030 Since we'll soon be removing ZooKeeper, I'll close this old PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-9094: Add server-side replica validation for ZK triggered reassignments [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #7591: KAFKA-9094: Add server-side replica validation for ZK triggered reassignments URL: https://github.com/apache/kafka/pull/7591 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Kafka streams scala3 [kafka]

2024-02-08 Thread via GitHub
mberndt123 commented on code in PR #15338: URL: https://github.com/apache/kafka/pull/15338#discussion_r1482713721 ## build.gradle: ## @@ -2355,7 +2366,7 @@ project(':streams:streams-scala') { spotless { scala { target '**/*.scala' -

Re: [PR] MINOR: Allow KafkaZkClient and ZooKeeperClient to wait for the underlying ZooKeeper client to fully close. [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #7220: URL: https://github.com/apache/kafka/pull/7220#issuecomment-1933737870 Since we'll soon be removing ZooKeeper, I'll close this old PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MINOR: Allow KafkaZkClient and ZooKeeperClient to wait for the underlying ZooKeeper client to fully close. [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #7220: MINOR: Allow KafkaZkClient and ZooKeeperClient to wait for the underlying ZooKeeper client to fully close. URL: https://github.com/apache/kafka/pull/7220 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] kafkatest: Make ZooKeeper log in "DEBUG" mode by default [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #5948: URL: https://github.com/apache/kafka/pull/5948#issuecomment-1933736492 Since we're now removing ZooKeeper, I'll close this old PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] kafkatest: Make ZooKeeper log in "DEBUG" mode by default [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #5948: kafkatest: Make ZooKeeper log in "DEBUG" mode by default URL: https://github.com/apache/kafka/pull/5948 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-5197: add a tool analyzing zookeeper client performance across its various apis [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #2999: URL: https://github.com/apache/kafka/pull/2999#issuecomment-1933730452 Since we're now removing ZooKeeper, I'll close this PR and Jira. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-5197: add a tool analyzing zookeeper client performance across its various apis [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #2999: KAFKA-5197: add a tool analyzing zookeeper client performance across its various apis URL: https://github.com/apache/kafka/pull/2999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MINOR: Remove unused configuration setting [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #3167: URL: https://github.com/apache/kafka/pull/3167#issuecomment-1933726599 Considering the age of this PR and that we'll soon remove ZooKeeper, I'll close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] MINOR: Remove unused configuration setting [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #3167: MINOR: Remove unused configuration setting URL: https://github.com/apache/kafka/pull/3167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-3987: Allow config of the hash algorithm used by the log cleaner [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #1661: KAFKA-3987: Allow config of the hash algorithm used by the log cleaner URL: https://github.com/apache/kafka/pull/1661 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-3987: Allow config of the hash algorithm used by the log cleaner [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #1661: URL: https://github.com/apache/kafka/pull/1661#issuecomment-1933722507 Adding a new configuration requires a KIP. Considering the age of this PR, I'll close this PR. Please reopen if you still want to work on this. -- This is an automated message from the

[PR] MINOR: EventAccumulator should signal to one thread when key becomes available [kafka]

2024-02-08 Thread via GitHub
dajac opened a new pull request, #15340: URL: https://github.com/apache/kafka/pull/15340 `signalAll` was mistakenly used instead of `signal` when a key become available in the `EventAccumulator`. The fix relies on existing tests. ### Committer Checklist (excluded from commit message)

Re: [PR] KAFKA-3736: Add HTTP Metrics reporter [kafka]

2024-02-08 Thread via GitHub
mimaison commented on PR #1412: URL: https://github.com/apache/kafka/pull/1412#issuecomment-1933662842 Adding a new reporter would require a KIP. Considering the age of this PR, I'll close it. Please reopen a one new if you still want to work on this feature. -- This is an automated

Re: [PR] KAFKA-3736: Add HTTP Metrics reporter [kafka]

2024-02-08 Thread via GitHub
mimaison closed pull request #1412: KAFKA-3736: Add HTTP Metrics reporter URL: https://github.com/apache/kafka/pull/1412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Kafka streams scala3 [kafka]

2024-02-08 Thread via GitHub
jlprat commented on code in PR #15338: URL: https://github.com/apache/kafka/pull/15338#discussion_r1482585039 ## build.gradle: ## @@ -2355,7 +2366,7 @@ project(':streams:streams-scala') { spotless { scala { target '**/*.scala' -

  1   2   >