Re: [PR] KAFKA-12216; Improve flaky test reporting [kafka]

2024-02-09 Thread via GitHub
dajac commented on PR #14862: URL: https://github.com/apache/kafka/pull/14862#issuecomment-1936915696 I need to update the PR to only apply this while building PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-16242: Mark slowest and most flaky tests as integration tests [kafka]

2024-02-09 Thread via GitHub
dajac commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1936915364 @gharris1727 I see. So if I understand correctly, two tests are flaky in the suite so we move the entire suite. This does not seem right to me. This particular suite is the one that you

Re: [PR] KAFKA-16242: Mark slowest and most flaky tests as integration tests [kafka]

2024-02-09 Thread via GitHub
gharris1727 commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1936910131 @dajac No, those were added because they were flaky:

Re: [PR] KAFKA-16242: Mark slowest and most flaky tests as integration tests [kafka]

2024-02-09 Thread via GitHub
dajac commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1936903652 @gharris1727 Thanks for looking into this. Overall, I like the idea. However, I see many suites that are unit tests and therefore we must be kept as unit tests (e.g. admin client test).

Re: [PR] KAFKA-16242: Mark slowest and most flaky tests as integration tests [kafka]

2024-02-09 Thread via GitHub
gharris1727 commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1936821280 @mumrah I used this page: https://ge.apache.org/scans/tests?search.names=Git%20branch=P28D=kafka=America%2FLos_Angeles=trunk=FLAKY and sorted by Flaky, Failed, and Mean Execution

Re: [PR] KAFKA-16242: Mark slowest and most flaky tests as integration tests [kafka]

2024-02-09 Thread via GitHub
mumrah commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1936811537 This is great, @gharris1727! How did you come up with the list of tests to mark as integration? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

2024-02-09 Thread via GitHub
jolshan merged PR #15324: URL: https://github.com/apache/kafka/pull/15324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-02-09 Thread via GitHub
jolshan commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1936789321 The issues started for 3.7 on the same day so it is one of the 3 commits backported feb 2

[jira] [Commented] (KAFKA-16225) Flaky test suite LogDirFailureTest

2024-02-09 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816260#comment-17816260 ] Justine Olshan commented on KAFKA-16225: Looks like it happened on 3.7 the same day which

Re: [PR] KAFKA-16195: ignore metadata.log.dir failure in ZK mode [kafka]

2024-02-09 Thread via GitHub
jolshan commented on PR #15262: URL: https://github.com/apache/kafka/pull/15262#issuecomment-1936787524 Hey folks. We've seen a large increase in LogDirFailureTest after this PR. Can we take a look and see if something here caused it? gradle enterprise:

Re: [PR] KAFKA-16242: Mark tests with the most flaky failures as integration tests [kafka]

2024-02-09 Thread via GitHub
gharris1727 commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1936785675 We did save a little time, but not really too much because the build tends to spend a lot of time waiting for compileTestScala to complete :) `./gradlew clean test` is 45

[jira] [Commented] (KAFKA-16225) Flaky test suite LogDirFailureTest

2024-02-09 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816258#comment-17816258 ] Justine Olshan commented on KAFKA-16225: I'm encountering this too. It looks pretty bad

[PR] fix syntax error [kafka]

2024-02-09 Thread via GitHub
mberndt123 opened a new pull request, #15350: URL: https://github.com/apache/kafka/pull/15350 Seems like a good idea to balance those parens. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16242: Mark tests with the most flaky failures as integration tests [kafka]

2024-02-09 Thread via GitHub
ijuma commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1936765040 This is very cool. Any chance you could do the same for the top N slowest unit tests (they're not unit tests if they're that slow)? Then the `unitTest` command would be useful enough to

Re: [PR] KAFKA-15665: Enforce min ISR when complete partition reassignment. [kafka]

2024-02-09 Thread via GitHub
splett2 commented on code in PR #14604: URL: https://github.com/apache/kafka/pull/14604#discussion_r1484905012 ## metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java: ## @@ -124,6 +124,8 @@ Optional maybeCompleteReassignment(List targetIs

Re: [PR] KAFKA-15665: Enforce min ISR when complete partition reassignment. [kafka]

2024-02-09 Thread via GitHub
splett2 commented on code in PR #14604: URL: https://github.com/apache/kafka/pull/14604#discussion_r1484905012 ## metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java: ## @@ -124,6 +124,8 @@ Optional maybeCompleteReassignment(List targetIs

Re: [PR] KAFKA-16242: Mark tests with the most flaky failures as integration tests [kafka]

2024-02-09 Thread via GitHub
gharris1727 commented on PR #15349: URL: https://github.com/apache/kafka/pull/15349#issuecomment-1936736732 Alright, I got 3 consecutive green builds, and I haven't seen any flaky failures locally. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-15665: Enforce min ISR when complete partition reassignment. [kafka]

2024-02-09 Thread via GitHub
CalvinConfluent commented on code in PR #14604: URL: https://github.com/apache/kafka/pull/14604#discussion_r1484883905 ## metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java: ## @@ -124,6 +124,8 @@ Optional maybeCompleteReassignment(List

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2024-02-09 Thread via GitHub
mjsax commented on PR #14426: URL: https://github.com/apache/kafka/pull/14426#issuecomment-1936706379 > Merged the code of [KAFKA-16123](https://issues.apache.org/jira/browse/KAFKA-16123) into this PR. Why? We are mixing up two ticket if we do this (cf

[jira] [Commented] (KAFKA-16156) System test failing for new consumer on endOffsets with negative timestamps

2024-02-09 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816239#comment-17816239 ] Philip Nee commented on KAFKA-16156: There seem to be a subtle difference in behavior between the

[jira] [Commented] (KAFKA-16241) Kafka Streams hits IllegalStateException trying to recycle a task

2024-02-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816238#comment-17816238 ] Matthias J. Sax commented on KAFKA-16241: - {quote} Detected out-of-order KTable update {quote} I

[jira] [Commented] (KAFKA-16241) Kafka Streams hits IllegalStateException trying to recycle a task

2024-02-09 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816234#comment-17816234 ] A. Sophie Blee-Goldman commented on KAFKA-16241: Off-topic but I opened the logs for a

Re: [PR] KAFKA-15665: Enforce min ISR when complete partition reassignment. [kafka]

2024-02-09 Thread via GitHub
CalvinConfluent commented on code in PR #14604: URL: https://github.com/apache/kafka/pull/14604#discussion_r1484850347 ## metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java: ## @@ -124,6 +124,8 @@ Optional maybeCompleteReassignment(List

Re: [PR] KAFKA-15665: Enforce min ISR when complete partition reassignment. [kafka]

2024-02-09 Thread via GitHub
CalvinConfluent commented on code in PR #14604: URL: https://github.com/apache/kafka/pull/14604#discussion_r1484850347 ## metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java: ## @@ -124,6 +124,8 @@ Optional maybeCompleteReassignment(List

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-02-09 Thread via GitHub
infantlikesprogramming commented on code in PR #15296: URL: https://github.com/apache/kafka/pull/15296#discussion_r1484843384 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch,

Re: [PR] KAFKA-15665: Enforce min ISR when complete partition reassignment. [kafka]

2024-02-09 Thread via GitHub
splett2 commented on code in PR #14604: URL: https://github.com/apache/kafka/pull/14604#discussion_r1484842081 ## metadata/src/main/java/org/apache/kafka/controller/PartitionReassignmentReplicas.java: ## @@ -124,6 +124,8 @@ Optional maybeCompleteReassignment(List targetIs

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-09 Thread via GitHub
hachikuji commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1484643624 ## clients/src/main/java/org/apache/kafka/clients/Metadata.java: ## @@ -127,6 +127,13 @@ public synchronized Cluster fetch() { return cache.cluster();

[PR] KAFKA-16242: Mark tests with the most flaky failures as integration tests [kafka]

2024-02-09 Thread via GitHub
gharris1727 opened a new pull request, #15349: URL: https://github.com/apache/kafka/pull/15349 These tests have had at least one flaky test failure in the last 28 days, and aren't already marked as integration tests. I looked at the top-50 flakiest tests in the project with gradle

Re: [PR] MINOR: Refactor GroupMetadataManagerTest [kafka]

2024-02-09 Thread via GitHub
OmniaGM commented on code in PR #15348: URL: https://github.com/apache/kafka/pull/15348#discussion_r1484726099 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java: ## @@ -0,0 +1,1485 @@ +/* + * Licensed to the Apache

Re: [PR] MINOR: Refactor GroupMetadataManagerTest [kafka]

2024-02-09 Thread via GitHub
OmniaGM commented on code in PR #15348: URL: https://github.com/apache/kafka/pull/15348#discussion_r1484726099 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java: ## @@ -0,0 +1,1485 @@ +/* + * Licensed to the Apache

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

2024-02-09 Thread via GitHub
jeqo commented on PR #15324: URL: https://github.com/apache/kafka/pull/15324#issuecomment-1936481385 @jolshan thanks for catching this! adding it now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-16241) Kafka Streams hits IllegalStateException trying to recycle a task

2024-02-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16241: Affects Version/s: 3.6.1 > Kafka Streams hits IllegalStateException trying to recycle a

[jira] [Updated] (KAFKA-16241) Kafka Streams hits IllegalStateException trying to recycle a task

2024-02-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16241: Attachment: streams-3.zip > Kafka Streams hits IllegalStateException trying to recycle a

Re: [PR] MINOR: Refactor GroupMetadataManagerTest [kafka]

2024-02-09 Thread via GitHub
jolshan commented on code in PR #15348: URL: https://github.com/apache/kafka/pull/15348#discussion_r1484696012 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java: ## @@ -0,0 +1,1485 @@ +/* + * Licensed to the Apache

[jira] [Created] (KAFKA-16242) Mark flaky tests as integration tests

2024-02-09 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16242: --- Summary: Mark flaky tests as integration tests Key: KAFKA-16242 URL: https://issues.apache.org/jira/browse/KAFKA-16242 Project: Kafka Issue Type: Test

[jira] [Updated] (KAFKA-16241) Kafka Streams hits IllegalStateException trying to recycle a task

2024-02-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16241: Attachment: streams-2.zip > Kafka Streams hits IllegalStateException trying to recycle a

Re: [PR] MINOR: Refactor GroupMetadataManagerTest [kafka]

2024-02-09 Thread via GitHub
jolshan commented on code in PR #15348: URL: https://github.com/apache/kafka/pull/15348#discussion_r1484689761 ## checkstyle/suppressions.xml: ## @@ -336,11 +336,11 @@ +

[jira] [Updated] (KAFKA-16241) Kafka Streams hits IllegalStateException trying to recycle a task

2024-02-09 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16241: Attachment: streams-1.zip > Kafka Streams hits IllegalStateException trying to recycle a

[jira] [Created] (KAFKA-16241) Kafka Streams hits IllegalStateException trying to recycle a task

2024-02-09 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-16241: --- Summary: Kafka Streams hits IllegalStateException trying to recycle a task Key: KAFKA-16241 URL: https://issues.apache.org/jira/browse/KAFKA-16241 Project:

Re: [PR] KAFKA-14576: Move ConsoleConsumer to tools [kafka]

2024-02-09 Thread via GitHub
mimaison commented on code in PR #15274: URL: https://github.com/apache/kafka/pull/15274#discussion_r1484652868 ## tests/kafkatest/services/console_consumer.py: ## @@ -21,7 +21,7 @@ from kafkatest.directory_layout.kafka_path import KafkaPathResolverMixin from

Re: [PR] KAFKA-16226 Reduce synchronization between producer threads [kafka]

2024-02-09 Thread via GitHub
msn-tldr commented on code in PR #15323: URL: https://github.com/apache/kafka/pull/15323#discussion_r1484638827 ## clients/src/main/java/org/apache/kafka/clients/MetadataCache.java: ## @@ -52,7 +52,7 @@ public class MetadataCache { private final Map metadataByPartition;

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-09 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1484632678 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -111,37 +233,138 @@ class ListConsumerGroupTest extends ConsumerGroupCommandTest {

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-09 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1484632200 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -18,74 +18,196 @@ package kafka.admin import joptsimple.OptionException import

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-09 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1484631548 ## core/src/test/scala/unit/kafka/admin/ListConsumerGroupTest.scala: ## @@ -18,44 +18,47 @@ package kafka.admin import joptsimple.OptionException import

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-09 Thread via GitHub
rreddy-22 commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1484628868 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -2811,6 +2811,72 @@ public void testListConsumerGroupsWithStates() throws

Re: [PR] KAFKA-16229: Fix slow expired producer id deletion [kafka]

2024-02-09 Thread via GitHub
jolshan commented on PR #15324: URL: https://github.com/apache/kafka/pull/15324#issuecomment-1936317088 Hey there @jeqo looks like check style failed. Do you mind adding the apache header to your new benchmark?

[jira] [Comment Edited] (KAFKA-16239) Clean up references to non-existent IntegrationTestHelper

2024-02-09 Thread Gaurav Salvi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816120#comment-17816120 ] Gaurav Salvi edited comment on KAFKA-16239 at 2/9/24 3:42 PM: --

[jira] [Commented] (KAFKA-16239) Clean up references to non-existent IntegrationTestHelper

2024-02-09 Thread Gaurav Salvi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816120#comment-17816120 ] Gaurav Salvi commented on KAFKA-16239: -- [~divijvaidya]  : What should the references to

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

2024-02-09 Thread via GitHub
lianetm commented on PR #15188: URL: https://github.com/apache/kafka/pull/15188#issuecomment-1936141808 @Phuc-Hong-Tran regarding this: > Just for clarification, when we were talking about "implement and test everything up to the point where the field is populated", does that mean

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

2024-02-09 Thread via GitHub
lianetm commented on PR #15188: URL: https://github.com/apache/kafka/pull/15188#issuecomment-1936091369 Hey @Phuc-Hong-Tran , regarding the mixed usage of subscribe with `Pattern` and with `SubscriptionPattern`, my opinion is that it is something we should live with to provide a smooth

[PR] MINOR: Refactor GroupMetadataManagerTest [kafka]

2024-02-09 Thread via GitHub
dajac opened a new pull request, #15348: URL: https://github.com/apache/kafka/pull/15348 `GroupMetadataManagerTest` class got a little under control. We have too many things defined in it. As a first steps, this patch extracts all the inner classes. It also extracts all the helper methods.

[jira] [Comment Edited] (KAFKA-16102) about DynamicListenerConfig, the dynamic modification of the listener's port or IP does not take effect.

2024-02-09 Thread Jialun Peng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17815470#comment-17815470 ] Jialun Peng edited comment on KAFKA-16102 at 2/9/24 2:06 PM: - Hi, can you

Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]

2024-02-09 Thread via GitHub
Phuc-Hong-Tran commented on PR #15020: URL: https://github.com/apache/kafka/pull/15020#issuecomment-1935914902 @philipnee All done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15556: Remove NetworkClientDelegate methods isUnavailable, maybeThrowAuthFailure, and tryConnect [kafka]

2024-02-09 Thread via GitHub
Phuc-Hong-Tran commented on PR #15020: URL: https://github.com/apache/kafka/pull/15020#issuecomment-1935913572 @philipnee Will do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2024-02-09 Thread via GitHub
VictorvandenHoven commented on PR #14426: URL: https://github.com/apache/kafka/pull/14426#issuecomment-1935911914 Merged the code of [KAFKA-16123](https://issues.apache.org/jira/browse/KAFKA-16123) into this PR. Everything else left as it was. All the tests still passed. -- This is

[jira] [Updated] (KAFKA-16240) Flaky test PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords(String).quorum=kraft

2024-02-09 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge updated KAFKA-16240: -- Description: Failed run

[jira] [Created] (KAFKA-16240) Flaky test PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords(String).quorum=kraft

2024-02-09 Thread Gantigmaa Selenge (Jira)
Gantigmaa Selenge created KAFKA-16240: - Summary: Flaky test PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords(String).quorum=kraft Key: KAFKA-16240 URL:

[jira] [Updated] (KAFKA-16240) Flaky test PlaintextAdminIntegrationTest.testReplicaCanFetchFromLogStartOffsetAfterDeleteRecords(String).quorum=kraft

2024-02-09 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16240?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge updated KAFKA-16240: -- Priority: Minor (was: Major) > Flaky test >

Re: [PR] [MINOR] Fix docker image build [kafka]

2024-02-09 Thread via GitHub
stanislavkozlovski merged PR #15347: URL: https://github.com/apache/kafka/pull/15347 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-13835) Fix two bugs related to dynamic broker configs in KRaft

2024-02-09 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816049#comment-17816049 ] Divij Vaidya commented on KAFKA-13835: -- [~cmccabe] the associated PR is merged. Can you please add

[jira] [Updated] (KAFKA-12670) KRaft support for unclean.leader.election.enable

2024-02-09 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-12670: - Component/s: kraft > KRaft support for unclean.leader.election.enable >

[jira] [Comment Edited] (KAFKA-14349) Support dynamically resizing the KRaft controller's thread pools

2024-02-09 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816045#comment-17816045 ] Divij Vaidya edited comment on KAFKA-14349 at 2/9/24 12:52 PM: --- [~cmccabe]

[jira] [Commented] (KAFKA-14349) Support dynamically resizing the KRaft controller's thread pools

2024-02-09 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816045#comment-17816045 ] Divij Vaidya commented on KAFKA-14349: -- [~cmccabe] might have forgot to close this since it's still

[PR] Fix docker image build [kafka]

2024-02-09 Thread via GitHub
VedarthConfluent opened a new pull request, #15347: URL: https://github.com/apache/kafka/pull/15347 Base image has removed bash. So we need to install it to run the bash scripts inside docker container. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

[jira] [Commented] (KAFKA-14349) Support dynamically resizing the KRaft controller's thread pools

2024-02-09 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816043#comment-17816043 ] Divij Vaidya commented on KAFKA-14349: -- [~cmccabe] can we remove "Modifying certain dynamic

[jira] [Resolved] (KAFKA-16238) ConnectRestApiTest broken after KIP-1004

2024-02-09 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-16238. Fix Version/s: 3.8.0 Resolution: Fixed > ConnectRestApiTest broken after KIP-1004

Re: [PR] KAFKA-16238: Fix ConnectRestApiTest system test [kafka]

2024-02-09 Thread via GitHub
mimaison merged PR #15346: URL: https://github.com/apache/kafka/pull/15346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: EventAccumulator should signal to one thread when key becomes available [kafka]

2024-02-09 Thread via GitHub
dajac merged PR #15340: URL: https://github.com/apache/kafka/pull/15340 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-14127) KIP-858: Handle JBOD broker disk failure in KRaft

2024-02-09 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816038#comment-17816038 ] Divij Vaidya commented on KAFKA-14127: -- Hey folks 3.7's documentation still says that JBOD is a

[jira] [Resolved] (KAFKA-16162) New created topics are unavailable after upgrading to 3.7

2024-02-09 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim resolved KAFKA-16162. --- Fix Version/s: 3.7.0 Resolution: Fixed > New created topics are unavailable after

[jira] [Commented] (KAFKA-16162) New created topics are unavailable after upgrading to 3.7

2024-02-09 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816037#comment-17816037 ] Omnia Ibrahim commented on KAFKA-16162: --- Marking this as resolved as the pr was committed > New

Re: [PR] KAFKA-16215; KAFKA-16178: Fix member not rejoining after error [kafka]

2024-02-09 Thread via GitHub
AndrewJSchofield commented on code in PR #15311: URL: https://github.com/apache/kafka/pull/15311#discussion_r1484254595 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -397,13 +400,17 @@ private void onErrorResponse(final

Re: [PR] KAFKA-14782: Implementation Details Different from Documentation (del… [kafka]

2024-02-09 Thread via GitHub
whiteyesx closed pull request #13721: KAFKA-14782: Implementation Details Different from Documentation (del… URL: https://github.com/apache/kafka/pull/13721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Resolved] (KAFKA-14616) Topic recreation with offline broker causes permanent URPs

2024-02-09 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim resolved KAFKA-14616. --- Fix Version/s: 3.7.0 Assignee: Colin McCabe Resolution: Fixed > Topic

[jira] [Commented] (KAFKA-14616) Topic recreation with offline broker causes permanent URPs

2024-02-09 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816034#comment-17816034 ] Omnia Ibrahim commented on KAFKA-14616: --- I'll mark this as resolved as [~cmccabe] committed the

Re: [PR] KAFKA-7504 Mitigate sendfile(2) blocking in network threads by waming up fetch data [kafka]

2024-02-09 Thread via GitHub
divijvaidya commented on code in PR #14289: URL: https://github.com/apache/kafka/pull/14289#discussion_r1484189476 ## clients/src/main/java/org/apache/kafka/common/record/FileRecords.java: ## @@ -421,6 +446,18 @@ private AbstractIterator batchIterator(int start) {

Re: [PR] KAFKA-13403 Fix KafkaServer crashes when deleting topics due to the race in log deletion [kafka]

2024-02-09 Thread via GitHub
divijvaidya commented on PR #11438: URL: https://github.com/apache/kafka/pull/11438#issuecomment-1935743682 We have a test failing for this PR which has not failed in trunk for last 28 days [2]. @arunmathew88 can you please debug why this PR is causing that test to fail. [1]

Re: [PR] MINOR: Improve Code Style [kafka]

2024-02-09 Thread via GitHub
divijvaidya merged PR #15319: URL: https://github.com/apache/kafka/pull/15319 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: ZKAcl Migration Client Test Problem failing in Scala version 2.12 [kafka]

2024-02-09 Thread via GitHub
divijvaidya closed pull request #15342: MINOR: ZKAcl Migration Client Test Problem failing in Scala version 2.12 URL: https://github.com/apache/kafka/pull/15342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] streams-scala: remove collections-compat dependency when on Scala 2.13 [kafka]

2024-02-09 Thread via GitHub
divijvaidya merged PR #15239: URL: https://github.com/apache/kafka/pull/15239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

2024-02-09 Thread via GitHub
gaurav-narula commented on code in PR #15065: URL: https://github.com/apache/kafka/pull/15065#discussion_r1484162204 ## clients/src/test/resources/junit-platform.properties: ## @@ -13,3 +13,4 @@ # See the License for the specific language governing permissions and #

Re: [PR] MINOR: ZKAcl Migration Client Test Problem failing in Scala version 2.12 [kafka]

2024-02-09 Thread via GitHub
divijvaidya commented on PR #15342: URL: https://github.com/apache/kafka/pull/15342#issuecomment-1935712826 Thank you for looking into this @highluck but this seems to have already been fixed by https://github.com/apache/kafka/pull/15343 -- This is an automated message from the Apache

[jira] [Created] (KAFKA-16239) Clean up references to non-existent IntegrationTestHelper

2024-02-09 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-16239: Summary: Clean up references to non-existent IntegrationTestHelper Key: KAFKA-16239 URL: https://issues.apache.org/jira/browse/KAFKA-16239 Project: Kafka

Re: [PR] streams-scala: remove collections-compat dependency when on Scala 2.13 [kafka]

2024-02-09 Thread via GitHub
jlprat commented on PR #15239: URL: https://github.com/apache/kafka/pull/15239#issuecomment-1935630910 https://issues.apache.org/jira/browse/KAFKA-12895?focusedCommentId=17365016=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17365016 This could be done when

Re: [PR] streams-scala: remove collections-compat dependency when on Scala 2.13 [kafka]

2024-02-09 Thread via GitHub
jlprat commented on PR #15239: URL: https://github.com/apache/kafka/pull/15239#issuecomment-1935623714 > I've tried that and thought it worked because of a silly mistake that I made. But core actually needs it, so it needs to stay. Correct, `core` needs the `compat` library as it

[PR] KAFKA-16238: Fix ConnectRestApiTest system test [kafka]

2024-02-09 Thread via GitHub
mimaison opened a new pull request, #15346: URL: https://github.com/apache/kafka/pull/15346 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

[jira] [Created] (KAFKA-16238) ConnectRestApiTest broken after KIP-1004

2024-02-09 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-16238: -- Summary: ConnectRestApiTest broken after KIP-1004 Key: KAFKA-16238 URL: https://issues.apache.org/jira/browse/KAFKA-16238 Project: Kafka Issue Type:

Re: [PR] KAFKA-15832: Trigger client reconciliation based on manager poll [kafka]

2024-02-09 Thread via GitHub
dajac commented on code in PR #15275: URL: https://github.com/apache/kafka/pull/15275#discussion_r1484072806 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1392,4 +1356,16 @@ public void

Re: [PR] KAFKA-15462: Add Group Type Filter for List Group to the Admin Client [kafka]

2024-02-09 Thread via GitHub
dajac commented on code in PR #15150: URL: https://github.com/apache/kafka/pull/15150#discussion_r1484046178 ## clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java: ## @@ -2811,6 +2811,72 @@ public void testListConsumerGroupsWithStates() throws

Re: [PR] KAFKA-15417 flip joinSpuriousLookBackTimeMs and emit non-joined items [kafka]

2024-02-09 Thread via GitHub
VictorvandenHoven commented on PR #14426: URL: https://github.com/apache/kafka/pull/14426#issuecomment-1935587072 Accidently closed the PR, reopening again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] MINOR fix scala compile issue [kafka]

2024-02-09 Thread via GitHub
mberndt123 commented on PR #15343: URL: https://github.com/apache/kafka/pull/15343#issuecomment-1935582325 odd 路‍♂️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To