github-actions[bot] commented on PR #14733:
URL: https://github.com/apache/kafka/pull/14733#issuecomment-1937409981
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
gharris1727 commented on code in PR #15349:
URL: https://github.com/apache/kafka/pull/15349#discussion_r1485425218
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java:
##
@@ -92,6 +94,7 @@
import static
gharris1727 commented on code in PR #15349:
URL: https://github.com/apache/kafka/pull/15349#discussion_r1485424799
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java:
##
@@ -97,6 +100,7 @@
import static
florin-akermann commented on PR #15189:
URL: https://github.com/apache/kafka/pull/15189#issuecomment-1937343465
Testing strategy:
Most test cases can be left intact by adding a large enough grace period. In
general, the grace period added should be as small as possible.
Additional
[ https://issues.apache.org/jira/browse/KAFKA-16123 ]
Florin Akermann deleted comment on KAFKA-16123:
-
was (Author: aki):
I now committed a 'generalized fix' proposal
> KStreamKStreamJoinProcessor does not drop late records.
>
[ https://issues.apache.org/jira/browse/KAFKA-16123 ]
Florin Akermann deleted comment on KAFKA-16123:
-
was (Author: aki):
This might actually be a general issue and not just for null-key records?
In other words, the problem already existed
[
https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florin Akermann updated KAFKA-16123:
Description:
Issue illustration: [https://github.com/apache/kafka/pull/15314/files]
[
https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florin Akermann updated KAFKA-16123:
Description: Issue illustration:
[https://github.com/apache/kafka/pull/15314/files]
[
https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florin Akermann updated KAFKA-16123:
Summary: KStreamKStreamJoinProcessor does not drop late records. (was:
[
https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florin Akermann updated KAFKA-16123:
Description:
As part of KIP-962 the non-null key requirements have been relaxed for left
florin-akermann commented on PR #14426:
URL: https://github.com/apache/kafka/pull/14426#issuecomment-1937311592
I now pushed a 'generalized' fix for
[KAFKA-16123](https://issues.apache.org/jira/browse/KAFKA-16123)
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816355#comment-17816355
]
Florin Akermann edited comment on KAFKA-16123 at 2/10/24 10:18 PM:
---
I
[
https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816355#comment-17816355
]
Florin Akermann commented on KAFKA-16123:
-
I now committed a 'generalized fix'
>
nizhikov commented on PR #15256:
URL: https://github.com/apache/kafka/pull/15256#issuecomment-1937178976
Hello @showuon
I found that `DeleteTopicTest.scala` don't close resources allocated in case
of kraft run.
It was hided by removed tests and lead to the tests failures we
[
https://issues.apache.org/jira/browse/KAFKA-14957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-14957.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> Default value for state.dir is
mjsax commented on PR #13909:
URL: https://github.com/apache/kafka/pull/13909#issuecomment-1937116991
Thanks for this PR @Owen-CH-Leung! -- Really nice improvements for the docs.
Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mjsax merged PR #13909:
URL: https://github.com/apache/kafka/pull/13909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mjsax commented on code in PR #15349:
URL: https://github.com/apache/kafka/pull/15349#discussion_r1485247145
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamSlidingWindowAggregateTest.java:
##
@@ -92,6 +94,7 @@
import static
mjsax commented on code in PR #15349:
URL: https://github.com/apache/kafka/pull/15349#discussion_r1485246193
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignorTest.java:
##
@@ -97,6 +100,7 @@
import static
[
https://issues.apache.org/jira/browse/KAFKA-16084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816344#comment-17816344
]
Arnav Dadarya commented on KAFKA-16084:
---
May I start working on this?
> Simplify and deduplicate
hgeraldino commented on code in PR #15313:
URL: https://github.com/apache/kafka/pull/15313#discussion_r1485210009
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskMockitoTest.java:
##
@@ -343,6 +354,103 @@ public void testShutdown() throws
hgeraldino commented on code in PR #15313:
URL: https://github.com/apache/kafka/pull/15313#discussion_r1485209378
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/WorkerSinkTaskTest.java:
##
@@ -162,7 +153,6 @@ public class WorkerSinkTaskTest {
@Mock
ijuma commented on PR #15349:
URL: https://github.com/apache/kafka/pull/15349#issuecomment-1937052374
One more thing: if it helps, we can add a comment explaining the reason for
the tag so it's easier for future people to know.
--
This is an automated message from the Apache Git Service.
ijuma commented on PR #15349:
URL: https://github.com/apache/kafka/pull/15349#issuecomment-1937051575
If we have some cases where a suite is mostly unit but it included some
integration tests, it's ok to tag them all as integration and file a JIRA to
fix it (move the integration test
ijuma commented on PR #15349:
URL: https://github.com/apache/kafka/pull/15349#issuecomment-1937051270
A flaky test cannot be a unit test in my opinion. Unit tests are meant to be
deterministic and fast. Anything that doesn't fit that definition should be
tagged as integration test.
--
appchemist commented on code in PR #15296:
URL: https://github.com/apache/kafka/pull/15296#discussion_r1485088569
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch,
appchemist commented on code in PR #15296:
URL: https://github.com/apache/kafka/pull/15296#discussion_r1485088569
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch,
appchemist commented on code in PR #15296:
URL: https://github.com/apache/kafka/pull/15296#discussion_r1485088569
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch,
appchemist commented on code in PR #15296:
URL: https://github.com/apache/kafka/pull/15296#discussion_r1485088569
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch,
appchemist commented on code in PR #15296:
URL: https://github.com/apache/kafka/pull/15296#discussion_r1485088569
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java:
##
@@ -704,7 +704,7 @@ private void completeBatch(ProducerBatch batch,
[
https://issues.apache.org/jira/browse/KAFKA-14606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17816300#comment-17816300
]
Anurag Agarwal commented on KAFKA-14606:
[~Hangleton] do you think this can be looked into now
[
https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814001#comment-17814001
]
Florin Akermann edited comment on KAFKA-16123 at 2/10/24 10:46 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814001#comment-17814001
]
Florin Akermann edited comment on KAFKA-16123 at 2/10/24 10:45 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-16123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17814001#comment-17814001
]
Florin Akermann edited comment on KAFKA-16123 at 2/10/24 10:46 AM:
---
florin-akermann commented on PR #15189:
URL: https://github.com/apache/kafka/pull/15189#issuecomment-1936966125
This might actually be a general issue and not just for null-key records?
In other words, the problem already existed prior to KIP-962 for non
null-key records.
See
florin-akermann commented on PR #14426:
URL: https://github.com/apache/kafka/pull/14426#issuecomment-1936963868
> > All the tests still passed.
What currently has been merged from
https://issues.apache.org/jira/browse/KAFKA-16123 into this PR wouldn't solve
the general case (non
gharris1727 commented on PR #15349:
URL: https://github.com/apache/kafka/pull/15349#issuecomment-1936929467
@dajac Maybe I misunderstand, but I don't see how the change you linked is
relevant. If you run the tests once (as in locally running `./gradlew
unitTest`) then the retries and
37 matches
Mail list logo
