[
https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817847#comment-17817847
]
Chaitanya Mukka commented on KAFKA-16223:
-
Sure! Let me know how you propose this. I had these
mukkachaitanya opened a new pull request, #15381:
URL: https://github.com/apache/kafka/pull/15381
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
jeffkbkim commented on code in PR #15242:
URL: https://github.com/apache/kafka/pull/15242#discussion_r1491990746
##
core/src/main/scala/kafka/server/ControllerServer.scala:
##
@@ -481,6 +481,8 @@ class ControllerServer(
gharris1727 commented on PR #15367:
URL: https://github.com/apache/kafka/pull/15367#issuecomment-1947714388
I realized that it was a bit silly both manually auditing these, and only
fixing the Connect ones. I've instead addressed all of the unused suppressions
by building a little audit
mjsax commented on PR #14782:
URL: https://github.com/apache/kafka/pull/14782#issuecomment-1947688465
Thanks for the PR. Merged to `trunk`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mjsax merged PR #14782:
URL: https://github.com/apache/kafka/pull/14782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Matthias J. Sax created KAFKA-16263:
---
Summary: Add Kafka Streams docs about available listeners/callback
Key: KAFKA-16263
URL: https://issues.apache.org/jira/browse/KAFKA-16263
Project: Kafka
Matthias J. Sax created KAFKA-16262:
---
Summary: Add IQv2 to Kafka Streams documentation
Key: KAFKA-16262
URL: https://issues.apache.org/jira/browse/KAFKA-16262
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817833#comment-17817833
]
Matthias J. Sax commented on KAFKA-12317:
-
[~aki] – I was just looking into
mjsax opened a new pull request, #15380:
URL: https://github.com/apache/kafka/pull/15380
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
[
https://issues.apache.org/jira/browse/KAFKA-14049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817827#comment-17817827
]
Matthias J. Sax commented on KAFKA-14049:
-
[~aki] does KIP-962 cover this ticket?
> Relax Non
rreddy-22 commented on code in PR #15150:
URL: https://github.com/apache/kafka/pull/15150#discussion_r1491863014
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -20,78 +20,225 @@
import kafka.admin.ConsumerGroupCommand;
import
jianjianjiao closed pull request #8906: KAFKA-10190: To set replication
throttling configs at broker entity-default
URL: https://github.com/apache/kafka/pull/8906
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jeffkbkim commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1491825284
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordHelpers.java:
##
@@ -346,10 +346,9 @@ public static Record newCurrentAssignmentRecord(
rreddy-22 commented on code in PR #15150:
URL: https://github.com/apache/kafka/pull/15150#discussion_r1491858986
##
core/src/test/scala/unit/kafka/admin/ConsumerGroupCommandTest.scala:
##
@@ -122,7 +123,9 @@ class ConsumerGroupCommandTest extends
KafkaServerTestHarness {
}
mjsax commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1491795591
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java:
##
@@ -191,6 +191,10 @@ public void process(final Record record) {
mjsax commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1491788610
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java:
##
@@ -609,17 +842,18 @@ public void testOrdering() {
mjsax commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1491788610
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java:
##
@@ -609,17 +842,18 @@ public void testOrdering() {
jeffkbkim commented on PR #15361:
URL: https://github.com/apache/kafka/pull/15361#issuecomment-1947456921
@cadonna can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jeffkbkim commented on code in PR #15361:
URL: https://github.com/apache/kafka/pull/15361#discussion_r1491745461
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/GlobalStateTaskTest.java:
##
@@ -217,21 +215,53 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zhifeng Chen resolved KAFKA-16259.
--
Resolution: Duplicate
> Immutable MetadataCache to improve client performance
>
ericzhifengchen commented on PR #15376:
URL: https://github.com/apache/kafka/pull/15376#issuecomment-1947428547
close as duplication
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ericzhifengchen closed pull request #15376: KAFKA-16259 Immutable MetadataCache
to improve client performance
URL: https://github.com/apache/kafka/pull/15376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
ericzhifengchen commented on PR #15376:
URL: https://github.com/apache/kafka/pull/15376#issuecomment-1947427960
@ijuma Thanks for the info. confirmed it's done in
[#15323](https://github.com/apache/kafka/pull/15323), I will close this one as
duplicated
--
This is an automated message
[
https://issues.apache.org/jira/browse/KAFKA-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817795#comment-17817795
]
Justine Olshan commented on KAFKA-16212:
Thanks [~omnia_h_ibrahim] I remember this particularly
jeqo commented on PR #15379:
URL: https://github.com/apache/kafka/pull/15379#issuecomment-1947314563
cc @C0urante @yashmayya @mimaison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
jeqo closed pull request #12637: KAFKA-14226 (KIP-821): [connect:transform]
Introduce support for nested structures
URL: https://github.com/apache/kafka/pull/12637
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
jeqo commented on PR #12637:
URL: https://github.com/apache/kafka/pull/12637#issuecomment-1947312971
@mimaison thanks for the reminder! I checked with @C0urante and decided to
open a new PR to continue this review as the current one just got too long for
anyone to grasp.
Opened a new
jeqo opened a new pull request, #15379:
URL: https://github.com/apache/kafka/pull/15379
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing
jeqo closed pull request #15378: KAFKA-14226: [connect:transform] Introduce
support for nested structures
URL: https://github.com/apache/kafka/pull/15378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817778#comment-17817778
]
Hector Geraldino commented on KAFKA-16223:
--
Hey [~cmukka20], I haven't started on this one just
jeqo opened a new pull request, #15378:
URL: https://github.com/apache/kafka/pull/15378
[KIP-821](https://cwiki.apache.org/confluence/display/KAFKA/KIP-821%3A+Connect+Transforms+support+for+nested+structures)
implementation.
Includes the following changes:
Firts (main) commit
nizhikov closed pull request #15070: KAFKA-14588 [WIP] ConfigCommand rewritten
in java
URL: https://github.com/apache/kafka/pull/15070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lianetm commented on PR #15372:
URL: https://github.com/apache/kafka/pull/15372#issuecomment-1946894520
thanks for the changes! lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lianetm commented on code in PR #15372:
URL: https://github.com/apache/kafka/pull/15372#discussion_r1491444058
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala:
##
@@ -265,6 +265,32 @@ class PlaintextConsumerTest extends BaseConsumerTest {
Andrew Schofield created KAFKA-16261:
Summary: MembershipManagerImpl.updateSubscription fails if already
empty subscription
Key: KAFKA-16261
URL: https://issues.apache.org/jira/browse/KAFKA-16261
artemlivshits commented on code in PR #15265:
URL: https://github.com/apache/kafka/pull/15265#discussion_r1491416954
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2129,63 +2167,183 @@ private Map>
handleDescribeTopicsByNames(f
hachikuji merged PR #15323:
URL: https://github.com/apache/kafka/pull/15323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
tinaselenge opened a new pull request, #15377:
URL: https://github.com/apache/kafka/pull/15377
This makes the test simpler to enable KRaft later.
It's unclear why a custom authoriser had to be used in the first place based
on the commit made this change and tests seem to work
lianetm commented on code in PR #15375:
URL: https://github.com/apache/kafka/pull/15375#discussion_r1491231865
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -731,10 +729,29 @@ private boolean targetAssignmentReconciled()
lianetm commented on code in PR #15375:
URL: https://github.com/apache/kafka/pull/15375#discussion_r1491222723
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -685,13 +690,6 @@ public boolean shouldHeartbeatNow() {
lianetm commented on code in PR #15375:
URL: https://github.com/apache/kafka/pull/15375#discussion_r1491204862
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -335,8 +335,13 @@ public int memberEpoch() {
return
lianetm commented on code in PR #15375:
URL: https://github.com/apache/kafka/pull/15375#discussion_r1491192487
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -188,18 +188,18 @@ public HeartbeatRequestManager(
lianetm commented on PR #15375:
URL: https://github.com/apache/kafka/pull/15375#issuecomment-1946314919
Hey @lucasbru, agree that the callback invocation is missing, I had filed
https://issues.apache.org/jira/browse/KAFKA-16258 to tackle that in a following
PR if that's ok (mostly because
dajac commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1491144005
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -2079,253 +2056,20 @@ public void testReconciliationProcess()
cadonna commented on code in PR #13931:
URL: https://github.com/apache/kafka/pull/13931#discussion_r1489430066
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java:
##
@@ -138,11 +150,30 @@ public class RecordCollectorTest {
[
https://issues.apache.org/jira/browse/KAFKA-16260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucia Cerchie updated KAFKA-16260:
--
Summary: Deprecate window.size.ms in StreamsConfig (was: Remove
window.size.ms from
[
https://issues.apache.org/jira/browse/KAFKA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817649#comment-17817649
]
Ahmed Sobeh commented on KAFKA-15729:
-
Can i pick this up?
> KRaft support in GetOffsetShellTest
>
Vaibhav-Nazare commented on code in PR #13817:
URL: https://github.com/apache/kafka/pull/13817#discussion_r1490885160
##
Jenkinsfile:
##
@@ -174,6 +183,28 @@ pipeline {
echo 'Skipping Kafka Streams archetype test for Java 21'
}
}
+
+
joobisb commented on PR #13931:
URL: https://github.com/apache/kafka/pull/13931#issuecomment-1945902179
> @joobisb Could you please fix the compilation errors?
@cadonna done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-15997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817639#comment-17817639
]
Emanuele Sabellico edited comment on KAFKA-15997 at 2/15/24 11:23 AM:
[
https://issues.apache.org/jira/browse/KAFKA-15997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17817639#comment-17817639
]
Emanuele Sabellico commented on KAFKA-15997:
The issue came from the coordinator not
nizhikov commented on PR #15363:
URL: https://github.com/apache/kafka/pull/15363#issuecomment-1945758213
Hello @mimaison @jolshan
Can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
nizhikov commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1945757954
Hello @mimaison @jolshan
Can you, please, take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
AyoubOm commented on code in PR #15361:
URL: https://github.com/apache/kafka/pull/15361#discussion_r1490720173
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StateConsumerTest.java:
##
@@ -161,6 +140,10 @@ public void update(final ConsumerRecord
record)
AyoubOm commented on code in PR #15361:
URL: https://github.com/apache/kafka/pull/15361#discussion_r1490718635
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java:
##
@@ -259,19 +251,14 @@ void initialize() {
for (final
AyoubOm commented on code in PR #15361:
URL: https://github.com/apache/kafka/pull/15361#discussion_r1490716253
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStateUpdateTask.java:
##
@@ -150,5 +150,11 @@ private void initTopology() {
}
lucasbru commented on PR #15372:
URL: https://github.com/apache/kafka/pull/15372#issuecomment-1945629703
@cadonna could you please have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dajac merged PR #15368:
URL: https://github.com/apache/kafka/pull/15368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
59 matches
Mail list logo
