[PR] KAFKA-14588 [WIP] [kafka]

2024-02-21 Thread via GitHub
nizhikov opened a new pull request, #15417: URL: https://github.com/apache/kafka/pull/15417 PR contains `ConfigCommand` rewritten in java. Due to heavy dependencies on `core` classes command can't be moved in `tools` for now. But it can be rewritten in java staying in `core` module

[PR] KAFKA-16277: AbstractStickyAssignor - Sort owned TopicPartitions by p… [kafka]

2024-02-21 Thread via GitHub
credpath-seek opened a new pull request, #15416: URL: https://github.com/apache/kafka/pull/15416 ## Context Treats `KAFKA-16277 - CooperativeStickyAssignor does not spread topics evenly among consumer group` https://issues.apache.org/jira/browse/KAFKA-16277 Tests WIP

[jira] [Commented] (KAFKA-16283) RoundRobinPartitioner will only send to half of the partitions in a topic

2024-02-21 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819471#comment-17819471 ] Luke Chen commented on KAFKA-16283: --- Oops, I was also involved in the discussion years ago, but I

Re: [PR] MINOR: Test flakyness verification [kafka]

2024-02-21 Thread via GitHub
github-actions[bot] commented on PR #14814: URL: https://github.com/apache/kafka/pull/14814#issuecomment-1958593965 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-16259 Immutable MetadataCache to improve client performance [kafka]

2024-02-21 Thread via GitHub
ericzhifengchen commented on PR #15376: URL: https://github.com/apache/kafka/pull/15376#issuecomment-1958593101 my github account is ericzhifengc...@gmail.com -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16251: Fix for not sending heartbeat while fenced [kafka]

2024-02-21 Thread via GitHub
lianetm commented on PR #15392: URL: https://github.com/apache/kafka/pull/15392#issuecomment-1958573687 Test failures seem unrelated to me. The `testAutoCommitOnClose` failing on the consumer integration tests has been reported flaky independently of this PR , tracked with

Re: [PR] KAFKA-16258: callback to release assignment when stale member leaves group [kafka]

2024-02-21 Thread via GitHub
lianetm commented on code in PR #15415: URL: https://github.com/apache/kafka/pull/15415#discussion_r1498553247 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -169,10 +169,8 @@ class PlaintextConsumerTest extends BaseConsumerTest {

Re: [PR] KAFKA-16258: callback to release assignment when stale member leaves group [kafka]

2024-02-21 Thread via GitHub
lianetm commented on PR #15415: URL: https://github.com/apache/kafka/pull/15415#issuecomment-1958564382 Hey @lucasbru , could you take a look at this one? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] KAFKA-16258: callback to release assignment when stale member leaves group [kafka]

2024-02-21 Thread via GitHub
lianetm opened a new pull request, #15415: URL: https://github.com/apache/kafka/pull/15415 Introduce call to `onPartitionsLost` callback to release assignment when a consumer pro-actively leaves the group due to poll timer expired. When the poll timer expires, the member sends a

Re: [PR] KAFKA-16214: add client info in authentication error log [kafka]

2024-02-21 Thread via GitHub
jeffkbkim commented on code in PR #15280: URL: https://github.com/apache/kafka/pull/15280#discussion_r1498526867 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1675,6 +1677,20 @@ public static Map entriesWithPrefix(Map map, String pr return

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

2024-02-21 Thread via GitHub
testn commented on code in PR #15402: URL: https://github.com/apache/kafka/pull/15402#discussion_r1498498644 ## checkstyle/suppressions.xml: ## @@ -92,7 +92,7 @@ files="(Utils|Topic|KafkaLZ4BlockOutputStream|AclData|JoinGroupRequest).java"/> +

Re: [PR] KAFKA-15867: Should ConsumerNetworkThread wrap the exception and notify the polling thread? [kafka]

2024-02-21 Thread via GitHub
jeffkbkim commented on code in PR #15312: URL: https://github.com/apache/kafka/pull/15312#discussion_r1498498011 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java: ## @@ -87,8 +92,8 @@ public void run() { try {

Re: [PR] KAFKA-16283: notify users about RoundRobinPartitioner bug [kafka]

2024-02-21 Thread via GitHub
showuon closed pull request #15400: KAFKA-16283: notify users about RoundRobinPartitioner bug URL: https://github.com/apache/kafka/pull/15400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (KAFKA-16283) RoundRobinPartitioner will only send to half of the partitions in a topic

2024-02-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819428#comment-17819428 ] ASF GitHub Bot commented on KAFKA-16283: showuon closed pull request #585: KAFKA-16283: notify

Re: [PR] KAFKA-16283: notify users about RoundRobinPartitioner bug [kafka]

2024-02-21 Thread via GitHub
showuon commented on PR #15400: URL: https://github.com/apache/kafka/pull/15400#issuecomment-1958464961 Sorry @stanislavkozlovski , I just found this issue has already found and documented on document. Let's close this PR now. -- This is an automated message from the Apache Git Service.

Re: [PR] KAFKA-16186: Broker metrics for client telemetry (KIP-714) [kafka]

2024-02-21 Thread via GitHub
junrao commented on code in PR #15251: URL: https://github.com/apache/kafka/pull/15251#discussion_r1498439741 ## server/src/main/java/org/apache/kafka/server/ClientMetricsManager.java: ## @@ -493,4 +520,124 @@ public void run() { } } } + +//

Re: [PR] KAFKA-16009: Fix PlaintextConsumerTest. testMaxPollIntervalMsDelayInRevocation [kafka]

2024-02-21 Thread via GitHub
mjsax commented on code in PR #15383: URL: https://github.com/apache/kafka/pull/15383#discussion_r1498439703 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java: ## @@ -419,6 +422,35 @@ public void testWakeupAfterNonEmptyFetch() {

Re: [PR] KAFKA-15143: Adding in MockFixedKeyProcessorContext and Test [kafka]

2024-02-21 Thread via GitHub
mjsax commented on PR #14605: URL: https://github.com/apache/kafka/pull/14605#issuecomment-1958253922 That weird -- signup should just work. (You definitely don't need to file an ICLA or become a committer :)) -- Maybe it's a temporary glitch -- or something is broken and we need to

[jira] [Updated] (KAFKA-16295) Align RocksDB and in-memory store init() sequence

2024-02-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-16295: --- Labels: newbie (was: ) > Align RocksDB and in-memory store init() sequence

[jira] [Updated] (KAFKA-16295) Align RocksDB and in-memory store init() sequence

2024-02-21 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-16295: --- Summary: Align RocksDB and in-memory store init() sequence (was: Align

Re: [PR] KAFKA-7663: initial commit for reprocessing on user added stores [kafka]

2024-02-21 Thread via GitHub
wcarlson5 commented on code in PR #15414: URL: https://github.com/apache/kafka/pull/15414#discussion_r1498391601 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/TableSourceNode.java: ## @@ -105,7 +105,8 @@ public void writeToTopology(final

[jira] [Created] (KAFKA-16295) Align RocksDB and in-memory store inti() sequence

2024-02-21 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-16295: --- Summary: Align RocksDB and in-memory store inti() sequence Key: KAFKA-16295 URL: https://issues.apache.org/jira/browse/KAFKA-16295 Project: Kafka

Re: [PR] KAFKA-7663: initial commit for reprocessing on user added stores [kafka]

2024-02-21 Thread via GitHub
wcarlson5 commented on code in PR #15414: URL: https://github.com/apache/kafka/pull/15414#discussion_r1498387326 ## streams/src/main/java/org/apache/kafka/streams/Topology.java: ## @@ -783,7 +783,8 @@ public synchronized Topology addGlobalStore(final StoreBuilder storeBu

[PR] KAFKA-7663: initial commit for reprocessing on user added stores [kafka]

2024-02-21 Thread via GitHub
wcarlson5 opened a new pull request, #15414: URL: https://github.com/apache/kafka/pull/15414 When custom processors are added via `StreamBuilder#addGlobalStore` they will now reprocess all records through the custom transformer instead of loading directly. We do this so that users

[PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-21 Thread via GitHub
federico-weisse-sportsbet opened a new pull request, #15413: URL: https://github.com/apache/kafka/pull/15413 This should be greater than 1 to be consistent with behavior described in max.in.flight.requests.per.connection property. More detailed description of your change, if

[jira] [Comment Edited] (KAFKA-16291) Mirrormaker2 wrong checkpoints

2024-02-21 Thread Claudio Benfatto (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819397#comment-17819397 ] Claudio Benfatto edited comment on KAFKA-16291 at 2/21/24 9:52 PM: --- Hi

[jira] [Comment Edited] (KAFKA-16291) Mirrormaker2 wrong checkpoints

2024-02-21 Thread Claudio Benfatto (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819397#comment-17819397 ] Claudio Benfatto edited comment on KAFKA-16291 at 2/21/24 9:52 PM: --- Hi

[jira] [Comment Edited] (KAFKA-16291) Mirrormaker2 wrong checkpoints

2024-02-21 Thread Claudio Benfatto (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819397#comment-17819397 ] Claudio Benfatto edited comment on KAFKA-16291 at 2/21/24 9:50 PM: --- Hi

[jira] [Comment Edited] (KAFKA-16291) Mirrormaker2 wrong checkpoints

2024-02-21 Thread Claudio Benfatto (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819397#comment-17819397 ] Claudio Benfatto edited comment on KAFKA-16291 at 2/21/24 9:48 PM: --- Hi

[jira] [Comment Edited] (KAFKA-16291) Mirrormaker2 wrong checkpoints

2024-02-21 Thread Claudio Benfatto (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819397#comment-17819397 ] Claudio Benfatto edited comment on KAFKA-16291 at 2/21/24 9:48 PM: --- Hi

[jira] [Commented] (KAFKA-16291) Mirrormaker2 wrong checkpoints

2024-02-21 Thread Claudio Benfatto (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819397#comment-17819397 ] Claudio Benfatto commented on KAFKA-16291: -- Hi [~gharris1727] , thanks a lot for your clear

[PR] MINOR: Fix ReadOnlySessionStore java docs [kafka]

2024-02-21 Thread via GitHub
AyoubOm opened a new pull request, #15412: URL: https://github.com/apache/kafka/pull/15412 *Fixes some typos in javadocs of readOnly SessionStore, and minor typos in WindowStore / KeyValueStore.* -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-15307: update/note deprecated configs [kafka]

2024-02-21 Thread via GitHub
Cerchie commented on code in PR #14360: URL: https://github.com/apache/kafka/pull/14360#discussion_r1498343776 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -482,7 +482,8 @@ public class StreamsConfig extends AbstractConfig { public static

[PR] KAFKA-16294: Add group protocol migration enabling config [kafka]

2024-02-21 Thread via GitHub
dongnuo123 opened a new pull request, #15411: URL: https://github.com/apache/kafka/pull/15411 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Assigned] (KAFKA-16294) Add group protocol migration enabling config

2024-02-21 Thread Dongnuo Lyu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16294?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dongnuo Lyu reassigned KAFKA-16294: --- Assignee: Dongnuo Lyu > Add group protocol migration enabling config >

[jira] [Created] (KAFKA-16294) Add group protocol migration enabling config

2024-02-21 Thread Dongnuo Lyu (Jira)
Dongnuo Lyu created KAFKA-16294: --- Summary: Add group protocol migration enabling config Key: KAFKA-16294 URL: https://issues.apache.org/jira/browse/KAFKA-16294 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-16224) Fix handling of deleted topic when auto-committing before revocation

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16224: --- Description: Current logic for auto-committing offsets when partitions are revoked will

[jira] [Resolved] (KAFKA-15665) Enforce ISR to have all target replicas when complete partition reassignment

2024-02-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15665?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan resolved KAFKA-15665. Resolution: Fixed > Enforce ISR to have all target replicas when complete partition

[jira] [Comment Edited] (KAFKA-16291) Mirrormaker2 wrong checkpoints

2024-02-21 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819368#comment-17819368 ] Greg Harris edited comment on KAFKA-16291 at 2/21/24 7:01 PM: -- Hi

[jira] [Commented] (KAFKA-16291) Mirrormaker2 wrong checkpoints

2024-02-21 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819368#comment-17819368 ] Greg Harris commented on KAFKA-16291: - Hi [~claudio.benfatto] Thanks for the bug report and the very

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

2024-02-21 Thread via GitHub
divijvaidya commented on code in PR #15402: URL: https://github.com/apache/kafka/pull/15402#discussion_r1498116256 ## checkstyle/suppressions.xml: ## @@ -92,7 +92,7 @@ files="(Utils|Topic|KafkaLZ4BlockOutputStream|AclData|JoinGroupRequest).java"/> +

[jira] [Commented] (KAFKA-16283) RoundRobinPartitioner will only send to half of the partitions in a topic

2024-02-21 Thread Artem Livshits (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819363#comment-17819363 ] Artem Livshits commented on KAFKA-16283: The issue was created by the first attempt to implement

[jira] [Comment Edited] (KAFKA-15898) Flaky test: testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest

2024-02-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819351#comment-17819351 ] Justine Olshan edited comment on KAFKA-15898 at 2/21/24 6:26 PM: - I have

[jira] [Commented] (KAFKA-15898) Flaky test: testFenceMultipleBrokers() – org.apache.kafka.controller.QuorumControllerTest

2024-02-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819351#comment-17819351 ] Justine Olshan commented on KAFKA-15898: I have 8 failures on one run

Re: [PR] KAFKA-16167: re-enable PlaintextConsumerTest.testAutoCommitOnCloseAfterWakeup [kafka]

2024-02-21 Thread via GitHub
jolshan commented on PR #15358: URL: https://github.com/apache/kafka/pull/15358#issuecomment-1957581558 This test seems somewhat flaky still:

[jira] [Resolved] (KAFKA-16194) KafkaConsumer.groupMetadata() should be correct when first records are returned

2024-02-21 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-16194. --- Resolution: Fixed > KafkaConsumer.groupMetadata() should be correct when first records are

Re: [PR] KAFKA-16194: Do not return records from poll if group metadata unknown [kafka]

2024-02-21 Thread via GitHub
cadonna merged PR #15369: URL: https://github.com/apache/kafka/pull/15369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: extend transaction unit test to validate drain [kafka]

2024-02-21 Thread via GitHub
jolshan commented on code in PR #15320: URL: https://github.com/apache/kafka/pull/15320#discussion_r1497943369 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -2548,6 +2548,23 @@ public void

Re: [PR] HOTFIX: Fix compilation error in TransactionManagerTest [kafka]

2024-02-21 Thread via GitHub
jolshan commented on PR #15405: URL: https://github.com/apache/kafka/pull/15405#issuecomment-1957306611 Sorry that was my bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-16283) RoundRobinPartitioner will only send to half of the partitions in a topic

2024-02-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819325#comment-17819325 ] Justine Olshan commented on KAFKA-16283: also https://issues.apache.org/jira/browse/KAFKA-14573 

[jira] [Commented] (KAFKA-16283) RoundRobinPartitioner will only send to half of the partitions in a topic

2024-02-21 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819324#comment-17819324 ] Justine Olshan commented on KAFKA-16283: https://issues.apache.org/jira/browse/KAFKA-13359 Is

[jira] [Commented] (KAFKA-16283) RoundRobinPartitioner will only send to half of the partitions in a topic

2024-02-21 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819322#comment-17819322 ] Jun Rao commented on KAFKA-16283: - [~showuon] : Is this the same as

[jira] [Comment Edited] (KAFKA-15538) Client support for java regex based subscription

2024-02-21 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819008#comment-17819008 ] Phuc Hong Tran edited comment on KAFKA-15538 at 2/21/24 4:43 PM: - I can

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

2024-02-21 Thread via GitHub
testn commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1957192264 > Nice! Small but very helpful change. > > Out of curiosity, do you happen to have any ideas to detect such performance-inefficiencies automatically in future? Currently,

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

2024-02-21 Thread via GitHub
testn commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1957177698 Add the file to the suppression list instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Comment Edited] (KAFKA-16292) Revamp upgrade.html page

2024-02-21 Thread Ahmed Sobeh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819310#comment-17819310 ] Ahmed Sobeh edited comment on KAFKA-16292 at 2/21/24 4:13 PM: -- Not sure if

[jira] [Commented] (KAFKA-16292) Revamp upgrade.html page

2024-02-21 Thread Ahmed Sobeh (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819310#comment-17819310 ] Ahmed Sobeh commented on KAFKA-16292: - Not sure if someone is already working on this, but happy to

[jira] [Updated] (KAFKA-16290) Investigate propagating subscription state updates via queues

2024-02-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16290: -- Priority: Critical (was: Major) > Investigate propagating subscription state updates via queues >

[jira] [Updated] (KAFKA-16290) Investigate propagating subscription state updates via queues

2024-02-21 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16290: -- Fix Version/s: 3.8.0 > Investigate propagating subscription state updates via queues >

Re: [PR] KAFKA-16286; Notify listener of latest leader and epoch [kafka]

2024-02-21 Thread via GitHub
jsancio commented on PR #15397: URL: https://github.com/apache/kafka/pull/15397#issuecomment-1957122692 All of the `raft:test` tests passed. There seem to be some unrelated failures. Running the tests again. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MINOR: remove unnecessary logging [kafka]

2024-02-21 Thread via GitHub
mjsax merged PR #15396: URL: https://github.com/apache/kafka/pull/15396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]

2024-02-21 Thread via GitHub
soarez commented on code in PR #15409: URL: https://github.com/apache/kafka/pull/15409#discussion_r1497794379 ## tests/kafkatest/tests/core/log_dir_failure_test.py: ## @@ -84,20 +84,25 @@ def __init__(self, test_context): self.num_consumers = 1 def setUp(self):

Re: [PR] KAFKA-15610: Fix CoreUtils.swallow() test gaps [kafka]

2024-02-21 Thread via GitHub
ghostspiders commented on PR #15410: URL: https://github.com/apache/kafka/pull/15410#issuecomment-1956966547 Hi, @divijvaidya please review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] KAFKA-15610: Fix CoreUtils.swallow() test gaps [kafka]

2024-02-21 Thread via GitHub
ghostspiders opened a new pull request, #15410: URL: https://github.com/apache/kafka/pull/15410 The CoreUtils.swallow() method in different logging levels test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

2024-02-21 Thread via GitHub
mumrah commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1497780170 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2129,63 +2167,183 @@ private Map> handleDescribeTopicsByNames(f }

[jira] [Resolved] (KAFKA-16010) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling

2024-02-21 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy resolved KAFKA-16010. Resolution: Duplicate > Fix

[jira] [Commented] (KAFKA-16010) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling

2024-02-21 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819289#comment-17819289 ] Lucas Brutschy commented on KAFKA-16010: [~kirktrue] I think you enabled this test already >

[jira] [Comment Edited] (KAFKA-16010) Fix PlaintextConsumerTest.testMultiConsumerSessionTimeoutOnStopPolling

2024-02-21 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819289#comment-17819289 ] Lucas Brutschy edited comment on KAFKA-16010 at 2/21/24 3:14 PM: -

[jira] [Commented] (KAFKA-16292) Revamp upgrade.html page

2024-02-21 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819283#comment-17819283 ] Mickael Maison commented on KAFKA-16292: We can add a paragraph with links to the previous

Re: [PR] MINOR: use 2 logdirs in ZK migration system tests [kafka]

2024-02-21 Thread via GitHub
gaurav-narula commented on PR #15394: URL: https://github.com/apache/kafka/pull/15394#issuecomment-1956779813 CC: @soarez @OmniaGM @pprovenzano @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16293: Test log directory failure in Kraft [kafka]

2024-02-21 Thread via GitHub
gaurav-narula commented on PR #15409: URL: https://github.com/apache/kafka/pull/15409#issuecomment-1956778458 CC: @soarez @OmniaGM @pprovenzano @cmccabe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] KAFKA-16293: Test log directory failure in Kraft [kafka]

2024-02-21 Thread via GitHub
gaurav-narula opened a new pull request, #15409: URL: https://github.com/apache/kafka/pull/15409 Enables log directory failure system test for all Kraft modes in addition to ZK mode. This depends on #15335 being merged. -- This is an automated message from the Apache Git Service.

[jira] [Updated] (KAFKA-16185) Fix client reconciliation of same assignment received in different epochs

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16185: --- Priority: Blocker (was: Critical) > Fix client reconciliation of same assignment received

[jira] [Updated] (KAFKA-16185) Fix client reconciliation of same assignment received in different epochs

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16185: --- Description: Currently, the intention in the client state machine is that the client always

[jira] [Updated] (KAFKA-16261) MembershipManagerImpl.updateSubscription fails if already empty subscription

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16261: --- Affects Version/s: 3.7.0 > MembershipManagerImpl.updateSubscription fails if already empty

[jira] [Updated] (KAFKA-16185) Fix client reconciliation of same assignment received in different epochs

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16185: --- Priority: Critical (was: Blocker) > Fix client reconciliation of same assignment received

Re: [PR] KAFKA-15143: Adding in MockFixedKeyProcessorContext and Test [kafka]

2024-02-21 Thread via GitHub
s7pandey commented on PR #14605: URL: https://github.com/apache/kafka/pull/14605#issuecomment-1956760536 Hey @mjsax I seem unable to gain access to Confluence, following the instructions on the KIP page leads me to a page where I cannot sign up, would I need to follow:

[jira] [Updated] (KAFKA-16224) Fix handling of deleted topic when auto-committing before revocation

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16224: --- Description: Current logic for auto-committing offsets when partitions are revoked will

[jira] [Updated] (KAFKA-16224) Fix handling of deleted topic when auto-committing before revocation

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16224?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16224: --- Priority: Critical (was: Major) > Fix handling of deleted topic when auto-committing

[jira] [Assigned] (KAFKA-16293) Test log directory failure in Kraft

2024-02-21 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Narula reassigned KAFKA-16293: - Assignee: Gaurav Narula > Test log directory failure in Kraft >

[jira] [Created] (KAFKA-16293) Test log directory failure in Kraft

2024-02-21 Thread Gaurav Narula (Jira)
Gaurav Narula created KAFKA-16293: - Summary: Test log directory failure in Kraft Key: KAFKA-16293 URL: https://issues.apache.org/jira/browse/KAFKA-16293 Project: Kafka Issue Type: Test

[jira] [Updated] (KAFKA-16185) Fix client reconciliation of same assignment received in different epochs

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16185: --- Description: Currently, the intention in the client state machine is that the client always

[jira] [Updated] (KAFKA-16261) MembershipManagerImpl.updateSubscription fails if already empty subscription

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16261: --- Labels: client-transitions-issues consumer-threading-refactor kip-848-client-support (was:

[jira] [Updated] (KAFKA-16004) Review new consumer inflight offset commit logic

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16004: --- Priority: Critical (was: Major) > Review new consumer inflight offset commit logic >

[jira] [Updated] (KAFKA-16103) Review client logic for triggering offset commit callbacks

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16103: --- Priority: Critical (was: Major) > Review client logic for triggering offset commit

[jira] [Updated] (KAFKA-15839) Topic ID integration in consumer subscription state

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15839: --- Fix Version/s: 4.0.0 (was: 3.8.0) > Topic ID integration in consumer

[jira] [Updated] (KAFKA-15847) Consider partial metadata requests for client reconciliation

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15847: --- Fix Version/s: 4.0.0 (was: 3.8.0) > Consider partial metadata

[jira] [Updated] (KAFKA-15843) Review consumer onPartitionsAssigned called with empty partitions

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15843: --- Fix Version/s: 4.0.0 (was: 3.8.0) > Review consumer

[jira] [Updated] (KAFKA-16185) Fix client reconciliation of same assignment received in different epochs

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16185: --- Priority: Critical (was: Major) > Fix client reconciliation of same assignment received in

[jira] [Updated] (KAFKA-16261) MembershipManagerImpl.updateSubscription fails if already empty subscription

2024-02-21 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16261: --- Priority: Critical (was: Minor) > MembershipManagerImpl.updateSubscription fails if

[jira] [Commented] (KAFKA-16292) Revamp upgrade.html page

2024-02-21 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17819258#comment-17819258 ] Ismael Juma commented on KAFKA-16292: - I agree that having the upgrade details for so many versions

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

2024-02-21 Thread via GitHub
lucasbru commented on PR #15408: URL: https://github.com/apache/kafka/pull/15408#issuecomment-1956664015 @kirktrue Hope that helps! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] KAFKA-16287: Implement example test for common rebalance callback [kafka]

2024-02-21 Thread via GitHub
lucasbru opened a new pull request, #15408: URL: https://github.com/apache/kafka/pull/15408 Add 6 example tests to the `PlaintextConsumerTest` that tests using a `ConsumerRebalanceListener` to invoke methods on the consumer. This test is implemented in a reasonably general way with a

Re: [PR] MINOR: Reduce memory allocation in ClientTelemetryReporter.java [kafka]

2024-02-21 Thread via GitHub
divijvaidya commented on PR #15402: URL: https://github.com/apache/kafka/pull/15402#issuecomment-1956592176 @testn could you please fix the checkstyle failures which is causing the build to fail.

Re: [PR] KAFKA-16259 Immutable MetadataCache to improve client performance [kafka]

2024-02-21 Thread via GitHub
msn-tldr commented on PR #15376: URL: https://github.com/apache/kafka/pull/15376#issuecomment-1956540126 @ericzhifengchen The email you shared is anonymised with "*", I see it as `***@***.***`. Is that because replied using email & github automatically anonymised it 樂

Re: [PR] MINOR: Add 3.7 upgrade notes [kafka]

2024-02-21 Thread via GitHub
divijvaidya commented on PR #15407: URL: https://github.com/apache/kafka/pull/15407#issuecomment-1956469824 As an aside - we need a similar PR for ops.html as well since kafka-site is ahead of trunk here right now. This doesn't block 3.7 and could be done later as well. Just have to make

Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]

2024-02-21 Thread via GitHub
mimaison commented on PR #15406: URL: https://github.com/apache/kafka/pull/15406#issuecomment-1956462946 So +1 for merging this and https://github.com/apache/kafka/pull/15407 now so we can update kafka-site. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-21 Thread via GitHub
jlprat commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-1956458474 Rebased -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINOR: Update dependencies [kafka]

2024-02-21 Thread via GitHub
divijvaidya commented on PR #15404: URL: https://github.com/apache/kafka/pull/15404#issuecomment-1956451482 It must have been fixed by https://github.com/apache/kafka/commit/cc49fc76564b15f2111801faf62341aaf01c4d8c Perhaps a rebase from trunk should help. -- This is an automated

Re: [PR] MINOR: Reconcile upgrade.html with kafka-site/36's version [kafka]

2024-02-21 Thread via GitHub
mimaison commented on PR #15406: URL: https://github.com/apache/kafka/pull/15406#issuecomment-1956448543 Locally I rebased this PR on trunk to fix the compilation issue (https://github.com/apache/kafka/commit/cc49fc76564b15f2111801faf62341aaf01c4d8c) and ran `./gradlew siteDocsTar`.

  1   2   >