[jira] [Created] (KAFKA-16314) Add the new ABORTABLE_ERROR

2024-02-28 Thread Sanskar Jhajharia (Jira)
Sanskar Jhajharia created KAFKA-16314: - Summary: Add the new ABORTABLE_ERROR Key: KAFKA-16314 URL: https://issues.apache.org/jira/browse/KAFKA-16314 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-15348: add support for 'range IQs with versioned state stores (KIP-969) [kafka]

2024-02-28 Thread via GitHub
github-actions[bot] commented on PR #14634: URL: https://github.com/apache/kafka/pull/14634#issuecomment-1970334774 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1506929452 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java: ## @@ -32,36 +36,42 @@ public enum Type { private final Type

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1506928829 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java: ## @@ -32,36 +36,42 @@ public enum Type { private final Type

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1506928334 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java: ## @@ -32,36 +36,42 @@ public enum Type { private final Type

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1506925947 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/BackgroundEvent.java: ## @@ -31,36 +32,42 @@ public enum Type { private final Type

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1506925786 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java: ## @@ -32,36 +36,42 @@ public enum Type { private final Type

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1506925548 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java: ## @@ -32,36 +36,42 @@ public enum Type { private final Type

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1506925362 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java: ## @@ -32,36 +36,42 @@ public enum Type { private final Type

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1506924671 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1017,11 +1016,10 @@ public Map> listTopics(Duration timeout) {

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1506924502 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -988,12 +988,11 @@ public List partitionsFor(String topic,

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1506924357 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java: ## @@ -32,36 +36,42 @@ public enum Type { private final Type

[jira] [Commented] (KAFKA-16290) Investigate propagating subscription state updates via queues

2024-02-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821910#comment-17821910 ] Kirk True commented on KAFKA-16290: --- There are many {{Consumer}} APIs in which the

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-02-28 Thread via GitHub
showuon merged PR #15213: URL: https://github.com/apache/kafka/pull/15213 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-02-28 Thread via GitHub
showuon commented on PR #15213: URL: https://github.com/apache/kafka/pull/15213#issuecomment-1970152996 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Remove the redundant space in the comments [kafka]

2024-02-28 Thread via GitHub
showuon merged PR #15439: URL: https://github.com/apache/kafka/pull/15439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add 3.7 to Kafka Streams system tests [kafka]

2024-02-28 Thread via GitHub
mjsax commented on PR #15443: URL: https://github.com/apache/kafka/pull/15443#issuecomment-1970088906 Triggered a system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6080/ -- This is an automated message from the Apache Git Service. To respond to the

[PR] MINOR: Add 3.7 to Kafka Streams system tests [kafka]

2024-02-28 Thread via GitHub
mjsax opened a new pull request, #15443: URL: https://github.com/apache/kafka/pull/15443 \cc @stanislavkozlovski (I assume the 3.7 artifacts got uploaded to S3, so we can merge this)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-16227) Console consumer fails with `IllegalStateException`

2024-02-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16227: -- Priority: Blocker (was: Critical) > Console consumer fails with `IllegalStateException` >

Re: [PR] KAFKA-16313: offline group protocol upgrade [kafka]

2024-02-28 Thread via GitHub
dongnuo123 commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1506768674 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1015,6 +1017,7 @@ private CoordinatorResult consumerGr

[PR] KAFKA-16313: offline group protocol upgrade [kafka]

2024-02-28 Thread via GitHub
dongnuo123 opened a new pull request, #15442: URL: https://github.com/apache/kafka/pull/15442 This patch enables the empty classic groups to upgrade to classic groups. For the common groups, the upgrade is triggered if the classic group is empty. For the existing simple

[jira] [Created] (KAFKA-16313) Offline group protocol upgrade

2024-02-28 Thread Dongnuo Lyu (Jira)
Dongnuo Lyu created KAFKA-16313: --- Summary: Offline group protocol upgrade Key: KAFKA-16313 URL: https://issues.apache.org/jira/browse/KAFKA-16313 Project: Kafka Issue Type: Sub-task

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1506743625 ## clients/src/main/java/org/apache/kafka/common/TopicPartitionInfo.java: ## @@ -79,9 +95,24 @@ public List isr() { return isr; } +/** + *

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-28 Thread via GitHub
federico-weisse-sportsbet commented on PR #15413: URL: https://github.com/apache/kafka/pull/15413#issuecomment-1970006347 Has been corrected for new versions on this [PR](https://github.com/apache/kafka/pull/13115). However, from version 3.1 to 3.4, the documentation must still be

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-02-28 Thread via GitHub
jolshan commented on PR #15413: URL: https://github.com/apache/kafka/pull/15413#issuecomment-1969983039 @federico-weisse-sportsbet Is there a reason we targeted 3.2? Is this not a problem in future releases? We don't usually change aspects this far back since we likely won't release

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change [kafka]

2024-02-28 Thread via GitHub
kirktrue commented on code in PR #15265: URL: https://github.com/apache/kafka/pull/15265#discussion_r1506629098 ## clients/src/main/java/org/apache/kafka/clients/admin/Admin.java: ## @@ -335,6 +335,21 @@ default DescribeTopicsResult describeTopics(TopicCollection topics) {

[PR] MINOR: detect uninitalized MetadataResponse and retry in KafkaAdminCl… [kafka]

2024-02-28 Thread via GitHub
cwildman opened a new pull request, #15441: URL: https://github.com/apache/kafka/pull/15441 …ient ## Description Brokers can respond to metadata requests with uninitialized metadata when they are starting up. The

Re: [PR] MINOR: Fix UpdatedImage and HighWatermarkUpdated events' logs [kafka]

2024-02-28 Thread via GitHub
jolshan commented on code in PR #15432: URL: https://github.com/apache/kafka/pull/15432#discussion_r1506416796 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1731,15 +1735,19 @@ public void onNewMetadataImage(

Re: [PR] MINOR: Fix UpdatedImage and HighWatermarkUpdated events' logs [kafka]

2024-02-28 Thread via GitHub
jolshan commented on code in PR #15432: URL: https://github.com/apache/kafka/pull/15432#discussion_r1506415431 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1695,8 +1683,8 @@ public void scheduleUnloadOperation(

[jira] [Updated] (KAFKA-16312) ConsumerRebalanceListener.onPartitionsAssigned() should be called after joining, even if empty

2024-02-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16312: -- Summary: ConsumerRebalanceListener.onPartitionsAssigned() should be called after joining, even if

[jira] [Commented] (KAFKA-16185) Fix client reconciliation of same assignment received in different epochs

2024-02-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821811#comment-17821811 ] Kirk True commented on KAFKA-16185: --- Please take a look at KAFKA-16312 to see if it is related. > Fix

[jira] [Commented] (KAFKA-16312) ConsumerRebalanceListener.onPartitionsAssigned should be called after joining, even if empty

2024-02-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17821810#comment-17821810 ] Kirk True commented on KAFKA-16312: --- Perhaps KAFKA-16185 will resolve this, but in case it turns out

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-02-28 Thread via GitHub
clolov commented on PR #15213: URL: https://github.com/apache/kafka/pull/15213#issuecomment-1969562705 Heya @showuon, I tried to reproduce the compilation failure of the unrelated test class locally, but have been unable to. I have rebased and kicked off a new build in case this was a

[jira] [Updated] (KAFKA-16312) ConsumerRebalanceListener.onPartitionsAssigned should be called after joining, even if empty

2024-02-28 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16312: -- Description: There is a difference between the {{LegacyKafkaConsumer}} and {{AsyncKafkaConsumer}}

[jira] [Created] (KAFKA-16312) ConsumerRebalanceListener.onPartitionsAssigned should be called after joining, even if empty

2024-02-28 Thread Kirk True (Jira)
Kirk True created KAFKA-16312: - Summary: ConsumerRebalanceListener.onPartitionsAssigned should be called after joining, even if empty Key: KAFKA-16312 URL: https://issues.apache.org/jira/browse/KAFKA-16312

[jira] [Resolved] (KAFKA-16116) AsyncKafkaConsumer: Add missing rebalance metrics

2024-02-28 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee resolved KAFKA-16116. Resolution: Fixed > AsyncKafkaConsumer: Add missing rebalance metrics >

Re: [PR] MINOR: Fix UpdatedImage and HighWatermarkUpdated events' logs [kafka]

2024-02-28 Thread via GitHub
jolshan commented on code in PR #15432: URL: https://github.com/apache/kafka/pull/15432#discussion_r1506329398 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1731,15 +1735,19 @@ public void onNewMetadataImage(

[jira] [Assigned] (KAFKA-16261) MembershipManagerImpl.updateSubscription fails if already empty subscription

2024-02-28 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Brutschy reassigned KAFKA-16261: -- Assignee: Lucas Brutschy (was: Lianet Magrans) >

Re: [PR] KAFKA-16261: updateSubscription fails if already empty subscription [kafka]

2024-02-28 Thread via GitHub
lucasbru commented on PR #15440: URL: https://github.com/apache/kafka/pull/15440#issuecomment-1969266254 @AndrewJSchofield could you have a look, since you created the ticket? I wasn't quite sure in which sequence of events to observed the problem. The unit test emulates clearing the

[PR] KAFKA-16261: updateSubscription fails if already empty subscription [kafka]

2024-02-28 Thread via GitHub
lucasbru opened a new pull request, #15440: URL: https://github.com/apache/kafka/pull/15440 The internal SubscriptionState object keeps track of whether the assignment is user-assigned, or auto-assigned. If there are no assigned partitions, the assignment resets to NONE. If you call

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-02-28 Thread Emanuele Sabellico (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emanuele Sabellico updated KAFKA-16310: --- Description: The last offset is reported instead. A test in librdkafka

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-02-28 Thread Emanuele Sabellico (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emanuele Sabellico updated KAFKA-16310: --- Description: The last offset is reported instead. A test in librdkafka

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-02-28 Thread Emanuele Sabellico (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emanuele Sabellico updated KAFKA-16310: --- Description: The last offset is reported instead. A test in librdkafka

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-02-28 Thread Emanuele Sabellico (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emanuele Sabellico updated KAFKA-16310: --- Description: The last offset is reported instead. A test in librdkafka

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-02-28 Thread Emanuele Sabellico (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emanuele Sabellico updated KAFKA-16310: --- Description: The last offset is reported instead. A test in librdkafka

[jira] [Resolved] (KAFKA-16311) [Debezium Informix Connector Unable to Commit Processed Log Position]

2024-02-28 Thread Hector Geraldino (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hector Geraldino resolved KAFKA-16311. -- Resolution: Invalid Please try reporting this to

[PR] MINOR: Remove the redundant space in the comments [kafka]

2024-02-28 Thread via GitHub
chiacyu opened a new pull request, #15439: URL: https://github.com/apache/kafka/pull/15439 Hi, all As I browsed the files I found the space between the words can be removed. Thanks! ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

Re: [PR] MINOR: Optimize EventAccumulator [kafka]

2024-02-28 Thread via GitHub
dajac merged PR #15430: URL: https://github.com/apache/kafka/pull/15430 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-15490) Invalid path provided to the log failure channel upon I/O error when writing broker metadata checkpoint

2024-02-28 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-15490: -- Description: There is a small bug/typo in the handling of I/O error when writing

[jira] [Created] (KAFKA-16311) [Debezium Informix Connector Unable to Commit Processed Log Position]

2024-02-28 Thread Maaheen Yasin (Jira)
Maaheen Yasin created KAFKA-16311: - Summary: [Debezium Informix Connector Unable to Commit Processed Log Position] Key: KAFKA-16311 URL: https://issues.apache.org/jira/browse/KAFKA-16311 Project:

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-02-28 Thread Emanuele Sabellico (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Emanuele Sabellico updated KAFKA-16310: --- Description: The last offset is reported instead. A test in librdkafka

[jira] [Created] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-02-28 Thread Emanuele Sabellico (Jira)
Emanuele Sabellico created KAFKA-16310: -- Summary: ListOffsets doesn't report the offset with maxTimestamp anymore Key: KAFKA-16310 URL: https://issues.apache.org/jira/browse/KAFKA-16310 Project:

[jira] [Assigned] (KAFKA-15490) Invalid path provided to the log failure channel upon I/O error when writing broker metadata checkpoint

2024-02-28 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez reassigned KAFKA-15490: - Assignee: (was: Alexandre Dupriez) > Invalid path provided to the log

[jira] [Updated] (KAFKA-15490) Invalid path provided to the log failure channel upon I/O error when writing broker metadata checkpoint

2024-02-28 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-15490: -- Description: There is a small bug/typo in the handling of I/O error when writing

[jira] [Updated] (KAFKA-15490) Invalid path provided to the log failure channel upon I/O error when writing broker metadata checkpoint

2024-02-28 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-15490: -- Description: There is a small bug/typo in the handling of I/O error when writing

[jira] [Updated] (KAFKA-15490) Invalid path provided to the log failure channel upon I/O error when writing broker metadata checkpoint

2024-02-28 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-15490: -- Description: There is a small bug/typo in the handling of I/O error when writing

[jira] [Updated] (KAFKA-15490) Invalid path provided to the log failure channel upon I/O error when writing broker metadata checkpoint

2024-02-28 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-15490: -- Description: There is a small bug/typo in the handling of I/O error when writing

[jira] [Updated] (KAFKA-15490) Invalid path provided to the log failure channel upon I/O error when writing broker metadata checkpoint

2024-02-28 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-15490: -- Description: There is a small bug/typo in the handling of I/O error when writing

[jira] [Updated] (KAFKA-15490) Invalid path provided to the log failure channel upon I/O error when writing broker metadata checkpoint

2024-02-28 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-15490: -- Description: There is a small bug/typo in the handling of I/O error when writing

Re: [PR] KAFKA-16154: Broker returns offset for LATEST_TIERED_TIMESTAMP [kafka]

2024-02-28 Thread via GitHub
clolov commented on PR #15213: URL: https://github.com/apache/kafka/pull/15213#issuecomment-1968689211 Apologies, I have had a lot of work recently, I will aim to provide an update by the end of the day today -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MINOR: Fix UpdatedImage and HighWatermarkUpdated events' logs [kafka]

2024-02-28 Thread via GitHub
dajac commented on code in PR #15432: URL: https://github.com/apache/kafka/pull/15432#discussion_r1505724297 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1731,15 +1735,19 @@ public void onNewMetadataImage(

Re: [PR] KAFKA-16191: Clean up of consumer client internal events [kafka]

2024-02-28 Thread via GitHub
cadonna commented on code in PR #15438: URL: https://github.com/apache/kafka/pull/15438#discussion_r1505580885 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java: ## @@ -32,36 +36,42 @@ public enum Type { private final Type

Re: [PR] KAFKA-16116: Rebalance Metrics for AsyncKafkaConsumer [kafka]

2024-02-28 Thread via GitHub
lucasbru merged PR #15339: URL: https://github.com/apache/kafka/pull/15339 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16305: Avoid optimisation in handshakeUnwrap [kafka]

2024-02-28 Thread via GitHub
rajinisivaram merged PR #15434: URL: https://github.com/apache/kafka/pull/15434 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16305: Avoid optimisation in handshakeUnwrap [kafka]

2024-02-28 Thread via GitHub
rajinisivaram commented on PR #15434: URL: https://github.com/apache/kafka/pull/15434#issuecomment-1968572233 Test failures not related, merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-15625: Do not flush global state store at each commit [kafka]

2024-02-28 Thread via GitHub
cadonna commented on code in PR #15361: URL: https://github.com/apache/kafka/pull/15361#discussion_r1505538908 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/GlobalStreamThread.java: ## @@ -259,19 +251,14 @@ void initialize() { for (final