lucasbru commented on PR #15437:
URL: https://github.com/apache/kafka/pull/15437#issuecomment-1972669980
@philipnee Could you please act as a second pair of eyes here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lucasbru commented on code in PR #15445:
URL: https://github.com/apache/kafka/pull/15445#discussion_r1508600306
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1277,8 +1280,7 @@ void prepareShutdown(final Timer timer, final
mjsax commented on code in PR #15445:
URL: https://github.com/apache/kafka/pull/15445#discussion_r1508477877
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1277,8 +1280,7 @@ void prepareShutdown(final Timer timer, final
[
https://issues.apache.org/jira/browse/KAFKA-15797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-15797:
---
Assignee: Matthias J. Sax
> Flaky test
mjsax commented on PR #15449:
URL: https://github.com/apache/kafka/pull/15449#issuecomment-1972488983
We have two runs of this test, one w/o error injection and one w/ error
injection.
The runs w/o error injections are more stable, and I did see a
"verifyCommitted" that did see fail
mjsax opened a new pull request, #15449:
URL: https://github.com/apache/kafka/pull/15449
Originally, we set commit-interval to MAX_VALUE for this test, to ensure we
only commit expliclity. However, we needed to decrease it later on when adding
the tx-timeout verification.
We did see
mjsax commented on code in PR #14448:
URL: https://github.com/apache/kafka/pull/14448#discussion_r1508427425
##
.github/workflows/codesee-arch-diagram.yml:
##
@@ -0,0 +1,23 @@
+# This workflow was added by CodeSee. Learn more at https://codesee.io/
Review Comment:
I don't
dongnuo123 commented on code in PR #15442:
URL: https://github.com/apache/kafka/pull/15442#discussion_r1508436563
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3500,6 +3501,42 @@ public void maybeDeleteGroup(String
mjsax commented on code in PR #14360:
URL: https://github.com/apache/kafka/pull/14360#discussion_r1508421651
##
docs/streams/developer-guide/config-streams.html:
##
@@ -300,8 +306,10 @@ num.standby.replicasnull
- default.windowed.key.serde.inner
+
mjsax commented on PR #15443:
URL: https://github.com/apache/kafka/pull/15443#issuecomment-1972305073
Couple of system test failed, but seems with env issue. Re-running:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/6081/
--
This is an automated message from the
jeffkbkim opened a new pull request, #15448:
URL: https://github.com/apache/kafka/pull/15448
This metric will help identify how fast all coordinator threads process
events.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ]
[
https://issues.apache.org/jira/browse/KAFKA-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16316:
Labels: needs-kip (was: )
> Make the restore behavior of GlobalKTables with custom
Jeff Kim created KAFKA-16317:
Summary: Add event rate in GroupCoordinatorRuntimeMetrics
Key: KAFKA-16317
URL: https://issues.apache.org/jira/browse/KAFKA-16317
Project: Kafka
Issue Type:
jeffkbkim opened a new pull request, #15447:
URL: https://github.com/apache/kafka/pull/15447
Move TimeRatio to `org.apache.kafka.common.metrics.stats` package
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test
Walker Carlson created KAFKA-16316:
--
Summary: Make the restore behavior of GlobalKTables with custom
processors configureable
Key: KAFKA-16316
URL: https://issues.apache.org/jira/browse/KAFKA-16316
artemlivshits commented on code in PR #15265:
URL: https://github.com/apache/kafka/pull/15265#discussion_r1506982605
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2276,6 +2337,141 @@ private Node leader(PartitionInfo partitionInfo) {
jeffkbkim commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1508185648
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1211,13 +1192,99 @@ private
CoordinatorResult consumerGr
jeffkbkim commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1508179840
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1211,13 +1193,71 @@ private
CoordinatorResult consumerGr
jeffkbkim commented on code in PR #15364:
URL: https://github.com/apache/kafka/pull/15364#discussion_r1508174554
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1211,13 +1192,99 @@ private
CoordinatorResult consumerGr
nizhikov commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-1971882476
Hello @mimaison @jolshan
It seems like I done with rewriting `ConfigCommand` code to java.
It can't be moved to `tools` right now, because of dependencies on
`KafkaConfig` and
lucasbru commented on code in PR #15445:
URL: https://github.com/apache/kafka/pull/15445#discussion_r1508102432
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -892,6 +893,24 @@ public void testWakeupCommitted() {
[
https://issues.apache.org/jira/browse/KAFKA-16190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822253#comment-17822253
]
Quoc Phong Dang commented on KAFKA-16190:
-
[~lianetm] I'm not sure how the extension of this
cadonna commented on code in PR #15445:
URL: https://github.com/apache/kafka/pull/15445#discussion_r1507973505
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -892,6 +893,24 @@ public void testWakeupCommitted() {
[
https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822250#comment-17822250
]
Bruno Cadonna commented on KAFKA-16290:
---
I changed the version to 4.0.0.
> Investigate
[
https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-16290:
--
Fix Version/s: 4.0.0
(was: 3.8.0)
> Investigate propagating
[
https://issues.apache.org/jira/browse/KAFKA-16315?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-16315:
-
Assignee: Kirk True
> Investigate propagating metadata updates via queues
>
cadonna commented on PR #15426:
URL: https://github.com/apache/kafka/pull/15426#issuecomment-1971644323
@kirktrue are you fine with merging this PR and coming back to this after
3.8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822246#comment-17822246
]
Kirk True commented on KAFKA-16290:
---
I just filed KAFKA-16315 which has a similar feel to this design
[
https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16290:
--
Labels: consumer-threading-refactor kip-848 kip-848-client-support (was:
kip-848)
> Investigate
Kirk True created KAFKA-16315:
-
Summary: Investigate propagating metadata updates via queues
Key: KAFKA-16315
URL: https://issues.apache.org/jira/browse/KAFKA-16315
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822245#comment-17822245
]
Kirk True commented on KAFKA-16290:
---
[~cadonna]—do we feel we have investigated this sufficiently? Are
[
https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-16290:
-
Assignee: Bruno Cadonna (was: Kirk True)
> Investigate propagating subscription state updates
jeffkbkim commented on code in PR #15446:
URL: https://github.com/apache/kafka/pull/15446#discussion_r1507948503
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1830,6 +1832,64 @@ public void onLoaded() {
});
jeffkbkim opened a new pull request, #15446:
URL: https://github.com/apache/kafka/pull/15446
In the new coordinator, we have lingering timers (heartbeats/revocation
timeouts/join groups/sync groups). For classic groups, we also have awaiting
join/sync futures that are never completed. This
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-1971535782
@mimaison any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lucasbru commented on code in PR #15445:
URL: https://github.com/apache/kafka/pull/15445#discussion_r1507865068
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java:
##
@@ -97,6 +101,10 @@ public void setFetchAction(final FetchBuffer
lucasbru commented on code in PR #15445:
URL: https://github.com/apache/kafka/pull/15445#discussion_r1507852098
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -892,6 +893,24 @@ public void testWakeupCommitted() {
cadonna commented on code in PR #15445:
URL: https://github.com/apache/kafka/pull/15445#discussion_r1507827920
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java:
##
@@ -97,6 +101,10 @@ public void setFetchAction(final FetchBuffer
dajac commented on code in PR #15442:
URL: https://github.com/apache/kafka/pull/15442#discussion_r1507837970
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -474,6 +474,8 @@ public CoordinatorResult
commitOffset(
dongnuo123 commented on code in PR #15442:
URL: https://github.com/apache/kafka/pull/15442#discussion_r1507826893
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3500,6 +3503,59 @@ public void maybeDeleteGroup(String
dongnuo123 commented on code in PR #15442:
URL: https://github.com/apache/kafka/pull/15442#discussion_r1507823457
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -474,6 +474,8 @@ public CoordinatorResult
commitOffset(
lucasbru commented on code in PR #15445:
URL: https://github.com/apache/kafka/pull/15445#discussion_r1507815350
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1277,8 +1280,7 @@ void prepareShutdown(final Timer timer, final
lucasbru commented on PR #15445:
URL: https://github.com/apache/kafka/pull/15445#issuecomment-1971423281
@cadonna Could you please take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lucasbru opened a new pull request, #15445:
URL: https://github.com/apache/kafka/pull/15445
When the consumer is closed, we perform a sychronous autocommit. We don't
want to be woken up here, because we are already executing a close operation
under a deadline. This is in line with the
[
https://issues.apache.org/jira/browse/KAFKA-3370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822181#comment-17822181
]
zhangzhisheng commented on KAFKA-3370:
--
AyoubOm commented on code in PR #15361:
URL: https://github.com/apache/kafka/pull/15361#discussion_r1507760037
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1664,18 +1664,17 @@ public void
dajac merged PR #15432:
URL: https://github.com/apache/kafka/pull/15432
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on code in PR #15440:
URL: https://github.com/apache/kafka/pull/15440#discussion_r1507649930
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -764,6 +766,44 @@ public void
lucasbru commented on code in PR #15440:
URL: https://github.com/apache/kafka/pull/15440#discussion_r1507649418
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -764,6 +766,44 @@ public void
cadonna commented on code in PR #15361:
URL: https://github.com/apache/kafka/pull/15361#discussion_r1507618245
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -1664,18 +1664,17 @@ public void
cadonna commented on code in PR #15440:
URL: https://github.com/apache/kafka/pull/15440#discussion_r1507610459
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##
@@ -764,6 +766,44 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
zhangzhisheng updated KAFKA-16314:
--
Attachment: image-2024-02-29-21-43-51-000.png
> Add the new ABORTABLE_ERROR
>
[
https://issues.apache.org/jira/browse/KAFKA-16314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822138#comment-17822138
]
zhangzhisheng commented on KAFKA-16314:
---
I think this ability is needed
> Add the new
[
https://issues.apache.org/jira/browse/KAFKA-12261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822135#comment-17822135
]
zhangzhisheng commented on KAFKA-12261:
---
It is like this, but in my understanding, this is normal.
chiacyu commented on PR #15444:
URL: https://github.com/apache/kafka/pull/15444#issuecomment-1971140347
Hi, @showuon
Please help to review this PR.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chiacyu opened a new pull request, #15444:
URL: https://github.com/apache/kafka/pull/15444
Hi, all
Change the function with a better way to deal with the NULL pointer
exception.
Thanks all!
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
gaurav-narula commented on code in PR #15289:
URL: https://github.com/apache/kafka/pull/15289#discussion_r1507510343
##
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##
@@ -137,7 +137,18 @@ object TestUtils extends Logging {
val parentFile = new File(parent)
AyoubOm commented on PR #15361:
URL: https://github.com/apache/kafka/pull/15361#issuecomment-1971038693
> @AyoubOm Thanks for the updates!
>
> Here my replies.
Thanks @cadonna, I made updates accordingly
--
This is an automated message from the Apache Git Service.
To respond
nizhikov commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1971031598
Hello, @rreddy-22 @dajac
Can you, please, take a look at these changes?
It PR moves test of `ConsoleGroupCommand` from Authorizer test and Sasl test
to `tools`.
It very
nizhikov commented on PR #15363:
URL: https://github.com/apache/kafka/pull/15363#issuecomment-1971028532
Hello, @rreddy-22 @dajac
Can you, please, take a look at these changes?
It PR moves `DescribeConsumerGroupTest` and `ResetConsumerGroupOffsetTest`
as part of moving
lucasbru commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1507409271
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -524,10 +524,10 @@ public void testHeartbeatState() {
lucasbru commented on code in PR #15401:
URL: https://github.com/apache/kafka/pull/15401#discussion_r1507409979
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -545,6 +545,15 @@ public ConsumerGroupHeartbeatRequestData
cadonna commented on PR #15440:
URL: https://github.com/apache/kafka/pull/15440#issuecomment-1970897046
@lucasbru Unit tests are failing in `MembershipManagerImplTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
lucasbru commented on code in PR #15330:
URL: https://github.com/apache/kafka/pull/15330#discussion_r1507381845
##
tests/kafkatest/tests/verifiable_consumer_test.py:
##
@@ -72,16 +86,59 @@ def await_produced_messages(self, producer,
min_messages=1000, timeout_sec=10):
cadonna merged PR #15438:
URL: https://github.com/apache/kafka/pull/15438
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cadonna commented on PR #15438:
URL: https://github.com/apache/kafka/pull/15438#issuecomment-1970829159
The test failures are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
cadonna commented on code in PR #15438:
URL: https://github.com/apache/kafka/pull/15438#discussion_r1507345366
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java:
##
@@ -32,36 +36,42 @@ public enum Type {
private final Type
cadonna commented on code in PR #15438:
URL: https://github.com/apache/kafka/pull/15438#discussion_r1507320914
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java:
##
@@ -32,36 +36,42 @@ public enum Type {
private final Type
cadonna commented on code in PR #15438:
URL: https://github.com/apache/kafka/pull/15438#discussion_r1507320914
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java:
##
@@ -32,36 +36,42 @@ public enum Type {
private final Type
cadonna commented on code in PR #15438:
URL: https://github.com/apache/kafka/pull/15438#discussion_r1507316466
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java:
##
@@ -32,36 +36,42 @@ public enum Type {
private final Type
cadonna commented on code in PR #15438:
URL: https://github.com/apache/kafka/pull/15438#discussion_r1507315536
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEvent.java:
##
@@ -32,36 +36,42 @@ public enum Type {
private final Type
dajac commented on code in PR #15442:
URL: https://github.com/apache/kafka/pull/15442#discussion_r1507296782
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -3500,6 +3503,59 @@ public void maybeDeleteGroup(String groupId,
dajac commented on code in PR #15442:
URL: https://github.com/apache/kafka/pull/15442#discussion_r1507302228
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java:
##
@@ -474,6 +474,8 @@ public CoordinatorResult
commitOffset(
dajac commented on code in PR #15432:
URL: https://github.com/apache/kafka/pull/15432#discussion_r1507247226
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1695,8 +1683,8 @@ public void scheduleUnloadOperation(
dajac commented on code in PR #15432:
URL: https://github.com/apache/kafka/pull/15432#discussion_r1507246125
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java:
##
@@ -1731,15 +1735,19 @@ public void onNewMetadataImage(
[
https://issues.apache.org/jira/browse/KAFKA-15462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-15462.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> Add group type filter to the admin client
>
dajac merged PR #15150:
URL: https://github.com/apache/kafka/pull/15150
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
77 matches
Mail list logo
