showuon commented on PR #15444:
URL: https://github.com/apache/kafka/pull/15444#issuecomment-1980240072
Ah, you're right! @iit2009060 , I missed that! Will you open another PR to
fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1513877668
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##
@@ -84,6 +85,9 @@ private enum SubscriptionType {
/* the
Phuc-Hong-Tran commented on code in PR #15188:
URL: https://github.com/apache/kafka/pull/15188#discussion_r1513877668
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java:
##
@@ -84,6 +85,9 @@ private enum SubscriptionType {
/* the
dajac commented on code in PR #15419:
URL: https://github.com/apache/kafka/pull/15419#discussion_r1513841644
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -546,8 +546,9 @@ public ConsumerGroupHeartbeatRequestData
iit2009060 commented on PR #15444:
URL: https://github.com/apache/kafka/pull/15444#issuecomment-1980040479
@showuon @chiacyu This has not fix the overall problem. It just moves the
NullPointerException in the RemoteLogManager instead of ProducerStateManager.
github-actions[bot] commented on PR #14556:
URL: https://github.com/apache/kafka/pull/14556#issuecomment-1980016226
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
bachmanity1 commented on PR #15475:
URL: https://github.com/apache/kafka/pull/15475#issuecomment-1980014397
Hi @kirktrue, thanks for the review! I've created a new KIP here
KevinZTW opened a new pull request, #15480:
URL: https://github.com/apache/kafka/pull/15480
upgrade Zookeeper from to 3.8.3 -> 3.8.4
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
-
[
https://issues.apache.org/jira/browse/KAFKA-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823831#comment-17823831
]
Chia-Ping Tsai commented on KAFKA-16346:
The count is increased even though the value is zero,
[
https://issues.apache.org/jira/browse/KAFKA-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-16346:
-
Assignee: PoAn Yang
> Fix flay MetricsTest.testMetrics
>
>
>
Chia-Ping Tsai created KAFKA-16346:
--
Summary: Fix flay MetricsTest.testMetrics
Key: KAFKA-16346
URL: https://issues.apache.org/jira/browse/KAFKA-16346
Project: Kafka
Issue Type: Bug
chia7712 commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1513702636
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -431,6 +432,7 @@ public interface LiteralSupplier {
* @param args
KevinZTW commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1513701081
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -431,6 +432,7 @@ public interface LiteralSupplier {
* @param args
kirktrue commented on code in PR #15475:
URL: https://github.com/apache/kafka/pull/15475#discussion_r1513681366
##
clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java:
##
@@ -192,6 +192,12 @@ public class SaslConfigs {
+ " be inspected for the
mjsax commented on PR #15189:
URL: https://github.com/apache/kafka/pull/15189#issuecomment-1979900538
@florin-akermann -- I finally merged
https://github.com/apache/kafka/pull/14426 -- can you rebase this PR and fixup
tests so we can move forward with this PR?
--
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-15417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-15417.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> JoinWindow does not seem to work
mjsax commented on PR #14426:
URL: https://github.com/apache/kafka/pull/14426#issuecomment-1979898854
Thanks for the fix! Merged to `trunk`.
Really appreciate that you did push this through. Was more complicated than
expected and took way to long to get finished.
--
This is an
mjsax merged PR #14426:
URL: https://github.com/apache/kafka/pull/14426
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15444:
URL: https://github.com/apache/kafka/pull/15444#issuecomment-1979894426
Thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
[
https://issues.apache.org/jira/browse/KAFKA-16209?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16209.
---
Fix Version/s: 3.8.0
3.7.1
Resolution: Fixed
> fetchSnapshot might return
showuon merged PR #15444:
URL: https://github.com/apache/kafka/pull/15444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823817#comment-17823817
]
Greg Harris commented on KAFKA-16344:
-
Hi [~janardhanag], thanks for the ticket.
At the current
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1513659746
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +55,30 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513643851
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java:
##
@@ -47,8 +49,32 @@ public DescribeTopicsOptions
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513646133
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2276,6 +2415,11 @@ private Node leader(PartitionInfo partitionInfo) {
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513643851
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java:
##
@@ -47,8 +49,32 @@ public DescribeTopicsOptions
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513641333
##
tools/src/main/java/org/apache/kafka/tools/TopicCommand.java:
##
@@ -799,6 +823,11 @@ public TopicCommandOptions(String[] args) {
"if set
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513641009
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -1399,6 +1404,184 @@ public void testInvalidTopicNames() throws
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513640718
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2190,6 +2201,117 @@ void handleFailure(Throwable throwable) {
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513640577
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java:
##
@@ -47,8 +49,32 @@ public DescribeTopicsOptions
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513640434
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java:
##
@@ -47,8 +49,32 @@ public DescribeTopicsOptions
appchemist commented on PR #15245:
URL: https://github.com/apache/kafka/pull/15245#issuecomment-1979765706
@chia7712 sorry, I checked it late.
I run the failed tests on my local too
```./gradlew cleanTest connect:mirror:test --tests
MirrorConnectorsIntegrationExactlyOnceTest
chia7712 commented on code in PR #15462:
URL: https://github.com/apache/kafka/pull/15462#discussion_r1513587296
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -498,29 +497,17 @@ public CompletableFuture
listGroups(
kirktrue commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1513571996
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture newFuture(
[
https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15402:
--
Labels: consumer-threading-refactor (was: )
> Performance regression on close consumer after
[
https://issues.apache.org/jira/browse/KAFKA-15402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-15402:
--
Component/s: clients
> Performance regression on close consumer after upgrading to 3.5.0
>
kirktrue commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1513515432
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java:
##
@@ -29,10 +30,19 @@ public abstract class CommitEvent extends
chia7712 commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1979651000
@nizhikov I feel this PR is ready, and so please check (or list) the failed
tests. If they are unconnected to this PR, I will merge it.
--
This is an automated message from the Apache
chia7712 merged PR #15245:
URL: https://github.com/apache/kafka/pull/15245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15245:
URL: https://github.com/apache/kafka/pull/15245#issuecomment-1979648508
run the failed tests on my local:
```sh
./gradlew cleanTest core:test --tests FetchRequestTestDowngrade --tests
ProduceRequestTest --tests DynamicBrokerReconfigurationTest
kirktrue commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513390603
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java:
##
@@ -47,8 +49,32 @@ public DescribeTopicsOptions
cmccabe merged PR #15435:
URL: https://github.com/apache/kafka/pull/15435
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823757#comment-17823757
]
AlexeyASF commented on KAFKA-16319:
---
Great news, thank you very much for quick reaction! (y)
> Wrong
[
https://issues.apache.org/jira/browse/KAFKA-16319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823755#comment-17823755
]
Andrew Schofield commented on KAFKA-16319:
--
No worries. My initial assessment was incorrect.
AndrewJSchofield opened a new pull request, #15479:
URL: https://github.com/apache/kafka/pull/15479
PR https://github.com/apache/kafka/pull/13760 introduced a problem with
KafkaAdmin.deleteRecords. If the request acted on a set of topic-partitions
which spanned multiple leader brokers, the
jsancio opened a new pull request, #15478:
URL: https://github.com/apache/kafka/pull/15478
There are three reasons why KRaft would delete a snapshot. One, it is older
than the retention time. Two, the total number of bytes between the log and the
snapshot excess the configuration. Three,
dajac commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513322953
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java:
##
@@ -47,8 +49,32 @@ public DescribeTopicsOptions
dajac commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513322953
##
clients/src/main/java/org/apache/kafka/clients/admin/DescribeTopicsOptions.java:
##
@@ -47,8 +49,32 @@ public DescribeTopicsOptions
AndrewJSchofield commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513310569
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2190,6 +2201,117 @@ void handleFailure(Throwable throwable) {
clolov commented on PR #15261:
URL: https://github.com/apache/kafka/pull/15261#issuecomment-1979391796
Thanks for the review @cadonna! I will provide an updated version tomorrow
morning!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
cmccabe commented on code in PR #15435:
URL: https://github.com/apache/kafka/pull/15435#discussion_r1513283747
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -792,6 +792,43 @@ class KRaftClusterTest {
}
}
+ /**
+ * Test that setting
divijvaidya commented on code in PR #15472:
URL: https://github.com/apache/kafka/pull/15472#discussion_r1513268220
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -707,6 +708,8 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
CalvinConfluent opened a new pull request, #15477:
URL: https://github.com/apache/kafka/pull/15477
Draft.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
[
https://issues.apache.org/jira/browse/KAFKA-16319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823723#comment-17823723
]
AlexeyASF commented on KAFKA-16319:
---
??How do you get it to do that? Do you have a small test program
[
https://issues.apache.org/jira/browse/KAFKA-16319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823706#comment-17823706
]
Andrew Schofield commented on KAFKA-16319:
--
I have reproduced it. Certainly fails like this on
johnnychhsu commented on PR #15464:
URL: https://github.com/apache/kafka/pull/15464#issuecomment-1979168636
the Jenkins pipeline (jdk8, scala 2.12) failed due to `Unable to connect to
the child process`. I tried the same command in locall, run `./gradlew
-PscalaVersion=2.12 clean check -x
[
https://issues.apache.org/jira/browse/KAFKA-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823698#comment-17823698
]
Aratz commented on KAFKA-14048:
---
Where can I find the timeline for this work? Is there any?
Thank you.
dajac commented on PR #15462:
URL: https://github.com/apache/kafka/pull/15462#issuecomment-1979123455
@chia7712 Would you be interested in reviewing this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-16099?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823686#comment-17823686
]
Aratz commented on KAFKA-16099:
---
Where can we find the corresponding PR?
> Handle timeouts for
[
https://issues.apache.org/jira/browse/KAFKA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823675#comment-17823675
]
PoAn Yang commented on KAFKA-16222:
---
I can reproduce the error. I will look into code tomorrow.
ijuma commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1513013595
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -52,20 +55,30 @@ public class GetOffsetShellTest {
private final int topicCount = 4;
pprovenzano commented on code in PR #15409:
URL: https://github.com/apache/kafka/pull/15409#discussion_r1513010665
##
tests/kafkatest/tests/core/log_dir_failure_test.py:
##
@@ -84,20 +84,25 @@ def __init__(self, test_context):
self.num_consumers = 1
def
VictorvandenHoven commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1512985080
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java:
##
@@ -884,11 +886,13 @@ public void
VictorvandenHoven commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1512983679
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamOuterJoinTest.java:
##
@@ -438,13 +438,13 @@ public void testOrdering() {
VictorvandenHoven commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1512982523
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java:
##
@@ -436,6 +436,239 @@ public void
VictorvandenHoven commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1512981646
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java:
##
@@ -436,6 +436,239 @@ public void
VictorvandenHoven commented on code in PR #14426:
URL: https://github.com/apache/kafka/pull/14426#discussion_r1512980857
##
streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java:
##
@@ -436,6 +436,239 @@ public void
KevinZTW commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1512973940
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -30,6 +30,7 @@
import org.apache.kafka.common.utils.AppInfoParser;
chia7712 merged PR #15467:
URL: https://github.com/apache/kafka/pull/15467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823653#comment-17823653
]
Andrew Schofield commented on KAFKA-16319:
--
[~alexeyasf] How do you get it to do that? Do you
dongnuo123 commented on code in PR #15467:
URL: https://github.com/apache/kafka/pull/15467#discussion_r1512942687
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTestContext.java:
##
@@ -901,7 +901,7 @@ public RebalanceResult
chia7712 commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1512938465
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -431,6 +432,7 @@ public interface LiteralSupplier {
* @param args
[
https://issues.apache.org/jira/browse/KAFKA-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823645#comment-17823645
]
Aratz commented on KAFKA-14679:
---
Okay found it, I think it is this one:
[
https://issues.apache.org/jira/browse/KAFKA-14679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823644#comment-17823644
]
Aratz commented on KAFKA-14679:
---
Hello,
Is there any Github PR related to this *resolved* work?
> Add
chia7712 commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1512899702
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -30,6 +30,7 @@
import org.apache.kafka.common.utils.AppInfoParser;
KevinZTW commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1512897988
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -431,6 +432,7 @@ public interface LiteralSupplier {
* @param args
KevinZTW commented on PR #15473:
URL: https://github.com/apache/kafka/pull/15473#issuecomment-1978869931
> Could you run the website with the change and paste the screenshot? Thanks.
Sure!
## Previous Version
johnnychhsu commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-1978864287
thanks for the quick review @chia7712 , sure let me address that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on PR #15476:
URL: https://github.com/apache/kafka/pull/15476#issuecomment-1978858961
The fix is perfect. Please rewrite the test according to #15474. Putting all
test cases together is more readable.
--
This is an automated message from the Apache Git Service.
To
johnnychhsu opened a new pull request, #15476:
URL: https://github.com/apache/kafka/pull/15476
## Context
Previously in the LogValidator, the `offsetOfMaxTimestamp` depends on two
parameter check
1. timestampType
2. batch.toMagic
If the `timestampType` is `LOG_APPEND_TIME`, and
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1512790426
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java:
##
@@ -263,13 +262,8 @@ public RecordsInfo info() {
} else if (maxTimestamp
soarez commented on code in PR #15335:
URL: https://github.com/apache/kafka/pull/15335#discussion_r1512748010
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##
@@ -289,13 +289,10 @@ class BrokerMetadataPublisher(
try {
// Start log
showuon commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1512747215
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -431,6 +432,7 @@ public interface LiteralSupplier {
* @param args
chia7712 commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1512687959
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -431,6 +432,7 @@ public interface LiteralSupplier {
* @param args
KevinZTW commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1512669605
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -431,6 +432,7 @@ public interface LiteralSupplier {
* @param args
KevinZTW commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1512665815
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -431,6 +432,7 @@ public interface LiteralSupplier {
* @param args
bachmanity1 commented on PR #15475:
URL: https://github.com/apache/kafka/pull/15475#issuecomment-1978544182
@kirktrue @mimaison can you have a look, please? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
bachmanity1 opened a new pull request, #15475:
URL: https://github.com/apache/kafka/pull/15475
When a client communicates with OIDC provider to retrieve an access token
RFC-6749 says that clientID and clientSecret must be urlencoded in the
authorization header. (see
chia7712 commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1512657775
##
clients/src/main/java/org/apache/kafka/common/record/MemoryRecordsBuilder.java:
##
@@ -263,13 +262,8 @@ public RecordsInfo info() {
} else if
Nelson B. created KAFKA-16345:
-
Summary: Optionally allow urlencoding clientId and clientSecret in
authorization header
Key: KAFKA-16345
URL: https://issues.apache.org/jira/browse/KAFKA-16345
Project:
[
https://issues.apache.org/jira/browse/KAFKA-16345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nelson B. reassigned KAFKA-16345:
-
Assignee: Nelson B.
> Optionally allow urlencoding clientId and clientSecret in authorization
[
https://issues.apache.org/jira/browse/KAFKA-16341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johnny Hsu reassigned KAFKA-16341:
--
Assignee: Johnny Hsu
> Fix un-compressed records
> -
>
>
chia7712 commented on code in PR #15473:
URL: https://github.com/apache/kafka/pull/15473#discussion_r1512617796
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectMetrics.java:
##
@@ -431,6 +432,7 @@ public interface LiteralSupplier {
* @param args
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1512610273
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software
nizhikov commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1512609597
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1512607158
##
tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java:
##
@@ -333,7 +382,7 @@ private void assertExitCodeIsOne(String... args) {
}
private
showuon commented on PR #15474:
URL: https://github.com/apache/kafka/pull/15474#issuecomment-1978460395
@chia7712 @ijuma @hachikuji , please take a look. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
showuon commented on code in PR #15474:
URL: https://github.com/apache/kafka/pull/15474#discussion_r1512604852
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java:
##
@@ -379,8 +381,11 @@ public ValidationResult
chia7712 commented on code in PR #15365:
URL: https://github.com/apache/kafka/pull/15365#discussion_r1512597183
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/SaslClientsWithInvalidCredentialsTest.java:
##
@@ -0,0 +1,191 @@
+/*
+ * Licensed to the Apache Software
showuon opened a new pull request, #15474:
URL: https://github.com/apache/kafka/pull/15474
Fix `getOffsetByMaxTimestamp` for compressed records.
This PR adds:
1. For inPlaceAssignment case, compute the correct offset for maxTimestamp
when traversing the batch records, and set to
1 - 100 of 118 matches
Mail list logo
