sjhajharia opened a new pull request, #15486:
URL: https://github.com/apache/kafka/pull/15486
As a part of KIP-890, we are introducing a new class of Exceptions which
when encountered shall lead to Aborting the ongoing Transaction. The following
PR introduces the same with client side
showuon commented on PR #15481:
URL: https://github.com/apache/kafka/pull/15481#issuecomment-1982498719
Also, please add some test cases for client and IP cases with sanitized
strings. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
showuon commented on code in PR #15481:
URL: https://github.com/apache/kafka/pull/15481#discussion_r1515554131
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -271,6 +273,9 @@ class ZkMigrationIntegrationTest {
assertEquals(10,
kirktrue commented on PR #15455:
URL: https://github.com/apache/kafka/pull/15455#issuecomment-1982356780
@cadonna—failing tests seem unrelated. Is this OK to merge? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nizhikov commented on PR #15465:
URL: https://github.com/apache/kafka/pull/15465#issuecomment-1982319460
@chia7712 PR merged with the latest trunk and ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
github-actions[bot] commented on PR #14951:
URL: https://github.com/apache/kafka/pull/14951#issuecomment-1982287149
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
[
https://issues.apache.org/jira/browse/KAFKA-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16350:
Summary: StateUpdater does not init transaction after canceling task close
action (was:
[
https://issues.apache.org/jira/browse/KAFKA-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16350:
Attachment:
Matthias J. Sax created KAFKA-16350:
---
Summary: StateUpdated does not init transaction after canceling
task close action
Key: KAFKA-16350
URL: https://issues.apache.org/jira/browse/KAFKA-16350
wcarlson5 commented on code in PR #12742:
URL: https://github.com/apache/kafka/pull/12742#discussion_r1515301279
##
streams/src/test/java/org/apache/kafka/streams/processor/ReadOnlyStoreTest.java:
##
@@ -0,0 +1,132 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
chia7712 closed pull request #15453: MINOR: Add version 3.7 to the Kafka
Streams system tests
URL: https://github.com/apache/kafka/pull/15453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on PR #15453:
URL: https://github.com/apache/kafka/pull/15453#issuecomment-1982060230
close this PR as #15443 is merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on PR #15465:
URL: https://github.com/apache/kafka/pull/15465#issuecomment-1982055889
@nizhikov I'm ready to review this PR, so please rebase it. thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on PR #15363:
URL: https://github.com/apache/kafka/pull/15363#issuecomment-1982054671
@nizhikov thanks for this nice patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 merged PR #15363:
URL: https://github.com/apache/kafka/pull/15363
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15363:
URL: https://github.com/apache/kafka/pull/15363#issuecomment-1982051350
the failed tests pass on my machine.
```sh
./gradlew cleanTest core:test --tests ReplicaManagerTest --tests
LogDirFailureTest
```
will merge it
--
This is an automated
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1515290353
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2178,138 @@ void handleFailure(Throwable throwable) {
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1515289272
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2178,138 @@ void handleFailure(Throwable throwable) {
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1515288246
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2177,122 @@ void handleFailure(Throwable throwable) {
mjsax commented on code in PR #15485:
URL: https://github.com/apache/kafka/pull/15485#discussion_r1515287246
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java:
##
@@ -628,7 +628,7 @@ private boolean assignTasksToClients(final
mjsax opened a new pull request, #15485:
URL: https://github.com/apache/kafka/pull/15485
This PR bumps some timeouts due to slow Jenkins builds.
+++
I looked into logs, and it seems that some assignment take up to 90 seconds
when they timeout. Also talked to @ableegoldman about
[
https://issues.apache.org/jira/browse/KAFKA-15964?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-15964:
---
Assignee: Matthias J. Sax
> Flaky test:
[
https://issues.apache.org/jira/browse/KAFKA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824207#comment-17824207
]
Ismael Juma commented on KAFKA-16349:
-
Good catch.
> ShutdownableThread fails build by calling Exit
gharris1727 opened a new pull request, #15484:
URL: https://github.com/apache/kafka/pull/15484
This test causes the build to fail with the current ShutdownableThread
implementation that calls Exit.
This is because Exit is inherently thread-unsafe, and ShutdownableThread may
live longer
Greg Harris created KAFKA-16349:
---
Summary: ShutdownableThread fails build by calling Exit with race
condition
Key: KAFKA-16349
URL: https://issues.apache.org/jira/browse/KAFKA-16349
Project: Kafka
caioguedes commented on PR #15482:
URL: https://github.com/apache/kafka/pull/15482#issuecomment-1981952353
Thanks @mjsax, I will fix the problems in the CI and let it open.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
artemlivshits commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1513820234
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2184,9 +2177,122 @@ void handleFailure(Throwable throwable) {
mjsax commented on PR #12742:
URL: https://github.com/apache/kafka/pull/12742#issuecomment-1981929378
@calmera -- As discussed in person (a long time back...) I took the liberty
to update this PR. Hope we can get this merged soon.
--
This is an automated message from the Apache Git
mjsax commented on code in PR #15189:
URL: https://github.com/apache/kafka/pull/15189#discussion_r1515212230
##
streams/src/main/java/org/apache/kafka/streams/kstream/internals/StreamStreamJoinUtil.java:
##
@@ -25,36 +25,46 @@
public final class StreamStreamJoinUtil {
-
florin-akermann commented on PR #15189:
URL: https://github.com/apache/kafka/pull/15189#issuecomment-1981795443
@mjsax thanks, it is rebased.
The tests didn't need any adjustments due to the idea quoted below.
> I realized that if we only want to assert that late records get
mjsax merged PR #15443:
URL: https://github.com/apache/kafka/pull/15443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1515057898
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -1399,6 +1404,184 @@ public void testInvalidTopicNames() throws
CalvinConfluent commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1515057124
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2276,6 +2415,11 @@ private Node leader(PartitionInfo partitionInfo) {
[
https://issues.apache.org/jira/browse/KAFKA-16343?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16343:
Component/s: unit tests
> Improve tests of streams foreignkeyjoin package
>
mjsax commented on PR #15482:
URL: https://github.com/apache/kafka/pull/15482#issuecomment-1981581044
Next release is 3.8, so we cannot merge this yet. We can of course leave
this PR open for the time being, and I can review it when we start 4.0 release
(which is planned after 3.8).
--
[
https://issues.apache.org/jira/browse/KAFKA-16335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824137#comment-17824137
]
Matthias J. Sax commented on KAFKA-16335:
-
Thanks for your interest to work on this ticket. Note
wernerdv commented on code in PR #15457:
URL: https://github.com/apache/kafka/pull/15457#discussion_r1514997085
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java:
##
@@ -322,6 +324,20 @@ private void invalidOffset(String offset) {
gharris1727 merged PR #15316:
URL: https://github.com/apache/kafka/pull/15316
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gharris1727 commented on PR #15316:
URL: https://github.com/apache/kafka/pull/15316#issuecomment-1981533086
Test failures appear unrelated, and the runtime tests pass locally for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mjsax merged PR #15449:
URL: https://github.com/apache/kafka/pull/15449
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Harris resolved KAFKA-16288.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> Values.convertToDecimal throws
mimaison commented on code in PR #15457:
URL: https://github.com/apache/kafka/pull/15457#discussion_r1514959532
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumerOptions.java:
##
@@ -322,6 +324,20 @@ private void invalidOffset(String offset) {
wernerdv commented on code in PR #15457:
URL: https://github.com/apache/kafka/pull/15457#discussion_r1514949575
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) {
}
chia7712 commented on code in PR #15462:
URL: https://github.com/apache/kafka/pull/15462#discussion_r1514944319
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -498,29 +497,17 @@ public CompletableFuture
listGroups(
danielgospodinow commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1514907422
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture
dajac commented on code in PR #15462:
URL: https://github.com/apache/kafka/pull/15462#discussion_r1514893077
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java:
##
@@ -498,29 +497,17 @@ public CompletableFuture
listGroups(
AndrewJSchofield commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1514890396
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture
clolov commented on PR #15261:
URL: https://github.com/apache/kafka/pull/15261#issuecomment-1981388046
Heya @cadonna, apologies for the delay! Hopefully the latest version
addresses your comments , but if not let me know and I will pick it up tomorrow
--
This is an automated message
danielgospodinow commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1514870475
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture
nizhikov commented on PR #15363:
URL: https://github.com/apache/kafka/pull/15363#issuecomment-1981384111
@nizhikov Thanks for the review.
All your comments fixed.
Please, take a look one more time.
--
This is an automated message from the Apache Git Service.
To respond to the
mimaison commented on code in PR #15457:
URL: https://github.com/apache/kafka/pull/15457#discussion_r1514821883
##
tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java:
##
@@ -148,43 +143,26 @@ static boolean checkErr(PrintStream output) {
}
nizhikov commented on code in PR #15363:
URL: https://github.com/apache/kafka/pull/15363#discussion_r1514833400
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -0,0 +1,840 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on code in PR #15363:
URL: https://github.com/apache/kafka/pull/15363#discussion_r1514832937
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -0,0 +1,840 @@
+/*
+ * Licensed to the Apache Software Foundation
chia7712 commented on code in PR #15483:
URL: https://github.com/apache/kafka/pull/15483#discussion_r1514824043
##
clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java:
##
@@ -20,6 +20,37 @@
import org.apache.kafka.common.MetricName;
import
iit2009060 commented on PR #15444:
URL: https://github.com/apache/kafka/pull/15444#issuecomment-1981236742
Yes @showuon definitely.
Can you help me with the reference or the process to start working on it. Do
I need to create a different JIRA for it ?
--
This is an automated message
johnnychhsu opened a new pull request, #15483:
URL: https://github.com/apache/kafka/pull/15483
## Context
There was no javadoc for `KafkaMetric`
## Solution
Add the javadoc for this class
## Test
Add screenshots
### Committer Checklist (excluded from commit
chia7712 commented on code in PR #15363:
URL: https://github.com/apache/kafka/pull/15363#discussion_r1514645806
##
tools/src/test/java/org/apache/kafka/tools/ToolsTestUtils.java:
##
@@ -210,6 +212,29 @@ public static File tempPropertiesFile(Map
properties) throws IOE
[
https://issues.apache.org/jira/browse/KAFKA-16335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Caio César reassigned KAFKA-16335:
--
Assignee: Caio César
> Remove Deprecated method on StreamPartitioner
>
[
https://issues.apache.org/jira/browse/KAFKA-15949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-15949:
-
Assignee: PoAn Yang
> Improve the KRaft metadata version related messages
>
caioguedes opened a new pull request, #15482:
URL: https://github.com/apache/kafka/pull/15482
Remove deprecated method StreamPartitioner#partition.
All tests were updated if the new signature of
`StreamPartitioner#partitions`.
--
This is an automated message from the
divijvaidya commented on code in PR #15472:
URL: https://github.com/apache/kafka/pull/15472#discussion_r1514414426
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -202,6 +203,9 @@ public List read() {
private final UnifiedLog mockLog =
nizhikov commented on code in PR #15363:
URL: https://github.com/apache/kafka/pull/15363#discussion_r1514391934
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -0,0 +1,855 @@
+/*
+ * Licensed to the Apache Software Foundation
nizhikov commented on code in PR #15363:
URL: https://github.com/apache/kafka/pull/15363#discussion_r1514388497
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -0,0 +1,855 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823930#comment-17823930
]
Janardhana Gopalachar edited comment on KAFKA-16344 at 3/6/24 12:19 PM:
chia7712 commented on code in PR #15363:
URL: https://github.com/apache/kafka/pull/15363#discussion_r1514369281
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -0,0 +1,855 @@
+/*
+ * Licensed to the Apache Software Foundation
chia7712 commented on code in PR #15363:
URL: https://github.com/apache/kafka/pull/15363#discussion_r1514366938
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##
@@ -0,0 +1,855 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-16346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang updated KAFKA-16346:
--
Summary: Fix flaky MetricsTest.testMetrics (was: Fix flay
MetricsTest.testMetrics)
> Fix flaky
[
https://issues.apache.org/jira/browse/KAFKA-16348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johnny Hsu reassigned KAFKA-16348:
--
Assignee: Johnny Hsu
> Fix flaky
>
Chia-Ping Tsai created KAFKA-16348:
--
Summary: Fix flaky
TopicCommandIntegrationTest.testDescribeUnderReplicatedPartitionsWhenReassignmentIsInProgress
Key: KAFKA-16348
URL:
[
https://issues.apache.org/jira/browse/KAFKA-16322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16322.
Fix Version/s: 3.8.0
Resolution: Fixed
> Fix CVE-2023-50572 by updating jline from
chia7712 merged PR #15464:
URL: https://github.com/apache/kafka/pull/15464
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15464:
URL: https://github.com/apache/kafka/pull/15464#issuecomment-1980679646
all failed tests pass on my local
```sh
./gradlew cleanTest core:test --tests ReplicaManagerTest --tests
AssignmentsManagerTest connect:runtime:test --tests
showuon commented on PR #15444:
URL: https://github.com/apache/kafka/pull/15444#issuecomment-1980653675
@iit2009060 , good question. If we want to make `producerSnapshot` as
optional, we might need a simple KIP to change to RSM API. Are you able to do
that?
--
This is an automated
hni61223 commented on code in PR #15478:
URL: https://github.com/apache/kafka/pull/15478#discussion_r1514278368
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -677,4 +675,38 @@ object KafkaMetadataLog extends Logging {
Snapshots.deleteIfExists(logDir,
hni61223 commented on code in PR #15478:
URL: https://github.com/apache/kafka/pull/15478#discussion_r1514278368
##
core/src/main/scala/kafka/raft/KafkaMetadataLog.scala:
##
@@ -677,4 +675,38 @@ object KafkaMetadataLog extends Logging {
Snapshots.deleteIfExists(logDir,
Nickstery commented on code in PR #15472:
URL: https://github.com/apache/kafka/pull/15472#discussion_r1514277995
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -707,6 +708,8 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
FrankYang0529 opened a new pull request, #15481:
URL: https://github.com/apache/kafka/pull/15481
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
Nickstery commented on code in PR #15472:
URL: https://github.com/apache/kafka/pull/15472#discussion_r1514277995
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -707,6 +708,8 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
Nickstery commented on code in PR #15472:
URL: https://github.com/apache/kafka/pull/15472#discussion_r1514266315
##
storage/src/main/java/org/apache/kafka/storage/internals/log/TimeIndex.java:
##
@@ -75,13 +75,14 @@ public void sanityCheck() {
TimestampOffset entry =
AndrewJSchofield commented on PR #15479:
URL: https://github.com/apache/kafka/pull/15479#issuecomment-1980543598
@showuon Would you be able to review this PR please? It's a fix to an
earlier PR which you reviewed, so I think you'll have the context to understand
it.
--
This is an
AndrewJSchofield commented on code in PR #15479:
URL: https://github.com/apache/kafka/pull/15479#discussion_r1514201905
##
clients/src/main/java/org/apache/kafka/clients/admin/internals/DeleteRecordsHandler.java:
##
@@ -79,15 +79,15 @@ public static SimpleAdminApiFuture
johnnychhsu commented on PR #15464:
URL: https://github.com/apache/kafka/pull/15464#issuecomment-1980499464
the test is flaky since the current failed pipeline succeeded in previous run
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
nizhikov commented on PR #15363:
URL: https://github.com/apache/kafka/pull/15363#issuecomment-1980469311
@chia7712 This PR ready for review.
Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
iit2009060 commented on PR #15444:
URL: https://github.com/apache/kafka/pull/15444#issuecomment-1980469009
Yes @showuon I will raise a PR for it. Need one clarification
As per code when we copy a
wernerdv commented on PR #15457:
URL: https://github.com/apache/kafka/pull/15457#issuecomment-1980452029
Hello, @mimaison
Please, take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
AndrewJSchofield commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1514119801
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2276,6 +2415,11 @@ private Node leader(PartitionInfo partitionInfo) {
AndrewJSchofield commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1514117940
##
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##
@@ -1399,6 +1404,184 @@ public void testInvalidTopicNames() throws
nizhikov commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1980426424
@chia7712 Thank you for the review and merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-16252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16252.
Resolution: Fixed
> Maligned Metrics formatting
> ---
>
>
[
https://issues.apache.org/jira/browse/KAFKA-16252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16252:
---
Fix Version/s: 3.8.0
> Maligned Metrics formatting
> ---
>
>
dengziming commented on PR #15304:
URL: https://github.com/apache/kafka/pull/15304#issuecomment-1980422478
@dajac Hello, this PR is ready for review except the upgrade docs, PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 merged PR #15473:
URL: https://github.com/apache/kafka/pull/15473
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1980412147
@nizhikov thanks for this refactor. let us deal with next PR :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
chia7712 merged PR #15365:
URL: https://github.com/apache/kafka/pull/15365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15365:
URL: https://github.com/apache/kafka/pull/15365#issuecomment-1980410184
the failed tests pass on my machine.
```sh
./gradlew cleanTest core:test --tests LogDirFailureTest --tests
ReplicaManagerTest --tests TransactionsTest --tests
[
https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823930#comment-17823930
]
Janardhana Gopalachar commented on KAFKA-16344:
---
HI [~gharris1727]
while processing 24k
dajac commented on code in PR #15470:
URL: https://github.com/apache/kafka/pull/15470#discussion_r1514092183
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -2276,6 +2399,11 @@ private Node leader(PartitionInfo partitionInfo) {
[
https://issues.apache.org/jira/browse/KAFKA-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823918#comment-17823918
]
Chia-Ping Tsai commented on KAFKA-16347:
trunk
[
https://issues.apache.org/jira/browse/KAFKA-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16347.
Resolution: Fixed
[~kevinztw] thanks for this contribution!
> Bump ZooKeeper to 3.8.4
>
[
https://issues.apache.org/jira/browse/KAFKA-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16347:
---
Fix Version/s: 3.6.2
3.7.1
> Bump ZooKeeper to 3.8.4
>
1 - 100 of 110 matches
Mail list logo
