[PR] KAFKA-15302: Stale value returned when using store.all() with key deletion [docs] [kafka]

2024-03-07 Thread via GitHub
jinyongchoi opened a new pull request, #15495: URL: https://github.com/apache/kafka/pull/15495 Related Issue [KAFKA-15302](https://issues.apache.org/jira/browse/KAFKA-15302) This PR adds documentation regarding the potential return of stale values when using 'withCachingEnabled'

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-03-07 Thread via GitHub
infantlikesprogramming commented on PR #15296: URL: https://github.com/apache/kafka/pull/15296#issuecomment-1984989351 > @infantlikesprogramming this PR is in my queue. If you want to do more contribution, please feel free to look up other tickets before reviewing. @chia7712

[jira] [Updated] (KAFKA-15302) Stale value returned when using store.all() with key deletion in punctuation function.

2024-03-07 Thread Jinyong Choi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jinyong Choi updated KAFKA-15302: - Summary: Stale value returned when using store.all() with key deletion in punctuation function.

Re: [PR] KAFKA-15795: Support fetch(fromKey, toKey, from, to) to WindowRangeQuery and unify WindowKeyQuery and WindowRangeQuery [kafka]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #14745: URL: https://github.com/apache/kafka/pull/14745#issuecomment-1984982734 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-15911: making sure the follower is making progress [kafka]

2024-03-07 Thread via GitHub
github-actions[bot] commented on PR #14971: URL: https://github.com/apache/kafka/pull/14971#issuecomment-1984982679 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[PR] MINOR: fix flaky EosIntegrationTest [kafka]

2024-03-07 Thread via GitHub
mjsax opened a new pull request, #15494: URL: https://github.com/apache/kafka/pull/15494 Bumping some timeout due to slow Jenkins build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-07 Thread via GitHub
gharris1727 commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1517018424 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -773,40 +730,34 @@ public void

[jira] [Updated] (KAFKA-16352) Transaction may get get stuck in PrepareCommit or PrepareAbort state

2024-03-07 Thread Artem Livshits (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Livshits updated KAFKA-16352: --- Description: A transaction took a long time to complete, trying to restart a producer would

[jira] [Resolved] (KAFKA-16325) Add missing producer metrics to documentation

2024-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16325. Fix Version/s: 3.8.0 Resolution: Fixed > Add missing producer metrics to

Re: [PR] KAFKA-16325 Add missing producer monitoring metrics to doc [kafka]

2024-03-07 Thread via GitHub
chia7712 commented on PR #15466: URL: https://github.com/apache/kafka/pull/15466#issuecomment-1984753002 @Owen-CH-Leung thanks for this patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16325 Add missing producer monitoring metrics to doc [kafka]

2024-03-07 Thread via GitHub
chia7712 merged PR #15466: URL: https://github.com/apache/kafka/pull/15466 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-14748) Relax non-null FK left-join requirement

2024-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-14748: Fix Version/s: 3.7.0 > Relax non-null FK left-join requirement >

[jira] [Updated] (KAFKA-12317) Relax non-null key requirement for left/outer KStream joins

2024-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12317: Fix Version/s: 3.7.0 > Relax non-null key requirement for left/outer KStream joins >

[jira] [Resolved] (KAFKA-15576) Add 3.6.0 to broker/client and streams upgrade/compatibility tests

2024-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-15576. - Resolution: Fixed > Add 3.6.0 to broker/client and streams upgrade/compatibility tests

[jira] [Created] (KAFKA-16354) FinalizedFeatureChangeListenerTest should use mocked latches

2024-03-07 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16354: --- Summary: FinalizedFeatureChangeListenerTest should use mocked latches Key: KAFKA-16354 URL: https://issues.apache.org/jira/browse/KAFKA-16354 Project: Kafka

[jira] [Assigned] (KAFKA-16202) Extra dot in error message in producer

2024-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16202: -- Assignee: Dung Ha > Extra dot in error message in producer >

[jira] [Resolved] (KAFKA-16202) Extra dot in error message in producer

2024-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16202?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16202. Fix Version/s: 3.8.0 Resolution: Fixed > Extra dot in error message in producer >

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-03-07 Thread via GitHub
chia7712 merged PR #15296: URL: https://github.com/apache/kafka/pull/15296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15585: DescribeTopicPartitions client side change. [kafka]

2024-03-07 Thread via GitHub
artemlivshits commented on code in PR #15470: URL: https://github.com/apache/kafka/pull/15470#discussion_r1516873731 ## clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java: ## @@ -2184,9 +2178,138 @@ void handleFailure(Throwable throwable) {

[PR] KAFKA-16226; Reduce synchronization between producer threads (#15323) [kafka]

2024-03-07 Thread via GitHub
msn-tldr opened a new pull request, #15493: URL: https://github.com/apache/kafka/pull/15493 NOTE this cherry-picks https://github.com/apache/kafka/pull/14522 into 3.7 As this [JIRA](https://issues.apache.org/jira/browse/KAFKA-16226) explains, there is increased synchronization

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-03-07 Thread via GitHub
chia7712 commented on PR #15296: URL: https://github.com/apache/kafka/pull/15296#issuecomment-1984553935 @infantlikesprogramming this PR is in my queue. If you want to do more contribution, please feel free to look up other tickets before reviewing. -- This is an automated message from

[PR] KAFKA-16353: Offline protocol migration integration tests [kafka]

2024-03-07 Thread via GitHub
dongnuo123 opened a new pull request, #15492: URL: https://github.com/apache/kafka/pull/15492 This patch adds integration tests for offline protocol migration. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dongnuo123 commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1516858539 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dongnuo123 commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1516784744 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-03-07 Thread via GitHub
federico-weisse-sportsbet commented on PR #15413: URL: https://github.com/apache/kafka/pull/15413#issuecomment-1984501431 Yeah, totally; I think the important thing is correcting the documentation, as people may be confused while reading it. Still, I don't know where the documentation is.

Re: [PR] KAFKA-10892: Shared Readonly State Stores ( revisited ) [kafka]

2024-03-07 Thread via GitHub
wcarlson5 commented on code in PR #12742: URL: https://github.com/apache/kafka/pull/12742#discussion_r1516823620 ## streams/src/test/java/org/apache/kafka/streams/processor/ReadOnlyStoreTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Created] (KAFKA-16353) Offline protocol migration integration tests

2024-03-07 Thread Dongnuo Lyu (Jira)
Dongnuo Lyu created KAFKA-16353: --- Summary: Offline protocol migration integration tests Key: KAFKA-16353 URL: https://issues.apache.org/jira/browse/KAFKA-16353 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-16025) Streams StateDirectory has orphaned locks after rebalancing, blocking future rebalancing

2024-03-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16025?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16025: Fix Version/s: 3.7.1 > Streams StateDirectory has orphaned locks after rebalancing,

Re: [PR] KAFKA-16025: Fix orphaned locks when rebalancing and store cleanup race on unassigned task directories [kafka]

2024-03-07 Thread via GitHub
mjsax commented on PR #15088: URL: https://github.com/apache/kafka/pull/15088#issuecomment-1984394573 Cherry-picked this to 3.7 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dongnuo123 commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1516784744 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void

Re: [PR] Fix documentation for RETRIES_DOC on version 3.2 [kafka]

2024-03-07 Thread via GitHub
jolshan commented on PR #15413: URL: https://github.com/apache/kafka/pull/15413#issuecomment-1984323889 @federico-weisse-sportsbet I see. We can update this branches but they may not be released again. If this is a concern for the website to have correct documentation it might be worth

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-03-07 Thread via GitHub
infantlikesprogramming commented on PR #15296: URL: https://github.com/apache/kafka/pull/15296#issuecomment-1984323114 @chia7712 Thank you so much. I have just created a JIRA account. Also, would you mind giving me some suggestions on what should do to get my PR merged? Thank you. --

Re: [PR] KAFKA-16073: [Tiered] Update localLogStartOffset before deleting segments in memory t… [kafka]

2024-03-07 Thread via GitHub
junrao commented on code in PR #15141: URL: https://github.com/apache/kafka/pull/15141#discussion_r1516745251 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1510,10 +1510,21 @@ class UnifiedLog(@volatile var logStartOffset: Long, } }

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-03-07 Thread via GitHub
chia7712 commented on PR #15296: URL: https://github.com/apache/kafka/pull/15296#issuecomment-1984313895 @infantlikesprogramming I just approve your request. Will assign the jira to you -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-03-07 Thread via GitHub
infantlikesprogramming commented on PR #15296: URL: https://github.com/apache/kafka/pull/15296#issuecomment-1984310306 > @infantlikesprogramming do you have jira account? I try to assign the jira to you @chia7712 thank you so much for asking. I have tried to sign up for a JIRA account

[jira] [Resolved] (KAFKA-16299) Classic group error responses should contain a no generation id and an empty members list

2024-03-07 Thread Jeff Kim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeff Kim resolved KAFKA-16299. -- Resolution: Invalid Not needed. Refer to

Re: [PR] KAFKA-16202: Extra dot in error message in producer [kafka]

2024-03-07 Thread via GitHub
chia7712 commented on PR #15296: URL: https://github.com/apache/kafka/pull/15296#issuecomment-1984257486 @infantlikesprogramming do you have jira account? I try to assign the jira to you -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Resolved] (KAFKA-16265) Add durationFilter to ListTransactionsRequest

2024-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16265. Fix Version/s: 3.8.0 Resolution: Fixed > Add durationFilter to

[jira] [Assigned] (KAFKA-16265) Add durationFilter to ListTransactionsRequest

2024-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16265: -- Assignee: Yang Yu > Add durationFilter to ListTransactionsRequest >

[jira] [Commented] (KAFKA-16352) Transaction may get get stuck in PrepareCommit or PrepareAbort state

2024-03-07 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824512#comment-17824512 ] Justine Olshan commented on KAFKA-16352: Thanks for filing [~alivshits]. If I understand

[jira] [Commented] (KAFKA-16320) CreateTopics, DeleteTopics and CreatePartitions differences between Zookeeper and KRaft

2024-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824508#comment-17824508 ] Chia-Ping Tsai commented on KAFKA-16320: thanks for this report. I will dig in it later. >

[jira] [Assigned] (KAFKA-16320) CreateTopics, DeleteTopics and CreatePartitions differences between Zookeeper and KRaft

2024-03-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16320: -- Assignee: Chia-Ping Tsai > CreateTopics, DeleteTopics and CreatePartitions

[jira] [Created] (KAFKA-16352) Transaction may get get stuck in PrepareCommit or PrepareAbort state

2024-03-07 Thread Artem Livshits (Jira)
Artem Livshits created KAFKA-16352: -- Summary: Transaction may get get stuck in PrepareCommit or PrepareAbort state Key: KAFKA-16352 URL: https://issues.apache.org/jira/browse/KAFKA-16352 Project:

Re: [PR] MINOR: Use INFO logging for tools tests [kafka]

2024-03-07 Thread via GitHub
chia7712 merged PR #15487: URL: https://github.com/apache/kafka/pull/15487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: move TimeRatio to server-common [kafka]

2024-03-07 Thread via GitHub
jeffkbkim commented on PR #15447: URL: https://github.com/apache/kafka/pull/15447#issuecomment-1984216605 closing as it will not be used in a package outside of `raft` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MINOR: move TimeRatio to server-common [kafka]

2024-03-07 Thread via GitHub
jeffkbkim closed pull request #15447: MINOR: move TimeRatio to server-common URL: https://github.com/apache/kafka/pull/15447 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-07 Thread via GitHub
ijuma commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1516657707 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -52,20 +55,30 @@ public class GetOffsetShellTest { private final int topicCount = 4;

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-07 Thread via GitHub
ijuma commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1516657707 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -52,20 +55,30 @@ public class GetOffsetShellTest { private final int topicCount = 4;

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-07 Thread via GitHub
ijuma commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1516656926 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -52,20 +55,30 @@ public class GetOffsetShellTest { private final int topicCount = 4;

Re: [PR] KAFKA-14589 [4/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-07 Thread via GitHub
nizhikov commented on code in PR #15465: URL: https://github.com/apache/kafka/pull/15465#discussion_r1516639945 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -0,0 +1,622 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-14589 [4/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-07 Thread via GitHub
chia7712 commented on code in PR #15465: URL: https://github.com/apache/kafka/pull/15465#discussion_r1516631446 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ResetConsumerGroupOffsetTest.java: ## @@ -0,0 +1,622 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-07 Thread via GitHub
jolshan commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1516626745 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -52,20 +55,30 @@ public class GetOffsetShellTest { private final int topicCount = 4;

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-07 Thread via GitHub
jolshan commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1516625703 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -52,20 +55,30 @@ public class GetOffsetShellTest { private final int topicCount = 4;

Re: [PR] MINOR: Cleanup log.dirs in ReplicaManagerTest on JVM exit [kafka]

2024-03-07 Thread via GitHub
gaurav-narula commented on code in PR #15289: URL: https://github.com/apache/kafka/pull/15289#discussion_r1516589314 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -195,6 +195,25 @@ public static File tempDirectory() { return tempDirectory(null);

Re: [PR] MINOR: Cleanup log.dirs in ReplicaManagerTest on JVM exit [kafka]

2024-03-07 Thread via GitHub
chia7712 commented on code in PR #15289: URL: https://github.com/apache/kafka/pull/15289#discussion_r1516374859 ## clients/src/test/java/org/apache/kafka/test/TestUtils.java: ## @@ -195,6 +195,25 @@ public static File tempDirectory() { return tempDirectory(null);

Re: [PR] KAFKA-10892: Shared Readonly State Stores ( revisited ) [kafka]

2024-03-07 Thread via GitHub
mjsax commented on code in PR #12742: URL: https://github.com/apache/kafka/pull/12742#discussion_r1516564608 ## streams/src/test/java/org/apache/kafka/streams/processor/ReadOnlyStoreTest.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-15964: fix flaky StreamsAssignmentScaleTest [kafka]

2024-03-07 Thread via GitHub
mjsax merged PR #15485: URL: https://github.com/apache/kafka/pull/15485 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15645 ReplicationQuotasTestRig rewritten in java [kafka]

2024-03-07 Thread via GitHub
ijuma commented on PR #14588: URL: https://github.com/apache/kafka/pull/14588#issuecomment-1983994964 Great, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dajac commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1516473475 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void

Re: [PR] KAFKA-16313: offline group protocol migration [kafka]

2024-03-07 Thread via GitHub
dongnuo123 commented on code in PR #15442: URL: https://github.com/apache/kafka/pull/15442#discussion_r1516453885 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -9607,6 +9607,151 @@ public void

Re: [PR] KAFKA-15645 ReplicationQuotasTestRig rewritten in java [kafka]

2024-03-07 Thread via GitHub
nizhikov commented on PR #14588: URL: https://github.com/apache/kafka/pull/14588#issuecomment-1983853541 @ijuma scala code removed in https://github.com/apache/kafka/commit/76b1b50b644149e77ee1ec42d882e2cb80742bdf#diff-48cfe3a3a1343f9583c6a3c74602deacfdbac3fc49d5570599b1dd821a0ae742 --

Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

2024-03-07 Thread via GitHub
gaurav-narula commented on code in PR #15490: URL: https://github.com/apache/kafka/pull/15490#discussion_r1516423400 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -154,6 +159,25 @@ class KafkaServerTest extends QuorumTestHarness { server.shutdown()

Re: [PR] KAFKA-15490: Fix dir path when marking offline [kafka]

2024-03-07 Thread via GitHub
gaurav-narula commented on code in PR #15490: URL: https://github.com/apache/kafka/pull/15490#discussion_r1516423400 ## core/src/test/scala/unit/kafka/server/KafkaServerTest.scala: ## @@ -154,6 +159,25 @@ class KafkaServerTest extends QuorumTestHarness { server.shutdown()

Re: [PR] KAFKA-16319: Divide DeleteTopics requests by leader node [kafka]

2024-03-07 Thread via GitHub
AndrewJSchofield commented on PR #15479: URL: https://github.com/apache/kafka/pull/15479#issuecomment-1983823759 Thank you @mimaison . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Add read/write all operation [kafka]

2024-03-07 Thread via GitHub
dajac merged PR #15462: URL: https://github.com/apache/kafka/pull/15462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16319: Divide DeleteTopics requests by leader node [kafka]

2024-03-07 Thread via GitHub
mimaison commented on PR #15479: URL: https://github.com/apache/kafka/pull/15479#issuecomment-1983790339 Backported to 3.7 and 3.6 too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: remove the copy constructor of LogSegment [kafka]

2024-03-07 Thread via GitHub
chia7712 commented on code in PR #15488: URL: https://github.com/apache/kafka/pull/15488#discussion_r1516370592 ## core/src/test/scala/unit/kafka/log/LogLoaderTest.scala: ## @@ -352,7 +353,10 @@ class LogLoaderTest { // Intercept all segment read calls val

Re: [PR] KAFKA-16227: Avoid IllegalStateException during fetch initialization [kafka]

2024-03-07 Thread via GitHub
cadonna commented on code in PR #15491: URL: https://github.com/apache/kafka/pull/15491#discussion_r1516359058 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/SubscriptionState.java: ## @@ -540,6 +540,14 @@ public synchronized FetchPosition

Re: [PR] KAFKA-16319: Divide DeleteTopics requests by leader node [kafka]

2024-03-07 Thread via GitHub
mimaison merged PR #15479: URL: https://github.com/apache/kafka/pull/15479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16227: Avoid IllegalStateException during fetch initialization [kafka]

2024-03-07 Thread via GitHub
cadonna commented on code in PR #15491: URL: https://github.com/apache/kafka/pull/15491#discussion_r1516351421 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/FetchCollectorTest.java: ## @@ -418,14 +648,7 @@ private void buildDependencies() { }

Re: [PR] KAFKA-16319: Divide DeleteTopics requests by leader node [kafka]

2024-03-07 Thread via GitHub
mimaison commented on PR #15479: URL: https://github.com/apache/kafka/pull/15479#issuecomment-1983744957 Tests failures don't seem related. merging to trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[PR] KAFKA-16227: Avoid IllegalStateException during fetch initialization [kafka]

2024-03-07 Thread via GitHub
cadonna opened a new pull request, #15491: URL: https://github.com/apache/kafka/pull/15491 The AsyncKafkaConsumer might throw an IllegalStateException during the initialization of a new fetch. The exception is caused by the partition being unassigned by the background thread before

[jira] [Updated] (KAFKA-16351) Add groupid field in fetch request

2024-03-07 Thread zou shengfu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zou shengfu updated KAFKA-16351: Summary: Add groupid field in fetch request (was: add groupid field in fetch request) > Add

Re: [PR] KAFKA-15645 ReplicationQuotasTestRig rewritten in java [kafka]

2024-03-07 Thread via GitHub
ijuma commented on PR #14588: URL: https://github.com/apache/kafka/pull/14588#issuecomment-1983724313 Thanks for the PR. Quick question, how come we didn't delete the Scala code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Updated] (KAFKA-16351) add groupid field in fetch request

2024-03-07 Thread zou shengfu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] zou shengfu updated KAFKA-16351: Summary: add groupid field in fetch request (was: add groupid in fetch request) > add groupid

[jira] [Created] (KAFKA-16351) add groupid in fetch request

2024-03-07 Thread zou shengfu (Jira)
zou shengfu created KAFKA-16351: --- Summary: add groupid in fetch request Key: KAFKA-16351 URL: https://issues.apache.org/jira/browse/KAFKA-16351 Project: Kafka Issue Type: Improvement

[jira] [Assigned] (KAFKA-15490) Invalid path provided to the log failure channel upon I/O error when writing broker metadata checkpoint

2024-03-07 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya reassigned KAFKA-15490: Assignee: Divij Vaidya > Invalid path provided to the log failure channel upon I/O error

[PR] KAFKA-15490: Fix dir path when marking offline [kafka]

2024-03-07 Thread via GitHub
divijvaidya opened a new pull request, #15490: URL: https://github.com/apache/kafka/pull/15490 ## Bug On startup, Kafka creates a checkpoint for broker metadata. If underlying storage throws an IOException for any reason (maybe disk is full), then Kafka should mark the directory as

[jira] [Comment Edited] (KAFKA-16344) Internal topic mm2-offset-syncsinternal created with single partition is putting more load on the broker

2024-03-07 Thread Janardhana Gopalachar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824385#comment-17824385 ] Janardhana Gopalachar edited comment on KAFKA-16344 at 3/7/24 2:27 PM:

Re: [PR] MINOR: Add 3.7.0 to core and client's upgrade compatibility tests [kafka]

2024-03-07 Thread via GitHub
chia7712 merged PR #15452: URL: https://github.com/apache/kafka/pull/15452 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add 3.7.0 to core and client's upgrade compatibility tests [kafka]

2024-03-07 Thread via GitHub
chia7712 commented on PR #15452: URL: https://github.com/apache/kafka/pull/15452#issuecomment-1983603303 All system tests pass on my local. will merge it into trunk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (KAFKA-15490) Invalid path provided to the log failure channel upon I/O error when writing broker metadata checkpoint

2024-03-07 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15490: - Affects Version/s: 3.6.1 > Invalid path provided to the log failure channel upon I/O error when

Re: [PR] KAFKA-13922: Adjustments for jacoco, coverage reporting [kafka]

2024-03-07 Thread via GitHub
akatona84 commented on code in PR #11982: URL: https://github.com/apache/kafka/pull/11982#discussion_r1516226046 ## gradle/dependencies.gradle: ## @@ -158,7 +158,7 @@ versions += [ // https://github.com/scalameta/scalafmt/releases/tag/v3.1.0. scalafmt: "3.7.14",

Re: [PR] MINOR: Add read/write all operation [kafka]

2024-03-07 Thread via GitHub
chia7712 commented on code in PR #15462: URL: https://github.com/apache/kafka/pull/15462#discussion_r1516221969 ## server-common/src/main/java/org/apache/kafka/server/util/FutureUtils.java: ## @@ -125,4 +127,21 @@ public static CompletableFuture combineFutures(

Re: [PR] MINOR: Add read/write all operation [kafka]

2024-03-07 Thread via GitHub
dajac commented on code in PR #15462: URL: https://github.com/apache/kafka/pull/15462#discussion_r1516215271 ## server-common/src/main/java/org/apache/kafka/server/util/FutureUtils.java: ## @@ -125,4 +127,21 @@ public static CompletableFuture combineFutures(

[jira] [Comment Edited] (KAFKA-16344) Internal topic mm2-offset-syncsinternal created with single partition is putting more load on the broker

2024-03-07 Thread Janardhana Gopalachar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824385#comment-17824385 ] Janardhana Gopalachar edited comment on KAFKA-16344 at 3/7/24 2:05 PM:

Re: [PR] MINOR: Add read/write all operation [kafka]

2024-03-07 Thread via GitHub
chia7712 commented on code in PR #15462: URL: https://github.com/apache/kafka/pull/15462#discussion_r1516205356 ## server-common/src/main/java/org/apache/kafka/server/util/FutureUtils.java: ## @@ -125,4 +127,21 @@ public static CompletableFuture combineFutures(

Re: [PR] KAFKA-16100: Add timeout to all the CompletableApplicationEvents [kafka]

2024-03-07 Thread via GitHub
cadonna merged PR #15455: URL: https://github.com/apache/kafka/pull/15455 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-15729) KRaft support in GetOffsetShellTest

2024-03-07 Thread Owen C.H. Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824422#comment-17824422 ] Owen C.H. Leung commented on KAFKA-15729: - FYI : https://github.com/apache/kafka/pull/15489 >

[jira] [Assigned] (KAFKA-15729) KRaft support in GetOffsetShellTest

2024-03-07 Thread Owen C.H. Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15729?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen C.H. Leung reassigned KAFKA-15729: --- Assignee: Owen C.H. Leung > KRaft support in GetOffsetShellTest >

[PR] Kafka-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-07 Thread via GitHub
Owen-CH-Leung opened a new pull request, #15489: URL: https://github.com/apache/kafka/pull/15489 https://issues.apache.org/jira/browse/KAFKA-15729 As per [KAFKA-15729](https://issues.apache.org/jira/browse/KAFKA-15729), this PR adds Kraft support to `GetOffsetShellTest`

[PR] MINOR: remove the copy constructor of LogSegment [kafka]

2024-03-07 Thread via GitHub
johnnychhsu opened a new pull request, #15488: URL: https://github.com/apache/kafka/pull/15488 ## Context In the `LogSegmnet`, the copy constructor is only used in LogLoaderTest ## Solution Remove the copy constructor and build the logic in test ## Test Run `./gradlew

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-03-07 Thread via GitHub
mimaison commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1983537805 Yeah that seems like the next best approach. However I have no idea how to set that up. If you know how to set that up, go ahead and update the PR otherwise you'll probably will have to

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-03-07 Thread via GitHub
Vaibhav-Nazare commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-1983520711 Thanks @mimaison for looking into at, so seems we are out of options to build the specific stage daily, what if we add an additional jenkins file just to build for ppc64le

Re: [PR] KAFKA-16319: Divide DeleteTopics requests by leader node [kafka]

2024-03-07 Thread via GitHub
mimaison commented on PR #15479: URL: https://github.com/apache/kafka/pull/15479#issuecomment-1983510030 I'll wait for the CI to complete before merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16222: KRaft Migration: Incorrect default user-principal quota after migration [kafka]

2024-03-07 Thread via GitHub
FrankYang0529 commented on code in PR #15481: URL: https://github.com/apache/kafka/pull/15481#discussion_r1516093537 ## core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala: ## @@ -271,6 +273,9 @@ class ZkMigrationIntegrationTest { assertEquals(10,

[jira] [Commented] (KAFKA-16344) Internal topic mm2-offset-syncsinternal created with single partition is putting more load on the broker

2024-03-07 Thread Janardhana Gopalachar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17824385#comment-17824385 ] Janardhana Gopalachar commented on KAFKA-16344: --- HI [~gharris1727]  Below are few

[PR] MINOR: Use INFO logging for tools tests [kafka]

2024-03-07 Thread via GitHub
FrankYang0529 opened a new pull request, #15487: URL: https://github.com/apache/kafka/pull/15487 Use `INFO` logging as default for better reading tools test log. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

Re: [PR] KAFKA-14589 [4/4] Tests of ConsoleGroupCommand rewritten in java [kafka]

2024-03-07 Thread via GitHub
nizhikov commented on PR #15465: URL: https://github.com/apache/kafka/pull/15465#issuecomment-1983347482 Checked CI results. Failures unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] (KAFKA-15729) KRaft support in GetOffsetShellTest

2024-03-07 Thread Owen C.H. Leung (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15729 ] Owen C.H. Leung deleted comment on KAFKA-15729: - was (Author: JIRAUSER300460): I tried to work on this issue by extending this test to KRaft. However, I got the following exception when

  1   2   >