[jira] [Commented] (KAFKA-16359) kafka-clients-3.7.0.jar published to Maven Central is defective

2024-03-11 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825313#comment-17825313 ] Gaurav Narula commented on KAFKA-16359: --- This is likely because of the shadow jar plugin

Re: [PR] KAFKA-15561: Client support for new SubscriptionPattern based subscription [kafka]

2024-03-11 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15188: URL: https://github.com/apache/kafka/pull/15188#discussion_r1519707860 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1730,6 +1744,21 @@ private void subscribeInternal(Pattern

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-11 Thread via GitHub
showuon commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1519669214 ## core/src/test/scala/integration/kafka/admin/ListOffsetsIntegrationTest.scala: ## @@ -36,65 +37,149 @@ class ListOffsetsIntegrationTest extends

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-11 Thread via GitHub
showuon commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1519665612 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -52,20 +55,30 @@ public class GetOffsetShellTest { private final int topicCount = 4;

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-11 Thread via GitHub
showuon commented on PR #15474: URL: https://github.com/apache/kafka/pull/15474#issuecomment-1988370290 > Also, [#15476 (comment)](https://github.com/apache/kafka/pull/15476#discussion_r1518413083) applies here too. We just need to fix it in one of the PRs. Let's fix it in #15476.

Re: [PR] KAFKA-16342: fix getOffsetByMaxTimestamp for compressed records [kafka]

2024-03-11 Thread via GitHub
showuon commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1519662867 ## storage/src/main/java/org/apache/kafka/storage/internals/log/LogValidator.java: ## @@ -417,8 +422,14 @@ public ValidationResult

[jira] [Created] (KAFKA-16359) kafka-clients-3.7.0.jar published to Maven Central is defective

2024-03-11 Thread Jeremy Norris (Jira)
Jeremy Norris created KAFKA-16359: - Summary: kafka-clients-3.7.0.jar published to Maven Central is defective Key: KAFKA-16359 URL: https://issues.apache.org/jira/browse/KAFKA-16359 Project: Kafka

[jira] [Assigned] (KAFKA-16350) StateUpdater does not init transaction after canceling task close action

2024-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reassigned KAFKA-16350: - Assignee: Bruno Cadonna > StateUpdater does not init transaction after canceling task

[jira] [Commented] (KAFKA-16350) StateUpdater does not init transaction after canceling task close action

2024-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825278#comment-17825278 ] Bruno Cadonna commented on KAFKA-16350: --- Thanks for the report [~mjsax]! I think the bug is in

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 3 [kafka]

2024-03-11 Thread via GitHub
cadonna merged PR #15497: URL: https://github.com/apache/kafka/pull/15497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14133: Move consumer mock in TaskManagerTest to Mockito - part 3 [kafka]

2024-03-11 Thread via GitHub
cadonna commented on PR #15497: URL: https://github.com/apache/kafka/pull/15497#issuecomment-1988260873 Test failures are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Remove deprecation and exception throw in ProcessorRecordContext#hashcode [kafka]

2024-03-11 Thread via GitHub
cadonna commented on PR #15508: URL: https://github.com/apache/kafka/pull/15508#issuecomment-1988235647 @ableegoldman I had a quick look at the code and theoretically `ProcessorRecordContext` is mutable because `headers()` returns a reference to the object of `Headers` stored internally.

[PR] KAFKA-15417 Sloppy bug: moved the outerJounBreak-flags out of the loop [kafka]

2024-03-11 Thread via GitHub
VictorvandenHoven opened a new pull request, #15510: URL: https://github.com/apache/kafka/pull/15510 Sloppy bug: moved the outerJounBreak-flags out of the loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

2024-03-11 Thread via GitHub
satishd merged PR #15201: URL: https://github.com/apache/kafka/pull/15201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

2024-03-11 Thread via GitHub
satishd commented on PR #15201: URL: https://github.com/apache/kafka/pull/15201#issuecomment-1987943134 Merging the changes as the test failures are unrelated to this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-16146: Checkpoint log-start-offset for remote log enabled topics [kafka]

2024-03-11 Thread via GitHub
satishd commented on code in PR #15201: URL: https://github.com/apache/kafka/pull/15201#discussion_r1519366268 ## core/src/main/scala/kafka/log/LogManager.scala: ## @@ -865,7 +865,8 @@ class LogManager(logDirs: Seq[File], try {

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-11 Thread via GitHub
sjhajharia commented on PR #15486: URL: https://github.com/apache/kafka/pull/15486#issuecomment-1987900169 > I took a quick skim of the tests -- just wanted to confirm we have a test for the old produce request + invalid txn state returned? @jolshan , if you have a look at

[jira] [Assigned] (KAFKA-15649) Handle directory failure timeout

2024-03-11 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass reassigned KAFKA-15649: --- Assignee: Viktor Somogyi-Vass > Handle directory failure timeout >

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-11 Thread via GitHub
sjhajharia commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1519333893 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1007,7 +1010,8 @@ class ReplicaManager(val config: KafkaConfig, transactionalId,

Re: [PR] KAFKA-10892: Shared Readonly State Stores ( revisited ) [kafka]

2024-03-11 Thread via GitHub
calmera commented on PR #12742: URL: https://github.com/apache/kafka/pull/12742#issuecomment-1987893614 Nice job @mjsax @wcarlson5! Sorry I couldn't spend more time on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-11 Thread via GitHub
sjhajharia commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1519327877 ## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ## @@ -228,11 +232,17 @@ class AddPartitionsToTxnManager( val tp = new

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-11 Thread via GitHub
sjhajharia commented on code in PR #15486: URL: https://github.com/apache/kafka/pull/15486#discussion_r1519322254 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -3151,6 +3152,45 @@ public void testInvalidTxnStateIsAnAbortableError()

[jira] [Closed] (KAFKA-16285) Make group metadata available when a new assignment is set in async Kafka consumer

2024-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16285?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna closed KAFKA-16285. - > Make group metadata available when a new assignment is set in async Kafka > consumer >

[jira] [Reopened] (KAFKA-10199) Separate state restoration into separate threads

2024-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna reopened KAFKA-10199: --- > Separate state restoration into separate threads >

[jira] [Updated] (KAFKA-10199) Separate state restoration into separate threads

2024-03-11 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10199: -- Fix Version/s: 3.8.0 (was: 3.7.0) > Separate state restoration into

Re: [PR] Doi testing [kafka]

2024-03-11 Thread via GitHub
KrishVora01 closed pull request #15509: Doi testing URL: https://github.com/apache/kafka/pull/15509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Doi testing [kafka]

2024-03-11 Thread via GitHub
KrishVora01 opened a new pull request, #15509: URL: https://github.com/apache/kafka/pull/15509 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Comment Edited] (KAFKA-16114) Fix partiton not retention after cancel alter intra broker log dir task

2024-03-11 Thread wangliucheng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17825153#comment-17825153 ] wangliucheng edited comment on KAFKA-16114 at 3/11/24 6:00 AM: --- Hello, are

<    1   2