Re: [PR] KAFKA-16369: Broker may not shut down when SocketServer fails to bind as Address already in use [kafka]

2024-03-14 Thread via GitHub
edoardocomar commented on PR #15530: URL: https://github.com/apache/kafka/pull/15530#issuecomment-1997572827 PR is ready for review, can anyone please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Closed] (KAFKA-16227) Console consumer fails with `IllegalStateException`

2024-03-14 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna closed KAFKA-16227. - > Console consumer fails with `IllegalStateException` >

Re: [PR] Metadata schema checker [kafka]

2024-03-14 Thread via GitHub
mannoopj commented on code in PR #14389: URL: https://github.com/apache/kafka/pull/14389#discussion_r1524953366 ## tools/src/main/java/org/apache/kafka/tools/SchemaChecker/MetadataSchemaChecker.java: ## @@ -0,0 +1,359 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (KAFKA-16226) Java client: Performance regression in Trogdor benchmark with high partition counts

2024-03-14 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-16226. - Resolution: Fixed > Java client: Performance regression in Trogdor benchmark with high

Re: [PR] KAFKA-16226; Reduce synchronization between producer threads (#15323) [kafka]

2024-03-14 Thread via GitHub
ijuma merged PR #15498: URL: https://github.com/apache/kafka/pull/15498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16226; Reduce synchronization between producer threads (#15323) [kafka]

2024-03-14 Thread via GitHub
ijuma merged PR #15493: URL: https://github.com/apache/kafka/pull/15493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16226; Reduce synchronization between producer threads (#15323) [kafka]

2024-03-14 Thread via GitHub
ijuma commented on PR #15493: URL: https://github.com/apache/kafka/pull/15493#issuecomment-1997497460 Test failures are the same as the 3.7 branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-14 Thread via GitHub
dajac opened a new pull request, #15534: URL: https://github.com/apache/kafka/pull/15534 When the group coordinator is under heavy load, the current mechanism to release pending events based on updated high watermark, which consist in pushing an event at the end of the queue, is bad

[jira] [Created] (KAFKA-16374) High watermark updates should have a higher priority

2024-03-14 Thread David Jacot (Jira)
David Jacot created KAFKA-16374: --- Summary: High watermark updates should have a higher priority Key: KAFKA-16374 URL: https://issues.apache.org/jira/browse/KAFKA-16374 Project: Kafka Issue

[jira] [Commented] (KAFKA-14048) The Next Generation of the Consumer Rebalance Protocol

2024-03-14 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827070#comment-17827070 ] David Jacot commented on KAFKA-14048: - [~aratz_ws] We are working with the current timeline in mind:

Re: [PR] MINOR: change KStream processor names [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #587: URL: https://github.com/apache/kafka/pull/587#issuecomment-1997293925 @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINOR: Fix compiler error in `KafkaLog4jAppender` [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #368: URL: https://github.com/apache/kafka/pull/368#issuecomment-1997293944 The branch wasn't rebased after the capitalisation fix for SSL classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-2737: Added single- and multi-consumer integration tests for round-robin assignment [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #413: URL: https://github.com/apache/kafka/pull/413#issuecomment-1997293898 Two tests: 1. One consumer subscribes to 2 topics, each with 2 partitions; includes adding and removing a topic. 2. Several consumers subscribe to 2 topics, several partition each;

Re: [PR] KAFKA-2738: Replica FetcherThread should connect to leader endpoint m… [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #428: URL: https://github.com/apache/kafka/pull/428#issuecomment-1997293955 …atching its inter-broker security protocol -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-2796 add support for reassignment partition to specified logdir [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #484: URL: https://github.com/apache/kafka/pull/484#issuecomment-1997293906 Currently when creating a log, the directory is chosen by calculating the number of partitions in each directory and then choosing the data directory with the fewest partitions.

Re: [PR] MINOR: Remove unreachable if check [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #396: URL: https://github.com/apache/kafka/pull/396#issuecomment-1997293797 @gwenshap @granders could you guys take a look at this trivial change. This piece makes one think that for SSL, not passing `new_consumer=True` should be fine. It was fine until recently,

Re: [PR] KAFKA-2295; Support given for dynamically loaded classes (encoders, e… [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #314: URL: https://github.com/apache/kafka/pull/314#issuecomment-1997293825 Rebased code.. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-2698: Add paused() method to o.a.k.c.c.Consumer [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #403: URL: https://github.com/apache/kafka/pull/403#issuecomment-1997293838 As per KAFKA-2698, this adds a `paused()` method to the Consumer interface such that client code can query Consumer implementations for paused partitions. Somewhat new to the code base

Re: [PR] Kafka 2902 streaming config use get base consumer configs [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #596: URL: https://github.com/apache/kafka/pull/596#issuecomment-1997293747 Changes made for using getBaseConsumerConfigs from StreamingConfig.getConsumerConfigs. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-2361: unit test failure in ProducerFailureHandlingTest.testNotE… [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #571: URL: https://github.com/apache/kafka/pull/571#issuecomment-1997293697 same issue with KAFKA-1999, so I want to fix it https://issues.apache.org/jira/browse/KAFKA-1999 -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] MINOR: update to correct clock skew [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #383: URL: https://github.com/apache/kafka/pull/383#issuecomment-1997293673 @ewencp Updated the provisioning script to install ntp daemon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] modify config specification of topic level [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #612: URL: https://github.com/apache/kafka/pull/612#issuecomment-1997293618 topic level config delete config options use --delete-config instead of --deleteConfig -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] MINOR: Add new build target for system test libs [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #361: URL: https://github.com/apache/kafka/pull/361#issuecomment-1997293781 KAFKA-2644 adds MiniKdc for system tests and hence needs a target to collect all MiniKdc jars. At the moment, system tests run `gradlew jar`. Replacing that with `gradlew systemTestLibs`

Re: [PR] KAFKA-2718: Add logging to investigate intermittent unit test failures [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #613: URL: https://github.com/apache/kafka/pull/613#issuecomment-1997293596 Print port and directories used by zookeeper in unit tests to figure out which may be causing conflict. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-2769: Multi-consumer integration tests for consumer assignment incl. session timeouts and corresponding fixes [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #472: URL: https://github.com/apache/kafka/pull/472#issuecomment-1997293531 -- Refactored multi-consumer integration group assignment validation tests for round-robin assignment -- Added multi-consumer integration tests for session timeout expiration: 1. When a

Re: [PR] KAFKA-2718: Avoid reusing temporary directories in core unit tests [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #399: URL: https://github.com/apache/kafka/pull/399#issuecomment-1997293731 Retry to find new directory and cleanup on exit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-2825, KAFKA-2851: Controller failover tests added to ducktape replication tests and fix to temp dir [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #570: URL: https://github.com/apache/kafka/pull/570#issuecomment-1997293532 I closed an original pull request that contained previous comments by Geoff (which are already addressed here), because I got into bad rebase situation. So, I created a new branch and

Re: [PR] Modified the async producer so it re-queues failed batches. [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-1997291739 I'm working on an application that needs the throughput offered by an async producer but also needs to handle send failures gracefully like a sync producer. I modified the ProducerSendThread so

Re: [PR] KAFKA-2847; Remove principal builder class from client configs [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #542: URL: https://github.com/apache/kafka/pull/542#issuecomment-1997293684 Also mark `PrincipalBuilder` as `Unstable` and tweak docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] Modified the async producer so it re-queues failed batches. [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-1997291740 I'm working on an application that needs the throughput offered by an async producer but also needs to handle send failures gracefully like a sync producer. I modified the ProducerSendThread so

Re: [PR] HOTFIX: correct sourceNodes for kstream.through() [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #374: URL: https://github.com/apache/kafka/pull/374#issuecomment-1997293633 @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] ConsumerConfig now expects "bootstrap.servers" in config. [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #51: URL: https://github.com/apache/kafka/pull/51#issuecomment-1997291755 Small typo to have the documentation in line with `KafkaProducer.java`. Kudos on the awesome documentation work! -- This is an automated message from the Apache Git Service. To respond

Re: [PR] Unmap before resizing [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #6: URL: https://github.com/apache/kafka/pull/6#issuecomment-1997291728 While I was studying how MappedByteBuffer works, I saw a sharing runtime exception on Windows. I applied what I learned to generate a patch which uses an internal open JDK API to solve this

Re: [PR] KAFKA-2719: Use wildcard classpath for dependant-libs [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #400: URL: https://github.com/apache/kafka/pull/400#issuecomment-1997293586 PR switches to wildcard classpath for dependant libs to restrict the length of classpath, thereby reducing command line length. -- This is an automated message from the Apache Git

Re: [PR] commitOffsets can be passed the offsets to commit [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #10: URL: https://github.com/apache/kafka/pull/10#issuecomment-1997291772 This adds another version of `commitOffsets` that takes the offsets to commit as a parameter. Without this change, getting correct user code is very hard. Despite kafka's at-least-once

Re: [PR] Rack-Aware replica assignment option [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #14: URL: https://github.com/apache/kafka/pull/14#issuecomment-1997291760 Adding a rack-id to kafka config. This rack-id can be used during replica assignment by using the max-rack-replication argument in the admin scripts (create topic, etc.). By default the

Re: [PR] commitOffsets can be passed the offsets to commit [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #10: URL: https://github.com/apache/kafka/pull/10#issuecomment-1997291761 This adds another version of `commitOffsets` that takes the offsets to commit as a parameter. Without this change, getting correct user code is very hard. Despite kafka's at-least-once

Re: [PR] Patch for KAFKA-2055: ConsumerBounceTest.testSeekAndCommitWithBrokerFail... [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #60: URL: https://github.com/apache/kafka/pull/60#issuecomment-1997291729 ...ures transient failure -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-948 : Update ReplicaStateMachine.scala [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #5: URL: https://github.com/apache/kafka/pull/5#issuecomment-1997291720 KAFKA-948 When the broker which is the leader for a partition is down, the ISR list in the LeaderAndISR path is updated. But if the broker , which is not a leader of the partition is down,

Re: [PR] zkclient and scalatest library updates [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #3: URL: https://github.com/apache/kafka/pull/3#issuecomment-1997291703 Following https://issues.apache.org/jira/browse/KAFKA-826 I forked the code and included fixes for 2 bugs I reported, https://issues.apache.org/jira/browse/KAFKA-807 and

Re: [PR] Switch to using scala 2.9.2 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-1997291688 Compiled and used fine. I had issues with the tests though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Switch to using scala 2.9.2 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-1997291690 Compiled and used fine. I had issues with the tests though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-2639: Refactoring of ZkUtils [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #303: URL: https://github.com/apache/kafka/pull/303#issuecomment-1997291631 I've split the work of KAFKA-1695 because this refactoring touches a large number of files. Most of the changes are trivial, but I feel it will be easier to review this way. This pull

Re: [PR] KAFKA-2015: Enable ConsoleConsumer to use new consumer [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #144: URL: https://github.com/apache/kafka/pull/144#issuecomment-1997291590 This extends the original patch done by GZ to provide Console access to both the new and old consumer API's. The code follows a pattern similar to that already used in ConsoleProducer.

Re: [PR] Exclude conflicting zookeeper version from 'com.101tec:zkclient' dependencies [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #162: URL: https://github.com/apache/kafka/pull/162#issuecomment-1997291552 'com.101tec:zkclient:0.5' package brings in a dependency on older zookeper version: `3.4.4` This causes conflicts if consumers of kafka jar are trying to use `maven-enforcer` plugin.

Re: [PR] KAFKA-948 : Update ReplicaStateMachine.scala [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #5: URL: https://github.com/apache/kafka/pull/5#issuecomment-1997291716 KAFKA-948 When the broker which is the leader for a partition is down, the ISR list in the LeaderAndISR path is updated. But if the broker , which is not a leader of the partition is down,

Re: [PR] Unmap before resizing [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #6: URL: https://github.com/apache/kafka/pull/6#issuecomment-1997291721 While I was studying how MappedByteBuffer works, I saw a sharing runtime exception on Windows. I applied what I learned to generate a patch which uses an internal open JDK API to solve this

Re: [PR] KAFKA-294 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #2: URL: https://github.com/apache/kafka/pull/2#issuecomment-1997291692 This issue can be caused by a non-existing path but also a misunderstanding from the config file. A short example will help the user. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-1545: KafkaHealthcheck.register failure [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #48: URL: https://github.com/apache/kafka/pull/48#issuecomment-1997291682 KAFKA-1545: java.net.InetAddress.getLocalHost in KafkaHealthcheck.register may fail on some irregular hostnames -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-2232: Make MockProducer generic [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #68: URL: https://github.com/apache/kafka/pull/68#issuecomment-1997291446 MockConsumer and MockProducer have been moved to test source set. KeySerializer and ValueSerializer have been added to mimic actual KafkaProducer behavior. -- This is an automated

Re: [PR] Corrected the Changes in ZkUtils.scala - KAFKA-2167 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #63: URL: https://github.com/apache/kafka/pull/63#issuecomment-1997291423 Corrected Spelling errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] zkclient and scalatest library updates [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #3: URL: https://github.com/apache/kafka/pull/3#issuecomment-1997291705 Following https://issues.apache.org/jira/browse/KAFKA-826 I forked the code and included fixes for 2 bugs I reported, https://issues.apache.org/jira/browse/KAFKA-807 and

Re: [PR] KAFKA-1370 Added Gradle startup script for Windows [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #22: URL: https://github.com/apache/kafka/pull/22#issuecomment-1997291413 This patch adds Gradle startup script for Windows -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Reducing code duplication in DefaultEventHandler [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #125: URL: https://github.com/apache/kafka/pull/125#issuecomment-1997291643 No functionality was changed -- just removed code duplication & [get advantage of case class copy

Re: [PR] KAFKA-2442: Fixing transiently failing test [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #160: URL: https://github.com/apache/kafka/pull/160#issuecomment-1997291371 Made the following changes: 1. Made the quotas very small. (100 and 10 bytes/sec for producer and consumer respectively) 2. For the producer, I'm asserting the throttle_time with a

Re: [PR] KAFKA-294 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #2: URL: https://github.com/apache/kafka/pull/2#issuecomment-1997291693 This issue can be caused by a non-existing path but also a misunderstanding from the config file. A short example will help the user. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-2638: Added default properties file to ConsumerPerformance [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #302: URL: https://github.com/apache/kafka/pull/302#issuecomment-1997291381 Blocker for SSL integration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Make private class FetchManagerMetrics as a static private class with [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #214: URL: https://github.com/apache/kafka/pull/214#issuecomment-1997291651 reduced visibility for members in Fetcher. Use Collections.singletonList instead of Arrays.asList in the Unit Test -- This is an automated message from the Apache Git Service. To

Re: [PR] KAFKA-2534: Fixes and unit tests for SSLTransportLayer buffer overflow [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #205: URL: https://github.com/apache/kafka/pull/205#issuecomment-1997291606 Unit tests which mock buffer overflow and underflow in the SSL transport layer and fixes for the couple of issues in buffer overflow handling described in the JIRA. -- This is an

Re: [PR] KAFKA-2419; Garbage collect unused sensors [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #233: URL: https://github.com/apache/kafka/pull/233#issuecomment-1997291613 As discussed in KAFKA-2419 - I've added a time based sensor retention config to Sensor. Sensors that have not been "recorded" for 'n' seconds are eligible for expiration. In addition

Re: [PR] support commit offset after consumed [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #207: URL: https://github.com/apache/kafka/pull/207#issuecomment-1997291340 Kafka Of Original Version do not support "commit offset after consuming",when kafka.consumer.ConsumerIterator[K, V].next() return a MessageAndMetadata,which consumed offset is already being

Re: [PR] Fix for KAFKA-2446 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #152: URL: https://github.com/apache/kafka/pull/152#issuecomment-1997291313 This bug was introduced while committing KAFKA-2205. Basically, the path for topic overrides was renamed to "topic" from "topics". However, this causes existing topic config overrides to

Re: [PR] KAFKA-2320; Test commit [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #76: URL: https://github.com/apache/kafka/pull/76#issuecomment-1997291570 Trying to test the CI build created via KAFKA-2320. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-2562: update kafka scripts to use new tools/code [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #242: URL: https://github.com/apache/kafka/pull/242#issuecomment-1997291551 Updated kafka-producer-perf-test.sh to use org.apache.kafka.clients.tools.ProducerPerformance. Updated build.gradle to add kafka-tools-0.9.0.0-SNAPSHOT.jar to kafka/libs folder.

Re: [PR] KAFKA-948 : Update ReplicaStateMachine.scala [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #5: URL: https://github.com/apache/kafka/pull/5#issuecomment-1997291530 KAFKA-948 When the broker which is the leader for a partition is down, the ISR list in the LeaderAndISR path is updated. But if the broker , which is not a leader of the partition is down,

Re: [PR] Should stop offset backing store in Copycat Worker's stop method [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #232: URL: https://github.com/apache/kafka/pull/232#issuecomment-1997291473 @ewencp @gwenshap This is a trivial bug fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Modified the async producer so it re-queues failed batches. [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-1997289604 I'm working on an application that needs the throughput offered by an async producer but also needs to handle send failures gracefully like a sync producer. I modified the ProducerSendThread so

Re: [PR] Upgrade Gradle wrapper to Gradle 2.0 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #29: URL: https://github.com/apache/kafka/pull/29#issuecomment-1997291512 This patch upgrades gradle wrapper to gradle 2.0. As consequence license plugin dependency had to be upgraded as well. Issue: KAFKA-1559 -- This is an automated message from the

Re: [PR] KAFKA-1833: OfflinePartitionLeaderSelector may return null leader when ISR and Assgi... [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #39: URL: https://github.com/apache/kafka/pull/39#issuecomment-1997291408 PR for [KAFKA-1833](https://issues.apache.org/jira/browse/KAFKA-1833) In OfflinePartitonLeaderSelector::selectLeader, when liveBrokerInIsr is not empty and have no common broker with

Re: [PR] Unmap before resizing [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #6: URL: https://github.com/apache/kafka/pull/6#issuecomment-1997291402 While I was studying how MappedByteBuffer works, I saw a sharing runtime exception on Windows. I applied what I learned to generate a patch which uses an internal open JDK API to solve this

Re: [PR] Unmap before resizing [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #6: URL: https://github.com/apache/kafka/pull/6#issuecomment-1997289579 While I was studying how MappedByteBuffer works, I saw a sharing runtime exception on Windows. I applied what I learned to generate a patch which uses an internal open JDK API to solve this

Re: [PR] KAFKA-2055; Fix transient ConsumerBounceTest.testSeekAndCommitWithBro… [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #98: URL: https://github.com/apache/kafka/pull/98#issuecomment-1997291356 …kerFailures failure; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] KAFKA-1054; Eliminate Scala Compilation Warnings [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #57: URL: https://github.com/apache/kafka/pull/57#issuecomment-1997291322 Changes: - Suppressed compiler warnings about type erasure in matching via unboxing by Jon Riehl. - Suppressed warning caused by slight difference in input function type by John

Re: [PR] commitOffsets can be passed the offsets to commit [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #10: URL: https://github.com/apache/kafka/pull/10#issuecomment-1997289614 This adds another version of `commitOffsets` that takes the offsets to commit as a parameter. Without this change, getting correct user code is very hard. Despite kafka's at-least-once

Re: [PR] Modified the async producer so it re-queues failed batches. [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-1997289594 I'm working on an application that needs the throughput offered by an async producer but also needs to handle send failures gracefully like a sync producer. I modified the ProducerSendThread so

Re: [PR] KAFKA-2071: Replace Producer Request/Response with their org.apache.kafka.common.requests equivalents [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #110: URL: https://github.com/apache/kafka/pull/110#issuecomment-1997289591 This PR replaces all occurrences of kafka.api.ProducerRequest/ProducerResponse by their common equivalents. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] Unmap before resizing [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #6: URL: https://github.com/apache/kafka/pull/6#issuecomment-1997289573 While I was studying how MappedByteBuffer works, I saw a sharing runtime exception on Windows. I applied what I learned to generate a patch which uses an internal open JDK API to solve this

Re: [PR] KAFKA-2486; fix performance regression in new consumer [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #180: URL: https://github.com/apache/kafka/pull/180#issuecomment-1997289535 The sleep() in KafkaConsumer's poll blocked any pending IO from being completed and created a performance bottleneck. It was intended to implement the fetch backoff behavior, but that was a

Re: [PR] KAFKA-948 : Update ReplicaStateMachine.scala [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #5: URL: https://github.com/apache/kafka/pull/5#issuecomment-1997289577 KAFKA-948 When the broker which is the leader for a partition is down, the ISR list in the LeaderAndISR path is updated. But if the broker , which is not a leader of the partition is down,

Re: [PR] KAFKA-2527; System Test for Quotas in Ducktape [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #275: URL: https://github.com/apache/kafka/pull/275#issuecomment-1997289572 @granders Can you take a look at this quota system test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] zkclient and scalatest library updates [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #3: URL: https://github.com/apache/kafka/pull/3#issuecomment-1997289563 Following https://issues.apache.org/jira/browse/KAFKA-826 I forked the code and included fixes for 2 bugs I reported, https://issues.apache.org/jira/browse/KAFKA-807 and

Re: [PR] KAFKA-294 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #2: URL: https://github.com/apache/kafka/pull/2#issuecomment-1997289550 This issue can be caused by a non-existing path but also a misunderstanding from the config file. A short example will help the user. -- This is an automated message from the Apache Git

Re: [PR] Replace "it's" with "its" where appropriate [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #186: URL: https://github.com/apache/kafka/pull/186#issuecomment-1997289545 No Jira ticket created, as the Contributing Code Changes doc says it's not necessary for javadoc typo fixes. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] zkclient and scalatest library updates [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #3: URL: https://github.com/apache/kafka/pull/3#issuecomment-1997289564 Following https://issues.apache.org/jira/browse/KAFKA-826 I forked the code and included fixes for 2 bugs I reported, https://issues.apache.org/jira/browse/KAFKA-807 and

Re: [PR] Switch to using scala 2.9.2 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-1997289540 Compiled and used fine. I had issues with the tests though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-294 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #2: URL: https://github.com/apache/kafka/pull/2#issuecomment-1997289547 This issue can be caused by a non-existing path but also a misunderstanding from the config file. A short example will help the user. -- This is an automated message from the Apache Git

Re: [PR] Switch to using scala 2.9.2 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-1997289548 Compiled and used fine. I had issues with the tests though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] validate configuration while parsing ConfigDef [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #66: URL: https://github.com/apache/kafka/pull/66#issuecomment-1997289518 In java client, configDef class's parse() function should return parsed and validated values (if validator is present) but it does not validate the configuration. e.g. i can create a

Re: [PR] MINOR: flush record collector after local state flush [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #304: URL: https://github.com/apache/kafka/pull/304#issuecomment-1997289489 @guozhangwang Fix the order of flushing. Undoing the change I did sometime ago. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-2594 Added InMemoryLRUCacheStore [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #256: URL: https://github.com/apache/kafka/pull/256#issuecomment-1997289508 Added a new `KeyValueStore` implementation called `InMemoryLRUCacheStore` that keeps a maximum number of entries in-memory, and as the size exceeds the capacity the least-recently used entry

Re: [PR] KAFKA-2548; kafka-merge-pr tool fails to update JIRA with fix version 0.9.0.0 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #238: URL: https://github.com/apache/kafka/pull/238#issuecomment-1997289449 Simplified the logic to choose the default fix version. We just hardcode it for `trunk` and try to compute it based on the branch name for the rest. Removed logic that tries to

Re: [PR] HOTFIX: Persistent store in ProcessorStateManagerTest [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #276: URL: https://github.com/apache/kafka/pull/276#issuecomment-1997289406 @ymatsuda @junrao Could you take a quick look? The current unit test is failing on this. -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] KAFKA-948 : Update ReplicaStateMachine.scala [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #5: URL: https://github.com/apache/kafka/pull/5#issuecomment-1997289575 KAFKA-948 When the broker which is the leader for a partition is down, the ISR list in the LeaderAndISR path is updated. But if the broker , which is not a leader of the partition is down,

Re: [PR] MINOR: typing ProcessorDef [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #289: URL: https://github.com/apache/kafka/pull/289#issuecomment-1997289207 @guozhangwang This code change properly types ProcessorDef. This also makes KStream.process() typesafe. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] MINOR: Fixed ConsumerRecord constructor javadoc [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #85: URL: https://github.com/apache/kafka/pull/85#issuecomment-1997289189 Refactoring of ConsumerRecord made in https://github.com/apache/kafka/commit/0699ff2ce60abb466cab5315977a224f1a70a4da#diff-fafe8d3a3942f3c6394927881a9389b2 left ConsumerRecord constructor

Re: [PR] MINOR: Added to .gitignore Kafka server logs directory [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #94: URL: https://github.com/apache/kafka/pull/94#issuecomment-1997289167 When running Kafka server from sources, logs directory gets created in root of repository, and kafka server logs end up there. Currently that directory is not ignored by git. This

Re: [PR] Improvements to server stop scripts [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #41: URL: https://github.com/apache/kafka/pull/41#issuecomment-1997289150 Interrupt signal doesn't work to stop the servers (at least not on Amazon Linux.) Also, improved the selectivity of the stop command for the Zookeeper stop script, so that it doesn't

Re: [PR] KAFKA-2328; merge-kafka-pr.py script should not leave user in a detached branch [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #84: URL: https://github.com/apache/kafka/pull/84#issuecomment-1997289505 The right command to get the branch name is `git rev-parse --abbrev-ref HEAD` instead of `git rev-parse HEAD`. The latter gives the commit hash causing a detached branch when we checkout to

Re: [PR] KAFKA-2549: Fixing checkstyle failure resulting due to unused imports… [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #215: URL: https://github.com/apache/kafka/pull/215#issuecomment-1997289470 … in Selector. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-2405 Don't kill the JVM on session establishment failure [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #111: URL: https://github.com/apache/kafka/pull/111#issuecomment-1997289430 As noted in the JIRA https://issues.apache.org/jira/browse/KAFKA-2405 currently the KafkaHealthCheck causes the JVM to terminate in cases where session establishment with Zookeeper fails. I

<    1   2   3   4   >