Re: [PR] KAFKA-294 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #2: URL: https://github.com/apache/kafka/pull/2#issuecomment-1997285130 This issue can be caused by a non-existing path but also a misunderstanding from the config file. A short example will help the user. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-294 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #2: URL: https://github.com/apache/kafka/pull/2#issuecomment-1997283060 This issue can be caused by a non-existing path but also a misunderstanding from the config file. A short example will help the user. -- This is an automated message from the Apache Git

Re: [PR] Switch to using scala 2.9.2 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-1997283063 Compiled and used fine. I had issues with the tests though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-2479: Transient exception [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #279: URL: https://github.com/apache/kafka/pull/279#issuecomment-1997283302 Transient exception handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] KAFKA-2428 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #282: URL: https://github.com/apache/kafka/pull/282#issuecomment-1997283282 Add sanity test in kafkaConsumer for the timeouts. This is a followup ticket for Kafka-2120. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Fix to run hadoop-consumer with hadoop 2 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #18: URL: https://github.com/apache/kafka/pull/18#issuecomment-1997283274 Changes to use hadoop-core-1.2.1.jar in hadoop-consumer Changes to import from maven the packages needed to run hadoop-consumer in HDFS -- This is an automated message from the Apache

Re: [PR] KAFKA-2555: Infinite recursive function call when call commitSync in … [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #221: URL: https://github.com/apache/kafka/pull/221#issuecomment-1997283234 @hachikuji @ewencp I found this problem when adding new consumer to mirror maker which commits offset in the rebalance callback. It is not clear to me why we are triggering rebalance for

Re: [PR] Small change to API doc for seekToEnd() to clarify lazy evaluation. [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #199: URL: https://github.com/apache/kafka/pull/199#issuecomment-1997283180 Small clarification to docs. Current behaviour could confuse when doing something like: consumer.seekToEnd() consumer.send(msg) consumer.poll() //would return msg as seek evaluates

Re: [PR] KAFKA-1371 Ignore build output dirs [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #21: URL: https://github.com/apache/kafka/pull/21#issuecomment-1997283175 This patch extends git ignore patterns to all build and .gradle dirs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] commitOffsets can be passed the offsets to commit [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #10: URL: https://github.com/apache/kafka/pull/10#issuecomment-1997283124 This adds another version of `commitOffsets` that takes the offsets to commit as a parameter. Without this change, getting correct user code is very hard. Despite kafka's at-least-once

Re: [PR] Modified the async producer so it re-queues failed batches. [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-1997283100 I'm working on an application that needs the throughput offered by an async producer but also needs to handle send failures gracefully like a sync producer. I modified the ProducerSendThread so

Re: [PR] KAFKA-2588 ReplicaManager partitionCount metric should actually be re… [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #254: URL: https://github.com/apache/kafka/pull/254#issuecomment-1997283126 …plicaCount -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Unmap before resizing [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #6: URL: https://github.com/apache/kafka/pull/6#issuecomment-1997283088 While I was studying how MappedByteBuffer works, I saw a sharing runtime exception on Windows. I applied what I learned to generate a patch which uses an internal open JDK API to solve this

Re: [PR] KAFKA-948 : Update ReplicaStateMachine.scala [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #5: URL: https://github.com/apache/kafka/pull/5#issuecomment-1997283087 KAFKA-948 When the broker which is the leader for a partition is down, the ISR list in the LeaderAndISR path is updated. But if the broker , which is not a leader of the partition is down,

Re: [PR] Log the real exception which triggered a reconnect [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #138: URL: https://github.com/apache/kafka/pull/138#issuecomment-1997281261 The commit here improves the logging in SimpleConsumer to log the real reason why a reconnect was attempted. Relates to https://issues.apache.org/jira/browse/KAFKA-2221. The same

Re: [PR] KAFKA-2344; kafka-merge-pr improvements [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #90: URL: https://github.com/apache/kafka/pull/90#issuecomment-1997281238 The first 4 commits are adapted from changes that have been done to the Spark version and the last one is the feature that @gwenshap asked for. -- This is an automated message from the

Re: [PR] MINOR: Set `sendTime` in `doSend` instead of `InFlightRequests.add` and rename method names for consistency [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #264: URL: https://github.com/apache/kafka/pull/264#issuecomment-1997281213 @hachikuji @MayureshGharat @jjkoshy Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Remove non-functional variable definition in log4j.properties [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #36: URL: https://github.com/apache/kafka/pull/36#issuecomment-1997281199 In log4j.properties, a property kafka.logs.dir was defined. However, modifying this property has no effect because log4j.properties does not support variable substitution in this manner.

Re: [PR] KAFKA-2428 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #282: URL: https://github.com/apache/kafka/pull/282#issuecomment-1997281191 Add sanity test in kafkaConsumer for the timeouts. This is a followup ticket for Kafka-2120. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-2098: gradle files [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #54: URL: https://github.com/apache/kafka/pull/54#issuecomment-1997281108 gradle files, tiny footprint.lets have it in.thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-2072 [WIP]: Add StopReplica request/response to o.a.k.common.requests and replace the usage in core module [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #141: URL: https://github.com/apache/kafka/pull/141#issuecomment-1997281107 Migration is done but this PR will need to be rebased on #110. I have copied some code (ef669a5) for now. I'd appreciate feedback on it mainly around how I handle things in the

Re: [PR] KAFKA-2624: Change log message position [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #287: URL: https://github.com/apache/kafka/pull/287#issuecomment-1997281226 Log warning message before truncating log in order to display right offset value for the truncated log. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Small change to API doc for seekToEnd() to clarify lazy evaluation. [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #199: URL: https://github.com/apache/kafka/pull/199#issuecomment-1997281080 Small clarification to docs. Current behaviour could confuse when doing something like: consumer.seekToEnd() consumer.send(msg) consumer.poll() //would return msg as seek evaluates

Re: [PR] KAFKA-2397: leave group request [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #103: URL: https://github.com/apache/kafka/pull/103#issuecomment-1997281237 Let's say every consumer in a group has session timeout s. Currently, if a consumer leaves the group, the worst case time to stabilize the group is 2s (s to detect the consumer failure + s

Re: [PR] KAFKA-2479: Transient exception [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #279: URL: https://github.com/apache/kafka/pull/279#issuecomment-1997281218 Transient exception handling. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Modified the async producer so it re-queues failed batches. [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #7: URL: https://github.com/apache/kafka/pull/7#issuecomment-1997281006 I'm working on an application that needs the throughput offered by an async producer but also needs to handle send failures gracefully like a sync producer. I modified the ProducerSendThread so

Re: [PR] Fix to run hadoop-consumer with hadoop 2 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #18: URL: https://github.com/apache/kafka/pull/18#issuecomment-1997281154 Changes to use hadoop-core-1.2.1.jar in hadoop-consumer Changes to import from maven the packages needed to run hadoop-consumer in HDFS -- This is an automated message from the Apache

Re: [PR] KAFKA-948 : Update ReplicaStateMachine.scala [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #5: URL: https://github.com/apache/kafka/pull/5#issuecomment-1997280991 KAFKA-948 When the broker which is the leader for a partition is down, the ISR list in the LeaderAndISR path is updated. But if the broker , which is not a leader of the partition is down,

Re: [PR] KAFKA-2408 ConsoleConsumerService direct log output to file [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #123: URL: https://github.com/apache/kafka/pull/123#issuecomment-1997281121 console consumer writes to System.out, while (some) log4j loggers operate in other threads. This occasionally led to funky interleaved output which disrupted parsing of consumed

Re: [PR] KAFKA-2555: Infinite recursive function call when call commitSync in … [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #221: URL: https://github.com/apache/kafka/pull/221#issuecomment-1997281124 @hachikuji @ewencp I found this problem when adding new consumer to mirror maker which commits offset in the rebalance callback. It is not clear to me why we are triggering rebalance for

Re: [PR] KAFKA-294 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #2: URL: https://github.com/apache/kafka/pull/2#issuecomment-1997280966 This issue can be caused by a non-existing path but also a misunderstanding from the config file. A short example will help the user. -- This is an automated message from the Apache Git

Re: [PR] KAFKA-1371 Ignore build output dirs [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #21: URL: https://github.com/apache/kafka/pull/21#issuecomment-1997281081 This patch extends git ignore patterns to all build and .gradle dirs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] KAFKA-2588 ReplicaManager partitionCount metric should actually be re… [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #254: URL: https://github.com/apache/kafka/pull/254#issuecomment-1997281031 …plicaCount -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] commitOffsets can be passed the offsets to commit [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #10: URL: https://github.com/apache/kafka/pull/10#issuecomment-1997281026 This adds another version of `commitOffsets` that takes the offsets to commit as a parameter. Without this change, getting correct user code is very hard. Despite kafka's at-least-once

Re: [PR] zkclient and scalatest library updates [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #3: URL: https://github.com/apache/kafka/pull/3#issuecomment-1997280978 Following https://issues.apache.org/jira/browse/KAFKA-826 I forked the code and included fixes for 2 bugs I reported, https://issues.apache.org/jira/browse/KAFKA-807 and

Re: [PR] Unmap before resizing [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #6: URL: https://github.com/apache/kafka/pull/6#issuecomment-1997280996 While I was studying how MappedByteBuffer works, I saw a sharing runtime exception on Windows. I applied what I learned to generate a patch which uses an internal open JDK API to solve this

Re: [PR] Switch to using scala 2.9.2 [kafka]

2024-03-14 Thread via GitHub
b-goyal commented on PR #1: URL: https://github.com/apache/kafka/pull/1#issuecomment-1997280964 Compiled and used fine. I had issues with the tests though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Updated] (KAFKA-16373) Docker Official Image for Apache Kafka

2024-03-14 Thread Krish Vora (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Krish Vora updated KAFKA-16373: --- Description: KIP-1028: Docker Official Image for Apache Kafka: 

[PR] KAFKA-16367; Full ConsumerGroupHeartbeat response must be sent when full request is received [kafka]

2024-03-14 Thread via GitHub
dajac opened a new pull request, #15533: URL: https://github.com/apache/kafka/pull/15533 This patch fixes a bug in the logic which decides when a full ConsumerGroupHeartbeat response must be returned to the client. Prior to it, the logic only relies on the `ownedTopicPartitions` field to

[jira] [Created] (KAFKA-16373) Docker Official Image for Apache Kafka

2024-03-14 Thread Krish Vora (Jira)
Krish Vora created KAFKA-16373: -- Summary: Docker Official Image for Apache Kafka Key: KAFKA-16373 URL: https://issues.apache.org/jira/browse/KAFKA-16373 Project: Kafka Issue Type: New Feature

[jira] [Updated] (KAFKA-16372) max.block.ms behavior inconsistency with javadoc and the config description

2024-03-14 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada updated KAFKA-16372: - Component/s: producer (was: clients) Priority: Minor (was: Major)

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
dajac commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1524608939 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -529,25 +530,18 @@ public ConsumerGroupHeartbeatRequestData

[jira] [Created] (KAFKA-16372) max.block.ms behavior inconsistency with javadoc and the config description

2024-03-14 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-16372: Summary: max.block.ms behavior inconsistency with javadoc and the config description Key: KAFKA-16372 URL: https://issues.apache.org/jira/browse/KAFKA-16372 Project:

Re: [PR] Fix so that a partition is retained, if the another parititon on same… [kafka]

2024-03-14 Thread via GitHub
msn-tldr closed pull request #15019: Fix so that a partition is retained, if the another parititon on same… URL: https://github.com/apache/kafka/pull/15019 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Updated] (KAFKA-16371) Unstable committed offsets after triggering commits where metadata for some partitions are over the limit

2024-03-14 Thread mlowicki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mlowicki updated KAFKA-16371: - Description: Issue is reproducible with simple CLI tool -

[jira] [Updated] (KAFKA-16371) Unstable committed offsets after triggering commits where metadata for some partitions are over the limit

2024-03-14 Thread mlowicki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mlowicki updated KAFKA-16371: - Description: Issue is reproducible with simple CLI tool -

[jira] [Updated] (KAFKA-16371) Unstable committed offsets after triggering commits where metadata for some partitions are over the limit

2024-03-14 Thread mlowicki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mlowicki updated KAFKA-16371: - Description: Issue is reproducible with simple CLI tool -

[jira] [Updated] (KAFKA-16371) Unstable committed offsets after triggering commits where metadata for some partitions are over the limit

2024-03-14 Thread mlowicki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mlowicki updated KAFKA-16371: - Description: Issue is reproducible with simple CLI tool -

[jira] [Updated] (KAFKA-16371) Unstable committed offsets after triggering commits where metadata for some partitions are over the limit

2024-03-14 Thread mlowicki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mlowicki updated KAFKA-16371: - Description: Issue is reproducible with simple CLI tool -

[jira] [Updated] (KAFKA-16369) Broker may not shut down when SocketServer fails to bind as Address already in use

2024-03-14 Thread Edoardo Comar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Edoardo Comar updated KAFKA-16369: -- Affects Version/s: 3.6.1 3.7.0 3.8.0 > Broker

[jira] [Updated] (KAFKA-16371) Unstable committed offsets after triggering commits where metadata for some partitions are over the limit

2024-03-14 Thread mlowicki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mlowicki updated KAFKA-16371: - Description: Issue is reproducible with simple CLI tool -

[jira] [Updated] (KAFKA-16371) Unstable committed offsets after triggering commits where metadata for some partitions are over the limit

2024-03-14 Thread mlowicki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mlowicki updated KAFKA-16371: - Description: Issue is reproducible with simple CLI tool -

[jira] [Updated] (KAFKA-16371) Unstable committed offsets after triggering commits where metadata for some partitions are over the limit

2024-03-14 Thread mlowicki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mlowicki updated KAFKA-16371: - Description: Issue is reproducible with simple CLI tool -

[jira] [Created] (KAFKA-16371) Unstable committed offsets after triggering commits where some metadata for some partitions are over the limit

2024-03-14 Thread mlowicki (Jira)
mlowicki created KAFKA-16371: Summary: Unstable committed offsets after triggering commits where some metadata for some partitions are over the limit Key: KAFKA-16371 URL:

[jira] [Updated] (KAFKA-16371) Unstable committed offsets after triggering commits where metadata for some partitions are over the limit

2024-03-14 Thread mlowicki (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] mlowicki updated KAFKA-16371: - Summary: Unstable committed offsets after triggering commits where metadata for some partitions are

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
lucasbru commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1524569366 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -530,19 +530,12 @@ public ConsumerGroupHeartbeatRequestData

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
lucasbru commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1524568814 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -889,43 +914,36 @@ private void transitionToStale() { */

Re: [PR] KAFKA-13922: Adjustments for jacoco, coverage reporting [kafka]

2024-03-14 Thread via GitHub
viktorsomogyi merged PR #11982: URL: https://github.com/apache/kafka/pull/11982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16312, KAFKA-16185: Local epochs in reconciliation [kafka]

2024-03-14 Thread via GitHub
dajac commented on code in PR #15511: URL: https://github.com/apache/kafka/pull/15511#discussion_r1524430731 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java: ## @@ -529,25 +530,18 @@ public ConsumerGroupHeartbeatRequestData

[jira] [Updated] (KAFKA-16370) offline rollback procedure from kraft mode to zookeeper mode.

2024-03-14 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kaushik srinivas updated KAFKA-16370: - Issue Type: Wish (was: Improvement) > offline rollback procedure from kraft mode to

[jira] [Updated] (KAFKA-16370) offline rollback procedure from kraft mode to zookeeper mode.

2024-03-14 Thread kaushik srinivas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16370?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] kaushik srinivas updated KAFKA-16370: - Issue Type: Improvement (was: Wish) > offline rollback procedure from kraft mode to

[jira] [Created] (KAFKA-16370) offline rollback procedure from kraft mode to zookeeper mode.

2024-03-14 Thread kaushik srinivas (Jira)
kaushik srinivas created KAFKA-16370: Summary: offline rollback procedure from kraft mode to zookeeper mode. Key: KAFKA-16370 URL: https://issues.apache.org/jira/browse/KAFKA-16370 Project: Kafka

[jira] [Updated] (KAFKA-16073) Kafka Tiered Storage: Consumer Fetch Error Due to Delayed localLogStartOffset Update During Segment Deletion

2024-03-14 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-16073: - Fix Version/s: 3.6.2 (was: 3.6.1) > Kafka Tiered Storage: Consumer Fetch

Re: [PR] MINOR: Only enable replay methods to modify timeline data structure [kafka]

2024-03-14 Thread via GitHub
dajac commented on code in PR #15528: URL: https://github.com/apache/kafka/pull/15528#discussion_r1524389411 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -579,7 +579,7 @@ public List describeGroups( } /** -

Re: [PR] KAFKA-15206: Fix the flaky RemoteIndexCacheTest.testClose test [kafka]

2024-03-14 Thread via GitHub
showuon commented on PR #15523: URL: https://github.com/apache/kafka/pull/15523#issuecomment-1996775024 If the root cause of the flaky test is the `ShutdownableThreadTest` is not running, could we add `TestUtils.waitUntilTrue(() => cache.cleanerThread.isStarted)` before we invoke

[jira] [Resolved] (KAFKA-16249) Improve reconciliation state machine

2024-03-14 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16249. - Fix Version/s: 3.8.0 Resolution: Fixed > Improve reconciliation state machine >

[jira] [Resolved] (KAFKA-15997) Ensure fairness in the uniform assignor

2024-03-14 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-15997. - Resolution: Fixed This issue got resolved by https://issues.apache.org/jira/browse/KAFKA-16249.

[jira] [Assigned] (KAFKA-15997) Ensure fairness in the uniform assignor

2024-03-14 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-15997: --- Assignee: David Jacot (was: Ritika Reddy) > Ensure fairness in the uniform assignor >

Re: [PR] KAFKA-16249; Improve reconciliation state machine [kafka]

2024-03-14 Thread via GitHub
dajac merged PR #15364: URL: https://github.com/apache/kafka/pull/15364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15853: Move KafkaConfig to server module [kafka]

2024-03-14 Thread via GitHub
OmniaGM commented on PR #15103: URL: https://github.com/apache/kafka/pull/15103#issuecomment-1996761545 I published another PR to move only the properties and their docs out of core #15501 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] KAFKA-15206: Fix the flaky RemoteIndexCacheTest.testClose test [kafka]

2024-03-14 Thread via GitHub
kamalcph commented on PR #15523: URL: https://github.com/apache/kafka/pull/15523#issuecomment-1996675858 Thanks for the review! > If the cleaner thread wasn't even started, are our really testing correct behaviour? For example, when we validate that cleaner shouldn't have deleted

<    1   2   3   4