[jira] [Commented] (KAFKA-12506) Expand AdjustStreamThreadCountTest

2024-03-17 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827837#comment-17827837 ] Arpit Goyal commented on KAFKA-12506: - [~ableegoldman] Is this ticket still open to work upon ? I

Re: [PR] KAFKA-16000: Migrate MembershipManagerImplTest away from ConsumerTestBuilder [kafka]

2024-03-17 Thread via GitHub
github-actions[bot] commented on PR #14950: URL: https://github.com/apache/kafka/pull/14950#issuecomment-2002866951 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[PR] MINOR : Removed the depreciated information about Zk to Kraft migration. [kafka]

2024-03-17 Thread via GitHub
chiacyu opened a new pull request, #15552: URL: https://github.com/apache/kafka/pull/15552 The current document about Zookeeper to kraft migration is depreciated. Accord to [KIP-833: Mark KRaft as Production

[jira] [Commented] (KAFKA-16376) Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric

2024-03-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827825#comment-17827825 ] Chia-Ping Tsai commented on KAFKA-16376: [~brandboat] you are right. will close this as

[jira] [Resolved] (KAFKA-16376) Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric

2024-03-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16376. Resolution: Duplicate > Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric >

[jira] [Commented] (KAFKA-16376) Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric

2024-03-17 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827824#comment-17827824 ] Kuan Po Tseng commented on KAFKA-16376: --- Correct me if I'm wrong, but this appears to be a

[jira] [Assigned] (KAFKA-16376) Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric

2024-03-17 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang reassigned KAFKA-16376: - Assignee: PoAn Yang > Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric >

[jira] [Commented] (KAFKA-16376) Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric

2024-03-17 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827821#comment-17827821 ] Chia-Ping Tsai commented on KAFKA-16376: [~yangpoan] go ahead :) > Fix flaky

[jira] [Commented] (KAFKA-16376) Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric

2024-03-17 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827820#comment-17827820 ] PoAn Yang commented on KAFKA-16376: --- Hi [~chia7712], may I take this issue? I would like to try this.

[jira] [Commented] (KAFKA-16376) Fix flaky ReplicaManagerTest.testRemoteFetchExpiresPerSecMetric

2024-03-17 Thread Chris Holland (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827819#comment-17827819 ] Chris Holland commented on KAFKA-16376: --- Hey, I un-assigned myself for now as I am unfamiliar with

Re: [PR] MINOR: unlock before closing queue [kafka]

2024-03-17 Thread via GitHub
TaiJuWu commented on code in PR #15551: URL: https://github.com/apache/kafka/pull/15551#discussion_r1527638304 ## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ## @@ -260,6 +260,7 @@ private void handleEvents() throws InterruptedException {

Re: [PR] MINOR: unlock before closing queue [kafka]

2024-03-17 Thread via GitHub
TaiJuWu closed pull request #15551: MINOR: unlock before closing queue URL: https://github.com/apache/kafka/pull/15551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINOR: unlock before closing queue [kafka]

2024-03-17 Thread via GitHub
chia7712 commented on code in PR #15551: URL: https://github.com/apache/kafka/pull/15551#discussion_r1527631191 ## server-common/src/main/java/org/apache/kafka/queue/KafkaEventQueue.java: ## @@ -260,6 +260,7 @@ private void handleEvents() throws InterruptedException {

[PR] MINOR: unlock before closing queue [kafka]

2024-03-17 Thread via GitHub
TaiJuWu opened a new pull request, #15551: URL: https://github.com/apache/kafka/pull/15551 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

Re: [PR] KAFKA-16318 : add javafoc for kafka metric [kafka]

2024-03-17 Thread via GitHub
chia7712 commented on code in PR #15483: URL: https://github.com/apache/kafka/pull/15483#discussion_r1527554674 ## clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java: ## @@ -78,6 +111,10 @@ public Measurable measurable() { } } +/** +

Re: [PR] KAFKA-16318 : add javafoc for kafka metric [kafka]

2024-03-17 Thread via GitHub
johnnychhsu commented on code in PR #15483: URL: https://github.com/apache/kafka/pull/15483#discussion_r1527554056 ## clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java: ## @@ -40,15 +48,30 @@ public KafkaMetric(Object lock, MetricName metricName,

[PR] KAFKA-16381: add lock for KafkaMetric config getter [kafka]

2024-03-17 Thread via GitHub
johnnychhsu opened a new pull request, #15550: URL: https://github.com/apache/kafka/pull/15550 ## Context In KafkaMetirc.java, the config getter isĀ  ``` @Override public MetricName metricName() { return this.metricName; } ``` and there is a setterĀ  ```

Re: [PR] KAFKA-16318 : add javafoc for kafka metric [kafka]

2024-03-17 Thread via GitHub
johnnychhsu commented on code in PR #15483: URL: https://github.com/apache/kafka/pull/15483#discussion_r1527553634 ## clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java: ## @@ -40,15 +48,30 @@ public KafkaMetric(Object lock, MetricName metricName,

[jira] [Created] (KAFKA-16381) We should use a lock to protect the config getter in KafkaMetric

2024-03-17 Thread Johnny Hsu (Jira)
Johnny Hsu created KAFKA-16381: -- Summary: We should use a lock to protect the config getter in KafkaMetric Key: KAFKA-16381 URL: https://issues.apache.org/jira/browse/KAFKA-16381 Project: Kafka

Re: [PR] KAFKA-16318 : add javafoc for kafka metric [kafka]

2024-03-17 Thread via GitHub
chia7712 commented on code in PR #15483: URL: https://github.com/apache/kafka/pull/15483#discussion_r1527537826 ## clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java: ## @@ -40,15 +48,30 @@ public KafkaMetric(Object lock, MetricName metricName,

Re: [PR] KAFKA-16318 : add javafoc for kafka metric [kafka]

2024-03-17 Thread via GitHub
johnnychhsu commented on PR #15483: URL: https://github.com/apache/kafka/pull/15483#issuecomment-2002480150 tested with ``` ./gradlew cleanTest core:test --tests ConnectionQuotasTest --tests ControllerMutationQuotaTest stream:test --tests StandbyTaskTest --tests StreamTaskTest

Re: [PR] KAFKA-16318 : add javafoc for kafka metric [kafka]

2024-03-17 Thread via GitHub
johnnychhsu commented on code in PR #15483: URL: https://github.com/apache/kafka/pull/15483#discussion_r1527503839 ## clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java: ## @@ -40,15 +48,28 @@ public KafkaMetric(Object lock, MetricName metricName,

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-17 Thread via GitHub
johnnychhsu commented on PR #15476: URL: https://github.com/apache/kafka/pull/15476#issuecomment-2002453829 @chia7712 thanks for the reminder. Below are the failed tests from the build > [Build / JDK 17 and Scala 2.13 /

[jira] [Commented] (KAFKA-16263) Add Kafka Streams docs about available listeners/callback

2024-03-17 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827779#comment-17827779 ] Kuan Po Tseng commented on KAFKA-16263: --- May I take over this issue ? I'm quite interested in

Re: [PR] KAFKA-15302: Stale value returned when using store.all() with key deletion [docs] [kafka]

2024-03-17 Thread via GitHub
jinyongchoi commented on code in PR #15495: URL: https://github.com/apache/kafka/pull/15495#discussion_r1527474042 ## docs/streams/developer-guide/memory-mgmt.html: ## @@ -151,6 +151,10 @@ Serdes.Long()) .withCachingEnabled(); Record caches are not supported for

Re: [PR] KAFKA-16341: fix the LogValidator for non-compressed type [kafka]

2024-03-17 Thread via GitHub
chia7712 commented on PR #15476: URL: https://github.com/apache/kafka/pull/15476#issuecomment-2002394407 @johnnychhsu Could you check the failed tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[PR] KAFKA-16232: kafka hangs forever in the starting process if the authorizer future is not returned [kafka]

2024-03-17 Thread via GitHub
brandboat opened a new pull request, #15549: URL: https://github.com/apache/kafka/pull/15549 This is part of [KAFKA-16232](https://issues.apache.org/jira/browse/KAFKA-16232) > 2. add logs before and after future waiting, to allow admin to know we're waiting for the authorizer future.

[jira] [Commented] (KAFKA-15538) Client support for java regex based subscription

2024-03-17 Thread Phuc Hong Tran (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17827769#comment-17827769 ] Phuc Hong Tran commented on KAFKA-15538: nvm I figured out what you meant > Client support for