Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-20 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1533239354 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -182,14 +187,19 @@ public void testTopicPartitionsArg() { setUp();

Re: [PR] Kafka-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-03-20 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1533209761 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -104,6 +104,11 @@ public Row(String name, int partition, Long timestamp) {

Re: [PR] MINOR: Use --no-daemon when building with Jenkins [kafka]

2024-03-20 Thread via GitHub
github-actions[bot] commented on PR #15057: URL: https://github.com/apache/kafka/pull/15057#issuecomment-2011157584 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-16391: Cleanup .lock file after server is down [kafka]

2024-03-20 Thread via GitHub
showuon commented on code in PR #15568: URL: https://github.com/apache/kafka/pull/15568#discussion_r1533195347 ## core/src/test/scala/unit/kafka/log/LogManagerTest.scala: ## @@ -1303,6 +1303,27 @@ class LogManagerTest {

Re: [PR] KAFKA-16391: Cleanup .lock file after server is down [kafka]

2024-03-20 Thread via GitHub
FrankYang0529 commented on code in PR #15568: URL: https://github.com/apache/kafka/pull/15568#discussion_r1533196551 ## core/src/main/scala/kafka/utils/FileLock.scala: ## @@ -65,8 +65,14 @@ class FileLock(val file: File) extends Logging { def unlock(): Unit = { this

Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]

2024-03-20 Thread via GitHub
chia7712 commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-201902 @nizhikov could you please rebase code to trigger QA again? one of build is shutdown :( -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-16397) Use ByteBufferOutputStream to avoid array copy

2024-03-20 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16397?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829359#comment-17829359 ] Chia-Ping Tsai commented on KAFKA-16397: [~apoorvmittal10] FYI, and please let me know if you

[jira] [Updated] (KAFKA-16396) Producer use the same Key(string) result in multiple paritition

2024-03-20 Thread ZhenChun Pan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhenChun Pan updated KAFKA-16396: - Affects Version/s: 3.5.0 (was: 3.8.0) > Producer use the same

[jira] [Created] (KAFKA-16397) Use ByteBufferOutputStream to avoid array copy

2024-03-20 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16397: -- Summary: Use ByteBufferOutputStream to avoid array copy Key: KAFKA-16397 URL: https://issues.apache.org/jira/browse/KAFKA-16397 Project: Kafka Issue

[jira] [Updated] (KAFKA-16396) Producer use the same Key(string) result in multiple paritition

2024-03-20 Thread ZhenChun Pan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhenChun Pan updated KAFKA-16396: - Description: In orede to make  record  in order,we use the same

Re: [PR] KAFKA-16391: Cleanup .lock file after server is down [kafka]

2024-03-20 Thread via GitHub
showuon commented on code in PR #15568: URL: https://github.com/apache/kafka/pull/15568#discussion_r1533191601 ## core/src/main/scala/kafka/utils/FileLock.scala: ## @@ -65,8 +65,14 @@ class FileLock(val file: File) extends Logging { def unlock(): Unit = { this

Re: [PR] MINOR : Removed the depreciated information about Zk to Kraft migration. [kafka]

2024-03-20 Thread via GitHub
chia7712 commented on PR #15552: URL: https://github.com/apache/kafka/pull/15552#issuecomment-2011101530 @chiacyu thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (KAFKA-16396) Producer use the same Key(string) result in multiple paritition

2024-03-20 Thread ZhenChun Pan (Jira)
ZhenChun Pan created KAFKA-16396: Summary: Producer use the same Key(string) result in multiple paritition Key: KAFKA-16396 URL: https://issues.apache.org/jira/browse/KAFKA-16396 Project: Kafka

[jira] [Updated] (KAFKA-16396) Producer use the same Key(string) result in multiple paritition

2024-03-20 Thread ZhenChun Pan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZhenChun Pan updated KAFKA-16396: - Description: In orede to make  record  in order,we use the same

Re: [PR] MINOR : Removed the depreciated information about Zk to Kraft migration. [kafka]

2024-03-20 Thread via GitHub
chia7712 merged PR #15552: URL: https://github.com/apache/kafka/pull/15552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: Add retry mechanism to EOS example [kafka]

2024-03-20 Thread via GitHub
showuon commented on PR #15561: URL: https://github.com/apache/kafka/pull/15561#issuecomment-2011075907 @gaoran10, call for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] MINOR: Add retry mechanism to EOS example [kafka]

2024-03-20 Thread via GitHub
showuon commented on code in PR #15561: URL: https://github.com/apache/kafka/pull/15561#discussion_r1533168785 ## examples/src/main/java/kafka/examples/ExactlyOnceMessageProcessor.java: ## @@ -152,17 +160,19 @@ public void run() {

[PR] KAFKA-16391: Cleanup .lock file after server is down [kafka]

2024-03-20 Thread via GitHub
FrankYang0529 opened a new pull request, #15568: URL: https://github.com/apache/kafka/pull/15568 Currently, server adds a `.lock` file to each log folder. The file is useless after server is down. ### Committer Checklist (excluded from commit message) - [ ] Verify design and

Re: [PR] KAFKA-15949: Unify metadata.version format in log and error message [kafka]

2024-03-20 Thread via GitHub
showuon commented on PR #15505: URL: https://github.com/apache/kafka/pull/15505#issuecomment-2011051818 Retriggering the CI build: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-15505/4/ -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-16318 : add javafoc for kafka metric [kafka]

2024-03-20 Thread via GitHub
chia7712 commented on code in PR #15483: URL: https://github.com/apache/kafka/pull/15483#discussion_r1533141970 ## clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java: ## @@ -40,15 +48,29 @@ public KafkaMetric(Object lock, MetricName metricName,

[jira] [Updated] (KAFKA-16390) consume_bench_test.py failed using AsyncKafkaConsumer

2024-03-20 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16390: -- Summary: consume_bench_test.py failed using AsyncKafkaConsumer (was: consumer_bench_test.py failed

[PR] KAFKA-16275: Update transactions_test.py to support KIP-848’s group protocol config [kafka]

2024-03-20 Thread via GitHub
kirktrue opened a new pull request, #15567: URL: https://github.com/apache/kafka/pull/15567 Added a new optional `group_protocol` parameter to the test methods, then passed that down to the methods involved. Unfortunately, because the new consumer can only be used with the new

Re: [PR] MINOR: Revert to Gradle 8.5 [DO NOT MERGE YET] [kafka]

2024-03-20 Thread via GitHub
pasharik commented on PR #15553: URL: https://github.com/apache/kafka/pull/15553#issuecomment-2010846230 @gaurav-narula I've tried zinc `1.9.6` with gradle `8.5` and `8.6`, but getting the same issue with all tests re-compiled. Probably one radical solution to this incremental

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-03-20 Thread via GitHub
apoorvmittal10 commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1532971164 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -175,16 +182,44 @@ public static boolean

[jira] [Resolved] (KAFKA-16395) Producer should refresh metadata on a socket request timeout

2024-03-20 Thread David Mao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Mao resolved KAFKA-16395. --- Resolution: Not A Bug > Producer should refresh metadata on a socket request timeout >

[jira] [Commented] (KAFKA-16395) Producer should refresh metadata on a socket request timeout

2024-03-20 Thread David Mao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829311#comment-17829311 ] David Mao commented on KAFKA-16395: --- on a closer reading, I believe I misunderstood the code in

Re: [PR] KAFKA-16395: Producer should refresh metadata when a request is cancelled due to request timeout [kafka]

2024-03-20 Thread via GitHub
splett2 closed pull request #15565: KAFKA-16395: Producer should refresh metadata when a request is cancelled due to request timeout URL: https://github.com/apache/kafka/pull/15565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] KAFKA-16359: Corrected manifest file for kafka-clients [kafka]

2024-03-20 Thread via GitHub
apoorvmittal10 commented on PR #15532: URL: https://github.com/apache/kafka/pull/15532#issuecomment-2010700271 @ijuma Build passes with unrelated test failures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-20 Thread via GitHub
jeffkbkim commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1532907721 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1191,30 +1212,37 @@ public void onHighWatermarkUpdated(

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-20 Thread via GitHub
jeffkbkim commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1532903183 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1191,30 +1212,37 @@ public void onHighWatermarkUpdated(

Re: [PR] KAFKA-16395: Producer should refresh metadata when a request is cancelled due to request timeout [kafka]

2024-03-20 Thread via GitHub
splett2 commented on PR #15565: URL: https://github.com/apache/kafka/pull/15565#issuecomment-2010669973 I took a closer look and I am pretty sure that my repro is incorrect. I think the network client was behaving correctly based on my reading of the code from KAFKA-14317, but perhaps it

[PR] KRaft upgrade tests should only use latest stable mv [kafka]

2024-03-20 Thread via GitHub
ahuang98 opened a new pull request, #15566: URL: https://github.com/apache/kafka/pull/15566 This should help us avoid testing MVs before the corresponding release exists. We revert back from testing 3.8 in this case since 3.7 is the current stable version. ### Committer Checklist

Re: [PR] KAFKA-16206 Fix unnecessary topic config deletion during ZK migration [kafka]

2024-03-20 Thread via GitHub
ahuang98 commented on PR #14206: URL: https://github.com/apache/kafka/pull/14206#issuecomment-2010532534 @mimaison could you help merge this if this looks good to you? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Assigned] (KAFKA-16276) Update transactions_test.py to support KIP-848’s group protocol config

2024-03-20 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16276: - Assignee: Kirk True > Update transactions_test.py to support KIP-848’s group protocol config >

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-20 Thread via GitHub
dajac commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1532741513 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1191,30 +1212,37 @@ public void onHighWatermarkUpdated(

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-20 Thread via GitHub
dajac commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1532739687 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -1191,30 +1212,37 @@ public void onHighWatermarkUpdated(

Re: [PR] KAFKA-16353: Offline protocol migration integration tests [kafka]

2024-03-20 Thread via GitHub
dajac commented on code in PR #15492: URL: https://github.com/apache/kafka/pull/15492#discussion_r1532711510 ## core/src/test/scala/unit/kafka/server/ConsumerProtocolMigrationTest.scala: ## @@ -0,0 +1,177 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

Re: [PR] KAFKA-16395: Producer should refresh metadata when a request is cancelled due to request timeout [kafka]

2024-03-20 Thread via GitHub
ijuma commented on code in PR #15565: URL: https://github.com/apache/kafka/pull/15565#discussion_r1532671434 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -586,7 +586,7 @@ private void handleProduceResponse(ClientResponse response, Map

[PR] KAFKA-16395: Producer should refresh metadata when a request is cancelled due to request timeout [kafka]

2024-03-20 Thread via GitHub
splett2 opened a new pull request, #15565: URL: https://github.com/apache/kafka/pull/15565 ### What On a client-side triggered request timeout (the client did not receive a response from the server in a timely manner), the client needs to refresh metadata. This requires the partition

[jira] [Created] (KAFKA-16395) Producer should refresh metadata on a socket request timeout

2024-03-20 Thread David Mao (Jira)
David Mao created KAFKA-16395: - Summary: Producer should refresh metadata on a socket request timeout Key: KAFKA-16395 URL: https://issues.apache.org/jira/browse/KAFKA-16395 Project: Kafka

[jira] [Assigned] (KAFKA-16389) consumer_test.py’s test_valid_assignment fails with new consumer

2024-03-20 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True reassigned KAFKA-16389: - Assignee: Kirk True (was: Lianet Magrans) > consumer_test.py’s test_valid_assignment fails

[jira] [Commented] (KAFKA-15899) Move kafka.security package from core to server module

2024-03-20 Thread Nikolay Izhikov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829267#comment-17829267 ] Nikolay Izhikov commented on KAFKA-15899: - Hello [~omnia_h_ibrahim] Can I assign this ticket to

[jira] [Resolved] (KAFKA-16352) Transaction may get get stuck in PrepareCommit or PrepareAbort state

2024-03-20 Thread Artem Livshits (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Artem Livshits resolved KAFKA-16352. Fix Version/s: 3.8.0 Reviewer: Justine Olshan Resolution: Fixed >

[jira] [Created] (KAFKA-16394) ForeignKey LEFT join propagates null value on foreignKey change

2024-03-20 Thread Ayoub Omari (Jira)
Ayoub Omari created KAFKA-16394: --- Summary: ForeignKey LEFT join propagates null value on foreignKey change Key: KAFKA-16394 URL: https://issues.apache.org/jira/browse/KAFKA-16394 Project: Kafka

[PR] KAFKA-16343: Add unit tests of foreignKeyJoin classes [kafka]

2024-03-20 Thread via GitHub
AyoubOm opened a new pull request, #15564: URL: https://github.com/apache/kafka/pull/15564 Added unit tests of two processors included in foreignKey join : `SubscriptionSendProcessorSupplier` and `ForeignTableJoinProcessorSupplier`. Renamed ForeignTableJoinProcessorSupplierTest to

Re: [PR] KAFKA-15950: Serialize broker heartbeat requests [kafka]

2024-03-20 Thread via GitHub
junrao commented on code in PR #14903: URL: https://github.com/apache/kafka/pull/14903#discussion_r1532500641 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -254,33 +262,41 @@ class BrokerLifecycleManagerTest { @Test def

Re: [PR] KAFKA-15062: Adding ppc64le build stage [kafka]

2024-03-20 Thread via GitHub
mimaison commented on PR #13817: URL: https://github.com/apache/kafka/pull/13817#issuecomment-2010007861 I don't think (at least don't know how) we can modify the jobs in Jenkins directly. The jobs are automatically created via the Jenkinsfile in this repository. I see some other Apache

Re: [PR] KAFKA-15517: Improve MirrorMaker logging in case of authorization errors [kafka]

2024-03-20 Thread via GitHub
mimaison commented on code in PR #15558: URL: https://github.com/apache/kafka/pull/15558#discussion_r1532418821 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -630,8 +631,16 @@ Map describeTopicConfigs(Set topics) Set

Re: [PR] KAFKA-16318 : add javafoc for kafka metric [kafka]

2024-03-20 Thread via GitHub
mimaison commented on code in PR #15483: URL: https://github.com/apache/kafka/pull/15483#discussion_r1532394640 ## clients/src/main/java/org/apache/kafka/common/metrics/KafkaMetric.java: ## @@ -40,15 +48,29 @@ public KafkaMetric(Object lock, MetricName metricName,

Re: [PR] KAFKA-16232: kafka hangs forever in the starting process if the authorizer future is not returned [kafka]

2024-03-20 Thread via GitHub
brandboat commented on PR #15549: URL: https://github.com/apache/kafka/pull/15549#issuecomment-2009924617 gentle ping @showuon , would you mind take a look ? Many thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[PR] KAFKA-16388: add production-ready test of 2.7, 3.3 - 3.6 release to MetadataVersionTest.testFromVersionString [kafka]

2024-03-20 Thread via GitHub
brandboat opened a new pull request, #15563: URL: https://github.com/apache/kafka/pull/15563 Add 2.7, 3.3~3.6 release test to MetadataVersionTest.testFromVersionString ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify

Re: [PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

2024-03-20 Thread via GitHub
C0urante merged PR #15562: URL: https://github.com/apache/kafka/pull/15562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

2024-03-20 Thread via GitHub
C0urante commented on PR #15562: URL: https://github.com/apache/kafka/pull/15562#issuecomment-2009913326 Tests pass locally and this change is trivial; going to merge... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

2024-03-20 Thread via GitHub
C0urante commented on code in PR #15562: URL: https://github.com/apache/kafka/pull/15562#discussion_r1532337351 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetUtilsTest.java: ## @@ -134,6 +134,16 @@ public void testProcessPartitionKeyValidList() {

[jira] [Updated] (KAFKA-16073) Kafka Tiered Storage: Consumer Fetch Error Due to Delayed localLogStartOffset Update During Segment Deletion

2024-03-20 Thread Manikumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manikumar updated KAFKA-16073: -- Fix Version/s: 3.6.3 (was: 3.6.2) > Kafka Tiered Storage: Consumer Fetch Error

[jira] [Created] (KAFKA-16393) SslTransportLayer doesn't implement write(ByteBuffer[], int, int) correctly

2024-03-20 Thread Haruki Okada (Jira)
Haruki Okada created KAFKA-16393: Summary: SslTransportLayer doesn't implement write(ByteBuffer[], int, int) correctly Key: KAFKA-16393 URL: https://issues.apache.org/jira/browse/KAFKA-16393 Project:

[jira] [Comment Edited] (KAFKA-16372) max.block.ms behavior inconsistency with javadoc and the config description

2024-03-20 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828960#comment-17828960 ] Haruki Okada edited comment on KAFKA-16372 at 3/20/24 2:16 PM: --- [~showuon]

[jira] [Assigned] (KAFKA-16372) max.block.ms behavior inconsistency with javadoc and the config description

2024-03-20 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haruki Okada reassigned KAFKA-16372: Assignee: Haruki Okada > max.block.ms behavior inconsistency with javadoc and the config

[jira] [Comment Edited] (KAFKA-16372) max.block.ms behavior inconsistency with javadoc and the config description

2024-03-20 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828960#comment-17828960 ] Haruki Okada edited comment on KAFKA-16372 at 3/20/24 2:15 PM: --- [~showuon]

[jira] [Commented] (KAFKA-16372) max.block.ms behavior inconsistency with javadoc and the config description

2024-03-20 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828960#comment-17828960 ] Haruki Okada commented on KAFKA-16372: -- [~showuon] Agreed. One concern is, IMO many developers

Re: [PR] [WIP] Splitting consumer tests [kafka]

2024-03-20 Thread via GitHub
lianetm closed pull request #15535: [WIP] Splitting consumer tests URL: https://github.com/apache/kafka/pull/15535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] MINOR : Removed the depreciated information about Zk to Kraft migration. [kafka]

2024-03-20 Thread via GitHub
chiacyu commented on code in PR #15552: URL: https://github.com/apache/kafka/pull/15552#discussion_r1532121819 ## docs/ops.html: ## @@ -3797,14 +3797,6 @@ Modifying certain dynamic configurations on the standalone KRaft controller - ZooKeeper to KRaft Migration Review

Re: [PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

2024-03-20 Thread via GitHub
yashmayya commented on code in PR #15562: URL: https://github.com/apache/kafka/pull/15562#discussion_r1532113435 ## connect/runtime/src/test/java/org/apache/kafka/connect/storage/OffsetUtilsTest.java: ## @@ -134,6 +134,16 @@ public void testProcessPartitionKeyValidList() {

Re: [PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

2024-03-20 Thread via GitHub
C0urante commented on PR #15562: URL: https://github.com/apache/kafka/pull/15562#issuecomment-2009601190 @yashmayya @gharris1727 would either of you have a quick moment for this small patch? -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] KAFKA-16392: Stop emitting warning log message when parsing source connector offsets with null partitions [kafka]

2024-03-20 Thread via GitHub
C0urante opened a new pull request, #15562: URL: https://github.com/apache/kafka/pull/15562 [Jira](https://issues.apache.org/jira/browse/KAFKA-16392) This is a pretty lightweight change; we wrap the warning log message for unrecognized source partition types in a null guard.

[jira] [Created] (KAFKA-16392) Spurious log warnings: "Ignoring offset partition key with an unexpected format for the second element in the partition key list. Expected type: java.util.Map, actual ty

2024-03-20 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-16392: - Summary: Spurious log warnings: "Ignoring offset partition key with an unexpected format for the second element in the partition key list. Expected type: java.util.Map, actual type: null" Key:

[jira] [Commented] (KAFKA-15951) MissingSourceTopicException should include topic names

2024-03-20 Thread sanghyeok An (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828944#comment-17828944 ] sanghyeok An commented on KAFKA-15951: -- Gently ping, [~mjsax]. When you have free time, could you

[PR] MINOR: Add retry mechanism to EOS example [kafka]

2024-03-20 Thread via GitHub
fvaleri opened a new pull request, #15561: URL: https://github.com/apache/kafka/pull/15561 In the initial EOS example, a retry logic was implemented within the `resetToLastCommittedPositions` method. During refactoring, this logic was removed becasue a poison pill prevented the example

Re: [PR] KAFKA-14752: Kafka examples improvements - processor changes [kafka]

2024-03-20 Thread via GitHub
fvaleri commented on code in PR #13516: URL: https://github.com/apache/kafka/pull/13516#discussion_r1531939832 ## examples/src/main/java/kafka/examples/ExactlyOnceMessageProcessor.java: ## @@ -81,111 +88,115 @@ public ExactlyOnceMessageProcessor(final String inputTopic,

Re: [PR] KAFKA-16381: add lock for KafkaMetric config getter [kafka]

2024-03-20 Thread via GitHub
vamossagar12 commented on PR #15550: URL: https://github.com/apache/kafka/pull/15550#issuecomment-2009204011 > So you mean only if the config(MetricConfig config) works, then we need to return the updated config, right? yes, that's correct. Any other thread should see the updated

Re: [PR] KAFKA-15949: Unify metadata.version format in log and error message [kafka]

2024-03-20 Thread via GitHub
FrankYang0529 commented on code in PR #15505: URL: https://github.com/apache/kafka/pull/15505#discussion_r1531943054 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -139,7 +139,7 @@ object StorageTool extends Logging { action(storeTrue())

Re: [PR] KAFKA-16318 : add javafoc for kafka metric [kafka]

2024-03-20 Thread via GitHub
chia7712 commented on PR #15483: URL: https://github.com/apache/kafka/pull/15483#issuecomment-2009231142 the failed tests are shown below, and they pass on my local ```script ./gradlew cleanTest :tools:test --tests ListConsumerGroupTest.testListConsumerGroupsWithTypesClassicProtocol

Re: [PR] KAFKA-15807: Added support for compression of metrics (KIP-714) [kafka]

2024-03-20 Thread via GitHub
chia7712 commented on code in PR #15148: URL: https://github.com/apache/kafka/pull/15148#discussion_r1531889679 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryUtils.java: ## @@ -175,16 +182,44 @@ public static boolean

Re: [PR] MINOR: Add retry mechanism to EOS example [kafka]

2024-03-20 Thread via GitHub
fvaleri commented on PR #15561: URL: https://github.com/apache/kafka/pull/15561#issuecomment-2009370898 To make it easier to review, I'm adding the output of the new example behavior with 1 partition, 1 processor, max.poll.records = 1, and forcing random exceptions. ```sh $

[jira] [Commented] (KAFKA-15736) KRaft support in PlaintextConsumerTest

2024-03-20 Thread Rory (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828892#comment-17828892 ] Rory commented on KAFKA-15736: -- Hi [~sameert], I think KRaft support is in place for this class, if I am

Re: [PR] KAFKA-15950: Serialize broker heartbeat requests [kafka]

2024-03-20 Thread via GitHub
soarez commented on code in PR #14903: URL: https://github.com/apache/kafka/pull/14903#discussion_r1531683586 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -197,11 +197,17 @@ class BrokerLifecycleManagerTest { result } - def

Re: [PR] KAFKA-15950: Serialize broker heartbeat requests [kafka]

2024-03-20 Thread via GitHub
soarez commented on code in PR #14903: URL: https://github.com/apache/kafka/pull/14903#discussion_r1531683014 ## core/src/test/scala/unit/kafka/server/BrokerLifecycleManagerTest.scala: ## @@ -254,33 +261,38 @@ class BrokerLifecycleManagerTest { @Test def

Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]

2024-03-20 Thread via GitHub
nizhikov commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2009033688 Done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-14589 Tuple2 replaced with Map.Entry [kafka]

2024-03-20 Thread via GitHub
chia7712 commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2009028276 @nizhikov This is unrelated to KAFKA-14589, so please use "MINOR:" instead of "KAFKA-14589" :) -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-14589 Tuple2 replaced with Map.Entry [kafka]

2024-03-20 Thread via GitHub
nizhikov commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2009012349 This PR is follow-up for #14471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-20 Thread via GitHub
nizhikov commented on PR #14471: URL: https://github.com/apache/kafka/pull/14471#issuecomment-2009012039 @chia7712 Please, take a look - https://github.com/apache/kafka/pull/15560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] KAFKA-14589 Tuple2 replaced with Map.Entry [kafka]

2024-03-20 Thread via GitHub
nizhikov opened a new pull request, #15560: URL: https://github.com/apache/kafka/pull/15560 `Tuple2` replaced with SDK `Map.Entry` and `SimleImmutableEntry`. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage

[jira] [Commented] (KAFKA-16385) Segment is rolled before segment.ms or segment.bytes breached

2024-03-20 Thread Kuan Po Tseng (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828654#comment-17828654 ] Kuan Po Tseng commented on KAFKA-16385: --- {quote} [~brandboat] , are you clear what you should do

[jira] [Resolved] (KAFKA-15989) Upgrade existing generic group to consumer group

2024-03-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-15989. - Fix Version/s: 3.8.0 Resolution: Fixed > Upgrade existing generic group to consumer

[jira] [Resolved] (KAFKA-15763) Group Coordinator should not deliver new assignment before previous one is acknowledged

2024-03-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15763?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-15763. - Resolution: Won't Fix We went with another approach. > Group Coordinator should not deliver

[jira] [Resolved] (KAFKA-16313) Offline group protocol migration

2024-03-20 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16313?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16313. - Fix Version/s: 3.8.0 Assignee: Dongnuo Lyu Resolution: Fixed > Offline group

Re: [PR] KAFKA-16313: Offline group protocol migration (reopened) [kafka]

2024-03-20 Thread via GitHub
dajac merged PR #15546: URL: https://github.com/apache/kafka/pull/15546 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-20 Thread via GitHub
chia7712 commented on PR #14471: URL: https://github.com/apache/kafka/pull/14471#issuecomment-2008956850 > The only issue I can see is naming. Map.Entry has getKey, getValue for first and second values in pair which sets some kind of relation between values for me. While Tuple2 just

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-20 Thread via GitHub
nizhikov commented on PR #14471: URL: https://github.com/apache/kafka/pull/14471#issuecomment-2008956417 @chia7712 @jolshan @mimaison @tledkov Guys, thank you for a help with this PR! -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-20 Thread via GitHub
chia7712 merged PR #14471: URL: https://github.com/apache/kafka/pull/14471 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-20 Thread via GitHub
nizhikov commented on PR #14471: URL: https://github.com/apache/kafka/pull/14471#issuecomment-2008931321 @chia7712 I tried to perform Tuple2 -> Map.Entry substitution. The only issue I can see is naming. `Map.Entry` has `getKey`, `getValue` for first and second values in pair

Re: [PR] KAFKA-15853: Move KafkaConfig properties definition out of core [kafka]

2024-03-20 Thread via GitHub
nizhikov commented on PR #15501: URL: https://github.com/apache/kafka/pull/15501#issuecomment-2008920265 @OmniaGM > Start doing this but will be continue this after the Kafka Summit London. Great! Don't hesitate to ask for assistance if you need any help. -- This is an

Re: [PR] KAFKA-16222: KRaft Migration: Incorrect default user-principal quota after migration [kafka]

2024-03-20 Thread via GitHub
showuon commented on PR #15481: URL: https://github.com/apache/kafka/pull/15481#issuecomment-2008904600 Backedport to 3.7 and 3.6. @omkreddy , FYI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (KAFKA-16222) KRaft Migration: Incorrect default user-principal quota after migration

2024-03-20 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-16222. --- Resolution: Fixed > KRaft Migration: Incorrect default user-principal quota after migration >

Re: [PR] KAFKA-14589 ConsumerGroupCommand rewritten in java [kafka]

2024-03-20 Thread via GitHub
chia7712 commented on PR #14471: URL: https://github.com/apache/kafka/pull/14471#issuecomment-2008792236 @nizhikov thanks for all efforts! Please file PR to address follow-up, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] KAFKA-16222: KRaft Migration: Incorrect default user-principal quota after migration [kafka]

2024-03-20 Thread via GitHub
showuon merged PR #15481: URL: https://github.com/apache/kafka/pull/15481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16222: KRaft Migration: Incorrect default user-principal quota after migration [kafka]

2024-03-20 Thread via GitHub
showuon commented on PR #15481: URL: https://github.com/apache/kafka/pull/15481#issuecomment-2008777656 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-16385) Segment is rolled before segment.ms or segment.bytes breached

2024-03-20 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17828620#comment-17828620 ] Luke Chen commented on KAFKA-16385: --- Thanks for the response Jun, and thanks for the summary,

Re: [PR] MINOR: Update upgrade docs to refer 3.6.2 version [kafka]

2024-03-20 Thread via GitHub
omkreddy closed pull request #15554: MINOR: Update upgrade docs to refer 3.6.2 version URL: https://github.com/apache/kafka/pull/15554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific