[jira] [Updated] (KAFKA-16412) Uncreated topics is considered as created topics

2024-03-22 Thread gendong1 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gendong1 updated KAFKA-16412: - Attachment: kafkaServer1.out > Uncreated topics is considered as created topics >

[jira] [Updated] (KAFKA-16412) Uncreated topics is considered as created topics

2024-03-22 Thread gendong1 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gendong1 updated KAFKA-16412: - Attachment: kafkaServer2.out > Uncreated topics is considered as created topics >

[jira] [Updated] (KAFKA-16412) Uncreated topics is considered as created topics

2024-03-22 Thread gendong1 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gendong1 updated KAFKA-16412: - Attachment: kafkaServer3.out > Uncreated topics is considered as created topics >

[jira] [Updated] (KAFKA-16412) Uncreated topics is considered as created topics

2024-03-22 Thread gendong1 (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16412?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] gendong1 updated KAFKA-16412: - Attachment: AnotherClientOutput.txt > Uncreated topics is considered as created topics >

[jira] [Created] (KAFKA-16412) Uncreated topics is considered as created topics

2024-03-22 Thread gendong1 (Jira)
gendong1 created KAFKA-16412: Summary: Uncreated topics is considered as created topics Key: KAFKA-16412 URL: https://issues.apache.org/jira/browse/KAFKA-16412 Project: Kafka Issue Type: Bug

Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]

2024-03-22 Thread via GitHub
chia7712 commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2016331846 ``` ./gradlew cleanTest :tools:test --tests MetadataQuorumCommandTest.testDescribeQuorumReplicationSuccessful --tests MetadataQuorumCommandTest.testDescribeQuorumStatusSuccessful

Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]

2024-03-22 Thread via GitHub
chia7712 commented on PR #15560: URL: https://github.com/apache/kafka/pull/15560#issuecomment-2016331977 @nizhikov thanks for this refactor! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Tuple2 replaced with Map.Entry [kafka]

2024-03-22 Thread via GitHub
chia7712 merged PR #15560: URL: https://github.com/apache/kafka/pull/15560 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-16381) use volatile to guarantee KafkaMetric#config visibility across threads

2024-03-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16381. Fix Version/s: 3.8.0 Resolution: Fixed > use volatile to guarantee

[jira] [Updated] (KAFKA-16381) use volatile to guarantee KafkaMetric#config visibility across threads

2024-03-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16381?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16381: --- Summary: use volatile to guarantee KafkaMetric#config visibility across threads (was: We

Re: [PR] KAFKA-16381 use volatile to guarantee KafkaMetric#config visibility across threads [kafka]

2024-03-22 Thread via GitHub
chia7712 merged PR #15550: URL: https://github.com/apache/kafka/pull/15550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16381: add lock for KafkaMetric config getter [kafka]

2024-03-22 Thread via GitHub
chia7712 commented on PR #15550: URL: https://github.com/apache/kafka/pull/15550#issuecomment-2016328832 ``` ./gradlew cleanTest :trogdor:test --tests CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated :connect:mirror:test --tests

[jira] [Commented] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830026#comment-17830026 ] Chia-Ping Tsai commented on KAFKA-16310: will resolve this jira after [~johnnyhsu] update

[jira] [Updated] (KAFKA-16310) ListOffsets doesn't report the offset with maxTimestamp anymore

2024-03-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16310: --- Fix Version/s: 3.6.2 3.8.0 > ListOffsets doesn't report the offset with

[jira] [Resolved] (KAFKA-16341) Fix un-compressed records

2024-03-22 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16341?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16341. Resolution: Fixed > Fix un-compressed records > - > >

Re: [PR] KAFKA-16341: [backport] fix the LogValidator for non-compressed type (#15476) [kafka]

2024-03-22 Thread via GitHub
chia7712 merged PR #15570: URL: https://github.com/apache/kafka/pull/15570 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16341: [backport] fix the LogValidator for non-compressed type (#15476) [kafka]

2024-03-22 Thread via GitHub
chia7712 commented on PR #15570: URL: https://github.com/apache/kafka/pull/15570#issuecomment-2016323661 run the failed tests and all pass on my local: ``` ./gradlew cleanTest :streams:test --tests EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore

[jira] [Commented] (KAFKA-16409) kafka-delete-records / DeleteRecordsCommand should use standard exception handling

2024-03-22 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830025#comment-17830025 ] PoAn Yang commented on KAFKA-16409: --- Hi [~gharris1727], may I take this? I have create a PR for it.

[PR] KAFKA-16409: DeleteRecordsCommand should use standard exception handling [kafka]

2024-03-22 Thread via GitHub
FrankYang0529 opened a new pull request, #15586: URL: https://github.com/apache/kafka/pull/15586 When an exception is thrown in kafka-delete-records, it propagates through `main` to the JVM, producing the following message: ``` bin/kafka-delete-records.sh --bootstrap-server

[PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-03-22 Thread via GitHub
Phuc-Hong-Tran opened a new pull request, #15585: URL: https://github.com/apache/kafka/pull/15585 * Fully implemented subscription using Pattern for AsyncKafkaConsumer. * Enabled related tests for subscription using Pattern in PlaintextConsumerTest. -- This is an automated message

Re: [PR] KAFKA-16408: Fix handling of '--version' or '--help' for GetOffsetShell [kafka]

2024-03-22 Thread via GitHub
wernerdv commented on PR #15583: URL: https://github.com/apache/kafka/pull/15583#issuecomment-2016305593 @gharris1727 Hello. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (KAFKA-15951) MissingSourceTopicException should include topic names

2024-03-22 Thread sanghyeok An (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830019#comment-17830019 ] sanghyeok An commented on KAFKA-15951: -- [~mjsax] Hi! I have a tiny PR issue and suggestion for

[jira] [Commented] (KAFKA-16349) ShutdownableThread fails build by calling Exit with race condition

2024-03-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17830010#comment-17830010 ] Greg Harris commented on KAFKA-16349: - I did some more exploration here. # Some of the "exit 1"

[jira] [Updated] (KAFKA-16411) Correctly migrate default client quota entities in KRaft migration

2024-03-22 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-16411: - Fix Version/s: 3.6.2 Affects Version/s: 3.4.0 Priority: Blocker (was:

[PR] KAFKA-16411: Correctly migrate default client quota entities [kafka]

2024-03-22 Thread via GitHub
cmccabe opened a new pull request, #15584: URL: https://github.com/apache/kafka/pull/15584 KAFKA-16222 fixed a bug whereby we didn't undo the name mangling used on client quota entity names stored in ZooKeeper. However, it incorrectly claimed to fix the handling of default client quota

[jira] [Updated] (KAFKA-16411) Correctly migrate default client quota entities in KRaft migration

2024-03-22 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-16411: - Summary: Correctly migrate default client quota entities in KRaft migration (was: Correctly

[jira] [Created] (KAFKA-16411) Correctly migrate default entities in KRaft migration

2024-03-22 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-16411: Summary: Correctly migrate default entities in KRaft migration Key: KAFKA-16411 URL: https://issues.apache.org/jira/browse/KAFKA-16411 Project: Kafka Issue

[jira] [Updated] (KAFKA-16222) KRaft Migration: desanitize entity name when migrate client quotas

2024-03-22 Thread Colin McCabe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Colin McCabe updated KAFKA-16222: - Summary: KRaft Migration: desanitize entity name when migrate client quotas (was: KRaft

[PR] KAFKA-16408: Fix handling of '--version' or '--help' for GetOffsetShell [kafka]

2024-03-22 Thread via GitHub
wernerdv opened a new pull request, #15583: URL: https://github.com/apache/kafka/pull/15583 Added call CommandLineUtils#maybePrintHelpOrVersion before check required args. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ]

[jira] [Updated] (KAFKA-16409) kafka-delete-records / DeleteRecordsCommand should use standard exception handling

2024-03-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-16409: Component/s: tools > kafka-delete-records / DeleteRecordsCommand should use standard exception >

[jira] [Created] (KAFKA-16410) kafka-leader-election / LeaderElectionCommand doesn't set exit code on error

2024-03-22 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16410: --- Summary: kafka-leader-election / LeaderElectionCommand doesn't set exit code on error Key: KAFKA-16410 URL: https://issues.apache.org/jira/browse/KAFKA-16410 Project:

[jira] [Updated] (KAFKA-16409) kafka-delete-records / DeleteRecordsCommand should use standard exception handling

2024-03-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-16409: Labels: newbie (was: ) > kafka-delete-records / DeleteRecordsCommand should use standard

[jira] [Created] (KAFKA-16409) kafka-delete-records / DeleteRecordsCommand should use standard exception handling

2024-03-22 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16409: --- Summary: kafka-delete-records / DeleteRecordsCommand should use standard exception handling Key: KAFKA-16409 URL: https://issues.apache.org/jira/browse/KAFKA-16409

[jira] [Assigned] (KAFKA-16408) kafka-get-offsets / GetOffsetShell doesn't handle --version or --help

2024-03-22 Thread Dmitry Werner (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dmitry Werner reassigned KAFKA-16408: - Assignee: Dmitry Werner > kafka-get-offsets / GetOffsetShell doesn't handle --version

[jira] [Updated] (KAFKA-16408) kafka-get-offsets / GetOffsetShell doesn't handle --version or --help

2024-03-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-16408: Description: The kafka-get-offsets script was moved to Java for the 3.7.0 release. It now

[jira] [Updated] (KAFKA-16408) kafka-get-offsets / GetOffsetShell doesn't handle --version or --help

2024-03-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-16408: Description: The kafka-get-offsets script was moved to Java for the 3.7.0 release. It now

[jira] [Created] (KAFKA-16408) kafka-get-offsets / GetOffsetShell doesn't handle --version or --help

2024-03-22 Thread Greg Harris (Jira)
Greg Harris created KAFKA-16408: --- Summary: kafka-get-offsets / GetOffsetShell doesn't handle --version or --help Key: KAFKA-16408 URL: https://issues.apache.org/jira/browse/KAFKA-16408 Project: Kafka

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on PR #15579: URL: https://github.com/apache/kafka/pull/15579#issuecomment-2015850725 Thanks both for the feedback. I pushed the changes addressing all the suggestions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536165527 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void

[PR] MINOR: ensure LocalLogManagerTestEnv is closed in QuorumControllerTest [kafka]

2024-03-22 Thread via GitHub
cmccabe opened a new pull request, #15582: URL: https://github.com/apache/kafka/pull/15582 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536155967 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1070,29 +1081,27 @@ private SortedSet

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536155669 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536155346 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void

[jira] [Updated] (KAFKA-16407) ForeignKey INNER join ignores FK change when its previous value is null

2024-03-22 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-16407: Affects Version/s: 3.6.1 3.5.2 3.4.1

[jira] [Created] (KAFKA-16407) ForeignKey INNER join ignores FK change when its previous value is null

2024-03-22 Thread Ayoub Omari (Jira)
Ayoub Omari created KAFKA-16407: --- Summary: ForeignKey INNER join ignores FK change when its previous value is null Key: KAFKA-16407 URL: https://issues.apache.org/jira/browse/KAFKA-16407 Project: Kafka

[jira] [Updated] (KAFKA-16407) ForeignKey INNER join ignores FK change when its previous value is null

2024-03-22 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16407?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-16407: Attachment: InnerFKJoinTest.scala JsonSerde.scala > ForeignKey INNER join ignores

[jira] [Updated] (KAFKA-16394) ForeignKey LEFT join propagates null value on foreignKey change

2024-03-22 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-16394: Description: We have two topics : _left-topic[String, LeftRecord]_ and _right-topic[String,

[jira] [Updated] (KAFKA-16394) ForeignKey LEFT join propagates null value on foreignKey change

2024-03-22 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayoub Omari updated KAFKA-16394: Description: We have two topics : _left-topic[String, LeftRecord]_ and _right-topic[String,

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536040639 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-22 Thread via GitHub
squah-confluent commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1536046613 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -1365,6 +1365,16 @@ object GroupMetadataManager { def

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536040639 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536040639 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1536040639 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-22 Thread via GitHub
jolshan commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1536023033 ## core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala: ## @@ -1365,6 +1365,16 @@ object GroupMetadataManager { def

Re: [PR] KAFKA-16314: Introducing the AbortableTransactionException [kafka]

2024-03-22 Thread via GitHub
jolshan merged PR #15486: URL: https://github.com/apache/kafka/pull/15486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-22 Thread via GitHub
squah-confluent commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1536004118 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java: ## @@ -1899,8 +1900,19 @@ public void

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-22 Thread via GitHub
jolshan commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1536002502 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -504,12 +518,6 @@ public void

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-22 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1535995024 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-22 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1535992897 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-22 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1535992897 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-22 Thread via GitHub
VedarthConfluent commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1535989381 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-22 Thread via GitHub
dajac commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1535988740 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -495,6 +502,7 @@ private void transitionTo(

Re: [PR] KAFKA-16374; High watermark updates should have a higher priority [kafka]

2024-03-22 Thread via GitHub
jolshan commented on code in PR #15534: URL: https://github.com/apache/kafka/pull/15534#discussion_r1535986083 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntime.java: ## @@ -495,6 +502,7 @@ private void transitionTo(

[jira] [Commented] (KAFKA-16354) FinalizedFeatureChangeListenerTest should use mocked latches

2024-03-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829950#comment-17829950 ] Greg Harris commented on KAFKA-16354: - Hi [~yangpoan] Thank you for looking into it more, it sounds

[jira] [Resolved] (KAFKA-16354) FinalizedFeatureChangeListenerTest should use mocked latches

2024-03-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris resolved KAFKA-16354. - Resolution: Won't Fix > FinalizedFeatureChangeListenerTest should use mocked latches >

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-22 Thread via GitHub
dajac commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1535973164 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorServiceTest.java: ## @@ -1899,8 +1900,19 @@ public void

Re: [PR] KAFKA-16406: Splitting consumer integration test [kafka]

2024-03-22 Thread via GitHub
lianetm commented on PR #15535: URL: https://github.com/apache/kafka/pull/15535#issuecomment-2015603774 Hey @lucasbru , could you take a look if you have a chance? No changes in logic other than the addition I pointed out (see comment above). With this split I've been getting the run times

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
dajac commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1535964547 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void revokeAndAssign(LocalAssignment

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1535917633 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void

[jira] [Created] (KAFKA-16406) Split long-running consumer integration test

2024-03-22 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-16406: -- Summary: Split long-running consumer integration test Key: KAFKA-16406 URL: https://issues.apache.org/jira/browse/KAFKA-16406 Project: Kafka Issue Type:

Re: [PR] KAFKA-16224: Do not retry committing if topic or partition deleted [kafka]

2024-03-22 Thread via GitHub
cadonna commented on PR #15581: URL: https://github.com/apache/kafka/pull/15581#issuecomment-2015538043 @lianetm Could you please have a look at this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] KAFKA-16375: Fix for rejoin while reconciling [kafka]

2024-03-22 Thread via GitHub
lianetm commented on code in PR #15579: URL: https://github.com/apache/kafka/pull/15579#discussion_r1535917633 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java: ## @@ -1010,49 +1015,55 @@ private void

[PR] KAFKA-16224: Do not retry committing if topic or partition deleted [kafka]

2024-03-22 Thread via GitHub
cadonna opened a new pull request, #15581: URL: https://github.com/apache/kafka/pull/15581 Current logic for auto-committing offsets when partitions are revoked will retry continuously when getting UNKNOWN_TOPIC_OR_PARTITION, leading to the member not completing the revocation in time.

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-22 Thread via GitHub
squah-confluent commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1535903580 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -830,7 +830,11 @@ class ReplicaManager(val config: KafkaConfig, val customException

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-22 Thread via GitHub
artemlivshits commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1535865337 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -830,7 +830,11 @@ class ReplicaManager(val config: KafkaConfig, val customException =

Re: [PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-22 Thread via GitHub
philipnee commented on PR #15576: URL: https://github.com/apache/kafka/pull/15576#issuecomment-2015459852 Thanks @vamossagar12 - You can either create a new jira ticket for fixing these connectors or using the existing tickets. Maybe we should create a new ticket for new connector

[jira] [Assigned] (KAFKA-16405) Mismatch assignment error when running consumer rolling upgrade system tests

2024-03-22 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16405?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reassigned KAFKA-16405: -- Assignee: Philip Nee > Mismatch assignment error when running consumer rolling upgrade

Re: [PR] KAFKA-16271: Upgrade consumer_rolling_upgrade_test.py [kafka]

2024-03-22 Thread via GitHub
philipnee commented on PR #15578: URL: https://github.com/apache/kafka/pull/15578#issuecomment-2015454839 @lucasbru - thanks. See KAFKA-16405 for the failing tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Created] (KAFKA-16405) Mismatch assignment error when running consumer rolling upgrade system tests

2024-03-22 Thread Philip Nee (Jira)
Philip Nee created KAFKA-16405: -- Summary: Mismatch assignment error when running consumer rolling upgrade system tests Key: KAFKA-16405 URL: https://issues.apache.org/jira/browse/KAFKA-16405 Project:

Re: [PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-22 Thread via GitHub
vamossagar12 commented on PR #15576: URL: https://github.com/apache/kafka/pull/15576#issuecomment-2015385828 @philipnee , thanks .ok will continue. Yeah I can send out a pr next week for this. -- This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-16398) mirror-maker2 running into OOM while filtering (dropping) high number of messages

2024-03-22 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829913#comment-17829913 ] Greg Harris commented on KAFKA-16398: - Hi [~srivignesh] I'm sorry you're having difficulties with

Re: [PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-22 Thread via GitHub
philipnee commented on PR #15576: URL: https://github.com/apache/kafka/pull/15576#issuecomment-2015334416 @vamossagar12 - Hey - The connector test still requires a bit of parametrization on the connector side. If you feel like you have the bandwidth to handle this feel free to continue

Re: [PR] KAFKA-16272: Update connect_distributed_test.py to support KIP-848’s group protocol config [kafka]

2024-03-22 Thread via GitHub
philipnee commented on PR #15576: URL: https://github.com/apache/kafka/pull/15576#issuecomment-2015330638 Hey @kirktrue - Thanks for the review. I didn't put in the parameters because these tests don't configure the consumer directly. I think if can modify the connector to use the latest

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-22 Thread via GitHub
gharris1727 commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1535731883 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -226,59 +223,51 @@ public void

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-22 Thread via GitHub
gharris1727 commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1535731883 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -226,59 +223,51 @@ public void

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-22 Thread via GitHub
gharris1727 commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1535731883 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -226,59 +223,51 @@ public void

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-22 Thread via GitHub
gharris1727 commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1535727231 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -726,21 +683,21 @@ public void testAccessors() throws

[jira] [Commented] (KAFKA-16275) Update kraft_upgrade_test.py to support KIP-848’s group protocol config

2024-03-22 Thread Lucas Brutschy (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17829893#comment-17829893 ] Lucas Brutschy commented on KAFKA-16275: You could start a new consumer after the upgrade, but

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-22 Thread via GitHub
ahmedsobeh commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1535694321 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -726,21 +683,21 @@ public void testAccessors() throws

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-22 Thread via GitHub
ahmedsobeh commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1535665054 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -773,40 +730,34 @@ public void

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-22 Thread via GitHub
ahmedsobeh commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1535654142 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -226,59 +223,51 @@ public void

Re: [PR] KAFKA-16084: Simplify and deduplicate standalone herder test mocking [kafka]

2024-03-22 Thread via GitHub
ahmedsobeh commented on code in PR #15389: URL: https://github.com/apache/kafka/pull/15389#discussion_r1535652744 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -726,21 +683,21 @@ public void testAccessors() throws

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-22 Thread via GitHub
squah-confluent commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1535637194 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -921,7 +921,10 @@ private[group] class GroupCoordinator( ): Unit = {

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-22 Thread via GitHub
squah-confluent commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1535637194 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -921,7 +921,10 @@ private[group] class GroupCoordinator( ): Unit = {

Re: [PR] KAFKA-16386: Convert NETWORK_EXCEPTIONs from KIP-890 transaction verification [kafka]

2024-03-22 Thread via GitHub
squah-confluent commented on code in PR #15559: URL: https://github.com/apache/kafka/pull/15559#discussion_r1535636055 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -831,6 +831,7 @@ class ReplicaManager(val config: KafkaConfig, error match {

Re: [PR] KAFKA-16276: Update transactions_test.py to support KIP-848’s group protocol config [kafka]

2024-03-22 Thread via GitHub
lucasbru merged PR #15567: URL: https://github.com/apache/kafka/pull/15567 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16274: Update replica_scale_test.py to support KIP-848’s group protocol config [kafka]

2024-03-22 Thread via GitHub
lucasbru merged PR #15577: URL: https://github.com/apache/kafka/pull/15577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-22 Thread via GitHub
mimaison commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1535628671 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-22 Thread via GitHub
mimaison commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1535628671 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

Re: [PR] KAFKA-15882: Add nightly docker image scan job [kafka]

2024-03-22 Thread via GitHub
mimaison commented on code in PR #15013: URL: https://github.com/apache/kafka/pull/15013#discussion_r1535628671 ## .github/workflows/docker_scan.yml: ## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

  1   2   >