OmniaGM commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1541328444
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java:
##
@@ -925,10 +926,13 @@ static Map adminConfigs(String connName,
// Ignore
OmniaGM commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1541293009
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -580,8 +601,15 @@ private Map
instantiateConfigProviders(Map providerClassName =
OmniaGM commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1541313630
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -1502,13 +1502,23 @@ public static Map filterMap(final Map map, final Predicate
[
https://issues.apache.org/jira/browse/KAFKA-16432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matej Sprysl resolved KAFKA-16432.
--
Resolution: Fixed
Fixed by using the same StreamsBuilder for both streams.
> KStreams:
[
https://issues.apache.org/jira/browse/KAFKA-15915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Katona reassigned KAFKA-15915:
-
Assignee: Andras Katona
> Flaky test - testUnrecoverableError - ProducerIdManagerTest
[
https://issues.apache.org/jira/browse/KAFKA-16432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831415#comment-17831415
]
Matej Sprysl commented on KAFKA-16432:
--
Update:
The issue was probably caused by creating the
[
https://issues.apache.org/jira/browse/KAFKA-16432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matej Sprysl updated KAFKA-16432:
-
Description:
h2. Code:
{code:java}
final StreamsBuilder builder = new StreamsBuilder();
final
brandboat opened a new pull request, #15611:
URL: https://github.com/apache/kafka/pull/15611
The method `ApiVersionsResponse#filterApis(RecordVersion,
ApiMessageType.ListenerType)` is only used in test, we can remove it and invoke
the other one.
### Committer Checklist (excluded
mjsax commented on code in PR #15597:
URL: https://github.com/apache/kafka/pull/15597#discussion_r1541286490
##
clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java:
##
@@ -58,6 +61,8 @@ public class AbstractConfig {
private final ConfigDef
Matej Sprysl created KAFKA-16432:
Summary: KStreams: Joining KStreams and GlobalKTable requires a
state store
Key: KAFKA-16432
URL: https://issues.apache.org/jira/browse/KAFKA-16432
Project: Kafka
chia7712 merged PR #15075:
URL: https://github.com/apache/kafka/pull/15075
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022937094
```
./gradlew cleanTest :tools:test --tests
GetOffsetShellTest.testTopicPatternArgWithPartitionsArg :trogdor:test --tests
CoordinatorTest.testTaskRequestWithOldStartMsGetsUpdated
[
https://issues.apache.org/jira/browse/KAFKA-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831383#comment-17831383
]
Satish Duggana commented on KAFKA-15265:
KIP-956 is approved. [~abhijeetkumar] is working on
mimaison commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1541117312
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -49,6 +49,7 @@ import
org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S
KevinZTW opened a new pull request, #15610:
URL: https://github.com/apache/kafka/pull/15610
Currently, when we using `kafka-reassign-partitions` to move the log
directory, the output only indicates which replica's movement has successfully
started.
This PR propose to show more
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -49,6 +49,7 @@ import
org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S
chia7712 commented on PR #15588:
URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022675724
@jeqo I should merge code after getting your reviews :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -49,6 +49,7 @@ import
org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -49,6 +49,7 @@ import
org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1541032203
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -49,6 +49,7 @@ import
org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1541026665
##
core/src/main/scala/kafka/server/ZkAdminManager.scala:
##
@@ -49,6 +49,7 @@ import
org.apache.kafka.common.security.scram.internals.{ScramCredentialUtils, S
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022645115
@chia7712 CI are ready and seems OK for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831327#comment-17831327
]
Jorge Esteban Quilcate Otoya commented on KAFKA-16414:
--
Just got the new messages
[
https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831324#comment-17831324
]
Jorge Esteban Quilcate Otoya commented on KAFKA-16414:
--
As well, I'm +1 on
brandboat commented on PR #15588:
URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022630053
Thank you @showuon , @jeqo . I will address the comments in the new JIRA
https://issues.apache.org/jira/browse/KAFKA-16429
--
This is an automated message from the Apache Git
nizhikov commented on PR #15575:
URL: https://github.com/apache/kafka/pull/15575#issuecomment-2022624611
@OmniaGM Can you, please, merge with latest trunk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1540968019
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
jeqo commented on PR #15588:
URL: https://github.com/apache/kafka/pull/15588#issuecomment-2022623732
Sorry for also being later with the review.
Changes look good to me overall, though I'd also add a mention on these
configs that: `log.roll` configs are ignored (as well as the mentioned
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1540992038
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
OmniaGM commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1540968019
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
sjhajharia commented on PR #15609:
URL: https://github.com/apache/kafka/pull/15609#issuecomment-2022517844
Thanks for the review @soarez
I have updated the variable names in the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
mimaison commented on code in PR #15569:
URL: https://github.com/apache/kafka/pull/15569#discussion_r1540885105
##
server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java:
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
lucasbru merged PR #15576:
URL: https://github.com/apache/kafka/pull/15576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lucasbru commented on PR #15525:
URL: https://github.com/apache/kafka/pull/15525#issuecomment-2022475971
> @lucasbru - Thanks again for reviewing the PR. Sorry about the
misinterpretation on short circuting logic so here I updated the
beginningOrEndOffsets API. It seems like the right
lucasbru commented on code in PR #15525:
URL: https://github.com/apache/kafka/pull/15525#discussion_r1540879732
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ListOffsetsEvent.java:
##
@@ -25,22 +25,15 @@
import java.util.Map;
/**
- * Event for
mimaison commented on code in PR #15558:
URL: https://github.com/apache/kafka/pull/15558#discussion_r1540866456
##
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorUtils.java:
##
@@ -320,4 +322,19 @@ static void createCompactedTopic(String topicName, short
[
https://issues.apache.org/jira/browse/KAFKA-16323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831291#comment-17831291
]
Chia-Ping Tsai commented on KAFKA-16323:
It seems to me the root cause could be the `spy` does
soarez commented on PR #15605:
URL: https://github.com/apache/kafka/pull/15605#issuecomment-2022452207
I think there is a JIRA already for this flaky test:
[KAFKA-15915](https://issues.apache.org/jira/browse/KAFKA-15915)
If this is correct, then you should update the PR title to refer to
[
https://issues.apache.org/jira/browse/KAFKA-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-16103:
--
Assignee: Lucas Brutschy (was: Lianet Magrans)
> Review client logic for triggering
viktorsomogyi commented on PR #15605:
URL: https://github.com/apache/kafka/pull/15605#issuecomment-2022430965
@akatona84 I think this one exceeds the "minor" commit, I think you should
create a jira ticket for this. Also, please add a description of your change
that reveals the thinking
viktorsomogyi merged PR #15580:
URL: https://github.com/apache/kafka/pull/15580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
akatona84 commented on code in PR #15605:
URL: https://github.com/apache/kafka/pull/15605#discussion_r1540748533
##
core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala:
##
@@ -38,19 +38,57 @@ import org.mockito.Mockito.{mock, when}
import
[
https://issues.apache.org/jira/browse/KAFKA-16365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16365:
Priority: Critical (was: Major)
> AssignmentsManager mismanages completion notifications
>
[
https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16297:
Component/s: jbod
> Race condition while promoting future replica can lead to partition
>
[
https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16297:
Affects Version/s: 3.7.0
> Race condition while promoting future replica can lead to partition
>
[
https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez updated KAFKA-16297:
Fix Version/s: 3.7.1
> Race condition while promoting future replica can lead to partition
>
[
https://issues.apache.org/jira/browse/KAFKA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez resolved KAFKA-16404.
-
Resolution: Not A Bug
Same as KAFKA-16403, this only failed once. It was likely the result of a
[
https://issues.apache.org/jira/browse/KAFKA-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831244#comment-17831244
]
Igor Soarez commented on KAFKA-16403:
-
The test only failed the one time. I agree it was likely a
[
https://issues.apache.org/jira/browse/KAFKA-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez resolved KAFKA-16403.
-
Resolution: Not A Bug
> Flaky test
>
[
https://issues.apache.org/jira/browse/KAFKA-16353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16353.
-
Resolution: Fixed
> Offline protocol migration integration tests
>
dajac merged PR #15492:
URL: https://github.com/apache/kafka/pull/15492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831228#comment-17831228
]
Stanislav Spiridonov edited comment on KAFKA-16382 at 3/27/24 8:57 AM:
[
https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831228#comment-17831228
]
Stanislav Spiridonov edited comment on KAFKA-16382 at 3/27/24 8:55 AM:
[
https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831230#comment-17831230
]
Stanislav Spiridonov commented on KAFKA-16382:
--
BTW if you take the wrong scenario from
dajac commented on PR #15446:
URL: https://github.com/apache/kafka/pull/15446#issuecomment-2022239076
@jeffkbkim There are failed tests that look related. Could you check them
please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
urbandan commented on code in PR #15605:
URL: https://github.com/apache/kafka/pull/15605#discussion_r1540691777
##
core/src/test/scala/unit/kafka/coordinator/transaction/ProducerIdManagerTest.scala:
##
@@ -38,19 +38,57 @@ import org.mockito.Mockito.{mock, when}
import
[
https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831228#comment-17831228
]
Stanislav Spiridonov commented on KAFKA-16382:
--
Wait, why is it not a bug? I have the real
chia7712 commented on code in PR #15075:
URL: https://github.com/apache/kafka/pull/15075#discussion_r1540685634
##
server/src/main/java/org/apache/kafka/server/config/ZkConfig.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
showuon merged PR #15561:
URL: https://github.com/apache/kafka/pull/15561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
nizhikov commented on code in PR #15075:
URL: https://github.com/apache/kafka/pull/15075#discussion_r1540643481
##
server/src/main/java/org/apache/kafka/server/config/ZkConfig.java:
##
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
[
https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831208#comment-17831208
]
Matthias J. Sax commented on KAFKA-16382:
-
An application reset, does not touch the output
nizhikov commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022177651
@chia7712 Conflicts resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
sjhajharia commented on PR #15609:
URL: https://github.com/apache/kafka/pull/15609#issuecomment-2022175562
Requesting review from @jolshan (reviewer of the parent PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-16404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831202#comment-17831202
]
Matthias J. Sax commented on KAFKA-16404:
-
Sounds like an env issue to me. I would propose to
[
https://issues.apache.org/jira/browse/KAFKA-16403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831201#comment-17831201
]
Matthias J. Sax commented on KAFKA-16403:
-
Sound like an env issue but not a bug to me? I would
sjhajharia opened a new pull request, #15609:
URL: https://github.com/apache/kafka/pull/15609
This is a follow-up to [this](https://github.com/apache/kafka/pull/15486) PR
which introduced the new `ABORTABLE_TRANSACTION` error as a part of KIP-890
efforts. However on further discussion, we
[
https://issues.apache.org/jira/browse/KAFKA-15558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831197#comment-17831197
]
Andrew Schofield commented on KAFKA-15558:
--
I was referring to the way that there is
showuon commented on PR #15521:
URL: https://github.com/apache/kafka/pull/15521#issuecomment-2022115867
Will try to review it this week or next week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
showuon commented on PR #15522:
URL: https://github.com/apache/kafka/pull/15522#issuecomment-2022115723
Will check it this week or next.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-15715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
johndoe reassigned KAFKA-15715:
---
Assignee: (was: johndoe)
> KRaft support in UpdateFeaturesTest
>
Gao Fei created KAFKA-16430:
---
Summary: The group-metadata-manager thread is always in a loading
state and occupies one CPU, unable to end.
Key: KAFKA-16430
URL: https://issues.apache.org/jira/browse/KAFKA-16430
[
https://issues.apache.org/jira/browse/KAFKA-16411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-16411:
--
Fix Version/s: 3.8.0
3.7.1
> Correctly migrate default client quota entities in
[
https://issues.apache.org/jira/browse/KAFKA-16428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Manikumar updated KAFKA-16428:
--
Fix Version/s: 3.6.2
3.8.0
3.7.1
> Fix bug where config change
chia7712 commented on PR #15075:
URL: https://github.com/apache/kafka/pull/15075#issuecomment-2022073236
@nizhikov Could you please rebase it again? Sorry for late review :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-16414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831186#comment-17831186
]
Chia-Ping Tsai commented on KAFKA-16414:
[~ckamal] Thanks for nice sharing. As you have digged
[
https://issues.apache.org/jira/browse/KAFKA-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17831182#comment-17831182
]
Chia-Ping Tsai commented on KAFKA-16429:
[~brandboat] Please feel free to un-assign this jira :)
[
https://issues.apache.org/jira/browse/KAFKA-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16429:
---
Parent: KAFKA-16385
Issue Type: Sub-task (was: Improvement)
> Enhance all configs
[
https://issues.apache.org/jira/browse/KAFKA-16429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16429:
--
Assignee: Kuan Po Tseng
> Enhance all configs which can trigger rolling of new
Chia-Ping Tsai created KAFKA-16429:
--
Summary: Enhance all configs which can trigger rolling of new
segment
Key: KAFKA-16429
URL: https://issues.apache.org/jira/browse/KAFKA-16429
Project: Kafka
101 - 179 of 179 matches
Mail list logo
