Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1548103258 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) {

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-02 Thread via GitHub
gharris1727 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2032352619 Hi @chia7712 This [test is disabled in

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1548067397 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) { return

[jira] [Updated] (KAFKA-16418) Review/split long-running admin client integration tests

2024-04-02 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16418?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-16418: --- Summary: Review/split long-running admin client integration tests (was: Split long-running

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1548061572 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) {

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547986293 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +420,15 @@ private String[] addBootstrapServer(String... args) { return

[jira] [Updated] (KAFKA-16297) Race condition while promoting future replica can lead to partition unavailability.

2024-04-02 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16297: Fix Version/s: 3.8.0 > Race condition while promoting future replica can lead to partition >

[jira] [Updated] (KAFKA-16234) Log directory failure re-creates partitions in another logdir automatically

2024-04-02 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16234: Fix Version/s: 3.8.0 > Log directory failure re-creates partitions in another logdir

[jira] [Updated] (KAFKA-16082) Broker recreates reassigned partition after logdir failure

2024-04-02 Thread Igor Soarez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Soarez updated KAFKA-16082: Fix Version/s: 3.8.0 > Broker recreates reassigned partition after logdir failure >

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-02 Thread via GitHub
lianetm commented on PR #15585: URL: https://github.com/apache/kafka/pull/15585#issuecomment-2032154288 Hey @Phuc-Hong-Tran , any update on this one? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-16039: RecordHeaders supports the addAll method [kafka]

2024-04-02 Thread via GitHub
funky-eyes commented on PR #15034: URL: https://github.com/apache/kafka/pull/15034#issuecomment-2032110132 > @funky-eyes let me know if you got a chance to review my comment Hello, thank you for your reminder. I submitted this PR to make the functions of recordheader and list

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547934887 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) { return

Re: [PR] KAFKA-16123: KStreamKStreamJoinProcessor does not drop late records. [kafka]

2024-04-02 Thread via GitHub
mjsax commented on PR #15189: URL: https://github.com/apache/kafka/pull/15189#issuecomment-2032098989 Just merged https://github.com/apache/kafka/pull/15510 -- can we move forward with this PR (maybe by rebasing it to see if any tests break?)? -- This is an automated message from the

Re: [PR] KAFKA-15417 Sloppy bug: moved the outerJoinBreak-flags out of the loop [kafka]

2024-04-02 Thread via GitHub
mjsax commented on PR #15510: URL: https://github.com/apache/kafka/pull/15510#issuecomment-2032092184 Thanks for the fix @VictorvandenHoven! Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15417 Sloppy bug: moved the outerJoinBreak-flags out of the loop [kafka]

2024-04-02 Thread via GitHub
mjsax merged PR #15510: URL: https://github.com/apache/kafka/pull/15510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16316: Configure reprocessing with addGlobalStateStore [kafka]

2024-04-02 Thread via GitHub
mjsax commented on code in PR #15619: URL: https://github.com/apache/kafka/pull/15619#discussion_r1543277915 ## streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java: ## @@ -596,7 +597,9 @@ public synchronized StreamsBuilder addGlobalStore(final StoreBuilder s

[jira] [Updated] (KAFKA-16458) Add contains method in KeyValue store interface

2024-04-02 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16458: Labels: needs-kip (was: ) > Add contains method in KeyValue store interface >

[jira] [Created] (KAFKA-16458) Add contains method in KeyValue store interface

2024-04-02 Thread Ayoub Omari (Jira)
Ayoub Omari created KAFKA-16458: --- Summary: Add contains method in KeyValue store interface Key: KAFKA-16458 URL: https://issues.apache.org/jira/browse/KAFKA-16458 Project: Kafka Issue Type:

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547789497 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547632847 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -343,7 +346,7 @@ public void

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547690392 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -69,6 +69,9 @@ public static void setup() {

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547690392 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -69,6 +69,9 @@ public static void setup() {

[PR] KAFKA-16457 Useless import class [kafka]

2024-04-02 Thread via GitHub
rykovsi opened a new pull request, #15646: URL: https://github.com/apache/kafka/pull/15646 [KAFKA-16457](https://issues.apache.org/jira/browse/KAFKA-16457) Useless import class in SslConfigs.java import org.apache.kafka.common.config.ConfigDef.Type; ...

[jira] [Created] (KAFKA-16457) Useless import class

2024-04-02 Thread Svyatoslav (Jira)
Svyatoslav created KAFKA-16457: -- Summary: Useless import class Key: KAFKA-16457 URL: https://issues.apache.org/jira/browse/KAFKA-16457 Project: Kafka Issue Type: Task Components:

[jira] [Updated] (KAFKA-16457) Useless import class

2024-04-02 Thread Svyatoslav (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Svyatoslav updated KAFKA-16457: --- Description: Useless import class in SslConfigs.java   {code:java} import

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547632847 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -343,7 +346,7 @@ public void

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547609546 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -331,7 +334,7 @@ public void

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-02 Thread via GitHub
nizhikov commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2031645630 Hello @chia7712 This is first PR that moves parts of ConfigCommand to java. It contains rewritten `ConfigCommandIntegrationTest`. Please, take a look. -- This is an automated

[PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-02 Thread via GitHub
nizhikov opened a new pull request, #15645: URL: https://github.com/apache/kafka/pull/15645 This is first part of #15417 refactoring. PR intention - split big PR in parts to simplify review. PR contains `ConfigCommandIntegrationTest` rewritten in java ### Committer Checklist

[jira] [Resolved] (KAFKA-16148) Implement GroupMetadataManager#onUnloaded

2024-04-02 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-16148. - Fix Version/s: 3.8.0 Resolution: Fixed > Implement GroupMetadataManager#onUnloaded >

Re: [PR] KAFKA-16148: Implement GroupMetadataManager#onUnloaded [kafka]

2024-04-02 Thread via GitHub
dajac merged PR #15446: URL: https://github.com/apache/kafka/pull/15446 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-16039: RecordHeaders supports the addAll method [kafka]

2024-04-02 Thread via GitHub
vamossagar12 commented on PR #15034: URL: https://github.com/apache/kafka/pull/15034#issuecomment-2031571928 @funky-eyes let me know if you got a chance to review my comment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [WIP] KAFKA-16383: fix flaky IdentityReplicationIntegrationTest .testReplicateFromLatest [kafka]

2024-04-02 Thread via GitHub
vamossagar12 commented on PR #15556: URL: https://github.com/apache/kafka/pull/15556#issuecomment-2031549949 @johnnychhsu ,for completeness sake, the issue with private constructor related noise in the logs is being fixed in this PR: https://github.com/apache/kafka/pull/15642 -- This is

Re: [PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
vamossagar12 commented on code in PR #15642: URL: https://github.com/apache/kafka/pull/15642#discussion_r1547506743 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectorValidationIntegrationTest.java: ## @@ -343,7 +346,7 @@ public void

[jira] [Commented] (KAFKA-16456) Can't stop kafka debug logs

2024-04-02 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833062#comment-17833062 ] Chia-Ping Tsai commented on KAFKA-16456: the debug message "Received {} response from node {}

[PR] Add s390x support to CI [kafka]

2024-04-02 Thread via GitHub
Prashant-Jagtap opened a new pull request, #15644: URL: https://github.com/apache/kafka/pull/15644 We would like to add support for s390x to existing CI. Adding s390x build stage which uses Jdk21 and Scala 2.13. Verified the build and tests locally. ### Committer Checklist

[jira] [Created] (KAFKA-16456) Can't stop kafka debug logs

2024-04-02 Thread Rajan Choudhary (Jira)
Rajan Choudhary created KAFKA-16456: --- Summary: Can't stop kafka debug logs Key: KAFKA-16456 URL: https://issues.apache.org/jira/browse/KAFKA-16456 Project: Kafka Issue Type: Bug

[PR] MINOR: fix typo [kafka]

2024-04-02 Thread via GitHub
appchemist opened a new pull request, #15643: URL: https://github.com/apache/kafka/pull/15643 fix typo amd -> and ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547302390 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547303323 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -94,15 +101,47 @@ private void setUp() { } } +private void

Re: [PR] KAFKA-15729: Add KRaft support in GetOffsetShellTest [kafka]

2024-04-02 Thread via GitHub
Owen-CH-Leung commented on code in PR #15489: URL: https://github.com/apache/kafka/pull/15489#discussion_r1547302390 ## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ## @@ -391,4 +447,15 @@ private String[] addBootstrapServer(String... args) {

Re: [PR] MINOR: AbstractConfig cleanup Part 2 [kafka]

2024-04-02 Thread via GitHub
chia7712 commented on PR #15639: URL: https://github.com/apache/kafka/pull/15639#issuecomment-2031262693 @gharris1727 just curious. How do you notice that incorrect changes? Are there failed tests related to #15597? -- This is an automated message from the Apache Git Service. To respond

[PR] KAFKA-16068: Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors [kafka]

2024-04-02 Thread via GitHub
Joker-5 opened a new pull request, #15642: URL: https://github.com/apache/kafka/pull/15642 Use TestPlugins in ConnectorValidationIntegrationTest to silence plugin scanning errors ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

Re: [PR] MINOR: enhance kafka-reassign-partitions command output [kafka]

2024-04-02 Thread via GitHub
showuon merged PR #15610: URL: https://github.com/apache/kafka/pull/15610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] MINOR: enhance kafka-reassign-partitions command output [kafka]

2024-04-02 Thread via GitHub
showuon commented on PR #15610: URL: https://github.com/apache/kafka/pull/15610#issuecomment-2031206526 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

<    1   2