clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1553223975
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -309,49 +300,49 @@ public void
chia7712 commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039276618
sorry :(
the correct PR is #15663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nizhikov commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039274380
@chia7712 Can you, please, double check PR number? It sees #15664 not
related to my changes
--
This is an automated message from the Apache Git Service.
To respond to the message,
chia7712 commented on PR #15666:
URL: https://github.com/apache/kafka/pull/15666#issuecomment-2039262579
@nizhikov thanks for this patch. let's wait for #15664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-16471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834200#comment-17834200
]
Gaurav Narula commented on KAFKA-16471:
---
[~chia7712] I'm not well versed with the backporting
vamossagar12 commented on PR #15653:
URL: https://github.com/apache/kafka/pull/15653#issuecomment-2039212910
The purpose of this PR was to validate a certain behaviour with circular
dependency (explained
[here](https://github.com/apache/kafka/pull/15642#discussion_r1551420344)) and
as
vamossagar12 closed pull request #15653: Test PR without the circular
dependency code
URL: https://github.com/apache/kafka/pull/15653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
vamossagar12 commented on PR #15034:
URL: https://github.com/apache/kafka/pull/15034#issuecomment-2039191732
The instructions for signing up are
[here](https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals#KafkaImprovementProposals-GettingStarted).
--
This is an
nizhikov commented on code in PR #15645:
URL: https://github.com/apache/kafka/pull/15645#discussion_r1553114805
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
nizhikov commented on code in PR #15645:
URL: https://github.com/apache/kafka/pull/15645#discussion_r1553114426
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
nizhikov opened a new pull request, #15667:
URL: https://github.com/apache/kafka/pull/15667
This PR adds junit-platform.properties to core and removes outdated constant
from scala code.
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or
nizhikov opened a new pull request, #15666:
URL: https://github.com/apache/kafka/pull/15666
This PR adds `junit-platform.properties` to `tools` and removes outdated
constant from java code.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
nizhikov commented on code in PR #15645:
URL: https://github.com/apache/kafka/pull/15645#discussion_r1553060780
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
chia7712 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039097741
> I think the class file size increasing is indeed a direct drawback after
adding -parameter option because we'll include all the parameters into .class
files. I'd like to know if
showuon commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039081866
Sorry @FrankYang0529 , I saw this:
https://stackoverflow.com/questions/44067477/drawbacks-of-javac-parameters-flag
> Briefly, the stated reasons to make parameter names optional are
FrankYang0529 commented on code in PR #15663:
URL: https://github.com/apache/kafka/pull/15663#discussion_r1553003195
##
build.gradle:
##
@@ -270,6 +270,7 @@ subprojects {
options.compilerArgs << "-Xlint:-serial"
options.compilerArgs << "-Xlint:-try"
PoAn Yang created KAFKA-16476:
-
Summary: Check whether TestInfo contains correct parameter name
Key: KAFKA-16476
URL: https://issues.apache.org/jira/browse/KAFKA-16476
Project: Kafka
Issue Type:
FrankYang0529 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039041551
> > However, this way still doesn't check whether "parameter name" is
correct. Probably, we can give another check is that if display name contains
zk or kraft, but not quorum,
chia7712 commented on code in PR #15663:
URL: https://github.com/apache/kafka/pull/15663#discussion_r1552981401
##
build.gradle:
##
@@ -270,6 +270,7 @@ subprojects {
options.compilerArgs << "-Xlint:-serial"
options.compilerArgs << "-Xlint:-try"
chia7712 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039025377
> However, this way still doesn't check whether "parameter name" is correct.
Probably, we can give another check is that if display name contains zk or
kraft, but not quorum, then
FrankYang0529 commented on PR #15663:
URL: https://github.com/apache/kafka/pull/15663#issuecomment-2039019880
> 2. How could we avoid this things happen in the future? Like adding some
checking before the tests startup or something? Do you have any idea?
I don't have a good idea to
101 - 121 of 121 matches
Mail list logo
