chia7712 commented on code in PR #15645:
URL: https://github.com/apache/kafka/pull/15645#discussion_r1568266095
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -0,0 +1,232 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
showuon commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1568266346
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -801,8 +803,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri
soarez commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2060431133
Thanks @chia7712 I'll have another look at this later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-16572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837974#comment-17837974
]
PoAn Yang commented on KAFKA-16572:
---
Hi [~chia7712], I'm interested in this issue. May I take it?
chia7712 commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2060429559
@soarez it would be great to get your reviews before merging it :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/KAFKA-16572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16572:
--
Assignee: PoAn Yang (was: Chia-Ping Tsai)
> allow defining number of disks per
[
https://issues.apache.org/jira/browse/KAFKA-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16559.
Fix Version/s: 3.8.0
Resolution: Fixed
> allow defining number of disks per broker
Chia-Ping Tsai created KAFKA-16572:
--
Summary: allow defining number of disks per broker in ClusterTest
Key: KAFKA-16572
URL: https://issues.apache.org/jira/browse/KAFKA-16572
Project: Kafka
chia7712 merged PR #15730:
URL: https://github.com/apache/kafka/pull/15730
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1568241856
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogSegment.java:
##
@@ -800,8 +802,23 @@ private Void deleteTypeIfExists(StorageAction delete, Stri
kamalcph commented on PR #15631:
URL: https://github.com/apache/kafka/pull/15631#issuecomment-2060333550
@junrao
Gentle reminder. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
LQXshane commented on code in PR #14446:
URL: https://github.com/apache/kafka/pull/14446#discussion_r1568199337
##
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##
@@ -685,6 +685,47 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final
LQXshane commented on code in PR #14446:
URL: https://github.com/apache/kafka/pull/14446#discussion_r1568199214
##
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##
@@ -685,6 +685,47 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final
LQXshane commented on code in PR #14446:
URL: https://github.com/apache/kafka/pull/14446#discussion_r1568198123
##
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##
@@ -685,6 +685,47 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final
LQXshane commented on PR #14446:
URL: https://github.com/apache/kafka/pull/14446#issuecomment-2060317790
@mjsax It's Shay. Taking this one up from my personal account. My personal
account don't have the permission to push to the other account, is it okay to
create a new PR here
LQXshane opened a new pull request, #15740:
URL: https://github.com/apache/kafka/pull/15740
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
LQXshane commented on code in PR #14446:
URL: https://github.com/apache/kafka/pull/14446#discussion_r1568173605
##
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##
@@ -685,6 +685,47 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final
LQXshane commented on code in PR #14446:
URL: https://github.com/apache/kafka/pull/14446#discussion_r1568173605
##
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##
@@ -685,6 +685,47 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final
lianetm closed pull request #15738: KAFKA-16566: Fix consumer static membership
system test with new protocol
URL: https://github.com/apache/kafka/pull/15738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
bachmanity1 commented on PR #14399:
URL: https://github.com/apache/kafka/pull/14399#issuecomment-2060259657
Hi @cmccabe
Given that this PR is merged now, is it possible to dynamically update
controller configs using `kafka-configs.sh`?
I've tested this locally but couldn't
lianetm commented on PR #15738:
URL: https://github.com/apache/kafka/pull/15738#issuecomment-2060248860
FYI, I've been getting successful runs with this change:
running:
`TC_PATHS="tests/kafkatest/tests/client/consumer_test.py::OffsetValidationTest.test_fencing_static_consumer"
bash
[
https://issues.apache.org/jira/browse/KAFKA-16467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837928#comment-17837928
]
ASF GitHub Bot commented on KAFKA-16467:
showuon commented on code in PR #596:
URL:
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1568044239
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {
void
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1568084297
##
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##
@@ -2117,6 +2117,20 @@ ListPartitionReassignmentsResponseData
lianetm commented on code in PR #15738:
URL: https://github.com/apache/kafka/pull/15738#discussion_r1568061403
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -348,13 +348,32 @@ def test_fencing_static_consumer(self,
num_conflict_consumers, fencing_stage, me
splett2 commented on code in PR #15685:
URL: https://github.com/apache/kafka/pull/15685#discussion_r1568050802
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -108,6 +103,43 @@ object StorageTool extends Logging {
}
}
+ def
showuon commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1568045423
##
core/src/test/scala/unit/kafka/log/LogManagerTest.scala:
##
@@ -413,7 +413,7 @@ class LogManagerTest {
assertEquals(numMessages * setSize / segmentBytes,
jolshan commented on PR #15739:
URL: https://github.com/apache/kafka/pull/15739#issuecomment-2060079351
Hmmm -- I ran the test and it is not working. I will debug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
splett2 commented on code in PR #15702:
URL: https://github.com/apache/kafka/pull/15702#discussion_r1568044239
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -2360,4 +2363,9 @@ void setNewNextWriteOffset(long newNextWriteOffset) {
void
jolshan opened a new pull request, #15739:
URL: https://github.com/apache/kafka/pull/15739
Added the check before the reassignment occurs and we start bouncing brokers.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
kirktrue commented on code in PR #15613:
URL: https://github.com/apache/kafka/pull/15613#discussion_r1568001935
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1388,6 +1393,31 @@ public void commitSync(Map offsets, Duration
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1568011957
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ClientSideAssignorBenchmark.java:
##
@@ -0,0 +1,256 @@
+/*
+ * Licensed to the Apache Software
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1568009821
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1568009691
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package
kirktrue commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1567992301
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -482,6 +482,15 @@ public long nextHeartbeatMs(final long
kirktrue commented on code in PR #15738:
URL: https://github.com/apache/kafka/pull/15738#discussion_r156796
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -348,13 +348,32 @@ def test_fencing_static_consumer(self,
num_conflict_consumers, fencing_stage, me
[
https://issues.apache.org/jira/browse/KAFKA-16571?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan reassigned KAFKA-16571:
--
Assignee: Justine Olshan
> reassign_partitions_test.bounce_brokers should wait for
[
https://issues.apache.org/jira/browse/KAFKA-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan updated KAFKA-16570:
---
Description:
When we want to fence a producer using the admin client, we send an
[
https://issues.apache.org/jira/browse/KAFKA-16570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837902#comment-17837902
]
Justine Olshan commented on KAFKA-16570:
cc: [~ChrisEgerton] [~showuon] [~tombentley] as author
David Mao created KAFKA-16571:
-
Summary: reassign_partitions_test.bounce_brokers should wait for
messages to be sent to every partition
Key: KAFKA-16571
URL: https://issues.apache.org/jira/browse/KAFKA-16571
Justine Olshan created KAFKA-16570:
--
Summary: FenceProducers API returns "unexpected error" when
successful
Key: KAFKA-16570
URL: https://issues.apache.org/jira/browse/KAFKA-16570
Project: Kafka
Ritika Reddy created KAFKA-16569:
Summary: Target Assignment Format Change
Key: KAFKA-16569
URL: https://issues.apache.org/jira/browse/KAFKA-16569
Project: Kafka
Issue Type: Sub-task
Ritika Reddy created KAFKA-16568:
Summary: Add JMH Benchmarks for assignor performance testing
Key: KAFKA-16568
URL: https://issues.apache.org/jira/browse/KAFKA-16568
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837892#comment-17837892
]
Francois Visconte commented on KAFKA-16511:
---
Here is for example one of the segments and
[ https://issues.apache.org/jira/browse/KAFKA-16511 ]
Francois Visconte deleted comment on KAFKA-16511:
---
was (Author: JIRAUSER288982):
>The issue might be due to the overlapping remote log segments after a new
>leader gets elected during
[ https://issues.apache.org/jira/browse/KAFKA-16511 ]
Francois Visconte deleted comment on KAFKA-16511:
---
was (Author: JIRAUSER288982):
Here is for example on one of the partition where I have the issue:
{code}
_zIcSPWGzlqLjUTFfw},
[
https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837891#comment-17837891
]
Francois Visconte commented on KAFKA-16511:
---
>The issue might be due to the overlapping remote
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16567:
Assignee: Walter Hernandez
> Add New Stream Metrics based on KIP-869
>
Walter Hernandez created KAFKA-16567:
Summary: Add New Stream Metrics based on KIP-869
Key: KAFKA-16567
URL: https://issues.apache.org/jira/browse/KAFKA-16567
Project: Kafka
Issue Type:
lianetm commented on PR #15738:
URL: https://github.com/apache/kafka/pull/15738#issuecomment-2059888686
Hey @lucasbru, could you take a look at this test fix? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
[
https://issues.apache.org/jira/browse/KAFKA-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16336:
Assignee: Walter Hernandez
> Remove Deprecated metric standby-process-ratio
>
[
https://issues.apache.org/jira/browse/KAFKA-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16336:
Assignee: (was: Walter Hernandez)
> Remove Deprecated metric
[
https://issues.apache.org/jira/browse/KAFKA-16511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837867#comment-17837867
]
Francois Visconte commented on KAFKA-16511:
---
Here is for example on one of the partition where
chia7712 commented on code in PR #15719:
URL: https://github.com/apache/kafka/pull/15719#discussion_r1567891428
##
core/src/main/java/kafka/server/builders/LogManagerBuilder.java:
##
@@ -55,6 +55,7 @@ public class LogManagerBuilder {
private Time time = Time.SYSTEM;
lianetm opened a new pull request, #15738:
URL: https://github.com/apache/kafka/pull/15738
Updating consumer system test that was failing with the new protocol,
related to static membership behaviour. The behaviour regarding static
consumers that join with conflicting group instance id is
chia7712 commented on code in PR #15714:
URL: https://github.com/apache/kafka/pull/15714#discussion_r1567861049
##
storage/src/test/java/org/apache/kafka/storage/internals/checkpoint/PartitionMetadataFileTest.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software
chia7712 commented on code in PR #15732:
URL: https://github.com/apache/kafka/pull/15732#discussion_r1567855363
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -391,13 +391,20 @@ void enqueueMetadataChangeEvent(
// Events
chia7712 commented on code in PR #15732:
URL: https://github.com/apache/kafka/pull/15732#discussion_r1567853719
##
metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java:
##
@@ -391,13 +391,20 @@ void enqueueMetadataChangeEvent(
// Events
[
https://issues.apache.org/jira/browse/KAFKA-16336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Walter Hernandez reassigned KAFKA-16336:
Assignee: Walter Hernandez
> Remove Deprecated metric standby-process-ratio
>
junrao commented on code in PR #15634:
URL: https://github.com/apache/kafka/pull/15634#discussion_r1567796843
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -282,15 +282,15 @@ class UnifiedLog(@volatile var logStartOffset: Long,
/**
* Update high watermark
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1567823511
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/KAFKA-16566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837826#comment-17837826
]
Lianet Magrans edited comment on KAFKA-16566 at 4/16/24 6:59 PM:
-
Hey
kirktrue opened a new pull request, #15737:
URL: https://github.com/apache/kafka/pull/15737
Checking that the `TopicPartition` is in assignment before attempting to
remove it.
Also added some logging and refactoring.
### Committer Checklist (excluded from commit message)
-
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1567815640
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/TargetAssignmentBuilderBenchmark.java:
##
@@ -0,0 +1,259 @@
+package
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1567812184
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1567812184
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1567812184
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,185 @@
+package
[
https://issues.apache.org/jira/browse/KAFKA-15250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837836#comment-17837836
]
Philip Nee commented on KAFKA-15250:
Added a testing branch under my fork:
[
https://issues.apache.org/jira/browse/KAFKA-16566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lianet Magrans updated KAFKA-16566:
---
Summary: Update consumer static membership fencing system test to support
new protocol
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1567794140
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/group_coordinator/AssignPartitionsMicroBenchmark.java:
##
@@ -0,0 +1,153 @@
+package
[
https://issues.apache.org/jira/browse/KAFKA-16566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837826#comment-17837826
]
Lianet Magrans edited comment on KAFKA-16566 at 4/16/24 6:34 PM:
-
Hey
kirktrue commented on PR #15723:
URL: https://github.com/apache/kafka/pull/15723#issuecomment-2059706910
@lianetm & @lucasbru—I've addressed your comments, and this is ready for
another review. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the
kirktrue commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1567791850
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/RequestState.java:
##
@@ -66,6 +67,7 @@ public RequestState(final LogContext logContext,
*
[
https://issues.apache.org/jira/browse/KAFKA-16566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837826#comment-17837826
]
Lianet Magrans edited comment on KAFKA-16566 at 4/16/24 6:31 PM:
-
Hey
[
https://issues.apache.org/jira/browse/KAFKA-16566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837826#comment-17837826
]
Lianet Magrans edited comment on KAFKA-16566 at 4/16/24 6:30 PM:
-
Hey
[
https://issues.apache.org/jira/browse/KAFKA-16566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837826#comment-17837826
]
Lianet Magrans commented on KAFKA-16566:
Hey [~ableegoldman], this is specific to the static
[
https://issues.apache.org/jira/browse/KAFKA-16566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17837820#comment-17837820
]
A. Sophie Blee-Goldman commented on KAFKA-16566:
I'm a bit confused – I thought we
Lianet Magrans created KAFKA-16566:
--
Summary: Update static membership fencing system test to support
new protocol
Key: KAFKA-16566
URL: https://issues.apache.org/jira/browse/KAFKA-16566
Project:
mimaison opened a new pull request, #15736:
URL: https://github.com/apache/kafka/pull/15736
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
OmniaGM commented on PR #15569:
URL: https://github.com/apache/kafka/pull/15569#issuecomment-2059643602
> Let's just let Omnia decides which PR she prefers doing first. Then we can
all review that PR, and once merged move onto the next one. This would avoid
unnecessary churn as I expect
cmccabe commented on PR #15735:
URL: https://github.com/apache/kafka/pull/15735#issuecomment-2059637927
Thanks, @mannoopj. Since this adds some new test cases beyond what was in
#15720, can you rebase your PR on trunk?
--
This is an automated message from the Apache Git Service.
To
mwesterby commented on PR #15733:
URL: https://github.com/apache/kafka/pull/15733#issuecomment-2059603416
@chia7712 Thanks again for the review. I've implemented all of your
suggested. Please let me know if you spot anything else I've missed.
--
This is an automated message from the
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567721679
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567721679
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this
[
https://issues.apache.org/jira/browse/KAFKA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16565:
--
Labels: consumer-threading-refactor kip-848-client-support system-tests
(was: )
>
[
https://issues.apache.org/jira/browse/KAFKA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True reassigned KAFKA-16565:
-
Assignee: Kirk True
> IncrementalAssignmentConsumerEventHandler throws error when attempting
Kirk True created KAFKA-16565:
-
Summary: IncrementalAssignmentConsumerEventHandler throws error
when attempting to remove a partition that isn't assigned
Key: KAFKA-16565
URL:
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567721679
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567721679
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this
kirktrue commented on code in PR #15723:
URL: https://github.com/apache/kafka/pull/15723#discussion_r1567722373
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/RequestStateTest.java:
##
@@ -48,4 +50,51 @@ public void testRequestStateSimple() {
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567721679
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -440,8 +440,12 @@ object StorageTool extends Logging {
"Use --ignore-formatted to ignore this
[
https://issues.apache.org/jira/browse/KAFKA-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16559:
--
Assignee: Gaurav Narula (was: Chia-Ping Tsai)
> allow defining number of disks per
[
https://issues.apache.org/jira/browse/KAFKA-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16559:
---
Summary: allow defining number of disks per broker in TestKitNodes (was:
Support to define
gaurav-narula commented on code in PR #15730:
URL: https://github.com/apache/kafka/pull/15730#discussion_r1567713128
##
core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
cmccabe merged PR #15720:
URL: https://github.com/apache/kafka/pull/15720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
cmccabe commented on PR #15720:
URL: https://github.com/apache/kafka/pull/15720#issuecomment-2059575247
Thanks, @johnnychhsu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 commented on code in PR #15730:
URL: https://github.com/apache/kafka/pull/15730#discussion_r1567703623
##
core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java:
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
chia7712 commented on code in PR #15730:
URL: https://github.com/apache/kafka/pull/15730#discussion_r1567700594
##
core/src/test/java/kafka/testkit/KafkaClusterTestKitTest.java:
##
@@ -0,0 +1,68 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
mwesterby commented on code in PR #15733:
URL: https://github.com/apache/kafka/pull/15733#discussion_r1567699963
##
core/src/test/scala/unit/kafka/tools/StorageToolTest.scala:
##
@@ -192,6 +192,66 @@ Found problem:
} finally Utils.delete(tempDir)
}
+ private def
[
https://issues.apache.org/jira/browse/KAFKA-16555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16555:
--
Issue Type: Bug (was: Task)
> Consumer's RequestState has incorrect logic to determine if inflight
>
1 - 100 of 232 matches
Mail list logo
