FrankYang0529 commented on code in PR #15679:
URL: https://github.com/apache/kafka/pull/15679#discussion_r1573623165
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java:
##
@@ -16,7 +16,15 @@
*/
package
[
https://issues.apache.org/jira/browse/KAFKA-16593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16593:
--
Assignee: TengYao Chi
> Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions
>
[
https://issues.apache.org/jira/browse/KAFKA-16593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839316#comment-17839316
]
TengYao Chi commented on KAFKA-16593:
-
I am able to handle this.
> Rewrite DeleteConsumerGroupsTest
[
https://issues.apache.org/jira/browse/KAFKA-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16549:
--
Assignee: charliecheng (was: Chia-Ping Tsai)
> suppress the warnings from
[
https://issues.apache.org/jira/browse/KAFKA-16549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839313#comment-17839313
]
charliecheng commented on KAFKA-16549:
--
I would like to work on this.
> suppress the warnings from
appchemist closed pull request #14765: MINOR: clear inFlightCorrelationId when
ConnectionState is changed to READY
URL: https://github.com/apache/kafka/pull/14765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
appchemist commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2067889913
@kirktrue, PTAL, thanks in advance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573570386
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -139,28 +159,46 @@ public Map nameTags() {
return tags;
}
-public ClusterConfig
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573473787
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
chia7712 commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573465932
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
throws
chia7712 commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573465553
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
throws
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573458599
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573458599
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573458599
##
clients/src/test/java/org/apache/kafka/common/network/SelectorTest.java:
##
@@ -1012,6 +1013,28 @@ public void testChannelCloseWhileProcessingReceives()
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1573452044
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -139,28 +159,46 @@ public Map nameTags() {
return tags;
}
-public ClusterConfig
emitskevich-blp commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573454740
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
lbradstreet opened a new pull request, #15764:
URL: https://github.com/apache/kafka/pull/15764
Minor javadoc argument rename to match the actual argument name in the
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chia7712 commented on code in PR #15762:
URL: https://github.com/apache/kafka/pull/15762#discussion_r1573448544
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -1256,6 +1256,15 @@ public static class ConfigKey {
public final boolean
[
https://issues.apache.org/jira/browse/KAFKA-16591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16591.
Fix Version/s: 3.8.0
Resolution: Fixed
> RaftClusterInvocationContext ought to
chia7712 merged PR #15763:
URL: https://github.com/apache/kafka/pull/15763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on code in PR #15722:
URL: https://github.com/apache/kafka/pull/15722#discussion_r1573445048
##
clients/src/main/java/org/apache/kafka/common/network/Selector.java:
##
@@ -1281,14 +1281,14 @@ private Meter createMeter(Metrics metrics, String
groupName, Map
chia7712 merged PR #15760:
URL: https://github.com/apache/kafka/pull/15760
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839274#comment-17839274
]
Ayoub Omari commented on KAFKA-16573:
-
Thanks [~mjsax], I am going to work on it in this case.
>
[
https://issues.apache.org/jira/browse/KAFKA-16573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ayoub Omari reassigned KAFKA-16573:
---
Assignee: Ayoub Omari
> Streams does not specify where a Serde is needed
>
brandboat commented on code in PR #15758:
URL: https://github.com/apache/kafka/pull/15758#discussion_r1573311578
##
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##
@@ -61,7 +61,7 @@ public void testParseAndValidateAddressesWithReverseLookup() {
brandboat commented on code in PR #15758:
URL: https://github.com/apache/kafka/pull/15758#discussion_r1573311578
##
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##
@@ -61,7 +61,7 @@ public void testParseAndValidateAddressesWithReverseLookup() {
brandboat commented on code in PR #15758:
URL: https://github.com/apache/kafka/pull/15758#discussion_r1573311578
##
clients/src/test/java/org/apache/kafka/clients/ClientUtilsTest.java:
##
@@ -61,7 +61,7 @@ public void testParseAndValidateAddressesWithReverseLookup() {
frankvicky commented on PR #15762:
URL: https://github.com/apache/kafka/pull/15762#issuecomment-2067692915
@chia7712 Could you please assist me with reviewing this pull request ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
frankvicky commented on PR #15763:
URL: https://github.com/apache/kafka/pull/15763#issuecomment-2067693222
@chia7712 Could you please assist me with reviewing this pull request ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
frankvicky opened a new pull request, #15763:
URL: https://github.com/apache/kafka/pull/15763
[KAFKA-16591](https://issues.apache.org/jira/browse/KAFKA-16591)
After closing all admins, we should also clear the queue of admins.
--
This is an automated message from the Apache Git
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839240#comment-17839240
]
Sal Sorrentino edited comment on KAFKA-16514 at 4/20/24 1:32 PM:
-
I
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839240#comment-17839240
]
Sal Sorrentino commented on KAFKA-16514:
I spent a little time looking at the code, and I really
Chia-Ping Tsai created KAFKA-16593:
--
Summary: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions
Key: KAFKA-16593
URL: https://issues.apache.org/jira/browse/KAFKA-16593
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16591:
--
Assignee: TengYao Chi
> RaftClusterInvocationContext ought to clear the admin queue
chia7712 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1573271296
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +118,57 @@ class AlterReplicaLogDirsRequestTest extends
BaseRequestTest {
[
https://issues.apache.org/jira/browse/KAFKA-16552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16552.
Fix Version/s: 3.8.0
Resolution: Fixed
> Create an internal config to control
chia7712 merged PR #15719:
URL: https://github.com/apache/kafka/pull/15719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839230#comment-17839230
]
TengYao Chi commented on KAFKA-16591:
-
I am able to handle this issue. :)
>
Sagar Rao created KAFKA-16592:
-
Summary: ConfigKey constructor update can break clients using it
Key: KAFKA-16592
URL: https://issues.apache.org/jira/browse/KAFKA-16592
Project: Kafka
Issue
Chia-Ping Tsai created KAFKA-16591:
--
Summary: RaftClusterInvocationContext ought to clear the admin
queue when stopping
Key: KAFKA-16591
URL: https://issues.apache.org/jira/browse/KAFKA-16591
chia7712 merged PR #15757:
URL: https://github.com/apache/kafka/pull/15757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839225#comment-17839225
]
Walter Hernandez commented on KAFKA-16567:
--
I noticed that KIP-869 not only introduced these
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17839225#comment-17839225
]
Walter Hernandez edited comment on KAFKA-16567 at 4/20/24 11:30 AM:
brandboat opened a new pull request, #15761:
URL: https://github.com/apache/kafka/pull/15761
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
soarez commented on code in PR #15744:
URL: https://github.com/apache/kafka/pull/15744#discussion_r1573203822
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -950,16 +980,47 @@ class ZkMigrationIntegrationTest {
chia7712 commented on PR #15760:
URL: https://github.com/apache/kafka/pull/15760#issuecomment-2067595468
@frankvicky thanks for this quick fix. I will check it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chia7712 commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1573199471
##
server/src/main/java/org/apache/kafka/server/config/KafkaSecurityConfigs.java:
##
@@ -0,0 +1,239 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
frankvicky commented on PR #15760:
URL: https://github.com/apache/kafka/pull/15760#issuecomment-2067594880
@chia7712 Hello, could you please assist me with reviewing this pull request
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
frankvicky opened a new pull request, #15760:
URL: https://github.com/apache/kafka/pull/15760
# MINOR: Fixed incorrect references for
SASL_OAUTHBEARER_SCOPE_CLAIM_NAME_DEFAULT and
SASL_OAUTHBEARER_SUB_CLAIM_NAME_DEFAULT
Change from:
```java
public static final String
MAHDI JAFARPUR created KAFKA-16590:
--
Summary: Current offset is higher than last offset
Key: KAFKA-16590
URL: https://issues.apache.org/jira/browse/KAFKA-16590
Project: Kafka
Issue Type:
chia7712 commented on code in PR #15656:
URL: https://github.com/apache/kafka/pull/15656#discussion_r1573179046
##
server/src/main/java/org/apache/kafka/server/config/KafkaSecurityConfigs.java:
##
@@ -0,0 +1,239 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/KAFKA-16588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16588:
--
Assignee: PoAn Yang (was: Chia-Ping Tsai)
> broker shutdown hangs when
52 matches
Mail list logo
