mimaison opened a new pull request, #15805:
URL: https://github.com/apache/kafka/pull/15805
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including
OmniaGM commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2077482581
Just rebase to fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2077461634
> @johnnychhsu Instead of removing them, could you make `MetadataLogConfig`
use those help methods?
> The reason these aren't used is because `MetadataLogConfig` signature uses
[
https://issues.apache.org/jira/browse/KAFKA-16568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16568.
-
Fix Version/s: 3.8.0
Resolution: Fixed
> Add JMH Benchmarks for assignor performance
dajac merged PR #15717:
URL: https://github.com/apache/kafka/pull/15717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison merged PR #15786:
URL: https://github.com/apache/kafka/pull/15786
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mimaison commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2077391342
Quite a few failures in the last CI run but it seems to be flaky tests as
none of the failures happened on all platforms. Merging to trunk
--
This is an automated message from the
lianetm commented on PR #15698:
URL: https://github.com/apache/kafka/pull/15698#issuecomment-2077313831
Thanks for the helpful comments @cadonna , all addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
lianetm commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1579555839
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##
@@ -469,19 +469,33 @@ public void resetTimer() {
lianetm commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1579555219
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {
jlprat merged PR #15054:
URL: https://github.com/apache/kafka/pull/15054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
raboof commented on PR #15054:
URL: https://github.com/apache/kafka/pull/15054#issuecomment-2077285239
> please ask a committer for review
Perhaps @jlprat? :innocent:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
AndrewJSchofield commented on code in PR #14111:
URL: https://github.com/apache/kafka/pull/14111#discussion_r1579542525
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java:
##
@@ -384,6 +389,32 @@ int attempts() {
return
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
[
https://issues.apache.org/jira/browse/KAFKA-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
yuzhou updated KAFKA-16621:
---
Description:
In connect-offsets topic:
the offsets wrote by connector, key is
yuzhou created KAFKA-16621:
--
Summary: Alter MirrorSourceConnector offsets dont work
Key: KAFKA-16621
URL: https://issues.apache.org/jira/browse/KAFKA-16621
Project: Kafka
Issue Type: Bug
AyoubOm commented on PR #15790:
URL: https://github.com/apache/kafka/pull/15790#issuecomment-2077173169
ping @mjsax
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
lianetm commented on PR #15750:
URL: https://github.com/apache/kafka/pull/15750#issuecomment-2077166262
Hey @phooq, having a `getDetails` that the inheritors override does achieve
the clarity I was looking for, sounds good.
--
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/KAFKA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gantigmaa Selenge updated KAFKA-16620:
--
Summary: KRaft quorum cannot be formed if all controllers are restarted at
the same
[
https://issues.apache.org/jira/browse/KAFKA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gantigmaa Selenge updated KAFKA-16620:
--
Description:
Controller quorum cannot seem to form at all after accidentally
[
https://issues.apache.org/jira/browse/KAFKA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gantigmaa Selenge reassigned KAFKA-16620:
-
Assignee: Luke Chen (was: Gantigmaa Selenge)
> Kraft quorum cannot be formed
[
https://issues.apache.org/jira/browse/KAFKA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gantigmaa Selenge reassigned KAFKA-16620:
-
Assignee: Gantigmaa Selenge
> Kraft quorum cannot be formed if all controllers
[
https://issues.apache.org/jira/browse/KAFKA-16620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gantigmaa Selenge updated KAFKA-16620:
--
Description:
Controller quorum cannot seem to form at all after accidentally
Gantigmaa Selenge created KAFKA-16620:
-
Summary: Kraft quorum cannot be formed if all controllers are
restarted at the same time
Key: KAFKA-16620
URL: https://issues.apache.org/jira/browse/KAFKA-16620
F Méthot created KAFKA-16619:
Summary: Unnecessary warning : "Loaded ZK migration state of NONE"
Key: KAFKA-16619
URL: https://issues.apache.org/jira/browse/KAFKA-16619
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
F Méthot updated KAFKA-16619:
-
Summary: Unnecessary controller warning : "Loaded ZK migration state of
NONE" (was: Unnecessary
[
https://issues.apache.org/jira/browse/KAFKA-16619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
F Méthot updated KAFKA-16619:
-
Description:
When we launch a fresh cluster of Kafka and Kraft Controller, no zookeeper
involved.
We
tinaselenge opened a new pull request, #15804:
URL: https://github.com/apache/kafka/pull/15804
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
dajac commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1579345622
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1336,6 +1422,233 @@ private
CoordinatorResult consumerGr
showuon commented on code in PR #15516:
URL: https://github.com/apache/kafka/pull/15516#discussion_r1579334152
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##
@@ -189,7 +189,7 @@ public RecordAccumulator(LogContext logContext,
AndrewJSchofield opened a new pull request, #15803:
URL: https://github.com/apache/kafka/pull/15803
The contract of KafkaConsumer.poll(Duration) says that it throws
InterruptException "if the calling thread is interrupted before or while this
function is called". The new KafkaConsumer
lucasbru commented on PR #15737:
URL: https://github.com/apache/kafka/pull/15737#issuecomment-2077011152
Do I understand it correctly that there is no functional change here, just
logging?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
lucasbru commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1579343899
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
cadonna commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1579221285
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -769,7 +730,8 @@ public void commitAsync(OffsetCommitCallback
lucasbru closed pull request #13876: KAFKA-10733: Clean up producer exceptions
URL: https://github.com/apache/kafka/pull/13876
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
showuon commented on PR #15690:
URL: https://github.com/apache/kafka/pull/15690#issuecomment-2076987711
@mimaison @soarez , PR updated. Please take a look when available. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1579328510
##
storage/src/test/java/org/apache/kafka/tiered/storage/actions/AlterLogDirAction.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1579328199
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -40,7 +92,72 @@ public interface TierStateMachine {
*/
PartitionFetchState
vamossagar12 commented on PR #13801:
URL: https://github.com/apache/kafka/pull/13801#issuecomment-2076983151
Thanks Chris! I ran through the scenarios in the test and I can see that it
handles the cases correctly. Regarding, `cancel` I don't see the future
returned from `set` being
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1579325677
##
core/src/test/scala/unit/kafka/server/TierStateMachineTest.scala:
##
@@ -153,12 +157,13 @@ class ReplicaFetcherTierStateMachineTest {
assertEquals(11L,
TaiJuWu commented on PR #13953:
URL: https://github.com/apache/kafka/pull/13953#issuecomment-2076900770
Hello @Kiriakos1998 ,
Do you still work on it?
If not, I want to take it over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
TaiJuWu commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2076894379
> @TaiJuWu could you please rebase code to include #15801
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chia7712 commented on code in PR #15645:
URL: https://github.com/apache/kafka/pull/15645#discussion_r1579206989
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+
showuon commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1579212500
##
storage/src/test/java/org/apache/kafka/tiered/storage/actions/AlterLogDirAction.java:
##
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
cadonna commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1579191646
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {
cadonna commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1579191646
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {
cadonna commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1579191646
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {
cadonna commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1579187392
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManagerTest.java:
##
@@ -164,6 +165,23 @@ public void testHeartbeatOnStartup() {
chia7712 commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2076761562
@TaiJuWu could you please rebase code to include
https://github.com/apache/kafka/pull/15801
--
This is an automated message from the Apache Git Service.
To respond to the message,
chia7712 commented on PR #15802:
URL: https://github.com/apache/kafka/pull/15802#issuecomment-2076758475
@FrankYang0529 We reuse the TOPIC and GROUP in the for-loop, and that could
be a issue if the cleanup of topic/group is not finished before running next
loop. Could you please use
[
https://issues.apache.org/jira/browse/KAFKA-16563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840723#comment-17840723
]
Luke Chen commented on KAFKA-16563:
---
[~davidarthur] [~akhileshchg] , could you take a look at this
showuon commented on PR #15732:
URL: https://github.com/apache/kafka/pull/15732#issuecomment-2076748016
@akhileshchg @mumrah @cmccabe , we need your comment on this. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
OmniaGM commented on PR #15797:
URL: https://github.com/apache/kafka/pull/15797#issuecomment-2076745737
> @OmniaGM Could you please rebase code to include fix (#15801)?
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 commented on PR #15645:
URL: https://github.com/apache/kafka/pull/15645#issuecomment-2076742667
> Can you, please, take a look?
sure! will take a look later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chia7712 commented on PR #15797:
URL: https://github.com/apache/kafka/pull/15797#issuecomment-2076741501
@OmniaGM Could you please rebase code to include fix
(https://github.com/apache/kafka/pull/15801)?
--
This is an automated message from the Apache Git Service.
To respond to the
nizhikov commented on PR #15645:
URL: https://github.com/apache/kafka/pull/15645#issuecomment-2076735612
Hello @chia7712
1. Reworked test to use ClusterTestExtensions
2. Extend `testExitWithNonZeroStatusOnUpdatingUnallowedConfig` to check in
kraft mode.
3. Other two test zk
lucasbru commented on PR #15723:
URL: https://github.com/apache/kafka/pull/15723#issuecomment-2076731964
Still looking good to me. I was waiting for the comments from philipp to be
commented on / addressed. Do you want to skip ahead an merge?
--
This is an automated message from the
lucasbru merged PR #15799:
URL: https://github.com/apache/kafka/pull/15799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/KAFKA-16212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840715#comment-17840715
]
Omnia Ibrahim commented on KAFKA-16212:
---
I believe that
dajac commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1579102085
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/ConsumerGroupSubscriptionModel.java:
##
@@ -0,0 +1,40 @@
+/*
+ * Licensed to the Apache
mimaison commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2076660780
Just rebased, let's run another build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
vamossagar12 commented on code in PR #15305:
URL: https://github.com/apache/kafka/pull/15305#discussion_r1579057875
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinatorTest.java:
##
@@ -533,6 +536,57 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dujian reassigned KAFKA-16584:
--
Assignee: dujian
> Make log processing summary configurable or debug
>
[
https://issues.apache.org/jira/browse/KAFKA-16582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840684#comment-17840684
]
dujian commented on KAFKA-16582:
hello [~ramiz.mehran]
I have reproduced this problem and found that
Phuc Hong Tran created KAFKA-16618:
--
Summary: Update the RPC for ConsumerGroupHeartbeatRequest and
ConsumerGroupHeartbeatResponse
Key: KAFKA-16618
URL: https://issues.apache.org/jira/browse/KAFKA-16618
FrankYang0529 opened a new pull request, #15802:
URL: https://github.com/apache/kafka/pull/15802
Use try-with-resource to create producer and make sure the producer send
record without error.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and
showuon merged PR #15801:
URL: https://github.com/apache/kafka/pull/15801
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
showuon commented on PR #15801:
URL: https://github.com/apache/kafka/pull/15801#issuecomment-2076455539
The thread leaking failed tests disappeared now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17840664#comment-17840664
]
Stanislav Spiridonov commented on KAFKA-16585:
--
# I can use the regular Processor, but as I
101 - 183 of 183 matches
Mail list logo
