chia7712 commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1585914471
##
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java:
##
@@ -25,21 +25,21 @@
import
chia7712 commented on code in PR #15838:
URL: https://github.com/apache/kafka/pull/15838#discussion_r1585911858
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -1541,6 +1541,36 @@ class KRaftClusterTest {
cluster.close()
}
}
+
+
mjsax commented on PR #15607:
URL: https://github.com/apache/kafka/pull/15607#issuecomment-2088000194
Can we update existing test to not use `Map` but `List` (as I mentioned on
the duplicate ticket https://issues.apache.org/jira/browse/KAFKA-16644) which
should expose the bug?
Need
[
https://issues.apache.org/jira/browse/KAFKA-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-16644.
-
Resolution: Duplicate
> FK join emits duplicate tombstone on left-side delete
>
mjsax commented on code in PR #15740:
URL: https://github.com/apache/kafka/pull/15740#discussion_r1585886754
##
streams/src/main/java/org/apache/kafka/streams/kstream/KStream.java:
##
@@ -685,6 +685,41 @@ KStream flatMapValues(final ValueMapper KStream flatMapValues(final
[
https://issues.apache.org/jira/browse/KAFKA-16650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16650:
--
Assignee: Kuan Po Tseng (was: Chia-Ping Tsai)
> add integration test for
[
https://issues.apache.org/jira/browse/KAFKA-16650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842542#comment-17842542
]
Kuan Po Tseng commented on KAFKA-16650:
---
May I take over this issue ? :)
> add integration test
AndrewJSchofield commented on code in PR #15803:
URL: https://github.com/apache/kafka/pull/15803#discussion_r1585852808
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##
@@ -1789,6 +1791,33 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842538#comment-17842538
]
Chia-Ping Tsai commented on KAFKA-16223:
[~cmukka20] Could we take over remaining tasks?
[
https://issues.apache.org/jira/browse/KAFKA-16027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842537#comment-17842537
]
Johnny Hsu commented on KAFKA-16027:
hey [~alexanderaghili] may I know if we have any updates on
FrankYang0529 commented on PR #15745:
URL: https://github.com/apache/kafka/pull/15745#issuecomment-2087904101
Hi @chia7712, thanks for the review. I address all comments and add some
test cases for ClusterConfig.
--
This is an automated message from the Apache Git Service.
To respond to
jsancio commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1580155319
##
clients/src/main/java/org/apache/kafka/common/record/ControlRecordType.java:
##
@@ -44,11 +44,15 @@ public enum ControlRecordType {
ABORT((short) 0),
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842530#comment-17842530
]
Kirk True commented on KAFKA-16637:
---
[~chickenchickenlove]—thanks for filing this. There are two
pasharik commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1585713585
##
core/src/main/scala/kafka/admin/AclCommand.scala:
##
@@ -115,8 +115,6 @@ object AclCommand extends Logging {
val aclBindings = acls.map(acl => new
pasharik commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1585704666
##
core/src/main/scala/kafka/admin/AclCommand.scala:
##
@@ -115,8 +115,6 @@ object AclCommand extends Logging {
val aclBindings = acls.map(acl => new
pasharik commented on PR #15830:
URL: https://github.com/apache/kafka/pull/15830#issuecomment-2087745006
> Hi @pasharik. Thanks for the change.
>
> > In the original implementation, listAcls() method was called directly
from addAcls() and removeAcls() methods, which caused a race
pasharik commented on code in PR #15830:
URL: https://github.com/apache/kafka/pull/15830#discussion_r1585704666
##
core/src/main/scala/kafka/admin/AclCommand.scala:
##
@@ -115,8 +115,6 @@ object AclCommand extends Logging {
val aclBindings = acls.map(acl => new
[
https://issues.apache.org/jira/browse/KAFKA-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842514#comment-17842514
]
Matthias J. Sax commented on KAFKA-16644:
-
Sorry. Wrong link. Fixed ->
[
https://issues.apache.org/jira/browse/KAFKA-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16644:
Description:
We introduced a regression bug in 3.7.0 release via KAFKA-14748. When a
cmccabe merged PR #15735:
URL: https://github.com/apache/kafka/pull/15735
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2087468237
@gharris1727 I do not have permission/write access to merge the PR. Will I
get permission/right to merge?
--
This is an automated message from the Apache Git Service.
To respond to
linu-shibu commented on PR #15620:
URL: https://github.com/apache/kafka/pull/15620#issuecomment-2087467721
> Test failures appear unrelated, there's a targeted
RemoteLogMetadataSerdeTest for this logic, and the storage tests appear to pass
for me locally.
Yes, in local, the tests
philipnee commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585558712
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java:
##
@@ -30,12 +29,7 @@ public abstract class CommitEvent extends
philipnee commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585179214
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1273,6 +1228,22 @@ private void close(Duration timeout, boolean
hachikuji commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1583487039
##
core/src/main/scala/kafka/raft/RaftManager.scala:
##
@@ -181,20 +181,12 @@ class KafkaRaftManager[T](
private val clientDriver = new
Chia-Ping Tsai created KAFKA-16650:
--
Summary: add integration test for Admin#abortTransaction
Key: KAFKA-16650
URL: https://issues.apache.org/jira/browse/KAFKA-16650
Project: Kafka
Issue
lianetm commented on PR #15640:
URL: https://github.com/apache/kafka/pull/15640#issuecomment-2087359722
Hey @kirktrue , thanks a lot for the PR, this is a big piece! I completed a
pass of all the non-test files, left some comments.
--
This is an automated message from the Apache Git
lianetm commented on PR #15640:
URL: https://github.com/apache/kafka/pull/15640#issuecomment-2087355371
> > Here I have a comment, I could not put at the right location in the code:
> >
> > On line 1362, in commitSync() the consumer waits on the commitFuture
with a timer. I think, it
cmccabe opened a new pull request, #15838:
URL: https://github.com/apache/kafka/pull/15838
Do not acquire the DynamicBrokerConfig lock in
DynamicBrokerConfig.removeReconfigurable. It's not necessary, because the list
that these functions are modifying is a thread-safe CopyOnWriteArrayList.
chia7712 commented on code in PR #15832:
URL: https://github.com/apache/kafka/pull/15832#discussion_r1585527416
##
core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java:
##
@@ -0,0 +1,213 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or
[
https://issues.apache.org/jira/browse/KAFKA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16649:
-
Summary: Remove lock from DynamicBrokerConfig.removeReconfigurable (was:
Fix potential
[
https://issues.apache.org/jira/browse/KAFKA-16649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-16649:
-
Description: Do not acquire the DynamicBrokerConfig lock in
Colin McCabe created KAFKA-16649:
Summary: Fix potential deadlock in DynamicBrokerConfig
Key: KAFKA-16649
URL: https://issues.apache.org/jira/browse/KAFKA-16649
Project: Kafka
Issue Type:
[
https://issues.apache.org/jira/browse/KAFKA-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842504#comment-17842504
]
A. Sophie Blee-Goldman edited comment on KAFKA-16644 at 4/30/24 8:57 PM:
[
https://issues.apache.org/jira/browse/KAFKA-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842504#comment-17842504
]
A. Sophie Blee-Goldman commented on KAFKA-16644:
[~mjsax] is KAFKA-14778 the correct
Cerchie commented on PR #14448:
URL: https://github.com/apache/kafka/pull/14448#issuecomment-2087251352
tagging @mjsax in for re-review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
chia7712 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1585496531
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -319,7 +302,10 @@ public Builder setPerBrokerProperties(Map> perBroke
}
public
chia7712 commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1585492894
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -91,9 +91,6 @@ public Stream
provideTestTemplateInvocationContex
ClusterTemplate
Cerchie commented on PR #14360:
URL: https://github.com/apache/kafka/pull/14360#issuecomment-2087132901
tagging @mjsax here, made some edits in response to the last roung
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Cerchie commented on code in PR #14360:
URL: https://github.com/apache/kafka/pull/14360#discussion_r1585489940
##
docs/streams/developer-guide/config-streams.html:
##
@@ -257,7 +258,12 @@ num.standby.replicasThe maximum number of records to buffer per
partition.
chia7712 commented on code in PR #15836:
URL: https://github.com/apache/kafka/pull/15836#discussion_r1585489570
##
core/src/main/scala/kafka/server/FetchSession.scala:
##
@@ -603,14 +619,16 @@ class FetchSessionCache(private val maxEntries: Int,
// A map containing sessions
TaiJuWu commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1585486875
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -91,9 +91,6 @@ public Stream
provideTestTemplateInvocationContex
ClusterTemplate
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842470#comment-17842470
]
Lianet Magrans edited comment on KAFKA-16637 at 4/30/24 8:25 PM:
-
Hey
TaiJuWu commented on code in PR #15800:
URL: https://github.com/apache/kafka/pull/15800#discussion_r1585486875
##
core/src/test/java/kafka/test/junit/ClusterTestExtensions.java:
##
@@ -91,9 +91,6 @@ public Stream
provideTestTemplateInvocationContex
ClusterTemplate
Cerchie commented on code in PR #14360:
URL: https://github.com/apache/kafka/pull/14360#discussion_r1585481048
##
docs/streams/developer-guide/config-streams.html:
##
@@ -257,7 +258,12 @@ num.standby.replicasThe maximum number of records to buffer per
partition.
chia7712 commented on PR #15055:
URL: https://github.com/apache/kafka/pull/15055#issuecomment-2087068199
> Okay I messed up the git a little here (still have much to learn), the
current trunk does exist on my
[Kafka-16027](https://issues.apache.org/jira/browse/KAFKA-16027) branch but I
chia7712 merged PR #15808:
URL: https://github.com/apache/kafka/pull/15808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585466853
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEvent.java:
##
@@ -16,9 +16,118 @@
*/
package
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1585460093
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1585460093
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1585460093
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
[
https://issues.apache.org/jira/browse/KAFKA-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula updated KAFKA-9401:
-
Fix Version/s: 3.8.0
3.7.1
> High lock contention for
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585435927
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java:
##
@@ -30,12 +29,7 @@ public abstract class CommitEvent extends
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1585435466
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585390985
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -273,9 +310,18 @@ void cleanup() {
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585390985
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThread.java:
##
@@ -273,9 +310,18 @@ void cleanup() {
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1585359721
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
[
https://issues.apache.org/jira/browse/KAFKA-13447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee reassigned KAFKA-13447:
--
Assignee: Philip Nee
> Consumer should not reuse committed offset after topic recreation
>
sidyag opened a new pull request, #15837:
URL: https://github.com/apache/kafka/pull/15837
Allowing WriteTxnMarkers API to run with AlterCluster permissions
https://issues.apache.org/jira/browse/KAFKA-16513
[
https://issues.apache.org/jira/browse/KAFKA-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-16110:
---
Issue Type: Task (was: New Feature)
> Document and publicize performance test results for
[
https://issues.apache.org/jira/browse/KAFKA-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Philip Nee updated KAFKA-16110:
---
Summary: Document and publicize performance test results for
AsyncKafkaConsumer (was: Implement
[
https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16290:
--
Priority: Major (was: Critical)
> Investigate propagating subscription state updates via queues
>
gharris1727 commented on code in PR #14309:
URL: https://github.com/apache/kafka/pull/14309#discussion_r1585294415
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -655,27 +811,38 @@ private static ConfigInfos
gaurav-narula commented on PR #15836:
URL: https://github.com/apache/kafka/pull/15836#issuecomment-2086478984
The following images show lock profiles collected using async-profiler
before and after this change with numCacheShards = numIoThreads = 64 and
demonstrates significant reduction
[
https://issues.apache.org/jira/browse/KAFKA-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16110:
--
Priority: Major (was: Blocker)
> Implement consumer performance tests
>
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1585308784
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,332 @@
package org.apache.kafka.tools.consumer.group;
gaurav-narula opened a new pull request, #15836:
URL: https://github.com/apache/kafka/pull/15836
KIP-227 introduced in-memory caching of FetchSessions. Brokers with a large
number of Fetch requests suffer from contention on trying to acquire a lock on
FetchSessionCache.
This change
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842470#comment-17842470
]
Lianet Magrans edited comment on KAFKA-16637 at 4/30/24 6:10 PM:
-
Hey
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842470#comment-17842470
]
Lianet Magrans edited comment on KAFKA-16637 at 4/30/24 6:10 PM:
-
Hey
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842470#comment-17842470
]
Lianet Magrans commented on KAFKA-16637:
Hey [~chickenchickenlove], just to rule out the basics,
[
https://issues.apache.org/jira/browse/KAFKA-16557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16557:
--
Priority: Minor (was: Major)
> Fix OffsetFetchRequestState.toString()
>
[
https://issues.apache.org/jira/browse/KAFKA-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16558:
--
Priority: Minor (was: Major)
> Implement HeartbeatRequestState.toStringBase()
>
jeffkbkim commented on code in PR #15835:
URL: https://github.com/apache/kafka/pull/15835#discussion_r1585255667
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java:
##
@@ -461,26 +459,30 @@ public void
jeffkbkim opened a new pull request, #15835:
URL: https://github.com/apache/kafka/pull/15835
This PR fixes the thread idle ratio. We take a similar approach to the kafka
request handler idle ratio:
[
https://issues.apache.org/jira/browse/KAFKA-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gaurav Narula reassigned KAFKA-9401:
Assignee: Gaurav Narula
> High lock contention for kafka.server.FetchManager.newContext
>
Alexander-Aghili commented on PR #15055:
URL: https://github.com/apache/kafka/pull/15055#issuecomment-2086139400
Okay I messed up the git a little here (still have much to learn), the
current trunk does exist on my Kafka-16027 branch but I had to redo it force
push which led to
Alexander-Aghili closed pull request #15055: KAFKA-16027: MINOR Refactor
MetadataTest#testUpdatePartitionLeadership
URL: https://github.com/apache/kafka/pull/15055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kirktrue closed pull request #14950: KAFKA-16000: Migrate
MembershipManagerImplTest away from ConsumerTestBuilder
URL: https://github.com/apache/kafka/pull/14950
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16623:
--
Description:
When running system tests for the KafkaAsyncConsumer, we occasionally see this
warning:
[
https://issues.apache.org/jira/browse/KAFKA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16623:
--
Description:
When running system tests for the KafkaAsyncConsumer, we occasionally see this
warning:
[
https://issues.apache.org/jira/browse/KAFKA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842453#comment-17842453
]
Kirk True commented on KAFKA-16623:
---
If I add the following code to {{test_fencing_static_consumer}}
kirktrue commented on PR #15723:
URL: https://github.com/apache/kafka/pull/15723#issuecomment-2086027819
Thanks everyone for the reviews and @lucasbru for the merge!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
chiacyu commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1585188342
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -584,27 +584,6 @@ public static String formatBytes(long bytes) {
}
}
-/**
C0urante commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-2085912341
@gharris1727 I've resolved the merge conflicts again; can you please take a
look when you get a chance?
--
This is an automated message from the Apache Git Service.
To respond to the
brandboat opened a new pull request, #15833:
URL: https://github.com/apache/kafka/pull/15833
related to https://issues.apache.org/jira/browse/KAFKA-16647
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1585160959
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1307,13 +1307,14 @@ private
CoordinatorResult consumerGr
dajac commented on PR #15798:
URL: https://github.com/apache/kafka/pull/15798#issuecomment-2085866313
@dongnuo123 Be aware of https://github.com/apache/kafka/pull/15785. The PR
changes code that you have refactored or reused in this one. We will need to
adapt when we merge it.
--
This
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1585158392
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##
@@ -1307,13 +1307,14 @@ private
CoordinatorResult consumerGr
dajac commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1585155736
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,55 @@ private static void
philipnee commented on PR #15723:
URL: https://github.com/apache/kafka/pull/15723#issuecomment-2085841809
Hey sorry for the delay, the changes look good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585152310
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1892,13 +1897,13 @@ private void subscribeInternal(Collection
dajac merged PR #15818:
URL: https://github.com/apache/kafka/pull/15818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585035057
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1853,6 +1824,40 @@ private void subscribeInternal(Collection
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585091606
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1892,13 +1897,13 @@ private void subscribeInternal(Collection
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585083395
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1892,13 +1897,13 @@ private void subscribeInternal(Collection
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585035057
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -1853,6 +1824,40 @@ private void subscribeInternal(Collection
[
https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842423#comment-17842423
]
Matthias J. Sax commented on KAFKA-16382:
-
Not yet from our side... Working on other things atm.
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585004533
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585003046
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
lianetm commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1585003046
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
1 - 100 of 164 matches
Mail list logo
