ivanyu commented on PR #6934:
URL: https://github.com/apache/kafka/pull/6934#issuecomment-2092245514
I also added the integration test as you proposed @C0urante
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843121#comment-17843121
]
Andrew Schofield commented on KAFKA-16514:
--
I agree that a KIP for extending Consumer.close is
chia7712 commented on code in PR #15847:
URL: https://github.com/apache/kafka/pull/15847#discussion_r1588652533
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##
@@ -252,14 +252,16 @@ public TargetAssignmentResult
nizhikov commented on PR #15850:
URL: https://github.com/apache/kafka/pull/15850#issuecomment-2092088305
Hello @chia7712
This PR is first part of rewriting `ConfigCommandTest` in java.
As you may see, test cases checks different variation of `ConfigCommand`
options both - zk and
[
https://issues.apache.org/jira/browse/KAFKA-16657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843119#comment-17843119
]
Andrew Schofield commented on KAFKA-16657:
--
My understanding is that the new consumer group
nizhikov commented on PR #15850:
URL: https://github.com/apache/kafka/pull/15850#issuecomment-2092075342
Parent PR is #15839
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
nizhikov opened a new pull request, #15850:
URL: https://github.com/apache/kafka/pull/15850
This is third part of https://github.com/apache/kafka/pull/15417 refactoring.
PR intention - split big PR in parts to simplify review.
PR contains first part of ConfigCommandTest rewritten in
[
https://issues.apache.org/jira/browse/KAFKA-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16659:
--
Assignee: PoAn Yang (was: Chia-Ping Tsai)
> KafkaConsumer#position() does not
github-actions[bot] commented on PR #15200:
URL: https://github.com/apache/kafka/pull/15200#issuecomment-2092064975
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
github-actions[bot] commented on PR #15203:
URL: https://github.com/apache/kafka/pull/15203#issuecomment-2092064955
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
kamalcph commented on PR #15690:
URL: https://github.com/apache/kafka/pull/15690#issuecomment-2092058377
The latest changes lgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
[
https://issues.apache.org/jira/browse/KAFKA-16372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843116#comment-17843116
]
Haruki Okada commented on KAFKA-16372:
--
[~mpedersencrwd] In either case, it takes time to fix
ocadaruma commented on PR #15571:
URL: https://github.com/apache/kafka/pull/15571#issuecomment-2092033373
@chia7712 Resolved the conflict. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chickenchickenlove commented on PR #15573:
URL: https://github.com/apache/kafka/pull/15573#issuecomment-2091999016
Hi @mjsax !
Sorry, I missed to check `checkStyle` and thanks for your working instead of
me ♂️
--
This is an automated message from the Apache Git Service.
To respond
FrankYang0529 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r158855
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -55,14 +56,21 @@ public class ClusterConfig {
private final Map>
perBrokerOverrideProperties;
mjsax commented on code in PR #12988:
URL: https://github.com/apache/kafka/pull/12988#discussion_r1588576144
##
streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java:
##
@@ -1202,16 +1202,47 @@ public class StreamsConfig extends AbstractConfig {
mjsax commented on PR #15573:
URL: https://github.com/apache/kafka/pull/15573#issuecomment-2091973130
I took the liberty to commit a fix to retrigger the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
mjsax commented on code in PR #15573:
URL: https://github.com/apache/kafka/pull/15573#discussion_r1588561925
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/RepartitionTopics.java:
##
@@ -110,6 +110,13 @@ public Set topologiesWithMissingInputTopics() {
mjsax commented on PR #15573:
URL: https://github.com/apache/kafka/pull/15573#issuecomment-2091972588
There is a checkstyle error:
```
[2024-05-02T11:03:05.489Z] > Task :streams:checkstyleMain
[2024-05-02T11:03:05.489Z] [ant:checkstyle] [ERROR]
[
https://issues.apache.org/jira/browse/KAFKA-16659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843107#comment-17843107
]
PoAn Yang commented on KAFKA-16659:
---
Hi [~chia7712], are you working on this? If not, may I take it?
dongnuo123 commented on code in PR #15847:
URL: https://github.com/apache/kafka/pull/15847#discussion_r1588552918
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -366,7 +365,7 @@ public ConsumerGroupMember
C0urante commented on PR #14309:
URL: https://github.com/apache/kafka/pull/14309#issuecomment-2091927044
Thanks @gharris1727, can you give this another round?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
junrao commented on code in PR #15516:
URL: https://github.com/apache/kafka/pull/15516#discussion_r1586920863
##
clients/src/main/java/org/apache/kafka/common/compress/NoCompression.java:
##
@@ -14,37 +14,48 @@
* See the License for the specific language governing permissions
chia7712 commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1588474788
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedConfig.java:
##
@@ -466,7 +467,7 @@ private static ConfigDef config(Crypto
chia7712 commented on code in PR #15745:
URL: https://github.com/apache/kafka/pull/15745#discussion_r1588469427
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -55,14 +56,21 @@ public class ClusterConfig {
private final Map>
perBrokerOverrideProperties;
chia7712 commented on PR #15839:
URL: https://github.com/apache/kafka/pull/15839#issuecomment-2091799986
> I can try to move only subset of tests to make patches smaller.
yep, that is good idea. Also, please try to migrate to the `ClusterTest`. I
haven't dug in ConfigCommandTest, and
junrao commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1588223773
##
clients/src/main/resources/common/message/VotersRecord.json:
##
@@ -0,0 +1,47 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
chia7712 commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1588449485
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -906,6 +906,7 @@ public long position(TopicPartition partition,
Chia-Ping Tsai created KAFKA-16659:
--
Summary: KafkaConsumer#position() does not respect wakup when
group protocol is CONSUMER
Key: KAFKA-16659
URL: https://issues.apache.org/jira/browse/KAFKA-16659
lucasbru commented on code in PR #15784:
URL: https://github.com/apache/kafka/pull/15784#discussion_r1588371452
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/WakeupTrigger.java:
##
@@ -43,8 +43,12 @@ public void wakeup() {
return new
kirktrue commented on PR #15844:
URL: https://github.com/apache/kafka/pull/15844#issuecomment-2091380043
> @kirktrue Should we rename the title of the PR/Jira now that we understand
the root cause?
Done
--
This is an automated message from the Apache Git Service.
To respond to
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16637:
--
Summary: AsyncKafkaConsumer removes offset fetch responses from cache too
aggressively (was: KIP-848
kirktrue commented on PR #15647:
URL: https://github.com/apache/kafka/pull/15647#issuecomment-2091362381
@lianetm & @philipnee—would you be able to review this PR? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kirktrue commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1588234154
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala:
##
@@ -271,6 +272,19 @@ class PlaintextConsumerCommitTest extends
kirktrue commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1588233090
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java:
##
@@ -906,6 +906,7 @@ public long position(TopicPartition partition,
kirktrue commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1588224603
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala:
##
@@ -271,6 +272,19 @@ class PlaintextConsumerCommitTest extends
junrao commented on code in PR #15671:
URL: https://github.com/apache/kafka/pull/15671#discussion_r1588223773
##
clients/src/main/resources/common/message/VotersRecord.json:
##
@@ -0,0 +1,47 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
cadonna opened a new pull request, #15849:
URL: https://github.com/apache/kafka/pull/15849
Currently, the state updater writes multiple tasks per exception in the
output queue for failed tasks. To add the functionality to remove tasks
synchronously from the state updater, it is simpler
ahuang98 commented on PR #15845:
URL: https://github.com/apache/kafka/pull/15845#issuecomment-2091208654
^ edited title to kick off another build (last one failed due to unrelated
issues)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
jeffkbkim commented on code in PR #15835:
URL: https://github.com/apache/kafka/pull/15835#discussion_r1588068337
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java:
##
@@ -126,9 +126,16 @@ private class
ahuang98 commented on code in PR #15845:
URL: https://github.com/apache/kafka/pull/15845#discussion_r1588067214
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -612,7 +613,12 @@ class ZkMigrationIntegrationTest {
val readyFuture =
jeffkbkim commented on code in PR #15835:
URL: https://github.com/apache/kafka/pull/15835#discussion_r1588049288
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/metrics/GroupCoordinatorRuntimeMetrics.java:
##
@@ -120,19 +121,14 @@ public
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1588022076
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1144,6 +1144,21 @@ public void putConnectorConfig(final
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587989524
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java:
##
@@ -1144,6 +1144,21 @@ public void putConnectorConfig(final
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587970461
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -751,6 +754,74 @@ public void testPutConnectorConfig()
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587966298
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -751,6 +754,74 @@ public void testPutConnectorConfig()
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587963241
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java:
##
@@ -751,6 +754,74 @@ public void testPutConnectorConfig()
riedelmax commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1587959903
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
riedelmax commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1587959903
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587958141
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -2336,6 +2336,95 @@ public void testPutConnectorConfig()
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587955412
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -2336,6 +2336,95 @@ public void testPutConnectorConfig()
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587938094
##
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java:
##
@@ -2336,6 +2336,95 @@ public void testPutConnectorConfig()
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587929296
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java:
##
@@ -246,6 +246,31 @@ private synchronized void
dajac commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587922375
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587926661
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java:
##
@@ -246,6 +246,31 @@ private synchronized void
cmccabe merged PR #15810:
URL: https://github.com/apache/kafka/pull/15810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587918212
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java:
##
@@ -242,6 +242,19 @@ public Response putConnectorConfig(final
dajac commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587912985
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void
philipnee commented on PR #15688:
URL: https://github.com/apache/kafka/pull/15688#issuecomment-2090947138
Hi @kirktrue - It was clearly documented why LegacyKafkaConsumer would do
this, maybe it is because in some scenarios users want to update the position
but actually don't care about
dajac commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587912168
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587904583
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java:
##
@@ -242,6 +242,19 @@ public Response putConnectorConfig(final
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587887974
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587889094
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587887974
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void
rreddy-22 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587887974
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void
cadonna commented on PR #15640:
URL: https://github.com/apache/kafka/pull/15640#issuecomment-2090837554
> > > > > Here I have a comment, I could not put at the right location in
the code:
> > > > > On line 1362, in commitSync() the consumer waits on the
commitFuture with a timer. I
cadonna commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1587841410
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
nizhikov opened a new pull request, #15848:
URL: https://github.com/apache/kafka/pull/15848
This is fourth part of https://github.com/apache/kafka/pull/15417
refactoring.
PR intention - split big PR in parts to simplify review.
PR contains tests of `DynamicBrokerReconfigurationTest`
dajac commented on PR #15652:
URL: https://github.com/apache/kafka/pull/15652#issuecomment-2090789895
@chia7712 I updated the PR with a different approach. I now print the
records using the json converters. This allow me to post process the group
metadata record to deserialize the
johnnychhsu commented on PR #15845:
URL: https://github.com/apache/kafka/pull/15845#issuecomment-2090696169
thanks for the PR!
got a question and left a comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
johnnychhsu commented on code in PR #15845:
URL: https://github.com/apache/kafka/pull/15845#discussion_r1587770348
##
core/src/test/scala/integration/kafka/zk/ZkMigrationIntegrationTest.scala:
##
@@ -612,7 +613,12 @@ class ZkMigrationIntegrationTest {
val readyFuture =
nizhikov commented on PR #15839:
URL: https://github.com/apache/kafka/pull/15839#issuecomment-2090657892
New tests passes on CI. PR ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1587740243
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -10921,6 +10823,1158 @@ public void
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1587735026
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -10921,6 +10823,1158 @@ public void
clolov commented on PR #15673:
URL: https://github.com/apache/kafka/pull/15673#issuecomment-2090629047
Heya, apologies, I will get to addressing these this weekend!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
dongnuo123 commented on code in PR #15798:
URL: https://github.com/apache/kafka/pull/15798#discussion_r1587732479
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -10921,6 +10823,1158 @@ public void
ivanyu commented on code in PR #6934:
URL: https://github.com/apache/kafka/pull/6934#discussion_r1587717243
##
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java:
##
@@ -992,4 +992,15 @@ public List setWorkerLoggerLevel(String namespace,
String
johnnychhsu commented on PR #15828:
URL: https://github.com/apache/kafka/pull/15828#issuecomment-2090603884
thanks @chia7712 for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dongnuo123 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587655470
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void
dongnuo123 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587657454
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void
dongnuo123 commented on code in PR #15785:
URL: https://github.com/apache/kafka/pull/15785#discussion_r1587655470
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java:
##
@@ -966,6 +979,53 @@ private static void
cadonna commented on PR #15640:
URL: https://github.com/apache/kafka/pull/15640#issuecomment-2090517636
> > > > Here I have a comment, I could not put at the right location in the
code:
> > > > On line 1362, in commitSync() the consumer waits on the commitFuture
with a timer. I think,
lianetm commented on code in PR #15843:
URL: https://github.com/apache/kafka/pull/15843#discussion_r1587645917
##
core/src/test/scala/integration/kafka/api/PlaintextConsumerCommitTest.scala:
##
@@ -271,6 +272,19 @@ class PlaintextConsumerCommitTest extends
AbstractConsumerTest
David Jacot created KAFKA-16658:
---
Summary: Drop `offsets.commit.required.acks` config in 4.0
(deprecate in 3.8)
Key: KAFKA-16658
URL: https://issues.apache.org/jira/browse/KAFKA-16658
Project: Kafka
chiacyu commented on code in PR #15823:
URL: https://github.com/apache/kafka/pull/15823#discussion_r1587563849
##
connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java:
##
@@ -399,7 +398,7 @@ public TopicCreationResponse createOrFindTopics(NewTopic...
Vaibhav-Nazare commented on PR #13817:
URL: https://github.com/apache/kafka/pull/13817#issuecomment-2090390142
Hi @mimaison seems no discussion happening on the mailing list, Just a query
as per the reply on the jira issue which I raised as per the comment a
committer has access to enable
dajac opened a new pull request, #15847:
URL: https://github.com/apache/kafka/pull/15847
While reviewing https://github.com/apache/kafka/pull/15785, I noticed that
the member is added to the group directly in
`ConsumerGroup#getOrMaybeCreateMember`. This does not hurt but confuses people
dajac commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1587519958
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under
dajac commented on PR #15727:
URL: https://github.com/apache/kafka/pull/15727#issuecomment-2090324252
> @dajac part 4/4 would be to handle IncludeAuthorizedOperations in the
request
Understood. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the
cadonna commented on code in PR #15640:
URL: https://github.com/apache/kafka/pull/15640#discussion_r1587519244
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java:
##
@@ -0,0 +1,150 @@
+/*
+ * Licensed to the Apache Software
johnnychhsu closed pull request #15842: KAFKA-16027: refactor MetadataTest
URL: https://github.com/apache/kafka/pull/15842
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
johnnychhsu commented on PR #15842:
URL: https://github.com/apache/kafka/pull/15842#issuecomment-2090319861
since [Alexander-Aghili](https://github.com/Alexander-Aghili) has a fix,
will close this
--
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-16027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842946#comment-17842946
]
Johnny Hsu commented on KAFKA-16027:
[~alexanderaghili] thanks for replying!
got you, then I will
FrankYang0529 commented on PR #15745:
URL: https://github.com/apache/kafka/pull/15745#issuecomment-2090298946
> @FrankYang0529 thanks for updated PR. two comments left.
Hi @chia7712, thanks for the review. I addressed last comments.
--
This is an automated message from the Apache
sanghyeok An created KAFKA-16657:
Summary: KIP-848 does not work well on Zookeeper Mode
Key: KAFKA-16657
URL: https://issues.apache.org/jira/browse/KAFKA-16657
Project: Kafka
Issue Type: Bug
soarez commented on code in PR #15690:
URL: https://github.com/apache/kafka/pull/15690#discussion_r1587465657
##
core/src/main/java/kafka/server/TierStateMachine.java:
##
@@ -17,15 +17,66 @@
package kafka.server;
+import java.io.BufferedReader;
+import java.io.File;
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842935#comment-17842935
]
sanghyeok An commented on KAFKA-16637:
--
[~kirktrue] Thanks for your comments.
I wasn't aware of
[
https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17842934#comment-17842934
]
sanghyeok An commented on KAFKA-16637:
--
Hi [~lianetm]!
I guess that it was problem caused by miss
chickenchickenlove commented on PR #15573:
URL: https://github.com/apache/kafka/pull/15573#issuecomment-2090210638
@mjsax thanks for your suggestion. it is very suitable
I commit your suggestion. when you have free time, please take a look ♂️
--
This is an automated message from
riedelmax commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1587442156
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF)
1 - 100 of 145 matches
Mail list logo
