Re: [PR] KAFKA-16399: Add JBOD support in tiered storage [kafka]

2024-05-07 Thread via GitHub
showuon commented on code in PR #15690: URL: https://github.com/apache/kafka/pull/15690#discussion_r1593390067 ## storage/src/test/java/org/apache/kafka/tiered/storage/utils/TieredStorageTestUtils.java: ## @@ -55,7 +57,7 @@ public class TieredStorageTestUtils { // Log

[jira] [Commented] (KAFKA-16656) Using a custom replication.policy.separator with DefaultReplicationPolicy

2024-05-07 Thread Lenin Joseph (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844529#comment-17844529 ] Lenin Joseph commented on KAFKA-16656: -- Hi [~ChrisEgerton] , thanks for looking into it. We see

[PR] [DON'T SEE THIS PR] debug for thread leak [kafka]

2024-05-07 Thread via GitHub
chia7712 opened a new pull request, #15891: URL: https://github.com/apache/kafka/pull/15891 thread leak where are you? ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

Re: [PR] MINOR: Correct connector scheduled rebalance logs [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on PR #15875: URL: https://github.com/apache/kafka/pull/15875#issuecomment-2099722116 @yuz10 thanks for your contribution! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] MINOR: Correct connector scheduled rebalance logs [kafka]

2024-05-07 Thread via GitHub
chia7712 merged PR #15875: URL: https://github.com/apache/kafka/pull/15875 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Resolved] (KAFKA-16678) Remove unimplementedquorum from EndToEndAuthorizationTest

2024-05-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16678?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16678. Fix Version/s: 3.8.0 Resolution: Fixed > Remove unimplementedquorum from

Re: [PR] KAFKA-16678: Remove variable "unimplementedquorum" [kafka]

2024-05-07 Thread via GitHub
chia7712 merged PR #15879: URL: https://github.com/apache/kafka/pull/15879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-16679) Merge unit test down to the class of integration test

2024-05-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16679: --- Summary: Merge unit test down to the class of integration test (was: Merge

[jira] [Updated] (KAFKA-16679) Merge `DeleteRecordsCommandUnitTest` into `DeleteRecordsCommandTest`, `FeatureCommandUnitTest` into FeatureCommandTest

2024-05-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16679: --- Summary: Merge `DeleteRecordsCommandUnitTest` into `DeleteRecordsCommandTest`,

Re: [PR] MINOR: merge unit test down to the class of integration test [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on code in PR #15884: URL: https://github.com/apache/kafka/pull/15884#discussion_r1593365819 ## tools/src/test/java/org/apache/kafka/tools/FeatureCommandTest.java: ## @@ -160,28 +154,26 @@ private String outputWithoutEpoch(String output) { int pos =

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-07 Thread via GitHub
kamalcph commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1593363337 ## core/src/main/scala/kafka/server/DelayedFetch.scala: ## @@ -92,7 +92,10 @@ class DelayedFetch( // has just rolled, then the high watermark offset will

Re: [PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on PR #15886: URL: https://github.com/apache/kafka/pull/15886#issuecomment-2099705033 @gaurav-narula thanks for your fix. Before merging this PR, I want to know which `timerTask` gets hanging when shutdown. Do you have any idea? -- This is an automated message from

Re: [PR] MINOR: migrate ListConsumerGroupTest to use ClusterTestExtensions [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on PR #15821: URL: https://github.com/apache/kafka/pull/15821#issuecomment-2099700974 > This is used by ListConsumerGroupTest and DescribeConsumerGroupTest. I think we can create a new class SimpleConsumerGroupExecutorTestUtils for it. WDYT? Thank you. That is

Re: [PR] KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on PR #15715: URL: https://github.com/apache/kafka/pull/15715#issuecomment-2099699004 build get failed ... retrigger again -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on PR #15779: URL: https://github.com/apache/kafka/pull/15779#issuecomment-2099697982 @m1a2st Could you please use `ConsumerGroupCommandTestUtils#generator` to rewrite this test? thanks!

Re: [PR] Kafka-16668: Add tags support in ClusterTestExtension [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1593356187 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -53,14 +52,15 @@ public class ClusterConfig { private final Map adminClientProperties; private

Re: [PR] Kafka-16668: Add tags support in ClusterTestExtension [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on code in PR #15861: URL: https://github.com/apache/kafka/pull/15861#discussion_r1593355835 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -153,15 +148,19 @@ public Map> perBrokerOverrideProperties() { return

Re: [PR] MINOR: use classic consumer with ZK mode for DeleteOffsetsConsumerGroupCommandIntegrationTest [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on code in PR #15872: URL: https://github.com/apache/kafka/pull/15872#discussion_r1593354055 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteOffsetsConsumerGroupCommandIntegrationTest.java: ## @@ -57,28 +56,47 @@ import static

[jira] [Assigned] (KAFKA-16689) Move LogValidatorTest to storage module

2024-05-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16689: -- Assignee: TaiJuWu (was: Chia-Ping Tsai) > Move LogValidatorTest to storage module >

[jira] [Commented] (KAFKA-16689) Move LogValidatorTest to storage module

2024-05-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844513#comment-17844513 ] Chia-Ping Tsai commented on KAFKA-16689: hi [~ijuma] thanks for your reminder. {quote} we can

[jira] [Assigned] (KAFKA-16684) FetchResponse#responseData could return incorrect data

2024-05-07 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-16684: -- Assignee: Johnny Hsu (was: Chia-Ping Tsai) > FetchResponse#responseData could

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099682338 @gharris1727 new pr : https://github.com/apache/kafka/pull/15890 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] KAFKA-16643 Fix chaos modifier [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang opened a new pull request, #15890: URL: https://github.com/apache/kafka/pull/15890 @gharris1727 https://github.com/apache/kafka/pull/15812 I modified all the non-standard code according to the rules of ModifierOrder, and I divided it into multiple commits by module for

Re: [PR] MINOR: Add MetadataType metric from KIP-866 #15299 [kafka]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #15306: URL: https://github.com/apache/kafka/pull/15306#issuecomment-2099674185 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] KAFKA-16218: Make partition reassignment completed as soon as adding replicas are in-sync [kafka]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #15332: URL: https://github.com/apache/kafka/pull/15332#issuecomment-2099674143 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] [No review] Repro kafka-16217 [kafka]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #15336: URL: https://github.com/apache/kafka/pull/15336#issuecomment-2099674110 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

Re: [PR] Global state store restore custom processor [kafka]

2024-05-07 Thread via GitHub
github-actions[bot] commented on PR #15337: URL: https://github.com/apache/kafka/pull/15337#issuecomment-2099674079 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has

[jira] [Commented] (KAFKA-16689) Move LogValidatorTest to storage module

2024-05-07 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844508#comment-17844508 ] Ismael Juma commented on KAFKA-16689: - [~chia7712] This is intentional - there is a separate Jira

Re: [PR] KAFKA-16452: Don't throw OOORE when converting the offset to metadata [kafka]

2024-05-07 Thread via GitHub
showuon commented on code in PR #15825: URL: https://github.com/apache/kafka/pull/15825#discussion_r1593331212 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -1424,11 +1424,18 @@ class UnifiedLog(@volatile var logStartOffset: Long, /** * Given a message

[jira] [Commented] (KAFKA-16584) Make log processing summary configurable or debug

2024-05-07 Thread dujian (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844506#comment-17844506 ] dujian commented on KAFKA-16584: hello [~mjsax]  very thanks you willing help me create KIP, but it’s 

[jira] [Commented] (KAFKA-16689) Move LogValidatorTest to storage module

2024-05-07 Thread TaiJuWu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844505#comment-17844505 ] TaiJuWu commented on KAFKA-16689: - Hi [~chia7712] , I am interested in this topic, could you assign it

[jira] [Commented] (KAFKA-16684) FetchResponse#responseData could return incorrect data

2024-05-07 Thread Johnny Hsu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844496#comment-17844496 ] Johnny Hsu commented on KAFKA-16684: hi [~chia7712]  May i know if you are working on this? if not I

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-07 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1593310007 ## clients/src/main/java/org/apache/kafka/common/metrics/stats/SampledStat.java: ## @@ -106,44 +106,55 @@ public String toString() { public abstract

Re: [PR] MINOR: Fix rate metric spikes [kafka]

2024-05-07 Thread via GitHub
emitskevich-blp commented on code in PR #15889: URL: https://github.com/apache/kafka/pull/15889#discussion_r1593308659 ## clients/src/test/java/org/apache/kafka/common/metrics/stats/RateTest.java: ## @@ -64,4 +67,31 @@ public void testRateWithNoPriorAvailableSamples(int

[PR] Fix Rate window size [kafka]

2024-05-07 Thread via GitHub
emitskevich-blp opened a new pull request, #15889: URL: https://github.com/apache/kafka/pull/15889 `Rate` metric reports value in the form of `sumOrCount`/`timePeriod`. It has a bug in `timePeriod` calculation, which leads to spikes in result values (see real example: `io-wait-ratio`

[jira] [Assigned] (KAFKA-16691) Support for nested structures: TimestampConverter

2024-05-07 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-16691: Assignee: Jorge Esteban Quilcate Otoya > Support for

[jira] [Assigned] (KAFKA-16690) Support for nested structures: HeaderFrom

2024-05-07 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-16690: Assignee: Jorge Esteban Quilcate Otoya > Support for

[jira] [Created] (KAFKA-16691) Support for nested structures: TimestampConverter

2024-05-07 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-16691: Summary: Support for nested structures: TimestampConverter Key: KAFKA-16691 URL: https://issues.apache.org/jira/browse/KAFKA-16691

[jira] [Created] (KAFKA-16690) Support for nested structures: HeaderFrom

2024-05-07 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-16690: Summary: Support for nested structures: HeaderFrom Key: KAFKA-16690 URL: https://issues.apache.org/jira/browse/KAFKA-16690 Project:

[jira] [Updated] (KAFKA-14226) Introduce support for nested structures

2024-05-07 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya updated KAFKA-14226: - Description: Abstraction for FieldPath and initial SMTs: *

[jira] [Resolved] (KAFKA-14226) Introduce support for nested structures

2024-05-07 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya resolved KAFKA-14226. -- Resolution: Fixed Merged:

[jira] [Commented] (KAFKA-16264) Expose `producer.id.expiration.check.interval.ms` as dynamic broker configuration

2024-05-07 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844484#comment-17844484 ] Jorge Esteban Quilcate Otoya commented on KAFKA-16264: -- Thanks [~jolshan] ! Finally

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099569696 @gharris1727 i request a jira acount link gongxuanzhang email: gongxuanzhangm...@gmail.com I need a confirmation. Can I get it from you -- This is an automated message

Re: [PR] MINOR: enable test for ensureInternalEndpointIsSecured [kafka]

2024-05-07 Thread via GitHub
FrankYang0529 commented on code in PR #15868: URL: https://github.com/apache/kafka/pull/15868#discussion_r1593273181 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/SessionedProtocolIntegrationTest.java: ## @@ -115,11 +112,11 @@ public void

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099566070 > @gongxuanzhang Do you want to merge this PR as-is, or do you want to add more fixes to this? I will create new pr linked -- This is an automated message from the Apache

[jira] [Created] (KAFKA-16689) Move LogValidatorTest to storage module

2024-05-07 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16689: -- Summary: Move LogValidatorTest to storage module Key: KAFKA-16689 URL: https://issues.apache.org/jira/browse/KAFKA-16689 Project: Kafka Issue Type:

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1593260374 ## core/src/test/scala/unit/kafka/log/LogValidatorTest.scala: ## @@ -404,9 +414,7 @@ class LogValidatorTest { assertEquals(now + 1,

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang closed pull request #15812: a slight change. URL: https://github.com/apache/kafka/pull/15812 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] KAFKA-16264: Expose `producer.id.expiration.check.interval.ms` as dynamic broker configuration [kafka]

2024-05-07 Thread via GitHub
jeqo opened a new pull request, #15888: URL: https://github.com/apache/kafka/pull/15888 Include expiration check interval configuration as dynamic to re-schedule producer state checker. See commits for more details. [KAFKA-16264] ### Committer Checklist (excluded from

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gongxuanzhang commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099540536 > @gongxuanzhang Do you want to merge this PR as-is, or do you want to add more fixes to this? I choose the latter and do more thank you for your trust -- This is an

[PR] KAFKA-15045: (KIP-924) New interfaces and stubbed utility classes for pluggable TaskAssignors. [kafka]

2024-05-07 Thread via GitHub
apourchet opened a new pull request, #15887: URL: https://github.com/apache/kafka/pull/15887 This is the first PR in a sequence to support custom task assignors in Kafka Streams, which was described in KIP 924. It creates and exposes all of the interfaces that will need to be implemented

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-05-07 Thread via GitHub
chia7712 commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1593241011 ## core/src/test/scala/unit/kafka/log/LogValidatorTest.scala: ## @@ -404,9 +414,7 @@ class LogValidatorTest { assertEquals(now + 1,

Re: [PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-07 Thread via GitHub
gaurav-narula commented on PR #15886: URL: https://github.com/apache/kafka/pull/15886#issuecomment-2099506624 CC: @soarez @chia7712 I came across this in the [CI pipeline run](https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-15885/1/tests) for

[PR] KAFKA-16688: Use helper method to shutdown ExecutorService [kafka]

2024-05-07 Thread via GitHub
gaurav-narula opened a new pull request, #15886: URL: https://github.com/apache/kafka/pull/15886 We observe some thread leaks in CI which point to the executor service thread. This change tries to shutdown the executor service using the helper method in `ThreadUtils`. ### Committer

[jira] [Created] (KAFKA-16688) SystemTimer leaks resources on close

2024-05-07 Thread Gaurav Narula (Jira)
Gaurav Narula created KAFKA-16688: - Summary: SystemTimer leaks resources on close Key: KAFKA-16688 URL: https://issues.apache.org/jira/browse/KAFKA-16688 Project: Kafka Issue Type: Test

Re: [PR] MINOR: Various cleanups in clients tests [kafka]

2024-05-07 Thread via GitHub
lianetm commented on code in PR #15877: URL: https://github.com/apache/kafka/pull/15877#discussion_r1593116655 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -106,10 +103,9 @@ public void setup() {

Re: [PR] Allowing WriteTxnMarkers API to run with AlterCluster permissions [kafka]

2024-05-07 Thread via GitHub
jolshan commented on code in PR #15837: URL: https://github.com/apache/kafka/pull/15837#discussion_r1593105981 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -3037,14 +3062,71 @@ class KafkaApisTest extends Logging { } @Test - def

Re: [PR] MINOR: Various cleanups in clients tests [kafka]

2024-05-07 Thread via GitHub
lianetm commented on code in PR #15877: URL: https://github.com/apache/kafka/pull/15877#discussion_r1593098515 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java: ## @@ -106,10 +103,9 @@ public void setup() {

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

2024-05-07 Thread via GitHub
lianetm commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1591377324 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-16287: Implement example tests for common rebalance callback [kafka]

2024-05-07 Thread via GitHub
lianetm commented on code in PR #15408: URL: https://github.com/apache/kafka/pull/15408#discussion_r1592977058 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerCallbackTest.scala: ## @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

Re: [PR] KAFKA-16362: Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-05-07 Thread via GitHub
ableegoldman commented on PR #15601: URL: https://github.com/apache/kafka/pull/15601#issuecomment-2099136409 Thanks Greg. If no one's had time to look at this by next week, we'll assign a reviewer during the next Kafka Streams hangout -- This is an automated message from the Apache Git

Re: [PR] a slight change. [kafka]

2024-05-07 Thread via GitHub
gharris1727 commented on PR #15812: URL: https://github.com/apache/kafka/pull/15812#issuecomment-2099128163 @gongxuanzhang Do you want to merge this PR as-is, or do you want to add more fixes to this? -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-16362: Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-05-07 Thread via GitHub
gharris1727 commented on code in PR #15601: URL: https://github.com/apache/kafka/pull/15601#discussion_r1592924655 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java: ## @@ -187,17 +157,25 @@ public void process(final Record record) {

Re: [PR] MINOR: Refactor Values class to fix checkstyle, add benchmark, optimize exceptions [kafka]

2024-05-07 Thread via GitHub
gharris1727 commented on code in PR #15469: URL: https://github.com/apache/kafka/pull/15469#discussion_r1592918790 ## connect/api/src/main/java/org/apache/kafka/connect/data/Values.java: ## @@ -766,135 +852,23 @@ protected static boolean canParseSingleTokenLiteral(Parser

Re: [PR] MINOR: Refactor Values class to fix checkstyle, add benchmark, optimize exceptions [kafka]

2024-05-07 Thread via GitHub
gharris1727 commented on PR #15469: URL: https://github.com/apache/kafka/pull/15469#issuecomment-2099075512 Here's the Values test coverage changes: State | Class % | Method % | Line % -- | -- | -- | -- Initial | 100% (4/4) | 81% (40/49) | 78% (464/589) Added tests | 100%

Re: [PR] KAFKA-16480: Bump ListOffsets version, IBP version and mark last version of ListOffsets as unstable [kafka]

2024-05-07 Thread via GitHub
junrao commented on code in PR #15673: URL: https://github.com/apache/kafka/pull/15673#discussion_r1592890872 ## metadata/src/test/java/org/apache/kafka/metadata/PartitionRegistrationTest.java: ## @@ -283,7 +283,7 @@ private static Stream

[jira] [Resolved] (KAFKA-15018) Potential tombstone offsets corruption for exactly-once source connectors

2024-05-07 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15018?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-15018. --- Fix Version/s: 3.8.0 Resolution: Fixed > Potential tombstone offsets corruption for

Re: [PR] KAFKA-15018: Failing offset flush for EOS when secondary offset store writes fails for tombstone records [kafka]

2024-05-07 Thread via GitHub
C0urante merged PR #13801: URL: https://github.com/apache/kafka/pull/13801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Updated] (KAFKA-16667) KRaftMigrationDriver gets stuck after successive failovers

2024-05-07 Thread David Arthur (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Arthur updated KAFKA-16667: - Fix Version/s: 3.8.0 3.7.1 > KRaftMigrationDriver gets stuck after

Re: [PR] MINOR: Remove dev_version parameter from streams tests [kafka]

2024-05-07 Thread via GitHub
mjsax commented on PR #15874: URL: https://github.com/apache/kafka/pull/15874#issuecomment-2099036837 Triggered a system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder-test/20/ -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] KAFKA-14226: feat(connect:transform): Introduce FieldPath abstraction [kafka]

2024-05-07 Thread via GitHub
C0urante merged PR #15379: URL: https://github.com/apache/kafka/pull/15379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14226: feat(connect:transform): Introduce FieldPath abstraction [kafka]

2024-05-07 Thread via GitHub
C0urante commented on code in PR #15379: URL: https://github.com/apache/kafka/pull/15379#discussion_r1592877739 ## connect/transforms/src/test/java/org/apache/kafka/connect/transforms/field/SingleFieldPathTest.java: ## @@ -0,0 +1,113 @@ +/* + * Licensed to the Apache Software

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

2024-05-07 Thread via GitHub
C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1592860284 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -773,6 +773,41 @@ public void

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

2024-05-07 Thread via GitHub
C0urante commented on PR #6934: URL: https://github.com/apache/kafka/pull/6934#issuecomment-2098991457 Thanks @ivanyu, this is really close. One other thing--can you update the description with a brief overview of the PR (probably enough to just mention the new endpoint and its behavior),

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

2024-05-07 Thread via GitHub
C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1592860284 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -773,6 +773,41 @@ public void

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

2024-05-07 Thread via GitHub
C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1592860284 ## connect/runtime/src/test/java/org/apache/kafka/connect/integration/ConnectWorkerIntegrationTest.java: ## @@ -773,6 +773,41 @@ public void

Re: [PR] KAFKA-16310 ListOffsets doesn't report the offset with maxTimestamp a… [kafka]

2024-05-07 Thread via GitHub
junrao commented on code in PR #15621: URL: https://github.com/apache/kafka/pull/15621#discussion_r1592859538 ## core/src/test/scala/unit/kafka/log/LogValidatorTest.scala: ## @@ -404,9 +414,7 @@ class LogValidatorTest { assertEquals(now + 1,

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

2024-05-07 Thread via GitHub
C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1592847527 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResource.java: ## @@ -242,6 +242,19 @@ public Response

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844408#comment-17844408 ] FTR commented on KAFKA-16687: - Actually, this Kafka client is used for a web application. Just simply use

Re: [PR] KAFKA-16445: Add PATCH method for connector config [kafka]

2024-05-07 Thread via GitHub
C0urante commented on code in PR #6934: URL: https://github.com/apache/kafka/pull/6934#discussion_r1592838802 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/DistributedHerder.java: ## @@ -1144,6 +1144,21 @@ public void putConnectorConfig(final

Re: [PR] MINOR: set test global timeout as 10 mins [kafka]

2024-05-07 Thread via GitHub
gaurav-narula commented on PR #15065: URL: https://github.com/apache/kafka/pull/15065#issuecomment-2098952056 Bumping this thread for more visibility. Would be nice if we give this a shot since we still run into builds which [time

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844400#comment-17844400 ] Philip Nee commented on KAFKA-16687: thanks for the information this is massively helpful. how do

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844397#comment-17844397 ] FTR commented on KAFKA-16687: - For Kafka client, I have used KafkaConsumer and AdminClient. But for this

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844395#comment-17844395 ] Philip Nee commented on KAFKA-16687: Your application uses KafkaConsumer only right? > Native

[jira] [Comment Edited] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844394#comment-17844394 ] FTR edited comment on KAFKA-16687 at 5/7/24 5:12 PM: - I am using stress testing to

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844394#comment-17844394 ] FTR commented on KAFKA-16687: - I am using stress testing to my Java application. Observing with NMT,

Re: [PR] KAFKA-9401: Reduce contention for Fetch requests [kafka]

2024-05-07 Thread via GitHub
soarez commented on PR #15836: URL: https://github.com/apache/kafka/pull/15836#issuecomment-2098918354 `:core:test` timed out only on JDK 8 and Scala 2.12. Restarted the build -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844390#comment-17844390 ] FTR commented on KAFKA-16687: - Surely, let me experiment with 3.6 and then feedback here. > Native memory

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844387#comment-17844387 ] Philip Nee commented on KAFKA-16687: But this is native memory leak so I suspect it's a different

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844382#comment-17844382 ] FTR commented on KAFKA-16687: - BTW, before that I had also encountered heap leak issue in Kafka client

[jira] [Assigned] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee reassigned KAFKA-16687: -- Assignee: Philip Nee > Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread FTR (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844381#comment-17844381 ] FTR commented on KAFKA-16687: - That's it, there are some topics with 30 partitions. I have tested Kafka

[jira] [Commented] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844379#comment-17844379 ] Philip Nee commented on KAFKA-16687: Hey [~fortherightous] - we also observed some (possible) memory

Re: [PR] KAFKA-16629: Add broker-related tests to ConfigCommandIntegrationTest [kafka]

2024-05-07 Thread via GitHub
m1a2st commented on PR #15840: URL: https://github.com/apache/kafka/pull/15840#issuecomment-2098869565 @chia7712 , I have been add zookeeper `--bootstrap-server` tests, please review, thank you -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] KAFKA-16598 Mirgrate `ResetConsumerGroupOffsetTest` to new test infra [kafka]

2024-05-07 Thread via GitHub
m1a2st commented on PR #15779: URL: https://github.com/apache/kafka/pull/15779#issuecomment-2098864822 @chia7712 , please take a look for this PR, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] Kafka-16668: Add tags support in ClusterTestExtension [kafka]

2024-05-07 Thread via GitHub
johnnychhsu commented on PR #15861: URL: https://github.com/apache/kafka/pull/15861#issuecomment-2098850247 @chia7712 > As https://github.com/apache/kafka/pull/15766 gets merged now, could you please fix the build error? sure, let me rebase the latest trunk and fix that since

[jira] [Commented] (KAFKA-16316) Make the restore behavior of GlobalKTables with custom processors configureable

2024-05-07 Thread Walker Carlson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17844373#comment-17844373 ] Walker Carlson commented on KAFKA-16316: KIP-1024 was made for this, but it has been put on hold

Re: [PR] KAFKA-16686: Wait for given offset in TopicBasedRemoteLogMetadataManagerTest [kafka]

2024-05-07 Thread via GitHub
gaurav-narula commented on PR #15885: URL: https://github.com/apache/kafka/pull/15885#issuecomment-2098848112 CC: @clolov @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] KAFKA-16686: Wait for given offset in TopicBasedRemoteLogMetadataManagerTest [kafka]

2024-05-07 Thread via GitHub
gaurav-narula opened a new pull request, #15885: URL: https://github.com/apache/kafka/pull/15885 Some tests in TopicBasedRemoteLogMetadataManagerTest flake because `waitUntilConsumerCatchesUp` may break early before consumer manager has caught up with all the events. This PR adds an

[jira] [Created] (KAFKA-16687) Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0

2024-05-07 Thread FTR (Jira)
FTR created KAFKA-16687: --- Summary: Native memory leak by Unsafe_allocatememory in Kafka Clients 3.7.0 Key: KAFKA-16687 URL: https://issues.apache.org/jira/browse/KAFKA-16687 Project: Kafka Issue

  1   2   >