[GitHub] [kafka] C0urante commented on a diff in pull request #13446: KAFKA-14837, KAFKA-14842: Ignore groups that do not have offsets for filtered topics in MirrorCheckpointConnector

2023-06-28 Thread via GitHub
C0urante commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1245885579 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -150,10 +156,31 @@ private void loadInitialConsumerGroups()

[GitHub] [kafka] C0urante commented on a diff in pull request #13446: KAFKA-14837, KAFKA-14842: Ignore groups that do not have offsets for filtered topics in MirrorCheckpointConnector

2023-06-27 Thread via GitHub
C0urante commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1244478202 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -150,10 +156,31 @@ private void loadInitialConsumerGroups()

[GitHub] [kafka] C0urante commented on a diff in pull request #13446: KAFKA-14837, KAFKA-14842: Ignore groups that do not have offsets for filtered topics in MirrorCheckpointConnector

2023-03-28 Thread via GitHub
C0urante commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1150582584 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnectorTest.java: ## @@ -123,13 +127,21 @@ public void testFindConsumerGroups()

[GitHub] [kafka] C0urante commented on a diff in pull request #13446: KAFKA-14837, KAFKA-14842: Ignore groups that do not have offsets for filtered topics in MirrorCheckpointConnector

2023-03-28 Thread via GitHub
C0urante commented on code in PR #13446: URL: https://github.com/apache/kafka/pull/13446#discussion_r1150581150 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java: ## @@ -178,6 +178,7 @@ private List sourceRecordsForGroup(String group)