C0urante commented on PR #12307:
URL: https://github.com/apache/kafka/pull/12307#issuecomment-1582800062
Test failures appear unrelated; merging...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
C0urante commented on PR #12307:
URL: https://github.com/apache/kafka/pull/12307#issuecomment-1580926841
Rebuilt locally after rebasing on trunk and discovered a few small issues
caused by newly-introduced tests; pushed a fix for those. Will merge pending CI
build
--
This is an
C0urante commented on PR #12307:
URL: https://github.com/apache/kafka/pull/12307#issuecomment-1579164297
@mimaison @showuon if you have a moment, would you mind taking a look?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
C0urante commented on PR #12307:
URL: https://github.com/apache/kafka/pull/12307#issuecomment-1160549247
@clolov I don't think it's necessary to add these tests to that list since
they're still passing locally with Java versions 16-18 and on Jenkins with Java
17. It's a little risky to add
C0urante commented on PR #12307:
URL: https://github.com/apache/kafka/pull/12307#issuecomment-1159756378
@clolov Hi! I'm aware of the effort to transition to Mockito; I don't think
this change makes that transition significantly harder. There are already
examples of parameterized tests in
