[GitHub] [kafka] cadonna commented on a diff in pull request #13756: KAFKA-14936: Add On Disk Time Ordered Buffer (1/N)

2023-06-14 Thread via GitHub
cadonna commented on code in PR #13756: URL: https://github.com/apache/kafka/pull/13756#discussion_r1229867769 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java: ## @@ -0,0 +1,192 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cadonna commented on a diff in pull request #13756: KAFKA-14936: Add On Disk Time Ordered Buffer (1/N)

2023-06-14 Thread via GitHub
cadonna commented on code in PR #13756: URL: https://github.com/apache/kafka/pull/13756#discussion_r1229370444 ## streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBufferTest.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] cadonna commented on a diff in pull request #13756: KAFKA-14936: Add On Disk Time Ordered Buffer (1/N)

2023-06-14 Thread via GitHub
cadonna commented on code in PR #13756: URL: https://github.com/apache/kafka/pull/13756#discussion_r1229288396 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cadonna commented on a diff in pull request #13756: KAFKA-14936: Add On Disk Time Ordered Buffer (1/N)

2023-06-13 Thread via GitHub
cadonna commented on code in PR #13756: URL: https://github.com/apache/kafka/pull/13756#discussion_r1227894014 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cadonna commented on a diff in pull request #13756: KAFKA-14936: Add On Disk Time Ordered Buffer (1/N)

2023-06-12 Thread via GitHub
cadonna commented on code in PR #13756: URL: https://github.com/apache/kafka/pull/13756#discussion_r1226821666 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cadonna commented on a diff in pull request #13756: KAFKA-14936: Add On Disk Time Ordered Buffer (1/N)

2023-06-08 Thread via GitHub
cadonna commented on code in PR #13756: URL: https://github.com/apache/kafka/pull/13756#discussion_r1223073798 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java: ## @@ -0,0 +1,185 @@ +/* + * Licensed to the Apache Software