[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

2023-06-27 Thread via GitHub
cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1243468362 ## streams/src/main/java/org/apache/kafka/streams/kstream/Joined.java: ## @@ -189,7 +221,22 @@ public Joined withOtherValueSerde(final Serde otherValueSerde) {

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

2023-06-22 Thread via GitHub
cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1238656502 ## streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java: ## @@ -122,12 +122,12 @@ public Maybe>

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

2023-06-20 Thread via GitHub
cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1235135157 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final KTable

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

2023-06-20 Thread via GitHub
cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1235096344 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final KTable

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

2023-06-20 Thread via GitHub
cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1235102765 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final KTable

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

2023-06-20 Thread via GitHub
cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1235096344 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final KTable

[GitHub] [kafka] cadonna commented on a diff in pull request #13855: KAFKA-14936: Add Grace period logic to Stream Table Join (2/N)

2023-06-15 Thread via GitHub
cadonna commented on code in PR #13855: URL: https://github.com/apache/kafka/pull/13855#discussion_r1230539039 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImpl.java: ## @@ -1256,10 +1261,25 @@ private KStream doStreamTableJoin(final KTable