[GitHub] [kafka] cadonna commented on a diff in pull request #13925: KAFKA-10199: Consider tasks in state updater when computing offset sums

2023-07-03 Thread via GitHub
cadonna commented on code in PR #13925: URL: https://github.com/apache/kafka/pull/13925#discussion_r1250497598 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1141,25 +1141,30 @@ public Map getTaskOffsetSums() { // Not all

[GitHub] [kafka] cadonna commented on a diff in pull request #13925: KAFKA-10199: Consider tasks in state updater when computing offset sums

2023-06-29 Thread via GitHub
cadonna commented on code in PR #13925: URL: https://github.com/apache/kafka/pull/13925#discussion_r1246365489 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1138,28 +1138,33 @@ public void signalResume() { public Map

[GitHub] [kafka] cadonna commented on a diff in pull request #13925: KAFKA-10199: Consider tasks in state updater when computing offset sums

2023-06-29 Thread via GitHub
cadonna commented on code in PR #13925: URL: https://github.com/apache/kafka/pull/13925#discussion_r1246336689 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1177,14 +1181,15 @@ private void tryToLockAllNonEmptyTaskDirectories() {

[GitHub] [kafka] cadonna commented on a diff in pull request #13925: KAFKA-10199: Consider tasks in state updater when computing offset sums

2023-06-29 Thread via GitHub
cadonna commented on code in PR #13925: URL: https://github.com/apache/kafka/pull/13925#discussion_r1246331625 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1138,28 +1138,33 @@ public void signalResume() { public Map

[GitHub] [kafka] cadonna commented on a diff in pull request #13925: KAFKA-10199: Consider tasks in state updater when computing offset sums

2023-06-28 Thread via GitHub
cadonna commented on code in PR #13925: URL: https://github.com/apache/kafka/pull/13925#discussion_r1245477150 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1138,28 +1138,33 @@ public void signalResume() { public Map

[GitHub] [kafka] cadonna commented on a diff in pull request #13925: KAFKA-10199: Consider tasks in state updater when computing offset sums

2023-06-28 Thread via GitHub
cadonna commented on code in PR #13925: URL: https://github.com/apache/kafka/pull/13925#discussion_r1245477150 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -1138,28 +1138,33 @@ public void signalResume() { public Map