[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1266270587 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -301,10 +302,12 @@ public CompletableFuture joinGroup(

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1266269140 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1245,4 +1422,1304 @@ public static String

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1266267667 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -531,7 +531,12 @@ class BrokerServer( config.consumerGroupHeartbeatIntervalMs,

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1266264686 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1245,4 +1422,1304 @@ public static String

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1265807612 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -3022,143 +3242,2087 @@ public void testOnLoaded() {

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1265807220 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -299,10 +299,10 @@ public CompletableFuture joinGroup(

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1264968675 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -2377,156 +2606,2165 @@ public void testOnNewMetadataImage() {

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1264967746 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -266,9 +282,32 @@ public CompletableFuture joinGroup(

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1264965443 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroup.java: ## @@ -561,7 +625,7 @@ public boolean hasReceivedSyncFromAllMembers() {

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1264964347 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -579,4 +618,32 @@ public void shutdown() {

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1264962406 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -5235,6 +5316,11 @@ private List

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1264961072 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -3022,143 +3242,2087 @@ public void testOnLoaded() {

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1264955867 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1243,4 +1406,1283 @@ public static String

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1264954924 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1243,4 +1406,1283 @@ public static String

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1264953365 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -247,31 +324,78 @@ GroupMetadataManager build() { */

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1247814090 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -266,9 +295,21 @@ public CompletableFuture joinGroup(

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1246778958 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1072,1338 @@ public void replay(

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1243806647 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1072,1338 @@ public void replay(

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1238725344 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorService.java: ## @@ -266,9 +295,21 @@ public CompletableFuture joinGroup(

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1238418966 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -171,70 +260,152 @@ GroupMetadataManager build() { /**

[GitHub] [kafka] dajac commented on a diff in pull request #13870: KAFKA-14500; [5/N] Implement JoinGroup protocol in new GroupCoordinator

dajac commented on code in PR #13870: URL: https://github.com/apache/kafka/pull/13870#discussion_r1238417804 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -171,70 +260,152 @@ GroupMetadataManager build() { /**