[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1249388374 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248223476 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248133399 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248097012 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -1932,6 +1961,435 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248096864 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248095763 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -564,9 +564,9 @@ public void testMetadataRefreshDeadline() {

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248095382 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -564,9 +564,9 @@ public void testMetadataRefreshDeadline() {

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248086301 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -825,4 +828,60 @@ public void testClose() throws

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248091492 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248088555 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -825,4 +828,60 @@ public void testClose() throws

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248087985 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -1932,6 +1961,435 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248087394 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -1932,6 +1961,435 @@ public void

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248086803 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroupTest.java: ## @@ -568,5 +568,20 @@ public void testMetadataRefreshDeadline()

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1248086301 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -825,4 +828,60 @@ public void testClose() throws

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1247805182 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -172,19 +186,21 @@ public List build(TopicsImage topicsImage)

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1247803617 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/CoordinatorRuntimeTest.java: ## @@ -825,4 +828,60 @@ public void testClose() throws

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1246649219 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -728,6 +794,81 @@ public void replay( }

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1246646144 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -728,6 +794,81 @@ public void replay( }

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1245226991 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -141,7 +141,7 @@ public static class TimeAndEpoch { *

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1245214287 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -423,6 +456,47 @@ public Map computeSubscriptionMetadata(

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1245213037 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -423,6 +456,47 @@ public Map computeSubscriptionMetadata(

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1245212300 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -119,6 +131,18 @@ public String toString() { */

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1245209953 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1245157302 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -874,4 +1021,34 @@ public void replay(

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1245156156 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -709,14 +780,16 @@ public void replay( String groupId =

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1245154086 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -506,32 +555,54 @@ private CoordinatorResult consumerGr

[GitHub] [kafka] dajac commented on a diff in pull request #13901: KAFKA-14462; [20/N] Refresh subscription metadata on new metadata image

dajac commented on code in PR #13901: URL: https://github.com/apache/kafka/pull/13901#discussion_r1245148023 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -88,10 +93,12 @@ public class GroupMetadataManager { public