[GitHub] [kafka] divijvaidya commented on a diff in pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

divijvaidya commented on code in PR #13828: URL: https://github.com/apache/kafka/pull/13828#discussion_r1226373376 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -474,7 +474,14 @@ class BrokerServer( new KafkaConfig(config.originals(), true) //

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

divijvaidya commented on code in PR #13828: URL: https://github.com/apache/kafka/pull/13828#discussion_r1224171314 ## clients/src/main/java/org/apache/kafka/common/network/ListenerName.java: ## @@ -36,6 +36,7 @@ public static ListenerName forSecurityProtocol(SecurityProtocol

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

divijvaidya commented on code in PR #13828: URL: https://github.com/apache/kafka/pull/13828#discussion_r1224064865 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -136,7 +137,10 @@ public class RemoteLogManager implements Closeable { // topic ids that

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

divijvaidya commented on code in PR #13828: URL: https://github.com/apache/kafka/pull/13828#discussion_r1224063364 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -220,11 +223,20 @@ public RemoteLogMetadataManager run() { }); } +public

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

divijvaidya commented on code in PR #13828: URL: https://github.com/apache/kafka/pull/13828#discussion_r1223142144 ## core/src/main/scala/kafka/server/BrokerServer.scala: ## @@ -197,7 +199,8 @@ class BrokerServer( logManager = LogManager(config, initialOfflineDirs,

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13828: KAFKA-15066: add "remote.log.metadata.manager.listener.name" config to rlmm

divijvaidya commented on code in PR #13828: URL: https://github.com/apache/kafka/pull/13828#discussion_r1223088072 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -220,11 +223,20 @@ public RemoteLogMetadataManager run() { }); } +public