[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-09-01 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1313025236 ## clients/src/main/java/org/apache/kafka/common/security/ssl/CommonNameLoggingSslEngineFactory.java: ## @@ -0,0 +1,581 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-20 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1299353603 ## clients/src/test/resources/log4j.properties: ## @@ -19,3 +19,5 @@ log4j.appender.stdout.layout=org.apache.log4j.PatternLayout

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-20 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1299353258 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -255,7 +271,7 @@ private SSLContext createSSLContext(SecurityStore

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-14 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1294020659 ## clients/src/test/resources/log4j.properties: ## @@ -19,3 +19,5 @@ log4j.appender.stdout.layout=org.apache.log4j.PatternLayout

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-14 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1294016888 ## clients/src/main/java/org/apache/kafka/common/security/ssl/CommonNameLoggingTrustManagerFactoryWrapper.java: ## @@ -0,0 +1,423 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-13 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1292864470 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -255,7 +271,7 @@ private SSLContext createSSLContext(SecurityStore

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-06 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1285195172 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -255,7 +271,7 @@ private SSLContext createSSLContext(SecurityStore

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-06 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1285195172 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -255,7 +271,7 @@ private SSLContext createSSLContext(SecurityStore

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-05 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1285078073 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -578,4 +594,335 @@ private List pemEntries(String pem) {

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-03 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1283766199 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -255,7 +271,7 @@ private SSLContext createSSLContext(SecurityStore

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-03 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1283754255 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -578,4 +594,335 @@ private List pemEntries(String pem) {

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-03 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1283751351 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -578,4 +594,335 @@ private List pemEntries(String pem) {

[GitHub] [kafka] ethaden commented on a diff in pull request #14130: KAFKA-15273: Log common name of expired client certificates

2023-08-03 Thread via GitHub
ethaden commented on code in PR #14130: URL: https://github.com/apache/kafka/pull/14130#discussion_r1283750683 ## clients/src/main/java/org/apache/kafka/common/security/ssl/DefaultSslEngineFactory.java: ## @@ -16,47 +16,48 @@ */ package org.apache.kafka.common.security.ssl;