[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1307122178 ## core/src/main/scala/kafka/tools/GetOffsetShell.scala: ## Review Comment: @dengziming are you good with this? -- This is an automated message from the

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1287993847 ## core/src/main/scala/kafka/tools/GetOffsetShell.scala: ## Review Comment: > We should still keep this file can forward all args to new GetOffsetShell, see

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1286654127 ## tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java: ## @@ -0,0 +1,404 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1285005842 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -99,4 +101,26 @@ public static void prettyPrintTable( printRow(columnLengths, headers,

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1285005842 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -99,4 +101,26 @@ public static void prettyPrintTable( printRow(columnLengths, headers,

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1282957101 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1280546556 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1280446002 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1274685519 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1271787804 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1271258247 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1270884317 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1270733830 ## tools/src/main/java/org/apache/kafka/tools/ToolsUtils.java: ## @@ -0,0 +1,44 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1259763311 ## tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java: ## @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1255510339 ## tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java: ## @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] fvaleri commented on a diff in pull request #13562: KAFKA-14581: Moving GetOffsetShell to tools

fvaleri commented on code in PR #13562: URL: https://github.com/apache/kafka/pull/13562#discussion_r1255500374 ## tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java: ## @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *