[GitHub] [kafka] fvaleri commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-05 Thread via GitHub
fvaleri commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1666442787 > That does appear to work, because [server-common is not being excluded from

[GitHub] [kafka] fvaleri commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-04 Thread via GitHub
fvaleri commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1665804677 @gharris1727 I tried various things, as I'm also learning how this works. The best solution I found is to move the ThroughputThrottler class from clients to server-common, adding

[GitHub] [kafka] fvaleri commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-04 Thread via GitHub
fvaleri commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1665393332 > So for example, if the node.version is 1.0.0, this condition will be true, and the script will add DEV jars to CLASSPATH. kafka-run-class.sh then finds the 1.0.0 jars and adds them to

[GitHub] [kafka] fvaleri commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-08-03 Thread via GitHub
fvaleri commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1664186438 Hi @gharris1727, thanks for the clarification and sorry for the delay, I've been busy with other stuff. > By "version mixing" I mean that artifacts from two different versions from

[GitHub] [kafka] fvaleri commented on pull request #14092: KAFKA-15239: Fix system tests using producer performance service

2023-07-26 Thread via GitHub
fvaleri commented on PR #14092: URL: https://github.com/apache/kafka/pull/14092#issuecomment-1652091101 > if we loaded a 1.0.0 server-common class that depended on a class which was missing from DEV clients, I would expect that to fail. These changes are just for the