[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-06-15 Thread via GitHub
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1593332941 > Also, @hudeqi please don't use force pushes because it makes it impossible to go back to previous commits which sometimes needed in reviews to get the proper context. When we merge a PR

[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-06-14 Thread via GitHub
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1591024699 Hi, is there any suggestion and must do for this PR now? @dajac @satishd @divijvaidya -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-06-08 Thread via GitHub
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1582994469 @viktorsomogyi hi, this minor pr is also about replica fetcher thread, please help to review, thanks! Seems @dajac have no time. -- This is an automated message from the Apache Git

[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-05-31 Thread via GitHub
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1569896940 hi, is this pr ready to merge? @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-05-17 Thread via GitHub
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1551304423 Hi, do you have time to help review this? @dajac @satishd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] hudeqi commented on pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

2023-05-15 Thread via GitHub
hudeqi commented on PR #13719: URL: https://github.com/apache/kafka/pull/13719#issuecomment-1548893409 Does anyone have a review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific