[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

2023-06-28 Thread via GitHub
ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r124885 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException { //

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

2023-06-26 Thread via GitHub
ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242345211 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException { //

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

2023-06-26 Thread via GitHub
ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242312432 ## Jenkinsfile: ## @@ -155,79 +155,23 @@ pipeline { echo 'Skipping Kafka Streams archetype test for Java 17' } } - -//

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

2023-06-26 Thread via GitHub
ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1242309422 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -290,25 +290,27 @@ public long skip(long toSkip) throws IOException { //

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

2023-06-23 Thread via GitHub
ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1240004510 ## core/src/test/scala/kafka/server/KafkaRequestHandlerTest.scala: ## @@ -53,7 +53,7 @@ class KafkaRequestHandlerTest { val context = new

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

2023-06-22 Thread via GitHub
ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1238720569 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -291,7 +291,7 @@ public long skip(long toSkip) throws IOException { //

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

2023-06-21 Thread via GitHub
ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1237383663 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -291,7 +291,7 @@ public long skip(long toSkip) throws IOException { //

[GitHub] [kafka] ijuma commented on a diff in pull request #12948: MINOR: Add JDK 20 CI build and remove some branch builds

2023-06-21 Thread via GitHub
ijuma commented on code in PR #12948: URL: https://github.com/apache/kafka/pull/12948#discussion_r1237064294 ## clients/src/main/java/org/apache/kafka/common/utils/ChunkedBytesStream.java: ## @@ -291,7 +291,7 @@ public long skip(long toSkip) throws IOException { //