[GitHub] [kafka] ijuma commented on a diff in pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse

2023-06-08 Thread via GitHub
ijuma commented on code in PR #13679: URL: https://github.com/apache/kafka/pull/13679#discussion_r1223558292 ## core/src/main/scala/kafka/server/ApiVersionManager.scala: ## @@ -112,4 +157,8 @@ class DefaultApiVersionManager( zkMigrationEnabled ) } + + override

[GitHub] [kafka] ijuma commented on a diff in pull request #13679: KAFKA-14291: KRaft controller should return right finalized features in ApiVersionResponse

2023-06-06 Thread via GitHub
ijuma commented on code in PR #13679: URL: https://github.com/apache/kafka/pull/13679#discussion_r1220723779 ## core/src/main/scala/kafka/server/ApiVersionManager.scala: ## @@ -112,4 +157,8 @@ class DefaultApiVersionManager( zkMigrationEnabled ) } + + override