[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-28 Thread via GitHub
jeffkbkim commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1245523659 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-28 Thread via GitHub
jeffkbkim commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1245495804 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-28 Thread via GitHub
jeffkbkim commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1245489701 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerdeTest.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-28 Thread via GitHub
jeffkbkim commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1245486249 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerdeTest.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jeffkbkim commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243002218 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-21 Thread via GitHub
jeffkbkim commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1237755278 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-20 Thread via GitHub
jeffkbkim commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1236242369 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerDe.java: ## @@ -0,0 +1,161 @@ +/* Review Comment: nit: Other serdes follow "Serde"