[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-28 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1245609479 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-27 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1244173231 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-27 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1244065077 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record.

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-27 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1244064321 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record.

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-27 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1244063578 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242860978 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242855495 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerdeTest.java: ## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242849519 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record.

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242822664 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record.

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242819355 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorLoader.java: ## @@ -26,7 +27,40 @@ * * @param The type of the record.

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242803548 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242789616 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerde.java: ## @@ -0,0 +1,158 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242786634 ## core/src/test/scala/unit/kafka/coordinator/group/CoordinatorLoaderImplTest.scala: ## @@ -0,0 +1,315 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242623544 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] jolshan commented on a diff in pull request #13880: KAFKA-14462; [19/N] Add CoordinatorLoader implementation

2023-06-26 Thread via GitHub
jolshan commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1242616962 ## core/src/main/scala/kafka/coordinator/group/CoordinatorLoaderImpl.scala: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or