[GitHub] [kafka] joobisb commented on pull request #13931: KAFKA-8977: Remove MockStreamsMetrics since it is not a mock

2023-08-05 Thread via GitHub
joobisb commented on PR #13931: URL: https://github.com/apache/kafka/pull/13931#issuecomment-1666466685 Hi @cadonna , As per the comment, I've setup mocks and verified the calls on it, also addressed other comments as well, please have a look. -- This is an automated message from

[GitHub] [kafka] joobisb commented on pull request #13931: KAFKA-8977: Remove MockStreamsMetrics since it is not a mock

2023-07-09 Thread via GitHub
joobisb commented on PR #13931: URL: https://github.com/apache/kafka/pull/13931#issuecomment-1627655971 @cadonna i have addressed the comments, could you please have a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] joobisb commented on pull request #13931: KAFKA-8977: Remove MockStreamsMetrics since it is not a mock

2023-06-30 Thread via GitHub
joobisb commented on PR #13931: URL: https://github.com/apache/kafka/pull/13931#issuecomment-1614288335 @cadonna could you please have a look at this PR ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above